Commits · f7e39388d0327e687854f22d7e06aec302770994 · tianlh / LightGBM-DCU

06 Dec, 2021 1 commit
- [R-package] remove support for '...' in predict() (#4857) · f7e39388
  James Lamb authored Dec 05, 2021
```
* [R-package] remove support for '...' in predict()

* restore ... in S3 method
```
  f7e39388
05 Dec, 2021 3 commits
- [R-package] remove support for '...' in Booster reset_parameter() (#4856) · 76fb0b62
  James Lamb authored Dec 05, 2021
  
  76fb0b62
- [python] remove workaround for `UnboundLocalError` in early stopping callback for Python 2 (#4855) · aa413f7e
  Nikita Titov authored Dec 05, 2021
  
  aa413f7e
- [python][sklearn] unify values of `best_iteration` for sklearn and standard APIs (#4845) · 12915d58
  Nikita Titov authored Dec 05, 2021
```
* unify values of `best_iteration` for sklearn and standard APIs

* update Dask test
```
  12915d58
04 Dec, 2021 3 commits

[python-package] remove unused imports (#4850) · 7d901749
James Lamb authored Dec 04, 2021

7d901749
[ci] migrate CI from macOS 10.14 to 10.15 and drop support of Mojave (#4849) · f77cfe83
Nikita Titov authored Dec 05, 2021
```
* Update .vsts-ci.yml

* Update setup.sh

* Update .vsts-ci.yml

* Update test.sh

* Update README.rst
```
f77cfe83

[R-package] enable saving Booster with saveRDS() and loading it with readRDS()... · 12b15273

david-cortes authored Dec 04, 2021


[R-package] enable saving Booster with saveRDS() and loading it with readRDS() (fixes #4296) (#4685)

* idiomatic serialization

* linter

* linter, namespace

* comments, linter, fix failing test

* standardize error messages for null handles

* auto-restore handle in more functions

* linter

* missing declaration

* correct wrong signature

* fix docs

* Update R-package/R/lgb.train.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update R-package/R/lgb.drop_serialized.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update R-package/R/lgb.restore_handle.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update R-package/R/lgb.restore_handle.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update R-package/R/lgb.make_serializable.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* move 'restore_handle' from feature importance to dump method

* missing header

* move arguments order, update docs

* linter

* avoid leaving files in working directory

* add test for save_model=NULL

* missing comma

* Update R-package/R/lgb.restore_handle.R
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update R-package/src/lightgbm_R.cpp
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* change name of error function

* update comment

* restore old serialization functions but set as deprecated

* Update R-package/R/readRDS.lgb.Booster.R
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update R-package/R/saveRDS.lgb.Booster.R
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* update docs

* Update R-package/R/readRDS.lgb.Booster.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update R-package/R/saveRDS.lgb.Booster.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update R-package/tests/testthat/test_basic.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update R-package/R/readRDS.lgb.Booster.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* comments

* fix variable name

* restore serialization test for linear models

* Update R-package/R/lightgbm.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* update docs

* fix issues with null terminator
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

12b15273

03 Dec, 2021 2 commits

[R-package] fix `--no-build-vignettes` option for `build-cran-package.sh` (#4848) · f54e32f7
James Lamb authored Dec 03, 2021

f54e32f7

Add C API function that returns all parameter names with their aliases (#4829) · cf38071b

Nikita Titov authored Dec 03, 2021



* add C API function that returns all param names with aliases

* add C API function that returns all param names with aliases

* add R code

* test R code

* remove debug CI

* fix R lint

* refactor

* run CI

* fix R

* fix

* revert CI checks

* revert changes in docs

* Try to make function `const`
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* add `const` in cpp file

* address review comments and sync with `master`
Co-authored-by: James Lamb <jaylamb20@gmail.com>

cf38071b

02 Dec, 2021 6 commits
- [python-package] fix mypy errors in engine.py (#4839) · 946817a5
  James Lamb authored Dec 02, 2021
```
* [python-package] fix mypy errors in engine.py

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* allow for stdv

* whitespace
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
```
  946817a5
- [python-package] [dask] fix mypy errors from dask.py docstrings (#4844) · de23b562
  James Lamb authored Dec 02, 2021
  
  de23b562
- [python-package] fix mypy errors in sklearn.py (#4837) · e048a6b4
  James Lamb authored Dec 01, 2021
```
* [python-package] fix mypy errors in sklearn.py

* use ignore comments
```
  e048a6b4
- [python][sklearn] respect parameters for predictions in `init()` and `set_params()` methods (#4822) · f57ef6f4
  Nikita Titov authored Dec 02, 2021
```
* in predict(), respect params set via `set_params()` after fit()

* continue

* add test

* fix return name

* hotfix

* simplify
```
  f57ef6f4
- [tests][dask] fix argument names in custom eval function in Dask test (#4833) · b31d5a43
  Nikita Titov authored Dec 02, 2021
```
* fix argument types in custom eval function for Dask estimators

* revert changes to docstrings

* fix argument names in Dask test
```
  b31d5a43
- [python-package] fix mypy errors in `plotting.py` (#4838) · f8bab7fc
  James Lamb authored Dec 01, 2021
```
* [python-package] fix mypy errors in plotting.py

* empty commit
```
  f8bab7fc
01 Dec, 2021 1 commit

[python-package] fix mypy error about missing type hint in dask.py (#4840) · 8f4126d6

James Lamb authored Dec 01, 2021

* [python-package] fix mypy error about missing type hint in dask.py

* list of lists

* use different variable

* use append()

8f4126d6

30 Nov, 2021 2 commits
- [python-package] fix mypy errors in `compat.py` and `setup.py` (#4836) · a32de359
  James Lamb authored Nov 30, 2021
  
  a32de359
- [python][sklearn] remove `verbose` argument from `fit()` method (#4832) · 4072e9f7
  Nikita Titov authored Dec 01, 2021
  
  4072e9f7
29 Nov, 2021 2 commits
- [docs] document that `pred_early_stop` can be used only in normal and raw scores prediction (#4823) · 67b4205c
  Nikita Titov authored Nov 29, 2021
  
  67b4205c
- [python] remove `learning_rates` argument of `train()` function(#4831) · b81f7dd6
  Nikita Titov authored Nov 29, 2021
  
  b81f7dd6
28 Nov, 2021 1 commit
- [docs][python] simplify mocking in docs (#4830) · 2f5d8985
  Nikita Titov authored Nov 28, 2021
  
  2f5d8985
26 Nov, 2021 3 commits
- [python] remove "auto" value of `ylabel` argument of `plot_metric()` function (#4818) · 953915f5
  Nikita Titov authored Nov 27, 2021
  
  953915f5
- [python] Remove `print_evaluation()` function (#4819) · 701e8740
  Nikita Titov authored Nov 27, 2021
```
* Update __init__.py

* Update callback.py
```
  701e8740
- [python][docs] fix type hints for custom functions and remove vague `array-like` wording (#4816) · 5e9b0209
  Nikita Titov authored Nov 27, 2021
```
* Update sklearn.py

* Update engine.py

* Update sklearn.py

* Update engine.py

* Update basic.py

* Update engine.py
```
  5e9b0209
23 Nov, 2021 1 commit
- [python] add type hints to `_compare_params_for_warning()` and make it reusable (#4824) · a1fdeb1f
  Nikita Titov authored Nov 23, 2021
  
  a1fdeb1f
20 Nov, 2021 1 commit

[python] Remove `silent` argument (#4800) · 2caf945f

Nikita Titov authored Nov 21, 2021

* Update test_plotting.py

* Update dask.py

* Update sklearn.py

* Update test_sklearn.py

* Update basic.py

* Update engine.py

* Update test_engine.py

* Update basic.py

* Update basic.py

* Update engine.py

2caf945f

18 Nov, 2021 3 commits

[R-package] Move R6 to Imports (#4812) · 65ee8ab2
david-cortes authored Nov 19, 2021
```
* update dependencies

* Update DESCRIPTION
```
65ee8ab2

[ci] Fix CI job for R artifact (#4811) · c2d13ec5

Nikita Titov authored Nov 19, 2021



* Update .vsts-ci.yml

* Update .vsts-ci.yml

* Update .vsts-ci.yml

* Update .vsts-ci.yml

* Update .vsts-ci.yml

* Try `RD` and `RDscript`

* Update .vsts-ci.yml
Co-authored-by: James Lamb <jaylamb20@gmail.com>

c2d13ec5

[R-package] [docs] add intro vignette (#3946) (#4775) · 5fa887bb

James Lamb authored Nov 17, 2021



* [R-package] [docs] add intro vignette (#3946)

* add 10 test vignettes

* Revert "add 10 test vignettes"

This reverts commit 40fb2e2f1982402798776ee44e4ec82fc4644d3d.

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Michael Mayer <mayermichael79@gmail.com>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

5fa887bb

17 Nov, 2021 1 commit
- [ci] fix getting status of optional workflows in PRs with a lot of comments (#4806) · 06e3c4a9
  Nikita Titov authored Nov 17, 2021
```
* Update get_workflow_status.py

* Update get_workflow_status.py
```
  06e3c4a9
16 Nov, 2021 1 commit

Add customized parser support (#4782) · b0137deb

chjinche authored Nov 16, 2021

* add customized parser support

* fix typo of parser_config_file description

* make delimiter as parameter of JoinedLines

b0137deb

15 Nov, 2021 2 commits

[python] add type hints for custom objective and metric functions in scikit-learn interface (#4547) · 843d380d

James Lamb authored Nov 15, 2021



* [python] add type hints for custom objective and metric functions in scikit-learn interface

* update type hints

* remote unnecessary input

* Update python-package/lightgbm/sklearn.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* remove type hint on objective being callable
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

843d380d

[c_api] Improve ANSI compatibility by avoiding <stdbool.h> (#4697) · bfb346c1

Drew Miller authored Nov 15, 2021

* [c_api] Improve ANSI compatibility by avoiding <stdbool.h>

* fixes in response to CI linting

* inline NOLINT instead of separate test

* moving length declaration to non-ANSI C conditional

* [c_api] Align expected return type in `basic.py` with new c_api type.

bfb346c1

14 Nov, 2021 3 commits

[ci] ignore CMakeLint errors related to package names (#4801) · 874e6359

Nikita Titov authored Nov 14, 2021

* Update test.sh

* Update test.sh

* Update test.sh

* Update FindLibR.cmake

* Update r_package.yml

* Update FindLibR.cmake

* Update r_package.yml

874e6359

[ci] fix CMakeLint errors related to function naming case (#4794) · 144036f2

Nikita Titov authored Nov 14, 2021

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update static_analysis.yml

* Update CMakeLists.txt

* Update test.sh

* Update CMakeLists.txt

* Update static_analysis.yml

144036f2

[ci] simplify processing of `CMAKE_CUDA_FLAGS` variable in `CMakeLists.txt` (#4799) · 968c60c5
Nikita Titov authored Nov 14, 2021
```
* Update CMakeLists.txt

* Update cuda.yml

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update cuda.yml
```
968c60c5

13 Nov, 2021 4 commits

[ci] fix CMakeLint `linelength` errors (#4796) · 5b587333

Nikita Titov authored Nov 14, 2021

* Update Sanitizer.cmake

* Update FindLibR.cmake

* Update IntegratedOpenCL.cmake

* Update FindLibR.cmake

* Update CMakeLists.txt

* Update FindLibR.cmake

* Update static_analysis.yml

* Update CMakeLists.txt

* Update FindLibR.cmake

* Update IntegratedOpenCL.cmake

* Update static_analysis.yml

5b587333

[ci] use pure `endif()` and `endfunction()` without expression inside in `CMakeLists.txt` (#4798) · c3ff1871
Nikita Titov authored Nov 13, 2021
```
* Update CMakeLists.txt

* Update FindLibR.cmake
```
c3ff1871

[R-package] Add `print()` and `summary()` methods for Booster (#4686) · 2f59773d

david-cortes authored Nov 13, 2021



* add print and summary S3 method

* correct wrong signature

* attempt at bypassing linter

* Update R-package/R/lgb.Booster.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update R-package/src/lightgbm_R.h
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update include/LightGBM/c_api.h
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* add more tests

* linter

* don't pluralize single tree

* remove duplicated function

* update changed function name

* missing declaration

* Update lightgbm_R.h

* Update R-package/tests/testthat/test_lgb.Booster.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* accommodate custom objectives in print

* linter

* linter
Co-authored-by: James Lamb <jaylamb20@gmail.com>

2f59773d

[docs] fix broken SynapseML link (#4795) · 6e6fb14c
Nikita Titov authored Nov 13, 2021

6e6fb14c