Skip to content

GitLab

Unverified Commit 144036f2 authored by Nikita Titov's avatar Nikita Titov Committed by GitHub
Browse files

[ci] fix CMakeLint errors related to function naming case (#4794) 

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update static_analysis.yml

* Update CMakeLists.txt

* Update test.sh

* Update CMakeLists.txt

* Update static_analysis.yml
parent 968c60c5
Hide whitespace changes
Inline Side-by-side
Showing with 60 additions and 60 deletions
.ci/test.sh
View file @ 144036f2
...@@ -82,7 +82,7 @@ if [[ $TASK == "lint" ]]; then ...@@ -82,7 +82,7 @@ if [[ $TASK == "lint" ]]; then
echo "Linting C++ code" echo "Linting C++ code"
cpplint --filter=-build/c++11,-build/include_subdir,-build/header_guard,-whitespace/line_length --recursive ./src ./include ./R-package ./swig ./tests || exit -1 cpplint --filter=-build/c++11,-build/include_subdir,-build/header_guard,-whitespace/line_length --recursive ./src ./include ./R-package ./swig ./tests || exit -1
cmake_files=$(find . -name CMakeLists.txt -o -path "*/cmake/*.cmake") cmake_files=$(find . -name CMakeLists.txt -o -path "*/cmake/*.cmake")
cmakelint --linelength=120 ${cmake_files} || true cmakelint --linelength=120 --filter=-readability/wonkycase ${cmake_files} || true
exit 0 exit 0
fi fi
......
CMakeLists.txt
View file @ 144036f2
OPTION(USE_MPI "Enable MPI-based distributed learning" OFF) option(USE_MPI "Enable MPI-based distributed learning" OFF)
OPTION(USE_OPENMP "Enable OpenMP" ON) option(USE_OPENMP "Enable OpenMP" ON)
OPTION(USE_GPU "Enable GPU-accelerated training" OFF) option(USE_GPU "Enable GPU-accelerated training" OFF)
OPTION(USE_SWIG "Enable SWIG to generate Java API" OFF) option(USE_SWIG "Enable SWIG to generate Java API" OFF)
OPTION(USE_HDFS "Enable HDFS support (EXPERIMENTAL)" OFF) option(USE_HDFS "Enable HDFS support (EXPERIMENTAL)" OFF)
OPTION(USE_TIMETAG "Set to ON to output time costs" OFF) option(USE_TIMETAG "Set to ON to output time costs" OFF)
OPTION(USE_CUDA "Enable CUDA-accelerated training (EXPERIMENTAL)" OFF) option(USE_CUDA "Enable CUDA-accelerated training (EXPERIMENTAL)" OFF)
OPTION(USE_DEBUG "Set to ON for Debug mode" OFF) option(USE_DEBUG "Set to ON for Debug mode" OFF)
OPTION(USE_SANITIZER "Use santizer flags" OFF) option(USE_SANITIZER "Use santizer flags" OFF)
SET( set(
ENABLED_SANITIZERS ENABLED_SANITIZERS
"address" "leak" "undefined" "address" "leak" "undefined"
CACHE CACHE
...@@ -15,13 +15,13 @@ SET( ...@@ -15,13 +15,13 @@ SET(
"Semicolon separated list of sanitizer names, e.g., 'address;leak'. \ "Semicolon separated list of sanitizer names, e.g., 'address;leak'. \
Supported sanitizers are address, leak, undefined and thread." Supported sanitizers are address, leak, undefined and thread."
) )
OPTION(BUILD_CPP_TEST "Build C++ tests with Google Test" OFF) option(BUILD_CPP_TEST "Build C++ tests with Google Test" OFF)
OPTION(BUILD_STATIC_LIB "Build static library" OFF) option(BUILD_STATIC_LIB "Build static library" OFF)
OPTION(__BUILD_FOR_R "Set to ON if building lib_lightgbm for use with the R package" OFF) option(__BUILD_FOR_R "Set to ON if building lib_lightgbm for use with the R package" OFF)
OPTION(__INTEGRATE_OPENCL "Set to ON if building LightGBM with the OpenCL ICD Loader and its dependencies included" OFF) option(__INTEGRATE_OPENCL "Set to ON if building LightGBM with the OpenCL ICD Loader and its dependencies included" OFF)
if(APPLE) if(APPLE)
OPTION(APPLE_OUTPUT_DYLIB "Output dylib shared library" OFF) option(APPLE_OUTPUT_DYLIB "Output dylib shared library" OFF)
endif() endif()
if(__INTEGRATE_OPENCL) if(__INTEGRATE_OPENCL)
...@@ -34,7 +34,7 @@ else() ...@@ -34,7 +34,7 @@ else()
cmake_minimum_required(VERSION 3.0) cmake_minimum_required(VERSION 3.0)
endif() endif()
PROJECT(lightgbm LANGUAGES C CXX) project(lightgbm LANGUAGES C CXX)
list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake/modules") list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake/modules")
...@@ -92,22 +92,22 @@ if(USE_SWIG) ...@@ -92,22 +92,22 @@ if(USE_SWIG)
include_directories(JNI_INCLUDE_DIRS) include_directories(JNI_INCLUDE_DIRS)
include_directories($ENV{JAVA_HOME}/include) include_directories($ENV{JAVA_HOME}/include)
if(WIN32) if(WIN32)
FILE(MAKE_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/com/microsoft/ml/lightgbm/windows/x86_64") file(MAKE_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/com/microsoft/ml/lightgbm/windows/x86_64")
include_directories($ENV{JAVA_HOME}/include/win32) include_directories($ENV{JAVA_HOME}/include/win32)
elseif(APPLE) elseif(APPLE)
FILE(MAKE_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/com/microsoft/ml/lightgbm/osx/x86_64") file(MAKE_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/com/microsoft/ml/lightgbm/osx/x86_64")
include_directories($ENV{JAVA_HOME}/include/darwin) include_directories($ENV{JAVA_HOME}/include/darwin)
else() else()
FILE(MAKE_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/com/microsoft/ml/lightgbm/linux/x86_64") file(MAKE_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/com/microsoft/ml/lightgbm/linux/x86_64")
include_directories($ENV{JAVA_HOME}/include/linux) include_directories($ENV{JAVA_HOME}/include/linux)
endif() endif()
endif() endif()
SET(EIGEN_DIR "${PROJECT_SOURCE_DIR}/external_libs/eigen") set(EIGEN_DIR "${PROJECT_SOURCE_DIR}/external_libs/eigen")
include_directories(${EIGEN_DIR}) include_directories(${EIGEN_DIR})
# See https://gitlab.com/libeigen/eigen/-/blob/master/COPYING.README # See https://gitlab.com/libeigen/eigen/-/blob/master/COPYING.README
ADD_DEFINITIONS(-DEIGEN_MPL2_ONLY) add_definitions(-DEIGEN_MPL2_ONLY)
if(__BUILD_FOR_R) if(__BUILD_FOR_R)
find_package(LibR REQUIRED) find_package(LibR REQUIRED)
...@@ -115,41 +115,41 @@ if(__BUILD_FOR_R) ...@@ -115,41 +115,41 @@ if(__BUILD_FOR_R)
message(STATUS "LIBR_INCLUDE_DIRS: ${LIBR_INCLUDE_DIRS}") message(STATUS "LIBR_INCLUDE_DIRS: ${LIBR_INCLUDE_DIRS}")
message(STATUS "LIBR_CORE_LIBRARY: ${LIBR_CORE_LIBRARY}") message(STATUS "LIBR_CORE_LIBRARY: ${LIBR_CORE_LIBRARY}")
include_directories(${LIBR_INCLUDE_DIRS}) include_directories(${LIBR_INCLUDE_DIRS})
ADD_DEFINITIONS(-DLGB_R_BUILD) add_definitions(-DLGB_R_BUILD)
endif() endif()
if(USE_TIMETAG) if(USE_TIMETAG)
ADD_DEFINITIONS(-DTIMETAG) add_definitions(-DTIMETAG)
endif() endif()
if(USE_DEBUG) if(USE_DEBUG)
ADD_DEFINITIONS(-DDEBUG) add_definitions(-DDEBUG)
endif() endif()
if(USE_MPI) if(USE_MPI)
find_package(MPI REQUIRED) find_package(MPI REQUIRED)
ADD_DEFINITIONS(-DUSE_MPI) add_definitions(-DUSE_MPI)
else() else()
ADD_DEFINITIONS(-DUSE_SOCKET) add_definitions(-DUSE_SOCKET)
endif() endif()
if(USE_CUDA) if(USE_CUDA)
SET(CMAKE_CUDA_HOST_COMPILER "${CMAKE_CXX_COMPILER}") set(CMAKE_CUDA_HOST_COMPILER "${CMAKE_CXX_COMPILER}")
enable_language(CUDA) enable_language(CUDA)
SET(USE_OPENMP ON CACHE BOOL "CUDA requires OpenMP" FORCE) set(USE_OPENMP ON CACHE BOOL "CUDA requires OpenMP" FORCE)
endif() endif()
if(USE_OPENMP) if(USE_OPENMP)
find_package(OpenMP REQUIRED) find_package(OpenMP REQUIRED)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}")
endif() endif()
if(USE_GPU) if(USE_GPU)
SET(BOOST_COMPUTE_HEADER_DIR ${PROJECT_SOURCE_DIR}/external_libs/compute/include) set(BOOST_COMPUTE_HEADER_DIR ${PROJECT_SOURCE_DIR}/external_libs/compute/include)
include_directories(${BOOST_COMPUTE_HEADER_DIR}) include_directories(${BOOST_COMPUTE_HEADER_DIR})
find_package(OpenCL REQUIRED) find_package(OpenCL REQUIRED)
include_directories(${OpenCL_INCLUDE_DIRS}) include_directories(${OpenCL_INCLUDE_DIRS})
MESSAGE(STATUS "OpenCL include directory: " ${OpenCL_INCLUDE_DIRS}) message(STATUS "OpenCL include directory: " ${OpenCL_INCLUDE_DIRS})
if(WIN32) if(WIN32)
set(Boost_USE_STATIC_LIBS ON) set(Boost_USE_STATIC_LIBS ON)
endif() endif()
...@@ -159,13 +159,13 @@ if(USE_GPU) ...@@ -159,13 +159,13 @@ if(USE_GPU)
add_definitions(-DBOOST_ALL_NO_LIB) add_definitions(-DBOOST_ALL_NO_LIB)
endif() endif()
include_directories(${Boost_INCLUDE_DIRS}) include_directories(${Boost_INCLUDE_DIRS})
ADD_DEFINITIONS(-DUSE_GPU) add_definitions(-DUSE_GPU)
endif() endif()
if(__INTEGRATE_OPENCL) if(__INTEGRATE_OPENCL)
if(WIN32) if(WIN32)
include(cmake/IntegratedOpenCL.cmake) include(cmake/IntegratedOpenCL.cmake)
ADD_DEFINITIONS(-DUSE_GPU) add_definitions(-DUSE_GPU)
else() else()
message(FATAL_ERROR "Integrated OpenCL build is available only for Windows") message(FATAL_ERROR "Integrated OpenCL build is available only for Windows")
endif() endif()
...@@ -188,18 +188,18 @@ if(USE_CUDA) ...@@ -188,18 +188,18 @@ if(USE_CUDA)
endif() endif()
list(POP_BACK CUDA_ARCHS CUDA_LAST_SUPPORTED_ARCH) list(POP_BACK CUDA_ARCHS CUDA_LAST_SUPPORTED_ARCH)
list(APPEND CUDA_ARCHS "${CUDA_LAST_SUPPORTED_ARCH}+PTX") list(APPEND CUDA_ARCHS "${CUDA_LAST_SUPPORTED_ARCH}+PTX")
CUDA_SELECT_NVCC_ARCH_FLAGS(CUDA_ARCH_FLAGS ${CUDA_ARCHS}) cuda_select_nvcc_arch_flags(CUDA_ARCH_FLAGS ${CUDA_ARCHS})
string(REPLACE ";" " " CUDA_ARCH_FLAGS "${CUDA_ARCH_FLAGS}") string(REPLACE ";" " " CUDA_ARCH_FLAGS "${CUDA_ARCH_FLAGS}")
set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} ${CUDA_ARCH_FLAGS}") set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} ${CUDA_ARCH_FLAGS}")
if(USE_DEBUG) if(USE_DEBUG)
SET(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -g") set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -g")
else() else()
SET(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -O3 -lineinfo") set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -O3 -lineinfo")
endif() endif()
message(STATUS "CMAKE_CUDA_FLAGS: ${CMAKE_CUDA_FLAGS}") message(STATUS "CMAKE_CUDA_FLAGS: ${CMAKE_CUDA_FLAGS}")
ADD_DEFINITIONS(-DUSE_CUDA) add_definitions(-DUSE_CUDA)
if(NOT DEFINED CMAKE_CUDA_STANDARD) if(NOT DEFINED CMAKE_CUDA_STANDARD)
set(CMAKE_CUDA_STANDARD 11) set(CMAKE_CUDA_STANDARD 11)
set(CMAKE_CUDA_STANDARD_REQUIRED ON) set(CMAKE_CUDA_STANDARD_REQUIRED ON)
...@@ -255,8 +255,8 @@ if(USE_HDFS) ...@@ -255,8 +255,8 @@ if(USE_HDFS)
find_path(HDFS_INCLUDE_DIR hdfs.h REQUIRED) find_path(HDFS_INCLUDE_DIR hdfs.h REQUIRED)
find_library(HDFS_LIB NAMES hdfs REQUIRED) find_library(HDFS_LIB NAMES hdfs REQUIRED)
include_directories(${HDFS_INCLUDE_DIR}) include_directories(${HDFS_INCLUDE_DIR})
ADD_DEFINITIONS(-DUSE_HDFS) add_definitions(-DUSE_HDFS)
SET(HDFS_CXX_LIBRARIES ${HDFS_LIB} ${JAVA_JVM_LIBRARY}) set(HDFS_CXX_LIBRARIES ${HDFS_LIB} ${JAVA_JVM_LIBRARY})
endif() endif()
include(CheckCXXSourceCompiles) include(CheckCXXSourceCompiles)
...@@ -271,7 +271,7 @@ int main() { ...@@ -271,7 +271,7 @@ int main() {
if(${MM_PREFETCH}) if(${MM_PREFETCH})
message(STATUS "Using _mm_prefetch") message(STATUS "Using _mm_prefetch")
ADD_DEFINITIONS(-DMM_PREFETCH) add_definitions(-DMM_PREFETCH)
endif() endif()
include(CheckCXXSourceCompiles) include(CheckCXXSourceCompiles)
...@@ -286,36 +286,36 @@ int main() { ...@@ -286,36 +286,36 @@ int main() {
if(${MM_MALLOC}) if(${MM_MALLOC})
message(STATUS "Using _mm_malloc") message(STATUS "Using _mm_malloc")
ADD_DEFINITIONS(-DMM_MALLOC) add_definitions(-DMM_MALLOC)
endif() endif()
if(UNIX OR MINGW OR CYGWIN) if(UNIX OR MINGW OR CYGWIN)
SET( set(
CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS
"${CMAKE_CXX_FLAGS} -std=c++11 -pthread -Wextra -Wall -Wno-ignored-attributes -Wno-unknown-pragmas -Wno-return-type" "${CMAKE_CXX_FLAGS} -std=c++11 -pthread -Wextra -Wall -Wno-ignored-attributes -Wno-unknown-pragmas -Wno-return-type"
) )
if(USE_DEBUG) if(USE_DEBUG)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -O0") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -O0")
else() else()
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3")
endif() endif()
if(USE_SWIG) if(USE_SWIG)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-strict-aliasing") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-strict-aliasing")
endif() endif()
if(NOT USE_OPENMP) if(NOT USE_OPENMP)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas -Wno-unused-private-field") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas -Wno-unused-private-field")
endif() endif()
if(__BUILD_FOR_R AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU") if(__BUILD_FOR_R AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-cast-function-type") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-cast-function-type")
endif() endif()
endif() endif()
if(WIN32 AND MINGW) if(WIN32 AND MINGW)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libstdc++") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libstdc++")
endif() endif()
if(MSVC) if(MSVC)
SET( set(
variables variables
CMAKE_C_FLAGS_DEBUG CMAKE_C_FLAGS_DEBUG
CMAKE_C_FLAGS_MINSIZEREL CMAKE_C_FLAGS_MINSIZEREL
...@@ -326,33 +326,33 @@ if(MSVC) ...@@ -326,33 +326,33 @@ if(MSVC)
CMAKE_CXX_FLAGS_RELEASE CMAKE_CXX_FLAGS_RELEASE
CMAKE_CXX_FLAGS_RELWITHDEBINFO CMAKE_CXX_FLAGS_RELWITHDEBINFO
) )
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4 /MP") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4 /MP")
if(USE_DEBUG) if(USE_DEBUG)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Od") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Od")
else() else()
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /O2 /Ob2 /Oi /Ot /Oy") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /O2 /Ob2 /Oi /Ot /Oy")
endif() endif()
else() else()
if(NOT BUILD_STATIC_LIB) if(NOT BUILD_STATIC_LIB)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")
endif() endif()
if(NOT USE_DEBUG) if(NOT USE_DEBUG)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -funroll-loops") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -funroll-loops")
endif() endif()
endif() endif()
SET(LightGBM_HEADER_DIR ${PROJECT_SOURCE_DIR}/include) set(LightGBM_HEADER_DIR ${PROJECT_SOURCE_DIR}/include)
SET(EXECUTABLE_OUTPUT_PATH ${PROJECT_SOURCE_DIR}) set(EXECUTABLE_OUTPUT_PATH ${PROJECT_SOURCE_DIR})
SET(LIBRARY_OUTPUT_PATH ${PROJECT_SOURCE_DIR}) set(LIBRARY_OUTPUT_PATH ${PROJECT_SOURCE_DIR})
include_directories(${LightGBM_HEADER_DIR}) include_directories(${LightGBM_HEADER_DIR})
if(APPLE) if(APPLE)
if(APPLE_OUTPUT_DYLIB) if(APPLE_OUTPUT_DYLIB)
SET(CMAKE_SHARED_LIBRARY_SUFFIX ".dylib") set(CMAKE_SHARED_LIBRARY_SUFFIX ".dylib")
else() else()
SET(CMAKE_SHARED_LIBRARY_SUFFIX ".so") set(CMAKE_SHARED_LIBRARY_SUFFIX ".so")
endif() endif()
endif() endif()
...@@ -403,7 +403,7 @@ endif() ...@@ -403,7 +403,7 @@ endif()
if(USE_SWIG) if(USE_SWIG)
set_property(SOURCE swig/lightgbmlib.i PROPERTY CPLUSPLUS ON) set_property(SOURCE swig/lightgbmlib.i PROPERTY CPLUSPLUS ON)
LIST(APPEND swig_options -package com.microsoft.ml.lightgbm) list(APPEND swig_options -package com.microsoft.ml.lightgbm)
set_property(SOURCE swig/lightgbmlib.i PROPERTY SWIG_FLAGS "${swig_options}") set_property(SOURCE swig/lightgbmlib.i PROPERTY SWIG_FLAGS "${swig_options}")
swig_add_module(_lightgbm_swig java swig/lightgbmlib.i) swig_add_module(_lightgbm_swig java swig/lightgbmlib.i)
swig_link_libraries(_lightgbm_swig _lightgbm) swig_link_libraries(_lightgbm_swig _lightgbm)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment