Unverified Commit 2a936a84 authored by Hubert Lu's avatar Hubert Lu Committed by GitHub
Browse files

[AMD] switch to custom allreduce regardless of MSCCL setting on ROCm (#6097)

parent 5e023301
...@@ -296,7 +296,6 @@ class CustomAllreduce: ...@@ -296,7 +296,6 @@ class CustomAllreduce:
self.meta, self.rank_data, handles, offsets, rank, self.full_nvlink self.meta, self.rank_data, handles, offsets, rank, self.full_nvlink
) )
self.register_buffer(self.buffer) self.register_buffer(self.buffer)
self.MSCCL = os.getenv("RCCL_MSCCL_ENABLE", "1") == "1"
self.disabled = False self.disabled = False
...@@ -430,13 +429,7 @@ class CustomAllreduce: ...@@ -430,13 +429,7 @@ class CustomAllreduce:
if _is_hip: if _is_hip:
if self.full_nvlink: if self.full_nvlink:
if self.world_size == 8: return inp_size < self.max_size
if self.MSCCL:
return False
else:
return inp_size < self.max_size
else:
return inp_size < self.max_size
return False return False
return False return False
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment