Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
change
sglang
Commits
2a936a84
"docs/vscode:/vscode.git/clone" did not exist on "34fab8b511846ca4d3432f17317026fed2d883ad"
Unverified
Commit
2a936a84
authored
May 08, 2025
by
Hubert Lu
Committed by
GitHub
May 08, 2025
Browse files
[AMD] switch to custom allreduce regardless of MSCCL setting on ROCm (#6097)
parent
5e023301
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
8 deletions
+1
-8
python/sglang/srt/distributed/device_communicators/custom_all_reduce.py
...srt/distributed/device_communicators/custom_all_reduce.py
+1
-8
No files found.
python/sglang/srt/distributed/device_communicators/custom_all_reduce.py
View file @
2a936a84
...
...
@@ -296,7 +296,6 @@ class CustomAllreduce:
self
.
meta
,
self
.
rank_data
,
handles
,
offsets
,
rank
,
self
.
full_nvlink
)
self
.
register_buffer
(
self
.
buffer
)
self
.
MSCCL
=
os
.
getenv
(
"RCCL_MSCCL_ENABLE"
,
"1"
)
==
"1"
self
.
disabled
=
False
...
...
@@ -430,13 +429,7 @@ class CustomAllreduce:
if
_is_hip
:
if
self
.
full_nvlink
:
if
self
.
world_size
==
8
:
if
self
.
MSCCL
:
return
False
else
:
return
inp_size
<
self
.
max_size
else
:
return
inp_size
<
self
.
max_size
return
inp_size
<
self
.
max_size
return
False
return
False
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment