GitLab

Summary:
Adding C++ documentation. (C++ APIs are categorized as prototype, though it's used by Python beta APIs.)

https://output.circle-artifacts.com/output/job/69654229-a99e-4b15-9ce0-7bc6bcf01101/artifacts/0/docs/libtorchaudio.html

<img width="1202" alt="Screenshot 2023-01-31 at 11 48 47 AM" src="https://user-images.githubusercontent.com/855818/215828167-d23032f8-9e40-4413-b5b1-5cbd12d705e9.png">

Pull Request resolved: https://github.com/pytorch/audio/pull/2994

Reviewed By: hwangjeff

Differential Revision: D42876621

Pulled By: mthrok

fbshipit-source-id: d8b8d610b87ec766501baa88b7506368a9905a6a

Summary:
https://github.com/pytorch/pytorch/pull/93155 Core has dropped python3.7

Pull Request resolved: https://github.com/pytorch/audio/pull/3020

Reviewed By: mthrok

Differential Revision: D42902346

Pulled By: weiwangmeta

fbshipit-source-id: 07ab1aff0e128c5960d87e5fa29e341310dea388

Summary:
Switch to Nova Linux Conda build.

Pull Request resolved: https://github.com/pytorch/audio/pull/2899

Reviewed By: seemethere, osalpekar, mthrok

Differential Revision: D42416835

Pulled By: DanilBaibak

fbshipit-source-id: 70886c4ff6f3243b80059be9385269cc0f2d4764

Summary:
XLS-R tests are supposed to be skipped on gpu machines, but they are forced to run in [_skipIf](https://github.com/pytorch/audio/blob/main/test/torchaudio_unittest/common_utils/case_utils.py#L143-L145) decorator. This PR skips the XLS-R tests if the machine is CI and CUDA is available.

Pull Request resolved: https://github.com/pytorch/audio/pull/2982

Reviewed By: xiaohui-zhang

Differential Revision: D42520292

Pulled By: nateanl

fbshipit-source-id: c6ee4d4a801245226c26d9cd13e039e8d910add2

Summary:
CC atalman

Pull Request resolved: https://github.com/pytorch/audio/pull/2951

Reviewed By: mthrok

Differential Revision: D42459205

Pulled By: atalman

fbshipit-source-id: b2d7c5604ba1f3bb4d9a45a052ac41054acd52dd

Summary:
Switch to Nova MacOS and M1 Wheels. This PR is a step in migrating from CircleCI to the Nova workflow.

- [x] Disable the CircleCI builds for MacOS Wheel.
- [x] Disable the CircleCI builds for M1 Wheel.
- [x] Enable the Nova workflow for MacOS Wheel.
- [x] Enable the Nova workflow for M1 Wheel.

Pull Request resolved: https://github.com/pytorch/audio/pull/2907

Reviewed By: osalpekar, mthrok

Differential Revision: D42040965

Pulled By: DanilBaibak

fbshipit-source-id: b87f028cf5686bf97265109591fb0a8c1190324c

Summary:
Switch to Nova Linux Wheel build.

- [x] Disable the CircleCI builds for Linux Wheel.
- [x] Enable the Nova workflow for Linux Wheel.

~The Linux Wheel Python3.8 build has been kept because it is a dependency for the `docstring_parameters_sync` job.~ As Omkar pointed out, Docstring Parameters Sync also runs on GHA (https://github.com/pytorch/audio/actions/runs/3638187635/jobs/6140090209). So, we completely switched to the Nova Linux Wheel build.

Pull Request resolved: https://github.com/pytorch/audio/pull/2896

Reviewed By: mthrok

Differential Revision: D41994993

Pulled By: DanilBaibak

fbshipit-source-id: 2bafdbe1b62ef8fa194ce96f4d4667a3ed3dc44f

Summary:
Dependent on PR https://github.com/pytorch/pytorch/pull/89101

Pull Request resolved: https://github.com/pytorch/audio/pull/2853

Reviewed By: atalman, osalpekar

Differential Revision: D41737634

Pulled By: malfet

fbshipit-source-id: 715a97a2da8ef309cea78d971b47c07463495683

Summary:
Increase inactivity timeout for binary build jobs

Pull Request resolved: https://github.com/pytorch/audio/pull/2754

Reviewed By: carolineechen

Differential Revision: D40275368

Pulled By: atalman

fbshipit-source-id: 5e682bb78bda640d615f874fbdf0e650b5a38ee0

Summary:
The goal is to to reduce the number of job failures due to timeouts, see https://app.circleci.com/pipelines/github/pytorch/audio/12882/workflows/f99da1a5-32e6-4bac-8ceb-fbf36d693e2d/jobs/936363?invite=true#step-105-105 for example.

Pull Request resolved: https://github.com/pytorch/audio/pull/2734

Reviewed By: weiwangmeta, atalman

Differential Revision: D40077578

fbshipit-source-id: 573f43a4d088a7086fa6925ac5ba1fdd1e8f39ec

Summary:
Cuda 10.2 deprecation, migration of unit tests from cuda 10.2 to cuda 11.6

Pull Request resolved: https://github.com/pytorch/audio/pull/2724

Reviewed By: weiwangmeta

Differential Revision: D39912484

Pulled By: atalman

fbshipit-source-id: e760b630375eae94384cda68d24f83ef46ada6d9

Summary:
Revert this fot now untill docker is updated

Pull Request resolved: https://github.com/pytorch/audio/pull/2723

Reviewed By: nateanl

Differential Revision: D39900382

Pulled By: atalman

fbshipit-source-id: f8701e359bc11e8f9f3a29144f7e7da336a470da

Summary:
Removing cuda102

Pull Request resolved: https://github.com/pytorch/audio/pull/2715

Reviewed By: hwangjeff

Differential Revision: D39823444

Pulled By: atalman

fbshipit-source-id: c11d798ab86cf9a6d5ed3804958b4a0c2f8a87ff

Summary:
Example job that was failing previously:
https://app.circleci.com/pipelines/github/pytorch/audio/12796/workflows/ae96794a-6df4-4a2a-84df-ada7a7250045/jobs/927709

The failure:
```
"Detected that PyTorch and TorchAudio were compiled with different CUDA versions. "
RuntimeError: Detected that PyTorch and TorchAudio were compiled with different CUDA versions. PyTorch has CUDA version 11.7 whereas TorchAudio has CUDA version 11.6. Please install the TorchAudio version that matches your PyTorch version.
```

Has install command:
```
pip install $(ls ~/workspace/torchaudio*.whl) -f "https://download.pytorch.org/whl/${UPLOAD_CHANNEL}/torch_${UPLOAD_CHANNEL}.html"

# expands to:
pip install /c/Users/circleci/workspace/torchaudio-0.13.0.dev20220927+cu116-cp37-cp37m-win_amd64.whl -f https://download.pytorch.org/whl/nightly/torch_nightly.html
```

Linux job (succeeds) for uses different "-f" (find links) url, that includes specific cuda version:
https://app.circleci.com/pipelines/github/pytorch/audio/12809/workflows/aadca2ab-5a00-4a0a-ab6a-4a1b7a503713/jobs/927861

Command:
```
pip install $(ls ~/workspace/torchaudio*.whl) -f "https://download.pytorch.org/whl/${UPLOAD_CHANNEL}/${CU_VERSION}/torch_${UPLOAD_CHANNEL}.html"

# expands to:
 pip install /root/workspace/torchaudio-0.13.0.dev20220927+cu116-cp37-cp37m-linux_x86_64.whl -f https://download.pytorch.org/whl/nightly/cu116/torch_nightly.html

```

This PR makes Windows installation match the linux one.

Testing:
* verified command manually on Circle CI:
```
>>> import torch
>>> import torchaudio
C:\tools\miniconda3\lib\site-packages\torchaudio\compliance\kaldi.py:22: UserWarning: Failed to initialize NumPy: numpy.core.multiarray failed to import (Triggered internally at C:\actions-runner\_work\pytorch\pytorch\builder\windows\pytorch\torch\csrc\utils\tensor_numpy.cpp:77.)
  EPSILON = torch.tensor(torch.finfo(torch.float).eps)
C:\tools\miniconda3\lib\site-packages\torchaudio\backend\utils.py:62: UserWarning: No audio backend is available.
  warnings.warn("No audio backend is available.")
```

Co-authered: weiwangmeta

Pull Request resolved: https://github.com/pytorch/audio/pull/2721

Reviewed By: hwangjeff

Differential Revision: D39870805

Pulled By: izaitsevfb

fbshipit-source-id: 2957cba4f53d00783a5c07099f24050ce15e7d1c

Summary:
Pull Request resolved: https://github.com/pytorch/audio/pull/2718

Original commit changeset: 7e222d80ca07

Original Phabricator Diff: D39756852 (https://github.com/pytorch/audio/commit/7ba7cf4d24a2967b8fa4aaff437116524281f8fd)

Reviewed By: weiwangmeta

Differential Revision: D39839899

fbshipit-source-id: f5605eb9882f7c7f0008e88338ab711131b29404

Summary:
Conda version on circleCI prints following message:
```
==> WARNING: A newer version of conda exists. <==
  current version: 4.6.14
  latest version: 4.14.0
```
and as a result this error:

```
+ /c/tools/miniconda3/Scripts/conda.exe install -v -y -c pytorch-nightly -c nvidia pytorch numpy ffmpeg pytorch-cuda=11.6
Collecting package metadata: ...working... done
Solving environment: ...working...

Too long with no output (exceeded 30m0s): context deadline exceeded
```

This should update the conda version running on the system and allow us to install pytorch and run some tests.

Pull Request resolved: https://github.com/pytorch/audio/pull/2704

Reviewed By: weiwangmeta

Differential Revision: D39820037

Pulled By: atalman

fbshipit-source-id: 4a82a7a6cbe3dc1a5807ac669e2fa79f454037fa

Summary:
Remove linux wheel from circleci

Pull Request resolved: https://github.com/pytorch/audio/pull/2714

Reviewed By: weiwangmeta

Differential Revision: D39816121

Pulled By: atalman

fbshipit-source-id: a3c99b530896888d7b4271d8b3f27f3c986b3480

Summary:
This does 2 things:

Comments out Linux Wheels-related jobs in CircleCI so that they are not run on nightlies/releases.
Adds a GHA workflow that calls the build workflow in pytorch/test-infra.
Testing:
Verified that the builds are triggered by this workflow, and all builds are green: https://github.com/pytorch/audio/actions/runs/3109635749/jobs/5040029155

Pull Request resolved: https://github.com/pytorch/audio/pull/2702

Reviewed By: seemethere

Differential Revision: D39756852

Pulled By: osalpekar

fbshipit-source-id: 7e222d80ca0720e3be43b929f1e55f5c0166b947

Summary: Pull Request resolved: https://github.com/pytorch/audio/pull/2672

Reviewed By: atalman

Differential Revision: D39468320

Pulled By: mthrok

fbshipit-source-id: 0e7bd4fd922ba0db51700e140b95328a5b687a6f

Summary:
CUDA 11.3 Removing.

Core PR: https://github.com/pytorch/pytorch/pull/84866
cc malfet ptrblck

Pull Request resolved: https://github.com/pytorch/audio/pull/2670

Reviewed By: malfet, osalpekar

Differential Revision: D39449263

Pulled By: atalman

fbshipit-source-id: f86bb119685ead3ffcabd92c4bb8076aecde4095

Summary:
CC atalman

Pull Request resolved: https://github.com/pytorch/audio/pull/2623

Reviewed By: hwangjeff, nateanl

Differential Revision: D39036432

Pulled By: atalman

fbshipit-source-id: cd74a1bf8f74e31bd2c32c80d32c617f4b1766e8

Summary:
Similar to https://github.com/pytorch/vision/pull/6218
Fixing MacOS builds

Pull Request resolved: https://github.com/pytorch/audio/pull/2622

Reviewed By: weiwangmeta

Differential Revision: D38722983

Pulled By: atalman

fbshipit-source-id: 4cef85c97dc270fc812bc289592c4f3815f73c85

Summary:
Introducing pytorch-cuda metapackage

Same as: https://github.com/pytorch/vision/pull/6371
Following PR: https://github.com/pytorch/builder/pull/1094
Adds cuda metapackage called pytorch-cuda . This way we can make sure to install correct version of cuda dependencies and don't depend on conda-forge.

Pull Request resolved: https://github.com/pytorch/audio/pull/2612

Reviewed By: hwangjeff, seemethere, nateanl

Differential Revision: D38633332

Pulled By: atalman

fbshipit-source-id: 78a6115bb252ebdb6d66a57d7d2c4a4978ddb501

Summary:
This commit enables CTC decoder on Windows.

The functionality seems to work fine.
The tests are passing, the decoding tutorial runs fine.

The only difference to the Linux/macOS version is that
loading model in XZ compression format is not supported.

![289961785_399620772041679_7768117002438616376_n](https://user-images.githubusercontent.com/855818/181420923-cfbd8402-20de-4e63-b9e4-e39f9aa9fc50.png)

Pull Request resolved: https://github.com/pytorch/audio/pull/2587

Reviewed By: carolineechen, nateanl

Differential Revision: D38276490

Pulled By: mthrok

fbshipit-source-id: f2203b2235c5bbb0220fe560aaaf0e1d5530347a

Summary:
- The "speech + noise" mixture still has a high SNR, which can't show the effectiveness of MVDR beamforming. To make the task more challenging, amplify the noise waveform to reduce the SNR of mixture speech.
- Show the Si-SNR score of mixture speech when visualizing the mixture spectrogram.
- FIx the figure in `rtf_power` subsection.
    - The description of enhanced spectrogram by `rtf_power` is wrong. Correct it to `rtf_power`.
- Print PESQ, STOI, and SDR metric scores.

Pull Request resolved: https://github.com/pytorch/audio/pull/2527

Reviewed By: mthrok

Differential Revision: D38190218

Pulled By: nateanl

fbshipit-source-id: 39562850a67f58a16e0a2866ed95f78c3f4dc7de

Summary:
Add tutorial python file, draft PR, will continue to modify accordingly to feedback.

Future plan: modify spectrogram and bottom audio design and work on finding best audio track and segments

Pull Request resolved: https://github.com/pytorch/audio/pull/2572

Reviewed By: carolineechen, nateanl, mthrok

Differential Revision: D38234001

Pulled By: skim0514

fbshipit-source-id: fe9207864f354dec5cf5ff52bf7d9ddcf4a001d5

Summary:
This commit fix build_docs job timeout by pinning `resampy=0.2.2`.

For some mysterious reason, `resampy=0.3.1` causes slowdown of unrelated code. https://github.com/bmcfee/resampy/issues/106

Pull Request resolved: https://github.com/pytorch/audio/pull/2543

Reviewed By: carolineechen

Differential Revision: D38115003

Pulled By: mthrok

fbshipit-source-id: 67cd1c73dd4adb3091e0b88aaf5c31de0dd4b87e

Summary:
Recent CircleCI migration https://github.com/pytorch/audio/pull/2529
silently bumped the minimum supported macOS version to 11.

PyTorch still supports 10.9 and the ecosystem still uses 10.9.
Issue: https://github.com/pytorch/audio/issues/2536

This commit sets MACOSX_DEPLOYMENT_TARGET=10.9, so that binary
distribution are compatible on macOS=10.9.

Pull Request resolved: https://github.com/pytorch/audio/pull/2546

Reviewed By: atalman

Differential Revision: D37854586

Pulled By: mthrok

fbshipit-source-id: a43986ae4de9ef51a4261e0f9fe58e88b4b72148

Summary:
CircleCI is removing Xcode 12.4.0 image on August, and there was a planned
burnout on July 6th. [[detail](https://discuss.circleci.com/t/xcode-image-deprecation/44294?mkt_tok=NDg1LVpNSC02MjYAAAGFbbxbX7nSPCzN0MCKN078pw0VLJ-TMdICr8_gouRNYBM8C55RL8NDKLXA_9CQGPqnhJE5lsSFdetLRF-nH7iBLzoPGBfYpf2vuJ-XkW_C4__4)]

https://app.circleci.com/pipelines/github/pytorch/audio/11566/workflows/da167296-a84f-4dfe-b1b9-60d67e7a3d1c/jobs/771638

This commit updates Xcode image to 12.5

Pull Request resolved: https://github.com/pytorch/audio/pull/2529

Reviewed By: atalman

Differential Revision: D37688122

Pulled By: mthrok

fbshipit-source-id: 1095edbf0d920c4dc772555915bce93875b74671

Summary:
Following the formatter changes heppened in fbcode, this commit update the linter config.

Pull Request resolved: https://github.com/pytorch/audio/pull/2389

Reviewed By: hwangjeff

Differential Revision: D37659649

Pulled By: mthrok

fbshipit-source-id: 1c52ff93f0b10cb2e7303d2ad13b2d65ffccfcb0

Summary:
The build doc job is failing these days due to the fact that CUDA 11.6 requires different handling.

Pull Request resolved: https://github.com/pytorch/audio/pull/2520

Reviewed By: xiaohui-zhang

Differential Revision: D37527088

Pulled By: mthrok

fbshipit-source-id: 34c23bdbf70ba9fb8e315c7036cff01b3ddf4c91

Summary:
Fix for the cuda 11.6 and usage of cudatoolkit

Pull Request resolved: https://github.com/pytorch/audio/pull/2501

Reviewed By: mthrok

Differential Revision: D37388598

Pulled By: atalman

fbshipit-source-id: 41add7ad6fbb3d156cc1270625dc085c62f7a531

Summary:
Lint style has diverged since fb-internal lint engine has been changed.

Backport of https://github.com/pytorch/audio/issues/2466.

Pull Request resolved: https://github.com/pytorch/audio/pull/2487

Reviewed By: carolineechen

Differential Revision: D37160193

Pulled By: mthrok

fbshipit-source-id: cf4e2091a78a0da53269ae1251a55d4d1e52ead2

Summary:
At the time of release, we need to download doc built by CI.
CircleCI does not have feature to download multiple files.

This commit add the archive of built documentations as
CI artifact so that the whole documentation can be downloaded
at once.

Resolves https://github.com/pytorch/audio/issues/2340

Pull Request resolved: https://github.com/pytorch/audio/pull/2448

Reviewed By: hwangjeff

Differential Revision: D36942077

Pulled By: mthrok

fbshipit-source-id: 61dde0d71841434a3d0624404d99911aa6956f88

Summary:
Remove the code related to libmad, which had been disabled in https://github.com/pytorch/audio/issues/2354

In https://github.com/pytorch/audio/issues/2419, we mp3 decoding to ffmpeg. But CI tests were still using libmad.
This commit completely removes libmad from torchaudio.

This is BC-breaking change as `apply_sox_effects_file` function cannot handle MP3, and it cannot fallback to ffmpeg.
The workaround for this is to use `torchaudio.load` then `apply_sox_effects_tensor`.

Pull Request resolved: https://github.com/pytorch/audio/pull/2428

Reviewed By: carolineechen

Differential Revision: D36851805

Pulled By: mthrok

fbshipit-source-id: f98795c59a1ac61cef511f2bbeac37f7c3c69d55

Summary:
A couple of weeks ago we started to see OpenMP not found error on macOS CI.
From https://github.com/pytorch/audio/issues/2404, we install OpenMP from brew, and build passes, but unit tests are seg-faulting ever since.

https://app.circleci.com/pipelines/github/pytorch/audio/10825/workflows/c0ecae99-d409-4df2-ab91-9bcb126c309d/jobs/671518

The failing test uses `torchaudio.functional.filitfilt`, which uses [OpenMP for parallel execution](https://github.com/pytorch/audio/blob/6057d3cf1c2f3a4c5072a3853a021bb8b4ce61f7/torchaudio/csrc/lfilter.cpp#L20).

This commit reverts https://github.com/pytorch/audio/issues/2404 and disables OpenMP for macOS builds and tests.

Pull Request resolved: https://github.com/pytorch/audio/pull/2431

Reviewed By: atalman

Differential Revision: D36819141

Pulled By: mthrok

fbshipit-source-id: 824300866a55f8b029d21649dc96cd80ae2ff697

Summary:
After https://github.com/pytorch/audio/issues/2395, build_doc job is exceeding default no-output-timeout
threshould (10m).

This commit updates the timeout threshold to 30m.
Also it moves the installation of tools to the previous step.

Pull Request resolved: https://github.com/pytorch/audio/pull/2399

Reviewed By: carolineechen

Differential Revision: D36539022

Pulled By: mthrok

fbshipit-source-id: 391764a0fb5bf87cfb2beaab401a90dcb56493e5

Summary:
This commit adds tutorial to enable/use NVDEC with Stream API.

https://output.circle-artifacts.com/output/job/19e66a4b-1819-4804-8834-d38e6c80c4fd/artifacts/0/docs/hw_acceleration_tutorial.html

Because the use of NVDEC requires build / install FFmpeg from source,
this tutorial was authored on Google Colab, tailored to its environment.

The tutorial here is the result of the notebook execution, with
the link to the publicly accessible Google Colab notebook.

Pull Request resolved: https://github.com/pytorch/audio/pull/2393

Reviewed By: hwangjeff

Differential Revision: D36404408

Pulled By: mthrok

fbshipit-source-id: 9c820d3db4d06c5b343ecad0708489125ca06948

Summary:
To resolve nightly / general build issues relating to OpenMP not being found, see https://hud.pytorch.org/pytorch/audio/commit/c6a376cc5679c1940e49fc3e0ba22eaead6c2467



```
-- Found Torch: /Users/distiller/miniconda3/envs/env3.10/lib/python3.10/site-packages/torch/lib/libtorch.dylib
CMake Error at /Users/distiller/miniconda3/envs/env3.10/lib/python3.10/site-packages/cmake/data/CMake.app/Contents/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)
Call Stack (most recent call first):
  /Users/distiller/miniconda3/envs/env3.10/lib/python3.10/site-packages/cmake/data/CMake.app/Contents/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /Users/distiller/miniconda3/envs/env3.10/lib/python3.10/site-packages/cmake/data/CMake.app/Contents/share/cmake-3.22/Modules/FindOpenMP.cmake:544 (find_package_handle_standard_args)
  CMakeLists.txt:131 (find_package)

-- Configuring incomplete, errors occurred!
```
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Pull Request resolved: https://github.com/pytorch/audio/pull/2404

Reviewed By: atalman

Differential Revision: D36495791

Pulled By: seemethere

fbshipit-source-id: 7b6fa2a62fda6fc468cfcbdf8d2163e6b9c327b0

Summary:
This commit moves `build_doc` job to run on top of Conda binary
build job.

The motivation is that Conda provides easy access to third party
tools that are required to build complex documentation.

Specifically in https://github.com/pytorch/audio/pull/2393,
ipynb-style tutorial is being added, which requires `nbsphinx`.

`nbsphinx` requires `pandoc` package and there was some issue
with the version from PyPI. A workaround is to use the one from
Conda package.

Pull Request resolved: https://github.com/pytorch/audio/pull/2395

Reviewed By: carolineechen, nateanl

Differential Revision: D36404407

Pulled By: mthrok

fbshipit-source-id: 26ec5ebfd5be795384306a9f24817a2eb3ec96c1