GitLab

Summary: By accident I think, we have been nudging people to install python 3.6. Using 3.8 is fine.

Reviewed By: nikhilaravi

Differential Revision: D20597240

fbshipit-source-id: 7fb778f1b84746db28b6eef763564af5c5fffcd7

Summary: Add pattern linter for PyTorch3D and SlowFast, this will suggest typo fixes whenever the wrong case is accidentally used.

Reviewed By: wanyenlo

Differential Revision: D20498696

fbshipit-source-id: 1a3f4702bd0dbe06e81d0f301b3ea38ea62e7885

Summary: Use a consistent case for PyTorch3D (matching the logo...): replace all occurrences of PyTorch3d with PyTorch3D across the codebase (including documentation and notebooks)

Reviewed By: wanyenlo, gkioxari

Differential Revision: D20427546

fbshipit-source-id: 8c7697f51434c51e99b7fe271935932c72a1d9b9

Reviewed By: nikhilaravi

Differential Revision: D20218481

fbshipit-source-id: b153282cc30ad75de970c89ae64526b6be62ee95

Summary: Document existence of nightly build. Fix some mistakes in windows-related CI code (not running yet).

Reviewed By: nikhilaravi

Differential Revision: D20030293

fbshipit-source-id: 2199ea7c6d34e881aa5641726feb6bfc20337ce3

Summary:
Lint related fixes: Improve internal/OSS consistency. Fix the fight between black and certain pyre-ignore markers by moving them to the line before.
Use clang-format-8 automatically if present. Small number of pyre fixes.

arc doesn't run pyre at the moment, so I put back the explicit call to pyre. I don't know if there's an option somewhere to change this.

Reviewed By: nikhilaravi

Differential Revision: D19780518

fbshipit-source-id: ef1c243392322fa074130f6cff2dd8a6f7738a7f

Summary:
Fixed a few MSVC compiler (visual studio 2019, MSVC 19.16.27034) compatibility issues
1. Replaced long with int64_t. aten::data_ptr\<long\> is not supported in MSVC
2. pytorch3d/csrc/rasterize_points/rasterize_points_cpu.cpp, inline function is not correctly recognized by MSVC.
3. pytorch3d/csrc/rasterize_meshes/geometry_utils.cuh
const auto kEpsilon = 1e-30;
MSVC does not compile this const into both host and device, change to a MACRO.
4. pytorch3d/csrc/rasterize_meshes/geometry_utils.cuh,
const float area2 = pow(area, 2.0);
2.0 is considered as double by MSVC and raised an error
5. pytorch3d/csrc/rasterize_points/rasterize_points_cpu.cpp
std::tuple<torch::Tensor, torch::Tensor> RasterizePointsCoarseCpu() return type does not match the declaration in rasterize_points_cpu.h.
Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/9

Reviewed By: nikhilaravi

Differential Revision: D19986567

Pulled By: yuanluxu

fbshipit-source-id: f4d98525d088c99c513b85193db6f0fc69c7f017

Summary:
pybind now seems to need C++17 on a mac, so advise people to use it. (Also delete an unused variable to silence a warning I got on a mac build.)

Reported in github issue #68.

Reviewed By: nikhilaravi

Differential Revision: D19970512

fbshipit-source-id: f9be20c8ed425bd6ba8d009a7d62dad658dccdb1

Summary:
the dot at the pip command was outside of the inline code formatting. I just moved the back tick after the dot.
Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/21

Differential Revision: D19791603

Pulled By: nikhilaravi

fbshipit-source-id: 6b0bedd2a788aef0d9678f9c1c25354ada76a3f4

Reviewed By: bottler, wanyenlo

Differential Revision: D19658045

fbshipit-source-id: a623a81c1ed1fa4054ea55bf06a2926e297b7966

Summary: Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/8

Differential Revision: D19556466

Pulled By: nikhilaravi

fbshipit-source-id: 26aa361882b688e7cd159e0d7d8cfad37d0049c1

fbshipit-source-id: ad58e416e3ceeca85fae0583308968d04e78fe0d