• merayxu's avatar
    Fixed windows MSVC build compatibility (#9) · 9e21659f
    merayxu authored
    Summary:
    Fixed a few MSVC compiler (visual studio 2019, MSVC 19.16.27034) compatibility issues
    1. Replaced long with int64_t. aten::data_ptr\<long\> is not supported in MSVC
    2. pytorch3d/csrc/rasterize_points/rasterize_points_cpu.cpp, inline function is not correctly recognized by MSVC.
    3. pytorch3d/csrc/rasterize_meshes/geometry_utils.cuh
    const auto kEpsilon = 1e-30;
    MSVC does not compile this const into both host and device, change to a MACRO.
    4. pytorch3d/csrc/rasterize_meshes/geometry_utils.cuh,
    const float area2 = pow(area, 2.0);
    2.0 is considered as double by MSVC and raised an error
    5. pytorch3d/csrc/rasterize_points/rasterize_points_cpu.cpp
    std::tuple<torch::Tensor, torch::Tensor> RasterizePointsCoarseCpu() return type does not match the declaration in rasterize_points_cpu.h.
    Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/9
    
    Reviewed By: nikhilaravi
    
    Differential Revision: D19986567
    
    Pulled By: yuanluxu
    
    fbshipit-source-id: f4d98525d088c99c513b85193db6f0fc69c7f017
    9e21659f
INSTALL.md 3.01 KB