GitLab

* dev

* dev

* dev

* Update static_analysis.yml

* Update .pre-commit-config.yaml

---------
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* [ci] [c++] use 'pre-commit' to run 'cpplint', upgrade to 'cpplint' 2.0.2

* remove bashisms

* one more pipefail use

* another pipefail

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

remove redundant whitespaces

* check existence of inet_pton for win32 in CMakeLists.txt (fix #5019)

* remove extra spaces

* add check for inet_pton in configure.win

* Update CMakeLists.txt
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update src/network/socket_wrapper.hpp
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update src/network/socket_wrapper.hpp
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeLists.txt
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update R-package/configure.win
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeLists.txt
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* fix comments in CMakeLists.txt

* include check for WIN64

* remove WIN64 flag checks

* fix #ifdef

* Update R-package/configure.win
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update dataset_loader.cpp

* Update gbdt.h

* Update regression_objective.hpp

* Update linker_topo.cpp

* Update xentropy_objective.hpp

* Update regression_objective.hpp

* investigate inf test failure

* avoid overflow in regression objective

* remove `test_inf_handle` test
Co-authored-by: Guolin Ke <guolin.ke@outlook.com>

* Update dataset_loader.cpp

* Update config.cpp

* Update application.cpp

* Update linkers_socket.cpp

* Correct spelling

Most changes were in comments, and there were a few changes to literals for log output.

There were no changes to variable names, function names, IDs, or functionality.

* Clarify a phrase in a comment
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Clarify a phrase in a comment
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Clarify a phrase in a comment
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Correct spelling

Most are code comments, but one case is a literal in a logging message.

There are a few grammar fixes too.
Co-authored-by: James Lamb <jaylamb20@gmail.com>

This allows for network retries, to scale well with the
number of machines, and still retains the existing functionality
for cases with smaller num_machines ( 500 )

Fixes #3301
Co-authored-by: Aakarsh Gopi <aakarsh@vaticlabs.com>

* [R-package] update DESCRIPTION per CRAN comments

* newlines

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* more fixes

* update Rbuildignore

* more changes

* more changes per CRAN response

* add email

* run examples in CI

* add newest CRAN response

* add Solaris patch

* update patch

* another attempt at ifaddrs patch

* fix unnecessary comment

* update configure

* comments

* bump version

* tabs

* fix address alignment, required by cran (#3415)

* fix dataset binary file alignment

* many fixes

* fix warnings

* fix bug

* Update file_io.cpp

* Update file_io.cpp

* simplify code

* Apply suggestions from code review

* general

* remove unneeded alignment

* Update file_io.h

* int32 to byte8 alignment

* Apply suggestions from code review

* Apply suggestions from code review

* [R-package] add new copyright holder in DESCRIPTION (#3409)

* [R-package] add new copyright holder in DESCRIPTION

* fix role

* fixing conflicts

* [R-package] add new copyright holder in DESCRIPTION (#3409)

* [R-package] add new copyright holder in DESCRIPTION

* fix role

* trying to fix conflicts

* more fixes

* this will work

* update cran-comments

* simplify solaris, add more testing docs

* stuff

* remove rchck docs

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* remove extra use of cat()

* change solaris check

* update docs

* remove testing code

* fix warning about cleanup not having execute permissions

* fix cmake builds

* remove blank line
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Guolin Ke <guolin.ke@outlook.com>

This reverts commit 656d2676.

* fix

* Apply suggestions from code review
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>

* various minor style, docs and cpplint improvements

* fixed typo in warning

* fix recently added cpplint errors

* move note for params upper in description for consistency

* LightGBM would hang on MPI run if only some nodes have a fatal error. The issue is that the destructor of Application calls MPI_Finalize(), which will cause the program to hand and prevent from exiting. So we move the network finalization out of the destructor and call MPI_Finalize() or MPI_Abort() based on whether there was an unhandled exception.

* Minor updates: Remove excess debug logging, whitespaces.

* Add comments for new functions.

* fixed miscellaneous typos in documentation

* fix typo introduced in typo-fixing PR

* refined order of includes

* hotfix

* fix many cpp lint errors

* indent

* fix bug

* fix more

* fix gpu

* more fixes

* change network retry delay strategy

* refine

* added all necessary includes - fixed build/include_what_you_use error

* fixed the order of includes (build/include_order)

* fix include

* reduce dependency on header file

* fix build