GitLab

* Fix resnet missing layers.

The official v1 model contains BN and Relu between input layer and
pooling.

* Remove the BN and Relu for V2.

After some discussion with team and refer to existing
implementation, those two layer seems to be only useful in V1.
In V2, the first unit of the block will have a projection, that
apply the BN and Relu for the shortcut. Adding a comment to make
this clear.

* Expand the comment section.

* Remove the pre-trained checkpoint since its broken right now.

Will restore it once we have new checkpoint generated.

* Move the benchmark_uploader to new location.

* Update benchmark logger to streaming upload.

* Fix lint and unit test error.

* delint.

* Update the benchmark uploader test.

Skip the import of benchmark_uploader when bigquery is not installed.

* Merge the 2 classes of benchmark uploader into 1.

* Address review comments.

* delint.

* Execute bigquery upload in a separate thread.

* Change to use python six.moves for importing.

* Address review comments and delint.

* Address review comment.

Adding comment for potential performance impact for model on CPU.

* Fix random failure on py3.

* Fix the order of flag saver to avoid the randomness.

The test is broken when the benchmark_logger_type is set first, and
validated when the benchmark_log_dir is not set yet.

The final BN and ReLU layer is only need for v2 model since it was
doing preactivation in each block.

* forbid resnet v1 fp16

* address PR comments

* rename --version flag and fix tests to correctly specify version rather than verbosity

* rename version to resnet_version throughout

* fix bugs

* delint

* missed layer_test

* fix indent

* Add dataset info and hyper parameter logging for benchmark.

* Address review comments.

* Address the view comment for data schema name.

* Fix test cases.

* Lint fix.

* Revert 823da318. This restores distribution strategies for resnet.

This commit is not a direct revert due to significant merge conflict
resolution.

* fix flags test

* npc is no longer used in resnet

* fix treatment of main() and absl flags

* add mnist_eager, and delint

* add mnist_eager docstring

* squash of modular absl usage commits

* delint

* address PR comments

* change hooks to comma separated list, as absl behavior for space separated lists is not as expected

Refer to commit "use reduce_mean instead of Average Pooling"(d5663b3c), "second_pool_size" and "second_pool_stride" no longer needed in resnet_model

1. trainning hooks and train/eval function does not need to be
declared several times.
2. change to use tf.logging.info instead of print
3. Show the current index and total count of training cycle, which
give user some hint about where they are in the whole process.

* Update the benchmark logger to have default logging.

1. Create global instance of benchmark logger, which default log to
tf.logging.info
2. Allow user to config the logging location.
3. Fix nits in code and comment.

* Fix lint and test error.

* Address review comments.

* Remove the duplicated print statement.

This reverts commit 32aa6563.

* begin transfer from contrib fork

more changes to resnet_run_loop

use AUTOTUNE in prefetch

first pass at resnet with functional distribution strategies

fix syntax error

delint

aesthetic tweaks

delint and fix typos

rip multi_gpu flag out of resnet entirely. Subject to saved model load verification

update cifar10 and imagenet tests to reflect that the model function no longer need to know about multi_gpu

fix imagenet test

start addressing PR comments

more PR response work

* misc tweaks

* add a comment

* final pr tweaks

* fix parsers

* Adding tests

* Adding tests

* Repackaging

* Adding logging

* Linting

* Add fp16 support to resnet.

* address PR comments

* add dtype checking to model definition

* delint

* more PR comments

* few more tweaks

* update resnet checkpoints

* Updating name of logging package to avoid overwriting Python builtin logging.

* Updating name of logging package to avoid overwriting Python builtin logging.

* Adding new checkpoints

* Adding links to other files as well

* Adding export_dir and model saving for Resnet

* Moving to utils for tests

* Adding batch_size

* Adding multi-gpu export warning

* Responding to CR

* Py3 compliance

* Add benchmark upload util to bigquery.

Also update the benchmark logger and bigquery schema for the
errors found during the integration test.

* Fix lint error.

* Update test to clear all the env vars during test.

This was causing error since the Kokoro test has TF_PKG=tf-nightly
injected during test.

* Update lintrc to ignore google related package.

* Another attempt to fix lint import error.

* Address the review comment.

* Fix lint error.

* Another fix for lint.

* Update test comment for env var clean up.

* Add golden test util to streamline symbolic and numerical comparison to reference graphs, and apply golden tests to ResNet.

update tests

use more concise logic for path property

delint

add some comments

delint

address PR comments

make resnet tests more concise, and supress warning test in py2

change resnet name template

more shuffling of data dirs

address PR comments and add tensorflow version info

Remove subTest due to py2

switch from tf.__version__ to tf.VERSION, and include tf.GIT_VERSION

supress lint error from json load unpack

* address PR comments

* address PR comments

* delint

* Update reset model for benchmark logging.

To enable benchmark logging, just add "--hooks LoggingMetricHook"

* Benchmark logger fix for resnet.

1. Update default at_end to False for metric logger to avoid
checkpoint error.
2. Update resnet run to log final evaluation result.

* Update log output for final eval_result.

* Typo fix.

* Unset the default value for benchmark_log_dir.

Usually the benchmark should be logged to different directly for
each run. Having a default value will hide the choice from user.

* Bug fix for benchmark logger initialization.

* Fix lint error.

* Address the review comment.

1. Update the logger to cover evaluation result.
2. Move the flag to performance parser.

* Undo the change for arg_parser.

* Try out affine layer instead of dense

* Use reduce mean instead of avg pooling

* Remove np

* Use reduce mean instead of avg pooling

* Fix axes

* Cleanup

* Fixing comment

* Fixing tests

Set correct number of train_epochs for resnet on imagenet, and fix help interception caused by moving arg parsing into main functions for resnet. (#3653)

* Glint everything

* Adding rcfile and pylinting

* Extra newline

* Few last lints

Use util functions hooks_helper and parser in mnist and wide_deep, and rename epochs_between_eval (from epochs_per_eval) (#3650)

* use proper temp directory for end to end tests.

* add supers to tearDown

This commit adds a basic end to end test for resnet cifar10 and imagenet models to check for syntax errors outside of the core neural net code. 

* Update resnet with logging utils

* intermediate commit

* commit before rebase from master

* Add tests of ExamplePerSecondHook

* Done with test

* Fix a style nit

* Fix a style nit