Commits · 52f44dd6d23f5c1b3d550685c50281fa6ca12ff3 · chenpangpang / transformers

05 Nov, 2020 2 commits

change TokenClassificationTask class methods to static methods (#7902) · 52f44dd6

Bobby Donchev authored Nov 05, 2020



* change TokenClassificationTask class methods to static methods

Since we do not require self in the class methods of TokenClassificationTask we should probably switch to static methods. Also, since the class TokenClassificationTask does not contain a constructor it is currently unusable as is. By switching to static methods this fixes the issue of having to document the intent of the broken class.

Also, since the get_labels and read_examples_from_file methods are ought to be implemented. Static method definitions are unchanged even after inheritance, which means that it can be overridden, similar to other class methods.

* Trigger Build
Co-authored-by: Lysandre <lysandre.debut@reseau.eseo.fr>

52f44dd6

Corrected typo in readme (#8320) · 77c8f6c6
Guillem García Subies authored Nov 05, 2020

77c8f6c6

04 Nov, 2020 4 commits
- Clean up data collators and datasets (#8308) · 9c4aa4ac
  Sylvain Gugger authored Nov 04, 2020
```
* Clean up data collators and datasets

* Apply suggestions from code review
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>

* Remove needless clone
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
```
  9c4aa4ac
- Fix path to old run_language_modeling.py script (#8302) · b1d3e95e
  Manuel Romero authored Nov 04, 2020
  
  b1d3e95e
- Fix validation file loading in scripts (#8298) · cf897246
  Sylvain Gugger authored Nov 04, 2020
  
  cf897246
- Fix typo in language-modeling README.md (#8287) · 734afa37
  Pengzhi Gao authored Nov 04, 2020
  
  734afa37
03 Nov, 2020 6 commits
- [CIs] Better reports everywhere (#8275) · 1bb4bba5
  Stas Bekman authored Nov 03, 2020
```
* make it possible to invoke testconf.py in both test suites without crashing on having the same option added

* perl -pi -e 's|--make_reports|--make-reports|' to be consistent with other opts

* add `pytest --make-reports` to all CIs (and artifacts)

* fix
```
  1bb4bba5
- make files independent (#8267) · 068e6b5e
  Patrick von Platen authored Nov 03, 2020
  
  068e6b5e
- [examples] minimal version requirement run-time check in PL (#8133) · cd360dcb
  Stas Bekman authored Nov 03, 2020
```
Co-authored-by: Sam Shleifer <sshleifer@gmail.com>
```
  cd360dcb
- Fix Tatoeba skip · eb6313e8
  Lysandre authored Nov 03, 2020
  
  eb6313e8
- Skip tatoeba tests if Tatoeba-Challenge not cloned (#8260) · b63beb74
  Sam Shleifer authored Nov 03, 2020
  
  b63beb74
- [Seq2Seq] Correct import in Seq2Seq Trainer (#8254) · 9f1747f9
  Patrick von Platen authored Nov 03, 2020
  
  9f1747f9
02 Nov, 2020 1 commit

Add line by line option to mlm/plm scripts (#8240) · e1b1b614

Sylvain Gugger authored Nov 02, 2020



* Make line by line optional in run_mlm

* Add option to disable dynamic padding

* Add option to plm too and update README

* Typos

* More typos

* Even more typos

* Apply suggestions from code review
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>

e1b1b614

01 Nov, 2020 1 commit
- [Seq2SeqTrainer] Move import to init to make file self-contained (#8194) · 9bd30f7c
  Patrick von Platen authored Nov 01, 2020
```
* boom boom

* reverse order
```
  9bd30f7c
30 Oct, 2020 2 commits

Remove deprecated arguments from new run_clm (#8197) · 9eb3a410
Sylvain Gugger authored Oct 30, 2020

9eb3a410

Finalize lm examples (#8188) · cdc48ce9

Sylvain Gugger authored Oct 30, 2020



* Finish the cleanup of the language-modeling examples

* Update main README

* Apply suggestions from code review
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>

* Apply suggestions from code review
Co-authored-by: Thomas Wolf <thomwolf@users.noreply.github.com>

* Propagate changes
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Co-authored-by: Thomas Wolf <thomwolf@users.noreply.github.com>

cdc48ce9

29 Oct, 2020 5 commits

Fix eval ref miss in Chinese WWM. (#8115) · 9a21b506

wlhgtc authored Oct 30, 2020



* ADD: add whole word mask proxy for both eng and chinese

* MOD: adjust format

* MOD: reformat code

* MOD: update import

* MOD: fix bug

* MOD: add import

* MOD: fix bug

* MOD: decouple code and update readme

* MOD: reformat code

* Update examples/language-modeling/README.md
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* Update examples/language-modeling/README.md
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* Update examples/language-modeling/run_language_modeling.py
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* Update examples/language-modeling/run_language_modeling.py
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* Update examples/language-modeling/run_language_modeling.py
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* Update examples/language-modeling/run_language_modeling.py
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* change wwm to whole_word_mask

* reformat code

* reformat

* format

* Code quality

* ADD: update chinese ref readme

* MOD: small changes

* MOD: small changes2

* update readme

* fix eval ref file miss bug

* format file

* MOD: move ref code to contrib

* MOD: add delimeter check

* reformat code

* refomat code

* Update examples/language-modeling/README.md
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <sylvain.gugger@gmail.com>
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>

9a21b506

Add a template for examples and apply it for mlm and plm examples (#8153) · 69117628

Sylvain Gugger authored Oct 29, 2020

* Add a template for example scripts and apply it to mlm

* Formatting

* Fix test

* Add plm script

* Add a template for example scripts and apply it to mlm

* Formatting

* Fix test

* Add plm script

* Add a template for example scripts and apply it to mlm

* Formatting

* Fix test

* Add plm script

* Styling

69117628

[s2s] distillBART docs for paper replication (#8150) · 49e4fece
Sam Shleifer authored Oct 29, 2020

49e4fece
Smarter prediction loop and no- -> no_ in console args (#8151) · acf56408
Sylvain Gugger authored Oct 29, 2020
```
* Smarter prediction loop and no- -> no_ in console args

* Fix test
```
acf56408

Fix doc errors and typos across the board (#8139) · 969859d5

Santiago Castro authored Oct 29, 2020

* Fix doc errors and typos across the board

* Fix a typo

* Fix the CI

* Fix more typos

* Fix CI

* More fixes

* Fix CI

* More fixes

* More fixes

969859d5

28 Oct, 2020 5 commits

[s2s test] cleanup (#8131) · 825925df
Stas Bekman authored Oct 28, 2020

825925df
Upgrade PyTorch Lightning to 1.0.2 (#7852) · 5e24982e
Sean Naren authored Oct 28, 2020
```
Co-authored-by: Sam Shleifer <sshleifer@gmail.com>
```
5e24982e
Rename add_start_docstrings_to_callable (#8120) · 378142af
Sylvain Gugger authored Oct 28, 2020

378142af

[testing] port test_trainer_distributed to distributed pytest + TestCasePlus enhancements (#8107) · 5423f2a9

Stas Bekman authored Oct 28, 2020



* move the helper code into testing_utils

* port test_trainer_distributed to work with pytest

* improve docs

* simplify notes

* doc

* doc

* style

* doc

* further improvements

* torch might not be available

* real fix

* Apply suggestions from code review
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

5423f2a9

New run_clm script (#8105) · 47dfa65b

Sylvain Gugger authored Oct 28, 2020



* New run_clm script

* Formatting

* More comments

* Remove unused imports

* Apply suggestions from code review
Co-authored-by: Thomas Wolf <thomwolf@users.noreply.github.com>

* Address review comments

* Change link to the hub
Co-authored-by: Thomas Wolf <thomwolf@users.noreply.github.com>

47dfa65b

27 Oct, 2020 4 commits
- Remove header · 1e01db35
  Sylvain Gugger authored Oct 27, 2020
  
  1e01db35
- Fix typo · b715e40c
  Sylvain Gugger authored Oct 27, 2020
  
  b715e40c
- Move installation instructions to the top (#8106) · 41cc5f3f
  Sylvain Gugger authored Oct 27, 2020
  
  41cc5f3f
- [CI] generate separate report files as artifacts (#7995) · bfd5e370
  Stas Bekman authored Oct 27, 2020
```
* better reports

* a whole bunch of reports in their own files

* clean up

* improvements

* github artifacts experiment

* style

* complete the report generator with multiple improvements/fixes

* fix

* save all reports under one dir to easy upload

* can remove temp failing tests

* doc fix

* some cleanup
```
  bfd5e370
26 Oct, 2020 3 commits

[Seq2Seq Trainer] Make sure padding is implemented for models without pad_token (#8043) · 664c7ec4

Patrick von Platen authored Oct 26, 2020

* make sure padding is implemented for non-padding tokens models as well

* add better error message

* add better warning

* remove results files

* Update examples/seq2seq/seq2seq_trainer.py

* remove unnecessary copy line

* correct usage of labels

* delete test files

664c7ec4

Update README.md (#8050) · 098ddc22

mohammadreza-Banaei73 authored Oct 26, 2020

--wwm cant be used as an argument given run_language_modeling.py and should be changed to --whole_word_mask

098ddc22

update version for scipy (#7998) · 20a0894d
suliuzh authored Oct 26, 2020

20a0894d

23 Oct, 2020 3 commits

[Examples] Allow EncoderDecoderModels to be trained with Seq2Seq (#7809) · 3c682ea1

Patrick von Platen authored Oct 23, 2020

* Make Seq2Seq Trainer more similar to Trainer

* fix typo

* fix seq2seq trainer

* remove from tests

* remove lock

* remove train files

* delete test files

* correct typo

* check at init

* make sure trainer is not slowed down on TPU

* correct isort

* remove use cache

* fix use cache

* add last use chache = false

3c682ea1

Handling longformer model_type (#7990) · d39da5a2

Ethan Perez authored Oct 23, 2020

Updating the run_squad training script to handle the "longformer" `model_type`. The longformer is trained in the same was as RoBERTa, so I've added the "longformer" `model_type` (that's the right hugginface name for the LongFormer model, right?) everywhere there was a "roberta" `model_type` reference. The longformer (like RoBERTa) doesn't use `token_type_ids` (as I understand from looking at the [longformer notebook](https://github.com/patil-suraj/Notebooks/blob/master/longformer_qa_training.ipynb), which is what gets updated after this change.

This fix might be related to [this issue](https://github.com/huggingface/transformers/issues/7249) with SQuAD training when using run_squad.py

d39da5a2

Handle the case when title is None (#7941) · 88b3a91e
Lalit Pagaria authored Oct 23, 2020

88b3a91e

22 Oct, 2020 3 commits

[s2s trainer] tests to use distributed on multi-gpu machine (#7965) · 023f0f37
Stas Bekman authored Oct 22, 2020

023f0f37

New run glue script (#7917) · 2e5052d4

Sylvain Gugger authored Oct 22, 2020



* Start simplification

* More progress

* Finished script

* Address comments and update tests instructions

* Wrong test

* Accept files as inputs and fix test

* Update src/transformers/trainer_utils.py
Co-authored-by: Julien Chaumond <chaumond@gmail.com>

* Fix labels and add combined score

* Add special labels

* Update TPU command

* Revert to old label strategy

* Use model labels

* Fix for STT-B

* Styling

* Apply suggestions from code review
Co-authored-by: Thomas Wolf <thomwolf@users.noreply.github.com>

* Code styling

* Fix review comments
Co-authored-by: Julien Chaumond <chaumond@gmail.com>
Co-authored-by: Thomas Wolf <thomwolf@users.noreply.github.com>

2e5052d4

# Add whole word mask support for lm fine-tune (#7925) · a16e568f

wlhgtc authored Oct 22, 2020



* ADD: add whole word mask proxy for both eng and chinese

* MOD: adjust format

* MOD: reformat code

* MOD: update import

* MOD: fix bug

* MOD: add import

* MOD: fix bug

* MOD: decouple code and update readme

* MOD: reformat code

* Update examples/language-modeling/README.md
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* Update examples/language-modeling/README.md
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* Update examples/language-modeling/run_language_modeling.py
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* Update examples/language-modeling/run_language_modeling.py
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* Update examples/language-modeling/run_language_modeling.py
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* Update examples/language-modeling/run_language_modeling.py
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* change wwm to whole_word_mask

* reformat code

* reformat

* format

* Code quality

* ADD: update chinese ref readme

* MOD: small changes

* MOD: small changes2

* update readme
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <sylvain.gugger@gmail.com>

a16e568f

21 Oct, 2020 1 commit
- [seq2seq testing] multigpu test run via subprocess (#7281) · 8b381733
  Stas Bekman authored Oct 21, 2020
```
Co-authored-by: Sam Shleifer <sshleifer@gmail.com>
```
  8b381733