You need to sign in or sign up before continuing.
Unverified Commit f5b2a3aa authored by Lianmin Zheng's avatar Lianmin Zheng Committed by GitHub
Browse files

Use proc.join instead of busy waiting (#2374)

parent f6817596
...@@ -462,8 +462,8 @@ def launch_engine( ...@@ -462,8 +462,8 @@ def launch_engine(
if server_args.node_rank >= 1: if server_args.node_rank >= 1:
# For other nodes, they do not need to run tokenizer or detokenizer, # For other nodes, they do not need to run tokenizer or detokenizer,
# so they can just wait here. # so they can just wait here.
while True: for proc in scheduler_procs:
pass proc.join()
else: else:
# Launch the data parallel controller # Launch the data parallel controller
reader, writer = mp.Pipe(duplex=False) reader, writer = mp.Pipe(duplex=False)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment