Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
change
sglang
Commits
f5b2a3aa
Unverified
Commit
f5b2a3aa
authored
Dec 06, 2024
by
Lianmin Zheng
Committed by
GitHub
Dec 06, 2024
Browse files
Use proc.join instead of busy waiting (#2374)
parent
f6817596
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
2 deletions
+2
-2
python/sglang/srt/server.py
python/sglang/srt/server.py
+2
-2
No files found.
python/sglang/srt/server.py
View file @
f5b2a3aa
...
@@ -462,8 +462,8 @@ def launch_engine(
...
@@ -462,8 +462,8 @@ def launch_engine(
if
server_args
.
node_rank
>=
1
:
if
server_args
.
node_rank
>=
1
:
# For other nodes, they do not need to run tokenizer or detokenizer,
# For other nodes, they do not need to run tokenizer or detokenizer,
# so they can just wait here.
# so they can just wait here.
while
True
:
for
proc
in
scheduler_procs
:
p
ass
p
roc
.
join
()
else
:
else
:
# Launch the data parallel controller
# Launch the data parallel controller
reader
,
writer
=
mp
.
Pipe
(
duplex
=
False
)
reader
,
writer
=
mp
.
Pipe
(
duplex
=
False
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment