Unverified Commit fec347de authored by Hyogeun Oh (오효근)'s avatar Hyogeun Oh (오효근) Committed by GitHub
Browse files

[Misc] Improve `s3_utils` type hints with `BaseClient` (#24825)


Signed-off-by: default avatarZerohertz <ohg3417@gmail.com>
parent cc3173ae
...@@ -2,10 +2,13 @@ ...@@ -2,10 +2,13 @@
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project # SPDX-FileCopyrightText: Copyright contributors to the vLLM project
import fnmatch import fnmatch
from typing import Any, Optional from typing import TYPE_CHECKING, Optional
from vllm.utils import PlaceholderModule from vllm.utils import PlaceholderModule
if TYPE_CHECKING:
from botocore.client import BaseClient
try: try:
import boto3 import boto3
except ImportError: except ImportError:
...@@ -26,7 +29,7 @@ def _filter_ignore(paths: list[str], patterns: list[str]) -> list[str]: ...@@ -26,7 +29,7 @@ def _filter_ignore(paths: list[str], patterns: list[str]) -> list[str]:
] ]
def glob(s3: Optional[Any] = None, def glob(s3: Optional["BaseClient"] = None,
path: str = "", path: str = "",
allow_pattern: Optional[list[str]] = None) -> list[str]: allow_pattern: Optional[list[str]] = None) -> list[str]:
""" """
...@@ -51,7 +54,7 @@ def glob(s3: Optional[Any] = None, ...@@ -51,7 +54,7 @@ def glob(s3: Optional[Any] = None,
def list_files( def list_files(
s3: Any, s3: "BaseClient",
path: str, path: str,
allow_pattern: Optional[list[str]] = None, allow_pattern: Optional[list[str]] = None,
ignore_pattern: Optional[list[str]] = None ignore_pattern: Optional[list[str]] = None
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment