Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
fec347de
Unverified
Commit
fec347de
authored
Sep 14, 2025
by
Hyogeun Oh (오효근)
Committed by
GitHub
Sep 14, 2025
Browse files
[Misc] Improve `s3_utils` type hints with `BaseClient` (#24825)
Signed-off-by:
Zerohertz
<
ohg3417@gmail.com
>
parent
cc3173ae
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
3 deletions
+6
-3
vllm/transformers_utils/s3_utils.py
vllm/transformers_utils/s3_utils.py
+6
-3
No files found.
vllm/transformers_utils/s3_utils.py
View file @
fec347de
...
...
@@ -2,10 +2,13 @@
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
import
fnmatch
from
typing
import
Any
,
Optional
from
typing
import
TYPE_CHECKING
,
Optional
from
vllm.utils
import
PlaceholderModule
if
TYPE_CHECKING
:
from
botocore.client
import
BaseClient
try
:
import
boto3
except
ImportError
:
...
...
@@ -26,7 +29,7 @@ def _filter_ignore(paths: list[str], patterns: list[str]) -> list[str]:
]
def
glob
(
s3
:
Optional
[
Any
]
=
None
,
def
glob
(
s3
:
Optional
[
"BaseClient"
]
=
None
,
path
:
str
=
""
,
allow_pattern
:
Optional
[
list
[
str
]]
=
None
)
->
list
[
str
]:
"""
...
...
@@ -51,7 +54,7 @@ def glob(s3: Optional[Any] = None,
def
list_files
(
s3
:
Any
,
s3
:
"BaseClient"
,
path
:
str
,
allow_pattern
:
Optional
[
list
[
str
]]
=
None
,
ignore_pattern
:
Optional
[
list
[
str
]]
=
None
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment