Unverified Commit b9b5bdfc authored by Rui Qiao's avatar Rui Qiao Committed by GitHub
Browse files

[Misc] Catching Ray Compiled Graph PP test failures for V1 (#14847)

parent 31060b27
...@@ -350,6 +350,10 @@ def _compare_tp( ...@@ -350,6 +350,10 @@ def _compare_tp(
else: else:
pp_env = None pp_env = None
tp_env = {
"VLLM_USE_V1": vllm_major_version,
}
pp_args = [ pp_args = [
*common_args, *common_args,
"--pipeline-parallel-size", "--pipeline-parallel-size",
...@@ -374,14 +378,20 @@ def _compare_tp( ...@@ -374,14 +378,20 @@ def _compare_tp(
] ]
try: try:
compare_two_settings(model_id, pp_args, tp_args, pp_env, method=method) compare_two_settings(model_id,
pp_args,
tp_args,
pp_env,
tp_env,
method=method)
except Exception: except Exception:
if pp_env is None: testing_ray_compiled_graph = pp_env is not None
raise if testing_ray_compiled_graph and vllm_major_version == "0":
else: # Ray Compiled Graph tests are flaky for V0,
# Ray Compiled Graph tests are flaky,
# so we don't want to fail the test # so we don't want to fail the test
logger.exception("Ray Compiled Graph tests failed") logger.exception("Ray Compiled Graph tests failed")
else:
raise
@pytest.mark.parametrize( @pytest.mark.parametrize(
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment