Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
b9b5bdfc
Unverified
Commit
b9b5bdfc
authored
Mar 16, 2025
by
Rui Qiao
Committed by
GitHub
Mar 16, 2025
Browse files
[Misc] Catching Ray Compiled Graph PP test failures for V1 (#14847)
parent
31060b27
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
15 additions
and
5 deletions
+15
-5
tests/distributed/test_pipeline_parallel.py
tests/distributed/test_pipeline_parallel.py
+15
-5
No files found.
tests/distributed/test_pipeline_parallel.py
View file @
b9b5bdfc
...
...
@@ -350,6 +350,10 @@ def _compare_tp(
else
:
pp_env
=
None
tp_env
=
{
"VLLM_USE_V1"
:
vllm_major_version
,
}
pp_args
=
[
*
common_args
,
"--pipeline-parallel-size"
,
...
...
@@ -374,14 +378,20 @@ def _compare_tp(
]
try
:
compare_two_settings
(
model_id
,
pp_args
,
tp_args
,
pp_env
,
method
=
method
)
compare_two_settings
(
model_id
,
pp_args
,
tp_args
,
pp_env
,
tp_env
,
method
=
method
)
except
Exception
:
if
pp_env
is
None
:
raise
else
:
# Ray Compiled Graph tests are flaky,
testing_ray_compiled_graph
=
pp_env
is
not
None
if
testing_ray_compiled_graph
and
vllm_major_version
==
"0"
:
# Ray Compiled Graph tests are flaky for V0,
# so we don't want to fail the test
logger
.
exception
(
"Ray Compiled Graph tests failed"
)
else
:
raise
@
pytest
.
mark
.
parametrize
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment