Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
4026ae31
Unverified
Commit
4026ae31
authored
Dec 05, 2025
by
Nick Hill
Committed by
GitHub
Dec 05, 2025
Browse files
[Misc] Move `disable_nccl_for_dp_synchronization` init logic into `VllmConfig` (#30161)
Signed-off-by:
Nick Hill
<
nhill@redhat.com
>
parent
b12f4a98
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
6 deletions
+9
-6
vllm/config/vllm.py
vllm/config/vllm.py
+9
-0
vllm/engine/arg_utils.py
vllm/engine/arg_utils.py
+0
-6
No files found.
vllm/config/vllm.py
View file @
4026ae31
...
...
@@ -586,6 +586,15 @@ class VllmConfig:
else
:
self
.
scheduler_config
.
async_scheduling
=
True
if
(
self
.
scheduler_config
.
async_scheduling
and
not
self
.
parallel_config
.
disable_nccl_for_dp_synchronization
):
logger
.
info
(
"Disabling NCCL for DP synchronization when using async scheduling."
)
self
.
parallel_config
.
disable_nccl_for_dp_synchronization
=
True
from
vllm.platforms
import
current_platform
if
(
...
...
vllm/engine/arg_utils.py
View file @
4026ae31
...
...
@@ -1602,12 +1602,6 @@ class EngineArgs:
model_config
.
skip_tokenizer_init
=
True
logger
.
info
(
"Skipping tokenizer initialization for tokens-only mode."
)
if
self
.
async_scheduling
and
not
self
.
disable_nccl_for_dp_synchronization
:
logger
.
info
(
"Disabling NCCL for DP synchronization when using async scheduling."
)
self
.
disable_nccl_for_dp_synchronization
=
True
parallel_config
=
ParallelConfig
(
pipeline_parallel_size
=
self
.
pipeline_parallel_size
,
tensor_parallel_size
=
self
.
tensor_parallel_size
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment