Unverified Commit 4026ae31 authored by Nick Hill's avatar Nick Hill Committed by GitHub
Browse files

[Misc] Move `disable_nccl_for_dp_synchronization` init logic into `VllmConfig` (#30161)


Signed-off-by: default avatarNick Hill <nhill@redhat.com>
parent b12f4a98
......@@ -586,6 +586,15 @@ class VllmConfig:
else:
self.scheduler_config.async_scheduling = True
if (
self.scheduler_config.async_scheduling
and not self.parallel_config.disable_nccl_for_dp_synchronization
):
logger.info(
"Disabling NCCL for DP synchronization when using async scheduling."
)
self.parallel_config.disable_nccl_for_dp_synchronization = True
from vllm.platforms import current_platform
if (
......
......@@ -1602,12 +1602,6 @@ class EngineArgs:
model_config.skip_tokenizer_init = True
logger.info("Skipping tokenizer initialization for tokens-only mode.")
if self.async_scheduling and not self.disable_nccl_for_dp_synchronization:
logger.info(
"Disabling NCCL for DP synchronization when using async scheduling."
)
self.disable_nccl_for_dp_synchronization = True
parallel_config = ParallelConfig(
pipeline_parallel_size=self.pipeline_parallel_size,
tensor_parallel_size=self.tensor_parallel_size,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment