GitLab

* Simlify and organize test_ops.

We perform the following:

- Simplify the functions slow_roi_pooling, slow_ps_roi_pooling, slow_ps_roi_align and bilinear_interpolate (including finding and removing a semi-bug in slow_ps_roi_pooling, which used bin_w instead of bin_h);
- Wrote a slow_roi_align function, that was missing;
- Create a base class testing all combinations of forward/backward, cpu/cuda, contiguous/non-contiguous;
- Organize all testing inside the base class with _test_forward and _test_backward (which can be easily overriden if a parciular op needs something different); an Op class then only needs to implement fn, get_script_fn, and expected_fn.

A few points:
- We are using the same inputs for all tests, and not trying all possible inputs in the domain of a given operation. One improvement would be to test more diverse inputs, and to personalize the inputs for some ops (e.g. different inputs for pooling ops and align ops).
- Running all tests is quite slow (~1 min only for CPU tests), so that can possibly be improved.

* Reduce input size used in gradcheck.

gradcheck can be quite costly, and it was causing OOM errors and making
the tests slow. By reducing the size of the input, the test speed is
down to 3 seconds for the CPU tests.

Other points:
- We remove an unused namedtuple;
- We inherit from object for better Python 2 compatibility;
- We remove a hardcoded pool_size from the TorchScript functions, and
add it as a parameter instead.

* Replace Tensor by torch.Tensor in type annotations.

This should fix lint errors.

* Fix inconsistent NMS implementation

* Improve tests for NMS

* Remove unnecessary using statement

* Add Scriptable Transform: Grayscale

* add scriptable transforms: rgb_to_grayscale

* add scriptable transform: rgb_to_grayscale

* add scriptable transform: rgb_to_grayscale

* add scriptable transform: rgb_to_grayscale

* update code: rgb_to_grayscale

* add test: rgb_to_grayscale

* update parameters: rgb_to_grayscale

* add scriptable transform: rgb_to_grayscale

* update rgb_to_grayscale

* update rgb_to_grayscale

* Disable C++ models from being compiled without explicitly being asked for

* Fix import in tests, which are already disabled

* Unify video metadata in VideoClips

* Bugfix

* Make tests a bit more robust

* Improve readability of affine transformation code

* Make shear transformation area preserving

The previous shear implementation did not preserve area, and we
implement a version that does.

The formula used was verified with the following sympy code:

from sympy import Matrix, cos, sin, tan, simplify
from sympy.abc import x, y, phi

Xs = Matrix(
        [[1, -tan(x)],
         [0, 1]]
        )

Ys = Matrix(
        [[1, 0],
         [-tan(y), 1]]
        )

R = Matrix(
        [[cos(phi), -sin(phi)],
         [sin(phi), cos(phi)]]
        )

RSS = Matrix(
        [[cos(phi - y)/cos(y), -cos(phi - y)*tan(x)/cos(y) - sin(phi)],
         [sin(phi - y)/cos(y), -sin(phi - y)*tan(x)/cos(y) + cos(phi)]])

print(simplify(R * Ys * Xs - RSS))

One thing that is not clear (and could be tested) is whether avoiding
the explicit products and calculations in _get_inverse_affine_matrix
really gives performance benefits - compared to doing the explicit
calculation done in _test_transformation.

* Use np.matmul instead of @

The @ syntax is not supported in Python 2.

* Support Exporting Mask Rcnn to ONNX

* update tetst

* add control flow test

* fix

* update test and fix img_shape

* add quantized models

* Modify mobilenet.py documentation and clean up comments
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Move fuse_model method to QuantizableInvertedResidual and clean up args documentation
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Restore relu settings to default in resnet.py
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix missing return in forward
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix missing return in forwards
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Change pretrained -> pretrained_float_models
Replace InvertedResidual with block

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Update tests to follow similar structure to test_models.py, allowing for modular testing

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Replace forward method with simple function assignment

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix error in arguments for resnet18

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* pretrained_float_model argument missing for mobilenet

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* reference script for quantization aware training and post training quantization

* reference script for quantization aware training and post training quantization

* set pretrained_float_model as False and explicitly provide float model

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Address review comments:
1. Replace forward with _forward
2. Use pretrained models in reference train/eval script
3. Modify test to skip if fbgemm is not supported

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix lint errors.
Use _forward for common code between float and quantized models
Clean up linting for reference train scripts
Test over all quantizable models

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Update default values for args in quantization/train.py

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Update models to conform to new API with quantize argument
Remove apex in training script, add post training quant as an option
Add support for separate calibration data set.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix minor errors in train_quantization.py

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Remove duplicate file

* Bugfix

* Minor improvements on the models

* Expose print_freq to evaluate

* Minor improvements on train_quantization.py

* Ensure that quantized models are created and run on the specified backends
Fix errors in test only mode

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add model urls

* Fix errors in quantized model tests.
Speedup creation of random quantized model by removing histogram observers

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Move setting qengine prior to convert.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix lint error

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add readme.md

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Readme.md

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix lint

* Add adjustment operations for RGB Tensor Images.

Right now, we have operations on PIL images, but we want to have a version of the opeartions that act directly on Tensor images.

Here, we add such operations for adjust_brightness, adjust_contrast and adjust_saturation.

In PIL, those functions are implemented by generating an degenerate image from the first, and then interpolating them together.
- https://github.com/python-pillow/Pillow/blob/master/src/PIL/ImageEnhance.py
- https://github.com/python-pillow/Pillow/blob/master/src/libImaging/Blend.c

A few caveats:
* Since PIL operates on uint8, and the tensor operations might be on float, we can get slightly different values because of int truncation.
* We assume here the images are RGB; in particular, to handle an alpha channel, we need to check whether it is present, in which case we copy it to the final image.

* Keep dtype and use broadcast in adjust operations

- We make our operations have input.dtype == output.dtype, at the cost of
adding a few type checks and branches.

- By using Tensor broadcast, we can simplify the calls to _blend.

* Use is_floating_point to check dtype.

* Remove unpacking in tuple

It seems Python 2 does not support this type of unpacking, so it broke
Python 2 builds. This should fix it.

* Add from __future__ import division for Python 2

* test: Updated asserts in test_utils

Updated all raw asserts to corresponding unittest.TestCase.assert. See #1483

* style: Fixed lint check

* Unify video backend interfaces

* Remove reference cycle

* Make functions private and enable tests on OSX

* Disable test if video_reader backend not available

* Lint

* Fix import after refactoring

* Fix lint

* test: Updated asserts in test_onnx

Updated all raw asserts to corresponding unittest.TestCase.assert. See #1483

* test: Refactored AssertionError

Opted for cleaner raise to avoid error type casting and string conversion

* extend DistributedSampler to support group_size

* Fix lint

* correctness test implemented with old test architecture

* reverted an unneeded change, ran flake8

* moving to relative tolerance of 1 part in 10k for classification correctness checks

* going down to 1 part in 1000 for correctness checks bc architecture differences

* one percent relative tolerance

* remove download process

* address comments

* fix logic error

* bug fixes

* removed unused import

* add docstrings

* flake8

* remove download BC

* fix test

* removed unused code

* flake 8

* add MD5 verification before extraction

* add mock to test

* * unify _verify_archive() method and function
* remove force flag for parse_*_archive functions
* cleanup

* flake8

* test: Updated asserts in test_io

Updated all raw asserts to corresponding unittest.TestCase.assert. See #1483

* test: Fixed test_io

In order to use unittest.TestCase for asserts in temp_video, the object has to be passed itself to temp_video.

* test: Updated asserts to AssertionError

Switched initial raw assert to AssertionError.

* test: Changed AssertionError for ValueError

Updated all raw asserts to corresponding unittest.TestCase.assert. See #1483

* Make crop torchscriptable

Relevant #1375

* Invert x and y axis

* fix lint

* Add crop test

* revert deletion of space in functional

* add import random

* add dimension in doc

* add import

* fix flake8

* change to self.assert*

* convert to uint8

* assertTrue

* lint

Updated all raw asserts to corresponding unittest.TestCase.assert. See #1483

Updated all raw asserts to corresponding unittest.TestCase.assert. See #1483

* onnx esport faster rcnn

* test

* address PR comments

* revert unbind workaround

* disable tests for older versions of pytorch

Updated all raw asserts to corresponding unittest.TestCase.assert. See #1483

This reverts commit 1e857d93.

* test: Updated assert in test_transforms

Updated all raw asserts to corresponding unittest.TestCase.assert. See #1483

* test: Fixed linter on test_transforms

* added correctness tests for classification models
* refactored tests for extensibility & usability
* flake8 fixes

* vflip and hflip tensor

* vflip and hflip tensor

* changes made

* lint

* lint

* lint failing

* added PSRoiAlign and PSRoiPool with C++ autograd and torch ops

* fixed linter errors

* fixed linter errors 2

* fixed linter errors 3

* Handle corrupted video headers in io

* Catch exceptions while decoding partly-corrupted files

* Add more tests

* Support Exporting RPN to ONNX

* address PR comments

* fix cat

* add flatten

* replace cat by stack

* update test to run only on rpn module

* use tolerate_small_mismatch

* extend video reader to support fast video probing

* fix c++ lint

* small fix

* allow to accept input video of type torch.Tensor

* Support Exporting MultiScaleRoiAlign to ONNX

* remove cast

* fix dtype

* move cast

* move sampler into TV core. Update UniformClipSampler

* Fix reference training script

* Skip test if pyav not available

* change interpolation from round() to floor() as round(0.5) behaves differently between py2 and py3

* add metadata to video dataset classes. bug fix. more robustness

* query video backend within VideoClips class

* Fix tests

* Fix lint

* add support for video resnet models, restructure script test to just ignore RCNN models

* switch back to testing subset of the models

* add expected result tests

* fix wrong assertion

* start with only detection models

* remove unneeded rng setting

* fix test

* add tuple support

* update test

* syntax error

* treat .pkl files as binary data, see : https://git-scm.com/book/en/v2/Customizing-Git-Git-Attributes#_binary_files

* fix test

* fix elif

* Map tensor results and enforce maximum pickle size

* unrelated change

* larger rtol

* pass rtol atol around

* last commit i swear...

* respond to comments

* fix flake

* fix py2 flake

modified code of io.read_video and io.read_video_timestamps to intepret pts values in seconds (#1331)

* modified code of io.read_video and io.read_video_timestamps to interpret pts values in seconds

* changed default value for pts_unit to pts, corrected formatting

* hanndliing both fractions and floats for start_pts and end_pts, added test cases for pts_unit sec

* moved unit conversion logic to _read_from_stream method

* make googlnet scriptable

* Remove typing import in favor of torch.jit.annotations

* add inceptionnet

* flake fixes

* fix asssert true

* add import division for torchscript

* fix script compilation

* fix flake, py2 division error

* fix py2 division error

* Fix nightly builds

* Fix lint

* Disable video_reader tests on Travis

* Disable one more test that segfaults on Travis

* Fix typo in expression