GitLab

* Consolidating __repr__ strings
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* fix bug when the target is empty

* Add unittest for empty instance training
Co-authored-by: Zhiqiang Wang <zhiqwang@foxmail.com>
Co-authored-by: Joao Gomes <joaopsgomes@gmail.com>

* Remove in-place mutation in DefaultBoxGenerator

* device fix

* Update torchvision/models/detection/anchor_utils.py
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* replace assert with valueerror

* pytest should raise ValueError not AssertionError

* minor edit

* raise assert changed to raise valueerror in test

* Update torchvision/models/detection/backbone_utils.py
Co-authored-by: Aditya Oke <47158509+oke-aditya@users.noreply.github.com>

* Update torchvision/models/detection/backbone_utils.py
Co-authored-by: Aditya Oke <47158509+oke-aditya@users.noreply.github.com>

* minor edits

* minor edits

* added one test

* added another test

* added another test

* test for mobilenet

* ufmt formatting

* cant have unused variables

* suggested changes

* minor edit

* corrected bug pointed out by datumbox

* corrected bug pointed out by datumbox

* bug correction and shorten msg

* ufmt stuff

* resolved last comment
Co-authored-by: Abhijit Deo <72816663+abhi-glitchhg@users.noreply.github.com>
Co-authored-by: Aditya Oke <47158509+oke-aditya@users.noreply.github.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* add fcos

* update fcos

* add giou_loss

* add BoxLinearCoder for FCOS

* add full code for FCOS

* add giou loss

* add fcos

* add __all__

* Fixing lint

* Fixing lint in giou_loss.py

* Add typing annotation to fcos

* Add trained checkpoints

* Use partial to replace lambda

* Minor fixes to docstrings

* Apply ufmt format

* Fixing docstrings

* Fixing jit scripting

* Minor fixes to docstrings

* Fixing jit scripting

* Ignore mypy in fcos

* Fixing trained checkpoints

* Fixing unit-test of jit script

* Fixing docstrings

* Add test/expect/ModelTester.test_fcos_resnet50_fpn_expect.pkl

* Fixing test_detection_model_trainable_backbone_layers

* Update test_fcos_resnet50_fpn_expect.pkl

* rename stride to box size

* remove TODO and fix some typo

* merge some code for better

* impove the comments

* remove decode and encode of BoxLinearCoder

* remove some unnecessary hints

* use the default value in detectron2.

* update doc

* Add unittest for BoxLinearCoder

* Add types in FCOS

* Add docstring for BoxLinearCoder

* Minor fix for the docstring

* update doc

* Update fcos_resnet50_fpn_coco pretained weights url

* Update torchvision/models/detection/fcos.py
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Update torchvision/models/detection/fcos.py
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Update torchvision/models/detection/fcos.py
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Update torchvision/models/detection/fcos.py
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Add FCOS model documentation

* Fix typo in FCOS documentation

* Add fcos to the prototype builder

* Capitalize COCO_V1

* Fix params of fcos

* fix bug for partial

* Fixing docs indentation

* Fixing docs format in giou_loss

* Adopt Reference for GIoU Loss

* Rename giou_loss to generalized_box_iou_loss

* remove overwrite_eps

* Update AP test values

* Minor fixes for the docs

* Minor fixes for the docs

* Update torchvision/models/detection/fcos.py
Co-authored-by: Zhiqiang Wang <zhiqwang@foxmail.com>

* Update torchvision/prototype/models/detection/fcos.py
Co-authored-by: Zhiqiang Wang <zhiqwang@foxmail.com>
Co-authored-by: zhiqiang <zhiqwang@foxmail.com>
Co-authored-by: Joao Gomes <jdsgomes@fb.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Co-authored-by: Joao Gomes <joaopsgomes@gmail.com>

* Modifying keypoint_rcnn.py

* Update torchvision/models/detection/keypoint_rcnn.py
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Remove unnecessary new line
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* log API v3

* make torchscript happy

* make torchscript happy

* add missing logs to constructor

* log ops C++ API as well

* fix type hint

* check function with isinstance
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* revamp log api usage method

Closes #4905
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Update typing

* Fix bug

* Unblock mypy

* Ignore small error
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Co-authored-by: Nicolas Hug <nicolashug@fb.com>

* Expand usage logging to detection models

Summary: Track all detection model instantiation.

Reviewed By: sallysyw

Differential Revision: D31741603

fbshipit-source-id: 89467db5d89ea41c5a9ab95d1846264d0a1f4199

* Fix lint
Co-authored-by: Kai Zhang <kaizh@fb.com>

* Refactoring resnet_fpn backbone building.

* Passing the change to *_rcnn and retinanet.

* Applying for faster_rcnn + mobilenetv3

* Applying for ssdlite + mobilenetv3

* Applying for ssd + vgg16

* Update the expected file of retinanet_resnet50_fpn to fix order of initialization.

* Adding full model weights for the VGG16 features.

* Start adding types

* add typing

* Type prototype models

* fix optional type bug

* transient import

* Fix weights type

* fix import

* Apply suggestions from code review

Address nits
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Co-authored-by: Khushi Agrawal <khushiagrawal411@gmail.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Annotate rpn

* Small fix

* Small fix and ignore
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Adding FasterRCNN ResNet50.

* Refactoring to remove duplicate code.

* Adding typing info.

* Setting weights_backbone=None as default value.

* Overwrite eps only for specific weights.

* Add typing for imagelist, move params to docstring

* Add docs

* Start annotating utils

* checking

* Add annotations at _utils.py

* Remove unnecessary comments.

* re-checked typings

* Update typing

* Ignore small error

* Use optional tensor

* Ignore for JIT
Co-authored-by: Khushi Agrawal <khushiagrawal411@gmail.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

* add ufmt as code formatter

* cleanup

* quote ufmt requirement

* split imports into more groups

* regenerate circleci config

* fix CI

* clarify local testing utils section

* use ufmt pre-commit hook

* split relative imports into local category

* Revert "split relative imports into local category"

This reverts commit f2e224cde2008c56c9347c1f69746d39065cdd51.

* pin black and usort dependencies

* fix local test utils detection

* fix ufmt rev

* add reference utils to local category

* fix usort config

* remove custom categories sorting

* Run pre-commit without fixing flake8

* got a double import in merge
Co-authored-by: Nicolas Hug <nicolashug@fb.com>

* Moving _make_divisible to utils.

* Replace the old ConvBNReLU and ConvBNActivation layers

* Fix minor bug.

* Moving SE layer to ops.

* Adding deprecation warnings on old layers.

* Apply changes to regnets.

* Allow gradient backpropagation through GeneralizedRCNNTransform to inputs
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>

* Add unit tests for gradient backpropagation to inputs
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>

* Update torchvision/models/detection/transform.py
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Update _check_input_backprop
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>

* Account for tests requiring cuda
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Co-authored-by: Julien RIPOCHE <ripoche@magic-lemp.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Added paper references to detection models

* Ignore linter warning

* Break long line into two

* Add types in transform.

* Trace on eval mode.
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Explicitely store a distance value that is reused 

I don't see a reason to calculate the value twice for each distance. 

Knowing that this code is going to be called at every epoch and that probably there is not a compiler that optimizes this (+ also code clarity), I think is best to store the value for x and y.

* Update torchvision/models/detection/_utils.py
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

* removing spaces
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Fix a bug when trainable_layers == 0

* Fix same issue on ssd.

* Moving tensors to the right device.

* Switch to gpu.medium