- 15 Jun, 2022 6 commits
-
-
Andrey Talman authored
Summary: Fix typo in release build step Pull Request resolved: https://github.com/pytorch/audio/pull/2495 Reviewed By: hwangjeff Differential Revision: D37176695 Pulled By: atalman fbshipit-source-id: 37b4e30c1084e506f3a45cf7427784c955868909
-
Andrey Talman authored
Summary: Fix push on release reference name We want to compare it against refs/heads/release rather then release Tests: https://github.com/atalman/vision/commit/af17cd95d2d43ca13354fb700e2da42108dd5a87 Sets correctly release chanell (wheels): https://github.com/atalman/vision/runs/6901327010?check_suite_focus=true Pull Request resolved: https://github.com/pytorch/audio/pull/2492 Reviewed By: hwangjeff Differential Revision: D37174090 Pulled By: atalman fbshipit-source-id: e114972935572a701eb7daff429a0df0ed5a75e4
-
Andrey Talman authored
Summary: Making sure we are picking correct release branch Ref: https://github.com/pytorch/vision/pull/6168 Pull Request resolved: https://github.com/pytorch/audio/pull/2489 Reviewed By: mthrok Differential Revision: D37160145 Pulled By: atalman fbshipit-source-id: 3e4a2208cbe47f85147573159f9adb8d6a824956
-
moto authored
Summary: closes https://github.com/pytorch/audio/issues/2420 Pull Request resolved: https://github.com/pytorch/audio/pull/2479 Reviewed By: carolineechen Differential Revision: D37142717 Pulled By: mthrok fbshipit-source-id: c3d4cc1435a74dfa6992112590c988c2903511a8
-
moto authored
Summary: Lint style has diverged since fb-internal lint engine has been changed. Backport of https://github.com/pytorch/audio/issues/2466. Pull Request resolved: https://github.com/pytorch/audio/pull/2487 Reviewed By: carolineechen Differential Revision: D37160193 Pulled By: mthrok fbshipit-source-id: cf4e2091a78a0da53269ae1251a55d4d1e52ead2
-
moto authored
Summary: The version of MKL that is installed alongside PyTorch has been bumped to 2022.1 on Windows and it is causing installation issue in unit tests. This commit pins the previous version Backport of https://github.com/pytorch/audio/issues/2463 Pull Request resolved: https://github.com/pytorch/audio/pull/2486 Reviewed By: nateanl Differential Revision: D37160156 Pulled By: mthrok fbshipit-source-id: 7e3a30c25782b349a3cad2ee6d1141affc921881
-
- 14 Jun, 2022 2 commits
-
-
Andrey Talman authored
Summary: Adding conda builds for M1 Pull Request resolved: https://github.com/pytorch/audio/pull/2473 Reviewed By: mthrok Differential Revision: D37151454 Pulled By: atalman fbshipit-source-id: 0108b937a4c7048bd4bb03b2b5a367704d7b78cc
-
moto authored
Summary: `load` function has `normalize` argument, which converts the native sample type to `torch.float32`. This argument is confusing for audio practitioners as it seems to perform [volume normalization](https://en.wikipedia.org/wiki/Audio_normalization). See https://github.com/pytorch/audio/issues/2253 Due to the BC-breaking concern, we cannot easily change the argument name. This commit adds warnings to documentations. Fix https://github.com/pytorch/audio/issues/2253 Pull Request resolved: https://github.com/pytorch/audio/pull/2449 Reviewed By: nateanl Differential Revision: D36995756 Pulled By: carolineechen fbshipit-source-id: 0b7db2758a355f6aafe06a2273bc72a1027690bd
-
- 13 Jun, 2022 2 commits
-
-
Andrey Talman authored
Summary: Fix typo in nightly m1 ref See: https://github.com/pytorch/vision/pull/6158 Pull Request resolved: https://github.com/pytorch/audio/pull/2474 Reviewed By: malfet, mthrok Differential Revision: D37117637 Pulled By: atalman fbshipit-source-id: 2a8f7b5bf3506f2a53884424799919137870a0ad
-
Reviewed By: ivanmurashko Differential Revision: D37103342 fbshipit-source-id: adc908c790a413384bd88a75d3c2b4b0974c6674
-
- 10 Jun, 2022 2 commits
-
-
Andrey Talman authored
Summary: Adding tagged builds for torchaudio see: https://github.com/pytorch/vision/pull/6140 Pull Request resolved: https://github.com/pytorch/audio/pull/2471 Reviewed By: hwangjeff Differential Revision: D37080828 Pulled By: atalman fbshipit-source-id: 13d754f522510514f0148ba465ce12a320058722
-
Sean Kim authored
Summary: Split existing Pitchshift into multiple helper functions in order to cache kernel and speed up overall process addressing https://github.com/pytorch/audio/issues/2359. Existing unit tests pass. edit: functional and transforms unit test pass. Adopted lazy initialization to avoid BC-breaking. Pull Request resolved: https://github.com/pytorch/audio/pull/2441 Reviewed By: carolineechen Differential Revision: D36905582 Pulled By: skim0514 fbshipit-source-id: 6780db3ac8a29d59017a6abe7e82ce1fd17aaac2
-
- 08 Jun, 2022 5 commits
-
-
moto authored
Summary: In https://github.com/pytorch/audio/issues/2461, `metadata` field was added to StreamInfo. However, the value attached to this new field was source-level metadata, while each stream can have different metadata. * source level metadata [AVFormatContext->metadata](https://ffmpeg.org/doxygen/4.1/structAVFormatContext.html#a3019a56080ed2e3297ff25bc2ff88adf) * stream level metadata [AVFormatContext->streams[]->metadata](https://ffmpeg.org/doxygen/4.1/structAVStream.html#a50d250a128a3da9ce3d135e84213fb82) This commit moves source level metadata to dedicated method, `get_metadata`, and fix the stream-level metadata to report stream metadata. Pull Request resolved: https://github.com/pytorch/audio/pull/2464 Reviewed By: hwangjeff, xiaohui-zhang Differential Revision: D36995452 Pulled By: mthrok fbshipit-source-id: 534be1f7feb07790a0ce8624c336cdb7b65a8697
-
moto authored
Summary: https://output.circle-artifacts.com/output/job/75187a52-b0d8-4cac-89f3-24e10889a36a/artifacts/0/docs/hw_acceleration_tutorial.html 1. Update HW decoding tutorial to include file-like object 1. Add note about unseekable object int streaming API tutorial Pull Request resolved: https://github.com/pytorch/audio/pull/2408 Reviewed By: hwangjeff Differential Revision: D36632702 Pulled By: mthrok fbshipit-source-id: 17be2fb8528cb1d2d1ee11901b6a95c512466feb
-
moto authored
Summary: The Streaming API tutorial has gotten long, so this commit split it into two. Pull Request resolved: https://github.com/pytorch/audio/pull/2446 Reviewed By: hwangjeff Differential Revision: D36987513 Pulled By: mthrok fbshipit-source-id: 13e3aad74c0d0e654c39c0eeceffca1a00b0dac4
-
moto authored
Summary: Add metadata, such as ID3 (https://github.com/pytorch/audio/commit/7d98db0567cb60fabcc173949b8c08e3a3487ac2)tag to `StreamReaderSourceAudioStream`. Pull Request resolved: https://github.com/pytorch/audio/pull/2461 Reviewed By: hwangjeff Differential Revision: D36985656 Pulled By: mthrok fbshipit-source-id: e66f9e6e980eb57c378cc643a8979b6b7813dae7
-
hwangjeff authored
Summary: Pull Request resolved: https://github.com/pytorch/audio/pull/2460 Reviewed By: nateanl, mthrok Differential Revision: D36992043 Pulled By: hwangjeff fbshipit-source-id: 3a2a7f8991beaeaa2af0f620985230a68df201c2
-
- 07 Jun, 2022 7 commits
-
-
Sean Kim authored
Summary: Fixing return types for quesst14 Pull Request resolved: https://github.com/pytorch/audio/pull/2458 Reviewed By: carolineechen Differential Revision: D36977139 Pulled By: skim0514 fbshipit-source-id: f8f5a2de7cab2de1bec49c529c3bb9316145403d
-
Caroline Chen authored
Summary: ctc decoder has been moved to beta, remove prototype message from tutorial (this is done on the release branch in https://github.com/pytorch/audio/issues/2457) Pull Request resolved: https://github.com/pytorch/audio/pull/2459 Reviewed By: hwangjeff Differential Revision: D36978417 Pulled By: carolineechen fbshipit-source-id: e580c1e8475a1a0aa924d44deea3852adc332a86
-
Zhaoheng Ni authored
Summary: The PR contains the CTC fine-tuning recipe of HuBERT Base model. The files include: - lightning module - training script - README and the result table - evaluation scripts Pull Request resolved: https://github.com/pytorch/audio/pull/2352 Reviewed By: hwangjeff Differential Revision: D36915712 Pulled By: nateanl fbshipit-source-id: 0249635ad5e81a8aa2d228c1d5fe84d78b62a15b
-
moto authored
Summary: - Adopt `torchaudio.utils.download_asset` to simplify asset management. - Break down the first section about helper functions. - Use tempfile so that executing tutorial won't leave any artifacts on local file system. Example: https://output.circle-artifacts.com/output/job/b11a0087-8bf9-4999-a74f-b53798eaa77f/artifacts/0/docs/tutorials/audio_io_tutorial.html Pull Request resolved: https://github.com/pytorch/audio/pull/2385 Reviewed By: hwangjeff Differential Revision: D36404399 Pulled By: mthrok fbshipit-source-id: 106af34e8ddd22a061aa12767b444b32aef07bad
-
moto authored
Summary: At the time of release, we need to download doc built by CI. CircleCI does not have feature to download multiple files. This commit add the archive of built documentations as CI artifact so that the whole documentation can be downloaded at once. Resolves https://github.com/pytorch/audio/issues/2340 Pull Request resolved: https://github.com/pytorch/audio/pull/2448 Reviewed By: hwangjeff Differential Revision: D36942077 Pulled By: mthrok fbshipit-source-id: 61dde0d71841434a3d0624404d99911aa6956f88
-
moto authored
Summary: Import StreamReader from the new location Pull Request resolved: https://github.com/pytorch/audio/pull/2455 Reviewed By: nateanl Differential Revision: D36959668 Pulled By: mthrok fbshipit-source-id: c2b8c9f9dff1ec306ea39c495294faa9208b3c4e
-
moto authored
Summary: Address https://github.com/pytorch/audio/issues/2445 Pull Request resolved: https://github.com/pytorch/audio/pull/2450 Reviewed By: carolineechen Differential Revision: D36945877 Pulled By: mthrok fbshipit-source-id: c7f9ba8093c8dc03b27582b9c608b023c7700332
-
- 06 Jun, 2022 1 commit
-
-
moto authored
Summary: With the default log-level, completely sane operation like converting YUV to RGB issues bunch of warnings like `[swscaler @ 0x128aa8000] No accelerated colorspace conversion found from yuv420p to rgb24.` This commit sets the log level to FATAL. Pull Request resolved: https://github.com/pytorch/audio/pull/2447 Reviewed By: hwangjeff Differential Revision: D36938728 Pulled By: mthrok fbshipit-source-id: 39c2e6a4307f1eac577fd606e17ab0f298079b54
-
- 04 Jun, 2022 3 commits
-
-
Jeff Hwang authored
Summary: Pull Request resolved: https://github.com/pytorch/audio/pull/2437 Refactors LibriSpeech Lightning datamodule to accommodate different dataset implementations. Reviewed By: carolineechen, nateanl Differential Revision: D36731577 fbshipit-source-id: 4ba91044311fa3f99a928aef6ef411316955f6b5
-
moto authored
Summary: Undesired logs are one of the loudest UX complains we get. Yet, loading media files involves uncertainty which is difficult to debug without debug log. This commit introduces utility functions to configure logging level so that we can ask users to enable it when they encounter an issue, while defaulting to non-verbose option. Pull Request resolved: https://github.com/pytorch/audio/pull/2439 Reviewed By: hwangjeff, xiaohui-zhang Differential Revision: D36903763 Pulled By: mthrok fbshipit-source-id: f4ddd9915b13197c2a2eb97e965005b8b5b8d987
-
Caroline Chen authored
Summary: Pull Request resolved: https://github.com/pytorch/audio/pull/2443 Reviewed By: nateanl Differential Revision: D36909822 Pulled By: carolineechen fbshipit-source-id: ef3ab2345e7a4666cf29dd02c83d03504e8aa62c
-
- 03 Jun, 2022 5 commits
-
-
moto authored
Summary: - Adopt `torchaudio.utils.download_asset` to simplify asset management. - Break down the first section about helper functions. - Reduce the number of helper functions https://output.circle-artifacts.com/output/job/d7dd1b93-6dfe-46da-a080-109bfdc63881/artifacts/0/docs/tutorials/audio_data_augmentation_tutorial.html Pull Request resolved: https://github.com/pytorch/audio/pull/2388 Reviewed By: carolineechen Differential Revision: D36404405 Pulled By: mthrok fbshipit-source-id: f460ed810519797fce6e2fa7baaee110bddd1d06
-
moto authored
Summary: - Replace mis-use of plot_specgram with plot_sweep, and remove plot_specgram - Move `benchmark_resample` to later section https://output.circle-artifacts.com/output/job/9f7af187-777d-4d75-840f-2630a36295b7/artifacts/0/docs/tutorials/audio_resampling_tutorial.html Pull Request resolved: https://github.com/pytorch/audio/pull/2386 Reviewed By: carolineechen Differential Revision: D36404403 Pulled By: mthrok fbshipit-source-id: f9df8453e3f531bdc4549b0134e5dbba90653bf7
-
moto authored
Summary: - Adopt torchaudio.utils.download_asset to simplify asset management. - Break down the first section about helper functions. - Reduce the number of helper functions Pull Request resolved: https://github.com/pytorch/audio/pull/2391 Reviewed By: carolineechen, nateanl Differential Revision: D36885626 Pulled By: mthrok fbshipit-source-id: 1306f22ab70ab1e7f74ed7e43bf43150015448b6
-
Sean Kim authored
Summary: For test files where applicable, removed manual seeds where applicable. Refactoring https://github.com/pytorch/audio/issues/2267 Pull Request resolved: https://github.com/pytorch/audio/pull/2436 Reviewed By: carolineechen Differential Revision: D36896854 Pulled By: skim0514 fbshipit-source-id: 7b4dd8a8dbfbef271f5cc56564dc83a760407e6c
-
Andrey Talman authored
Summary: Refactor M1 logic These improvement introduced in following PR: https://github.com/pytorch/vision/pull/6117 Pull Request resolved: https://github.com/pytorch/audio/pull/2438 Reviewed By: nateanl Differential Revision: D36896028 Pulled By: atalman fbshipit-source-id: 2ce360bfa78b2a7c77d5d4db800d487d171831a9
-
- 02 Jun, 2022 5 commits
-
-
Andrey Talman authored
Summary: Retrieve version from version.txt These improvement introduced in following PR: https://github.com/pytorch/vision/pull/6117 In addition to this we add version.txt file to help us manage torchaudio version Pull Request resolved: https://github.com/pytorch/audio/pull/2434 Reviewed By: mthrok Differential Revision: D36867886 Pulled By: atalman fbshipit-source-id: 14b6d653e46489d8db1c5ae2016a8202c632861e
-
Caroline Chen authored
Summary: update QUESST14 getitem to include docstrings and additionally return sample rate Pull Request resolved: https://github.com/pytorch/audio/pull/2435 Reviewed By: nateanl Differential Revision: D36864254 Pulled By: carolineechen fbshipit-source-id: 9e68bbc5de27ad2f32f6b298414103c4f6784801
-
moto authored
Summary: Remove the code related to libmad, which had been disabled in https://github.com/pytorch/audio/issues/2354 In https://github.com/pytorch/audio/issues/2419, we mp3 decoding to ffmpeg. But CI tests were still using libmad. This commit completely removes libmad from torchaudio. This is BC-breaking change as `apply_sox_effects_file` function cannot handle MP3, and it cannot fallback to ffmpeg. The workaround for this is to use `torchaudio.load` then `apply_sox_effects_tensor`. Pull Request resolved: https://github.com/pytorch/audio/pull/2428 Reviewed By: carolineechen Differential Revision: D36851805 Pulled By: mthrok fbshipit-source-id: f98795c59a1ac61cef511f2bbeac37f7c3c69d55
-
Zhaoheng Ni authored
Summary: - Use `download_asset` to download audios. - Replace `MVDR` module with new-added `SoudenMVDR` and `RTFMVDR` modules. - Benchmark performances of `F.rtf_evd` and `F.rtf_power` for RTF computation. - Visualize the spectrograms and masks. Pull Request resolved: https://github.com/pytorch/audio/pull/2398 Reviewed By: carolineechen Differential Revision: D36549402 Pulled By: nateanl fbshipit-source-id: dfd6754e6c33246e6991ccc51c4603b12502a1b5
-
moto authored
Summary: This commit add fallback mechanism to `info` and `load` functions of sox_io backend. If torchaudio is compiled to use FFmpeg, and runtime dependencies are properly loaded, in case `info` and `load` fail, it fallback to FFmpeg-based implementation. BC-breaking changes: - FFmpeg does not report the number of frames for MP3, this is because MP3 does not store the information of the number of frames. It can be estimated from the audio duration and sample rate, but it might be inaccurate, so we keep it 0. Depends on - https://github.com/pytorch/audio/issues/2416 - https://github.com/pytorch/audio/issues/2417 - https://github.com/pytorch/audio/issues/2418 - https://github.com/pytorch/audio/issues/2423 - https://github.com/pytorch/audio/issues/2427 Pull Request resolved: https://github.com/pytorch/audio/pull/2419 Reviewed By: carolineechen Differential Revision: D36740306 Pulled By: mthrok fbshipit-source-id: 9e2ad095b8b39e41404970de0d8d9b5aaa856c97
-
- 01 Jun, 2022 2 commits
-
-
Sean Kim authored
Summary: Checks download flag and raises error when dataset is missing given download flag exists. Unit tested manually. edit: Changed path to check as well as comment that is returned. Pull Request resolved: https://github.com/pytorch/audio/pull/2430 Reviewed By: carolineechen Differential Revision: D36815729 Pulled By: skim0514 fbshipit-source-id: f062db7919271665b88ec9754d85cfa83b4f6fa3
-
moto authored
Summary: A couple of weeks ago we started to see OpenMP not found error on macOS CI. From https://github.com/pytorch/audio/issues/2404, we install OpenMP from brew, and build passes, but unit tests are seg-faulting ever since. https://app.circleci.com/pipelines/github/pytorch/audio/10825/workflows/c0ecae99-d409-4df2-ab91-9bcb126c309d/jobs/671518 The failing test uses `torchaudio.functional.filitfilt`, which uses [OpenMP for parallel execution](https://github.com/pytorch/audio/blob/6057d3cf1c2f3a4c5072a3853a021bb8b4ce61f7/torchaudio/csrc/lfilter.cpp#L20). This commit reverts https://github.com/pytorch/audio/issues/2404 and disables OpenMP for macOS builds and tests. Pull Request resolved: https://github.com/pytorch/audio/pull/2431 Reviewed By: atalman Differential Revision: D36819141 Pulled By: mthrok fbshipit-source-id: 824300866a55f8b029d21649dc96cd80ae2ff697
-