- 11 Oct, 2022 1 commit
-
-
atalman authored
Summary: Increase inactivity timeout for binary build jobs Pull Request resolved: https://github.com/pytorch/audio/pull/2754 Reviewed By: carolineechen Differential Revision: D40275368 Pulled By: atalman fbshipit-source-id: 5e682bb78bda640d615f874fbdf0e650b5a38ee0
-
- 06 Oct, 2022 1 commit
-
-
Ivan Zaitsev authored
Summary: The goal is to to reduce the number of job failures due to timeouts, see https://app.circleci.com/pipelines/github/pytorch/audio/12882/workflows/f99da1a5-32e6-4bac-8ceb-fbf36d693e2d/jobs/936363?invite=true#step-105-105 for example. Pull Request resolved: https://github.com/pytorch/audio/pull/2734 Reviewed By: weiwangmeta, atalman Differential Revision: D40077578 fbshipit-source-id: 573f43a4d088a7086fa6925ac5ba1fdd1e8f39ec
-
- 29 Sep, 2022 1 commit
-
-
atalman authored
Summary: Cuda 10.2 deprecation, migration of unit tests from cuda 10.2 to cuda 11.6 Pull Request resolved: https://github.com/pytorch/audio/pull/2724 Reviewed By: weiwangmeta Differential Revision: D39912484 Pulled By: atalman fbshipit-source-id: e760b630375eae94384cda68d24f83ef46ada6d9
-
- 28 Sep, 2022 3 commits
-
-
atalman authored
Summary: Revert this fot now untill docker is updated Pull Request resolved: https://github.com/pytorch/audio/pull/2723 Reviewed By: nateanl Differential Revision: D39900382 Pulled By: atalman fbshipit-source-id: f8701e359bc11e8f9f3a29144f7e7da336a470da
-
Andrey Talman authored
Summary: Removing cuda102 Pull Request resolved: https://github.com/pytorch/audio/pull/2715 Reviewed By: hwangjeff Differential Revision: D39823444 Pulled By: atalman fbshipit-source-id: c11d798ab86cf9a6d5ed3804958b4a0c2f8a87ff
-
Ivan Zaitsev authored
Summary: Example job that was failing previously: https://app.circleci.com/pipelines/github/pytorch/audio/12796/workflows/ae96794a-6df4-4a2a-84df-ada7a7250045/jobs/927709 The failure: ``` "Detected that PyTorch and TorchAudio were compiled with different CUDA versions. " RuntimeError: Detected that PyTorch and TorchAudio were compiled with different CUDA versions. PyTorch has CUDA version 11.7 whereas TorchAudio has CUDA version 11.6. Please install the TorchAudio version that matches your PyTorch version. ``` Has install command: ``` pip install $(ls ~/workspace/torchaudio*.whl) -f "https://download.pytorch.org/whl/${UPLOAD_CHANNEL}/torch_${UPLOAD_CHANNEL}.html" # expands to: pip install /c/Users/circleci/workspace/torchaudio-0.13.0.dev20220927+cu116-cp37-cp37m-win_amd64.whl -f https://download.pytorch.org/whl/nightly/torch_nightly.html ``` Linux job (succeeds) for uses different "-f" (find links) url, that includes specific cuda version: https://app.circleci.com/pipelines/github/pytorch/audio/12809/workflows/aadca2ab-5a00-4a0a-ab6a-4a1b7a503713/jobs/927861 Command: ``` pip install $(ls ~/workspace/torchaudio*.whl) -f "https://download.pytorch.org/whl/${UPLOAD_CHANNEL}/${CU_VERSION}/torch_${UPLOAD_CHANNEL}.html" # expands to: pip install /root/workspace/torchaudio-0.13.0.dev20220927+cu116-cp37-cp37m-linux_x86_64.whl -f https://download.pytorch.org/whl/nightly/cu116/torch_nightly.html ``` This PR makes Windows installation match the linux one. Testing: * verified command manually on Circle CI: ``` >>> import torch >>> import torchaudio C:\tools\miniconda3\lib\site-packages\torchaudio\compliance\kaldi.py:22: UserWarning: Failed to initialize NumPy: numpy.core.multiarray failed to import (Triggered internally at C:\actions-runner\_work\pytorch\pytorch\builder\windows\pytorch\torch\csrc\utils\tensor_numpy.cpp:77.) EPSILON = torch.tensor(torch.finfo(torch.float).eps) C:\tools\miniconda3\lib\site-packages\torchaudio\backend\utils.py:62: UserWarning: No audio backend is available. warnings.warn("No audio backend is available.") ``` Co-authered: weiwangmeta Pull Request resolved: https://github.com/pytorch/audio/pull/2721 Reviewed By: hwangjeff Differential Revision: D39870805 Pulled By: izaitsevfb fbshipit-source-id: 2957cba4f53d00783a5c07099f24050ce15e7d1c
-
- 27 Sep, 2022 1 commit
-
-
Omkar Salpekar authored
Summary: Pull Request resolved: https://github.com/pytorch/audio/pull/2718 Original commit changeset: 7e222d80ca07 Original Phabricator Diff: D39756852 (https://github.com/pytorch/audio/commit/7ba7cf4d24a2967b8fa4aaff437116524281f8fd) Reviewed By: weiwangmeta Differential Revision: D39839899 fbshipit-source-id: f5605eb9882f7c7f0008e88338ab711131b29404
-
- 26 Sep, 2022 2 commits
-
-
Andrey Talman authored
Summary: Conda version on circleCI prints following message: ``` ==> WARNING: A newer version of conda exists. <== current version: 4.6.14 latest version: 4.14.0 ``` and as a result this error: ``` + /c/tools/miniconda3/Scripts/conda.exe install -v -y -c pytorch-nightly -c nvidia pytorch numpy ffmpeg pytorch-cuda=11.6 Collecting package metadata: ...working... done Solving environment: ...working... Too long with no output (exceeded 30m0s): context deadline exceeded ``` This should update the conda version running on the system and allow us to install pytorch and run some tests. Pull Request resolved: https://github.com/pytorch/audio/pull/2704 Reviewed By: weiwangmeta Differential Revision: D39820037 Pulled By: atalman fbshipit-source-id: 4a82a7a6cbe3dc1a5807ac669e2fa79f454037fa
-
Andrey Talman authored
Summary: Remove linux wheel from circleci Pull Request resolved: https://github.com/pytorch/audio/pull/2714 Reviewed By: weiwangmeta Differential Revision: D39816121 Pulled By: atalman fbshipit-source-id: a3c99b530896888d7b4271d8b3f27f3c986b3480
-
- 23 Sep, 2022 1 commit
-
-
Omkar Salpekar authored
Summary: This does 2 things: Comments out Linux Wheels-related jobs in CircleCI so that they are not run on nightlies/releases. Adds a GHA workflow that calls the build workflow in pytorch/test-infra. Testing: Verified that the builds are triggered by this workflow, and all builds are green: https://github.com/pytorch/audio/actions/runs/3109635749/jobs/5040029155 Pull Request resolved: https://github.com/pytorch/audio/pull/2702 Reviewed By: seemethere Differential Revision: D39756852 Pulled By: osalpekar fbshipit-source-id: 7e222d80ca0720e3be43b929f1e55f5c0166b947
-
- 20 Sep, 2022 1 commit
-
-
Jithun Nair authored
Summary: Pull Request resolved: https://github.com/pytorch/audio/pull/2672 Reviewed By: atalman Differential Revision: D39468320 Pulled By: mthrok fbshipit-source-id: 0e7bd4fd922ba0db51700e140b95328a5b687a6f
-
- 14 Sep, 2022 1 commit
-
-
Andrey Talman authored
Summary: CUDA 11.3 Removing. Core PR: https://github.com/pytorch/pytorch/pull/84866 cc malfet ptrblck Pull Request resolved: https://github.com/pytorch/audio/pull/2670 Reviewed By: malfet, osalpekar Differential Revision: D39449263 Pulled By: atalman fbshipit-source-id: f86bb119685ead3ffcabd92c4bb8076aecde4095
-
- 26 Aug, 2022 1 commit
-
-
pbialecki authored
Summary: CC atalman Pull Request resolved: https://github.com/pytorch/audio/pull/2623 Reviewed By: hwangjeff, nateanl Differential Revision: D39036432 Pulled By: atalman fbshipit-source-id: cd74a1bf8f74e31bd2c32c80d32c617f4b1766e8
-
- 24 Aug, 2022 1 commit
-
-
moto authored
Summary: This commit adds FFmpeg-based encoder StreamWriter class. StreamWriter is pretty much the opposite of StreamReader class, and it supports; * Encoding audio / still image / video * Exporting to local file / streaming protocol / devices etc... * File-like object support (in later commit) * HW video encoding (in later commit) See also: https://fburl.com/gslide/z85kn5a9 (Meta internal) Pull Request resolved: https://github.com/pytorch/audio/pull/2628 Reviewed By: nateanl Differential Revision: D38816650 Pulled By: mthrok fbshipit-source-id: a9343b0d55755e186971dc96fb86eb52daa003c8
-
- 16 Aug, 2022 1 commit
-
-
Andrey Talman authored
Summary: Similar to https://github.com/pytorch/vision/pull/6218 Fixing MacOS builds Pull Request resolved: https://github.com/pytorch/audio/pull/2622 Reviewed By: weiwangmeta Differential Revision: D38722983 Pulled By: atalman fbshipit-source-id: 4cef85c97dc270fc812bc289592c4f3815f73c85
-
- 12 Aug, 2022 1 commit
-
-
Andrey Talman authored
Summary: Introducing pytorch-cuda metapackage Same as: https://github.com/pytorch/vision/pull/6371 Following PR: https://github.com/pytorch/builder/pull/1094 Adds cuda metapackage called pytorch-cuda . This way we can make sure to install correct version of cuda dependencies and don't depend on conda-forge. Pull Request resolved: https://github.com/pytorch/audio/pull/2612 Reviewed By: hwangjeff, seemethere, nateanl Differential Revision: D38633332 Pulled By: atalman fbshipit-source-id: 78a6115bb252ebdb6d66a57d7d2c4a4978ddb501
-
- 29 Jul, 2022 2 commits
-
-
moto authored
Summary: This commit enables CTC decoder on Windows. The functionality seems to work fine. The tests are passing, the decoding tutorial runs fine. The only difference to the Linux/macOS version is that loading model in XZ compression format is not supported.  Pull Request resolved: https://github.com/pytorch/audio/pull/2587 Reviewed By: carolineechen, nateanl Differential Revision: D38276490 Pulled By: mthrok fbshipit-source-id: f2203b2235c5bbb0220fe560aaaf0e1d5530347a
-
Zhaoheng Ni authored
Summary: - The "speech + noise" mixture still has a high SNR, which can't show the effectiveness of MVDR beamforming. To make the task more challenging, amplify the noise waveform to reduce the SNR of mixture speech. - Show the Si-SNR score of mixture speech when visualizing the mixture spectrogram. - FIx the figure in `rtf_power` subsection. - The description of enhanced spectrogram by `rtf_power` is wrong. Correct it to `rtf_power`. - Print PESQ, STOI, and SDR metric scores. Pull Request resolved: https://github.com/pytorch/audio/pull/2527 Reviewed By: mthrok Differential Revision: D38190218 Pulled By: nateanl fbshipit-source-id: 39562850a67f58a16e0a2866ed95f78c3f4dc7de
-
- 28 Jul, 2022 1 commit
-
-
Sean Kim authored
Summary: Add tutorial python file, draft PR, will continue to modify accordingly to feedback. Future plan: modify spectrogram and bottom audio design and work on finding best audio track and segments Pull Request resolved: https://github.com/pytorch/audio/pull/2572 Reviewed By: carolineechen, nateanl, mthrok Differential Revision: D38234001 Pulled By: skim0514 fbshipit-source-id: fe9207864f354dec5cf5ff52bf7d9ddcf4a001d5
-
- 25 Jul, 2022 1 commit
-
-
moto authored
Summary: This commit fix build_docs job timeout by pinning `resampy=0.2.2`. For some mysterious reason, `resampy=0.3.1` causes slowdown of unrelated code. https://github.com/bmcfee/resampy/issues/106 Pull Request resolved: https://github.com/pytorch/audio/pull/2543 Reviewed By: carolineechen Differential Revision: D38115003 Pulled By: mthrok fbshipit-source-id: 67cd1c73dd4adb3091e0b88aaf5c31de0dd4b87e
-
- 19 Jul, 2022 1 commit
-
-
Sean Kim authored
Summary: Factory functions have been added to HDemucs class and test the implementation within the testing files. Pull Request resolved: https://github.com/pytorch/audio/pull/2547 Reviewed By: carolineechen Differential Revision: D37948600 Pulled By: skim0514 fbshipit-source-id: 7ac4e4a71519450cfbbc24ff7d7e70521f676040
-
- 15 Jul, 2022 1 commit
-
-
moto authored
Summary: Recent CircleCI migration https://github.com/pytorch/audio/pull/2529 silently bumped the minimum supported macOS version to 11. PyTorch still supports 10.9 and the ecosystem still uses 10.9. Issue: https://github.com/pytorch/audio/issues/2536 This commit sets MACOSX_DEPLOYMENT_TARGET=10.9, so that binary distribution are compatible on macOS=10.9. Pull Request resolved: https://github.com/pytorch/audio/pull/2546 Reviewed By: atalman Differential Revision: D37854586 Pulled By: mthrok fbshipit-source-id: a43986ae4de9ef51a4261e0f9fe58e88b4b72148
-
- 07 Jul, 2022 2 commits
-
-
moto authored
Summary: CircleCI is removing Xcode 12.4.0 image on August, and there was a planned burnout on July 6th. [[detail](https://discuss.circleci.com/t/xcode-image-deprecation/44294?mkt_tok=NDg1LVpNSC02MjYAAAGFbbxbX7nSPCzN0MCKN078pw0VLJ-TMdICr8_gouRNYBM8C55RL8NDKLXA_9CQGPqnhJE5lsSFdetLRF-nH7iBLzoPGBfYpf2vuJ-XkW_C4__4)] https://app.circleci.com/pipelines/github/pytorch/audio/11566/workflows/da167296-a84f-4dfe-b1b9-60d67e7a3d1c/jobs/771638 This commit updates Xcode image to 12.5 Pull Request resolved: https://github.com/pytorch/audio/pull/2529 Reviewed By: atalman Differential Revision: D37688122 Pulled By: mthrok fbshipit-source-id: 1095edbf0d920c4dc772555915bce93875b74671
-
moto authored
Summary: Following the formatter changes heppened in fbcode, this commit update the linter config. Pull Request resolved: https://github.com/pytorch/audio/pull/2389 Reviewed By: hwangjeff Differential Revision: D37659649 Pulled By: mthrok fbshipit-source-id: 1c52ff93f0b10cb2e7303d2ad13b2d65ffccfcb0
-
- 29 Jun, 2022 1 commit
-
-
moto authored
Summary: The build doc job is failing these days due to the fact that CUDA 11.6 requires different handling. Pull Request resolved: https://github.com/pytorch/audio/pull/2520 Reviewed By: xiaohui-zhang Differential Revision: D37527088 Pulled By: mthrok fbshipit-source-id: 34c23bdbf70ba9fb8e315c7036cff01b3ddf4c91
-
- 27 Jun, 2022 1 commit
-
-
Andrey Talman authored
Summary: Fix for the cuda 11.6 and usage of cudatoolkit Pull Request resolved: https://github.com/pytorch/audio/pull/2501 Reviewed By: mthrok Differential Revision: D37388598 Pulled By: atalman fbshipit-source-id: 41add7ad6fbb3d156cc1270625dc085c62f7a531
-
- 15 Jun, 2022 2 commits
-
-
moto authored
Summary: Lint style has diverged since fb-internal lint engine has been changed. Backport of https://github.com/pytorch/audio/issues/2466. Pull Request resolved: https://github.com/pytorch/audio/pull/2487 Reviewed By: carolineechen Differential Revision: D37160193 Pulled By: mthrok fbshipit-source-id: cf4e2091a78a0da53269ae1251a55d4d1e52ead2
-
moto authored
Summary: The version of MKL that is installed alongside PyTorch has been bumped to 2022.1 on Windows and it is causing installation issue in unit tests. This commit pins the previous version Backport of https://github.com/pytorch/audio/issues/2463 Pull Request resolved: https://github.com/pytorch/audio/pull/2486 Reviewed By: nateanl Differential Revision: D37160156 Pulled By: mthrok fbshipit-source-id: 7e3a30c25782b349a3cad2ee6d1141affc921881
-
- 07 Jun, 2022 1 commit
-
-
moto authored
Summary: At the time of release, we need to download doc built by CI. CircleCI does not have feature to download multiple files. This commit add the archive of built documentations as CI artifact so that the whole documentation can be downloaded at once. Resolves https://github.com/pytorch/audio/issues/2340 Pull Request resolved: https://github.com/pytorch/audio/pull/2448 Reviewed By: hwangjeff Differential Revision: D36942077 Pulled By: mthrok fbshipit-source-id: 61dde0d71841434a3d0624404d99911aa6956f88
-
- 02 Jun, 2022 1 commit
-
-
moto authored
Summary: Remove the code related to libmad, which had been disabled in https://github.com/pytorch/audio/issues/2354 In https://github.com/pytorch/audio/issues/2419, we mp3 decoding to ffmpeg. But CI tests were still using libmad. This commit completely removes libmad from torchaudio. This is BC-breaking change as `apply_sox_effects_file` function cannot handle MP3, and it cannot fallback to ffmpeg. The workaround for this is to use `torchaudio.load` then `apply_sox_effects_tensor`. Pull Request resolved: https://github.com/pytorch/audio/pull/2428 Reviewed By: carolineechen Differential Revision: D36851805 Pulled By: mthrok fbshipit-source-id: f98795c59a1ac61cef511f2bbeac37f7c3c69d55
-
- 01 Jun, 2022 1 commit
-
-
moto authored
Summary: A couple of weeks ago we started to see OpenMP not found error on macOS CI. From https://github.com/pytorch/audio/issues/2404, we install OpenMP from brew, and build passes, but unit tests are seg-faulting ever since. https://app.circleci.com/pipelines/github/pytorch/audio/10825/workflows/c0ecae99-d409-4df2-ab91-9bcb126c309d/jobs/671518 The failing test uses `torchaudio.functional.filitfilt`, which uses [OpenMP for parallel execution](https://github.com/pytorch/audio/blob/6057d3cf1c2f3a4c5072a3853a021bb8b4ce61f7/torchaudio/csrc/lfilter.cpp#L20). This commit reverts https://github.com/pytorch/audio/issues/2404 and disables OpenMP for macOS builds and tests. Pull Request resolved: https://github.com/pytorch/audio/pull/2431 Reviewed By: atalman Differential Revision: D36819141 Pulled By: mthrok fbshipit-source-id: 824300866a55f8b029d21649dc96cd80ae2ff697
-
- 30 May, 2022 1 commit
-
-
moto authored
Summary: All the unittests jobs are failing due to import error due to protobuf and scipy. This commit pins the versions of them to an older version. ## protobuf https://app.circleci.com/pipelines/github/pytorch/audio/10979/workflows/42005226-ca7e-471c-80f4-db09f4bd2089/jobs/692078 ``` E TypeError: Descriptors cannot not be created directly. E If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0. E If you cannot immediately regenerate your protos, some other possible workarounds are: E 1. Downgrade the protobuf package to 3.20.x or lower. E 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower). E E More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates ``` https://github.com/protocolbuffers/protobuf/issues/10051 https://github.com/PyTorchLightning/pytorch-lightning/issues/13159 ## scipy (pypocketfft) 1.8.1 is causing issue. https://app.circleci.com/pipelines/github/pytorch/audio/10980/workflows/470a9361-4cc5-4d7c-9264-28fc8b86f1cb/jobs/692267 ``` ../env/lib/python3.9/site-packages/librosa/core/audio.py:11: in <module> import scipy.signal ../env/lib/python3.9/site-packages/scipy/signal/__init__.py:309: in <module> from . import _sigtools, windows ../env/lib/python3.9/site-packages/scipy/signal/windows/__init__.py:41: in <module> from ._windows import * ../env/lib/python3.9/site-packages/scipy/signal/windows/_windows.py:7: in <module> from scipy import linalg, special, fft as sp_fft ../env/lib/python3.9/site-packages/scipy/fft/__init__.py:91: in <module> from ._helper import next_fast_len ../env/lib/python3.9/site-packages/scipy/fft/_helper.py:3: in <module> from ._pocketfft import helper as _helper ../env/lib/python3.9/site-packages/scipy/fft/_pocketfft/__init__.py:3: in <module> from .basic import * ../env/lib/python3.9/site-packages/scipy/fft/_pocketfft/basic.py:6: in <module> from . import pypocketfft as pfft E ImportError: /home/circleci/project/env/lib/python3.9/site-packages/torch/lib/../../../.././libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by /home/circleci/project/env/lib/python3.9/site-packages/scipy/fft/_pocketfft/pypocketfft.cpython-39-x86_64-linux-gnu.so) Pull Request resolved: https://github.com/pytorch/audio/pull/2422 Reviewed By: atalman Differential Revision: D36764198 Pulled By: mthrok fbshipit-source-id: 897a79fe9c3165206c2e747147fd0f257fc4f683
-
- 20 May, 2022 2 commits
-
-
moto authored
Summary: After https://github.com/pytorch/audio/issues/2395, build_doc job is exceeding default no-output-timeout threshould (10m). This commit updates the timeout threshold to 30m. Also it moves the installation of tools to the previous step. Pull Request resolved: https://github.com/pytorch/audio/pull/2399 Reviewed By: carolineechen Differential Revision: D36539022 Pulled By: mthrok fbshipit-source-id: 391764a0fb5bf87cfb2beaab401a90dcb56493e5
-
moto authored
Summary: This commit adds tutorial to enable/use NVDEC with Stream API. https://output.circle-artifacts.com/output/job/19e66a4b-1819-4804-8834-d38e6c80c4fd/artifacts/0/docs/hw_acceleration_tutorial.html Because the use of NVDEC requires build / install FFmpeg from source, this tutorial was authored on Google Colab, tailored to its environment. The tutorial here is the result of the notebook execution, with the link to the publicly accessible Google Colab notebook. Pull Request resolved: https://github.com/pytorch/audio/pull/2393 Reviewed By: hwangjeff Differential Revision: D36404408 Pulled By: mthrok fbshipit-source-id: 9c820d3db4d06c5b343ecad0708489125ca06948
-
- 19 May, 2022 1 commit
-
-
Eli Uriegas authored
Summary: To resolve nightly / general build issues relating to OpenMP not being found, see https://hud.pytorch.org/pytorch/audio/commit/c6a376cc5679c1940e49fc3e0ba22eaead6c2467 ``` -- Found Torch: /Users/distiller/miniconda3/envs/env3.10/lib/python3.10/site-packages/torch/lib/libtorch.dylib CMake Error at /Users/distiller/miniconda3/envs/env3.10/lib/python3.10/site-packages/cmake/data/CMake.app/Contents/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES) Call Stack (most recent call first): /Users/distiller/miniconda3/envs/env3.10/lib/python3.10/site-packages/cmake/data/CMake.app/Contents/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE) /Users/distiller/miniconda3/envs/env3.10/lib/python3.10/site-packages/cmake/data/CMake.app/Contents/share/cmake-3.22/Modules/FindOpenMP.cmake:544 (find_package_handle_standard_args) CMakeLists.txt:131 (find_package) -- Configuring incomplete, errors occurred! ``` Signed-off-by:
Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: https://github.com/pytorch/audio/pull/2404 Reviewed By: atalman Differential Revision: D36495791 Pulled By: seemethere fbshipit-source-id: 7b6fa2a62fda6fc468cfcbdf8d2163e6b9c327b0
-
- 16 May, 2022 1 commit
-
-
moto authored
Summary: This commit moves `build_doc` job to run on top of Conda binary build job. The motivation is that Conda provides easy access to third party tools that are required to build complex documentation. Specifically in https://github.com/pytorch/audio/pull/2393, ipynb-style tutorial is being added, which requires `nbsphinx`. `nbsphinx` requires `pandoc` package and there was some issue with the version from PyPI. A workaround is to use the one from Conda package. Pull Request resolved: https://github.com/pytorch/audio/pull/2395 Reviewed By: carolineechen, nateanl Differential Revision: D36404407 Pulled By: mthrok fbshipit-source-id: 26ec5ebfd5be795384306a9f24817a2eb3ec96c1
-
- 13 May, 2022 1 commit
-
-
moto authored
Summary: This commit moves the Streaming API out of prototype module. * The related classes are renamed as following - `Streamer` -> `StreamReader`. - `SourceStream` -> `StreamReaderSourceStream` - `SourceAudioStream` -> `StreamReaderSourceAudioStream` - `SourceVideoStream` -> `StreamReaderSourceVideoStream` - `OutputStream` -> `StreamReaderOutputStream` This change is preemptive measurement for the possibility to add `StreamWriter` API. * Replace BUILD_FFMPEG build arg with USE_FFMPEG We are not building FFmpeg, so USE_FFMPEG is more appropriate --- After https://github.com/pytorch/audio/issues/2377 Remaining TODOs: (different PRs) - [ ] Introduce `is_ffmpeg_binding_available` function. - [ ] Refactor C++ code: - Rename `Streamer` to `StreamReader`. - Rename `streamer.[h|cpp]` to `stream_reader.[h|cpp]`. - Rename `prototype.cpp` to `stream_reader_binding.cpp`. - Introduce `stream_reader` directory. - [x] Enable FFmpeg in smoke test (https://github.com/pytorch/audio/issues/2381) Pull Request resolved: https://github.com/pytorch/audio/pull/2378 Reviewed By: carolineechen Differential Revision: D36359299 Pulled By: mthrok fbshipit-source-id: 6a57b702996af871e577fb7addbf3522081c1328
-
- 11 May, 2022 1 commit
-
-
moto authored
Summary: Conda package build performs simple smoke test, which is different from smoke_test jobs we define on our CI jobs. Currently Conda packaging smoke test verifies the imporatability of `torchaudio.prototype.io`, which requires FFmpeg 4. 1. We list FFmpeg 4 as runtime requirements, but this means that conda's dependency resolver takes FFmpeg 4 into consideration. FFmpeg 5 was release this year, and we can expect that user base will move to FFmpeg gradually. If user environment has some constraint on FFmpeg, torchaudio will have conflict and it will prevent users from install torchaudio. 2. In #2377 the way optional dependency is checked/initialized is changed, so this Conda smoke test will no longer check the integrity with FFmpeg libraries. To solve the issues above, this commit moves the part that tests integrity with FFmpeg libraries to the smoke test we define on CircleCI. Pull Request resolved: https://github.com/pytorch/audio/pull/2381 Reviewed By: carolineechen Differential Revision: D36323706 Pulled By: mthrok fbshipit-source-id: 57ca816e0f3ad8e16d21e56062f6ed8a09ab93a3
-
- 10 May, 2022 1 commit
-
-
Kyle Chen authored
Summary: previous update for rocm: https://github.com/pytorch/audio/pull/2186 Pull Request resolved: https://github.com/pytorch/audio/pull/2362 Reviewed By: seemethere Differential Revision: D36283672 Pulled By: mthrok fbshipit-source-id: bfd38940d027c8ccd72ab48991e5ab7f84b0e9c0
-
- 06 May, 2022 1 commit
-
-
moto authored
Summary: This commit changes the way torchaudio binary distributions are built. * For all the binary distributions (conda/pip on Linux/macOS/Windnows), build custom FFmpeg libraries. * The custom FFmpeg libraries do not use `--use-gpl` nor `--use-nonfree`, so that they stay LGPL. * The custom FFmpeg libraries employ rpath so that the torchaudio binary distributions look for the corresponding FFmpeg libraries installed in the runtime environment. * The torchaudio binary build process will use them to bootstrap its build process. * The custom FFmpeg libraries are NOT shipped. This commit also add disclaimer about FFmpeg in README. Pull Request resolved: https://github.com/pytorch/audio/pull/2355 Reviewed By: nateanl Differential Revision: D36202087 Pulled By: mthrok fbshipit-source-id: c30e5222ba190106c897e42f567cac9152dbd8ef
-