Skip to content

GitLab

Switch branch/tag
  1. 07 Jul, 2022 2 commits
    • moto's avatar
      Move helper functions out of common utility for better locality (#2512) · 10ac6d2b
      moto authored 
      Summary:
This commits move helper functions/definitions around so that better locality of logics are achieved.

## Detail

`ffmpeg.[h|cpp]` implements classes that convert FFmpeg structures into RAII semantics.
Initially it these classes included the construction logic in their constructors, but such logics were
extracted to factory functions in https://github.com/pytorch/audio/issues/2373.

Now the reason why the factory functions stayed in `ffmpeg.[h|cpp]` was because the logic for
the initialization and  clean-up of AVDictionary class was only available in `ffmpeg.cpp`.

Now AVDictionary class handling is properly defined in https://github.com/pytorch/audio/issues/2507, the factory functions, which are not
that reusable better stay with the implementation that use them.

This makes `ffmpeg.h` lean and clean, makes it easier to see what can be reused.

Pull Request resolved: https://github.com/pytorch/audio/pull/2512

Reviewed By: hwangjeff

Differential Revision: D37477592

Pulled By: mthrok

fbshipit-source-id: 8c1b5059ea5f44649cc0eb1f82d1a92877ef186e
      10ac6d2b
    • moto's avatar
      Update lint config (#2389) · 515fd01c
      moto authored 
      Summary:
Following the formatter changes heppened in fbcode, this commit update the linter config.

Pull Request resolved: https://github.com/pytorch/audio/pull/2389

Reviewed By: hwangjeff

Differential Revision: D37659649

Pulled By: mthrok

fbshipit-source-id: 1c52ff93f0b10cb2e7303d2ad13b2d65ffccfcb0
      515fd01c
  3. 06 Jul, 2022 1 commit
    • Caroline Chen's avatar
      Fix fluent test for windows (#2510) · 09daa438
      Caroline Chen authored 
      Summary:
fluent dataset test currently fails on windows, due to new line generation in csv writer in testing and incorrect path parsing in dataset impl.

Pull Request resolved: https://github.com/pytorch/audio/pull/2510

Reviewed By: carolineechen

Differential Revision: D37573203

Pulled By: mthrok

fbshipit-source-id: 4868bc649690c7e596b002686c6128ce735d3564
      09daa438
  5. 29 Jun, 2022 1 commit
    • moto's avatar
      Fix build doc job (#2520) · ef8bd7b6
      moto authored 
      Summary:
The build doc job is failing these days due to the fact that CUDA 11.6 requires different handling.

Pull Request resolved: https://github.com/pytorch/audio/pull/2520

Reviewed By: xiaohui-zhang

Differential Revision: D37527088

Pulled By: mthrok

fbshipit-source-id: 34c23bdbf70ba9fb8e315c7036cff01b3ddf4c91
      ef8bd7b6
  7. 28 Jun, 2022 3 commits
    • hwangjeff's avatar
      Add 0.12.0 to version compatibility matrix (#2513) · d3b4ce68
      hwangjeff authored 
      Summary: Pull Request resolved: https://github.com/pytorch/audio/pull/2513

Reviewed By: mthrok

Differential Revision: D37491994

Pulled By: hwangjeff

fbshipit-source-id: 2c164bcec39342fd94abf4cc148d96dc9844699e
      d3b4ce68
    • moto's avatar
      Refactor FilterGraph interface (#2508) · 0dd57236
      moto authored 
      Summary:
FilterGraph is necessary for StreamWriter when saving video as
Tensor array format cannot express commonot video formats like yub420.

The current implementation of FilterGraph is specific to StreamReader,
as it takes AVCodecParameters object. Not individual parameters.

This PR refactor FilterGraph interface so that it can be constructed
from more primitive information.

Pull Request resolved: https://github.com/pytorch/audio/pull/2508

Reviewed By: hwangjeff

Differential Revision: D37466033

Pulled By: mthrok

fbshipit-source-id: 8414e985da7579c2dfe260b4dccd2afe113bb573
      0dd57236
    • moto's avatar
      Refactor AVDictionary clean up (#2507) · 0ad03adf
      moto authored 
      Summary:
Small clean up in ffmpeg binding code.

1. Make `get_option_dict` and `clean_up_dict` public utility
2. Merge the exception into `clean_up_dict`
3. Get rid of custom string join function and use `c10::Join`.

Pull Request resolved: https://github.com/pytorch/audio/pull/2507

Reviewed By: hwangjeff

Differential Revision: D37466022

Pulled By: mthrok

fbshipit-source-id: 44b769ac6ff1ab20e6d6ae086cd1447deacb5969
      0ad03adf
  9. 27 Jun, 2022 5 commits
  11. 24 Jun, 2022 1 commit
  13. 23 Jun, 2022 1 commit
  15. 21 Jun, 2022 1 commit
    • Sean Kim's avatar
      Create musdb handler and tests (#2484) · b92a8a09
      Sean Kim authored 
      Summary:
Create dataset handler and tests for new dataset. Manually tested and unit tested to test validity. Pre-commit ran for style checks.

Pull Request resolved: https://github.com/pytorch/audio/pull/2484

Reviewed By: carolineechen, nateanl

Differential Revision: D37250556

Pulled By: skim0514

fbshipit-source-id: d2c8d73d22fd9d7282026265676f3eab1e178d51
      b92a8a09
  17. 20 Jun, 2022 1 commit
  19. 17 Jun, 2022 1 commit
  21. 16 Jun, 2022 1 commit
  23. 15 Jun, 2022 7 commits
  25. 14 Jun, 2022 2 commits
  27. 13 Jun, 2022 2 commits
  29. 10 Jun, 2022 2 commits
  31. 08 Jun, 2022 5 commits
  33. 07 Jun, 2022 4 commits