cache_test.go 12.9 KB
Newer Older
Jesse Gross's avatar
Jesse Gross committed
1
package ollamarunner
2
3

import (
4
5
	"errors"
	"fmt"
6
7
	"testing"
	"time"
8

9
	"github.com/ollama/ollama/ml"
10
	"github.com/ollama/ollama/model/input"
11
12
13
14
15
)

func TestCountCommon(t *testing.T) {
	tests := []struct {
		name     string
16
17
		t1       []*input.Input
		t2       []*input.Input
Jesse Gross's avatar
Jesse Gross committed
18
		expected int32
19
20
21
	}{
		{
			name:     "Equal",
22
23
			t1:       []*input.Input{{Token: 1}, {Token: 2}, {Token: 3}},
			t2:       []*input.Input{{Token: 1}, {Token: 2}, {Token: 3}},
24
25
26
27
			expected: 3,
		},
		{
			name:     "Prefix",
28
29
			t1:       []*input.Input{{Token: 1}},
			t2:       []*input.Input{{Token: 1}, {Token: 2}, {Token: 3}},
30
31
32
			expected: 1,
		},
		{
Jesse Gross's avatar
Jesse Gross committed
33
			name:     "Image Prefix",
34
35
			t1:       []*input.Input{{MultimodalHash: 1}},
			t2:       []*input.Input{{MultimodalHash: 1}, {MultimodalHash: 2}, {MultimodalHash: 3}},
36
37
38
39
			expected: 1,
		},
		{
			name:     "Mixed",
40
41
			t1:       []*input.Input{{Token: 1}, {MultimodalHash: 1}},
			t2:       []*input.Input{{Token: 1}, {MultimodalHash: 1}, {Token: 5}},
42
43
			expected: 2,
		},
44
45
		{
			name:     "Mixed, Same Length",
46
47
			t1:       []*input.Input{{Token: 1}, {MultimodalHash: 1}},
			t2:       []*input.Input{{Token: 1}, {MultimodalHash: 2}},
48
49
			expected: 1,
		},
50
51
		{
			name:     "Empty",
52
53
			t1:       []*input.Input{},
			t2:       []*input.Input{{Token: 1}, {Token: 2}, {Token: 3}},
54
55
56
57
			expected: 0,
		},
		{
			name:     "Both Empty",
58
59
			t1:       []*input.Input{},
			t2:       []*input.Input{},
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
			expected: 0,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			result := countCommonPrefix(tt.t1, tt.t2)
			if result != tt.expected {
				t.Errorf("countCommonPrefix(%v, %v): have %v; want %v", tt.t1, tt.t2, result, tt.expected)
			}
		})
	}
}

func TestFindCacheSlot(t *testing.T) {
	type expected struct {
		result int
Jesse Gross's avatar
Jesse Gross committed
77
		len    int32
78
79
80
81
82
	}

	tests := []struct {
		name    string
		cache   InputCache
83
		prompt  []*input.Input
84
85
86
87
88
89
90
91
		longest expected
		best    expected
	}{
		{
			name: "Empty",
			cache: InputCache{slots: []InputCacheSlot{
				{
					Id:       0,
92
					Inputs:   []*input.Input{},
93
94
95
96
97
					InUse:    false,
					lastUsed: time.Time{},
				},
				{
					Id:       1,
98
					Inputs:   []*input.Input{},
99
100
101
102
					InUse:    false,
					lastUsed: time.Time{},
				},
			}},
103
			prompt:  []*input.Input{{Token: 1}},
104
105
106
107
108
109
110
111
			longest: expected{result: 0, len: 0},
			best:    expected{result: 0, len: 0},
		},
		{
			name: "Extend",
			cache: InputCache{slots: []InputCacheSlot{
				{
					Id:       0,
112
					Inputs:   []*input.Input{{Token: 1}},
113
114
115
116
117
					InUse:    false,
					lastUsed: time.Now().Add(-time.Second),
				},
				{
					Id:       1,
118
					Inputs:   []*input.Input{{Token: 1}, {Token: 2}},
119
120
121
122
					InUse:    false,
					lastUsed: time.Now().Add(-2 * time.Second),
				},
			}},
123
			prompt:  []*input.Input{{Token: 1}, {Token: 2}},
124
125
126
127
128
129
130
131
			longest: expected{result: 1, len: 2},
			best:    expected{result: 1, len: 2},
		},
		{
			name: "New",
			cache: InputCache{slots: []InputCacheSlot{
				{
					Id:       0,
132
					Inputs:   []*input.Input{{Token: 1}, {Token: 2}},
133
134
135
136
137
					InUse:    false,
					lastUsed: time.Now().Add(-time.Second),
				},
				{
					Id:       1,
138
					Inputs:   []*input.Input{},
139
140
141
142
					InUse:    false,
					lastUsed: time.Time{},
				},
			}},
143
			prompt:  []*input.Input{{Token: 2}},
144
145
146
147
148
149
150
151
152
			longest: expected{result: 0, len: 0},
			best:    expected{result: 1, len: 0},
		},
		{
			name: "Fork",
			cache: InputCache{
				slots: []InputCacheSlot{
					{
						Id:       0,
153
						Inputs:   []*input.Input{{Token: 1}, {Token: 2}},
154
155
156
157
158
						InUse:    false,
						lastUsed: time.Now().Add(-time.Second),
					},
					{
						Id:       1,
159
						Inputs:   []*input.Input{},
160
161
162
163
164
						InUse:    false,
						lastUsed: time.Time{},
					},
				},
			},
165
			prompt:  []*input.Input{{Token: 1}},
166
167
168
169
170
171
172
173
			longest: expected{result: 0, len: 1},
			best:    expected{result: 1, len: 1},
		},
		{
			name: "Evict",
			cache: InputCache{slots: []InputCacheSlot{
				{
					Id:       0,
174
					Inputs:   []*input.Input{{Token: 1}},
175
176
177
178
179
					InUse:    false,
					lastUsed: time.Now().Add(-time.Second),
				},
				{
					Id:       1,
180
					Inputs:   []*input.Input{{Token: 1}, {Token: 2}},
181
182
183
184
					InUse:    false,
					lastUsed: time.Now().Add(-2 * time.Second),
				},
			}},
185
			prompt:  []*input.Input{{Token: 2}, {Token: 3}},
186
187
188
189
190
191
192
193
			longest: expected{result: 0, len: 0},
			best:    expected{result: 1, len: 0},
		},
		{
			name: "In use",
			cache: InputCache{slots: []InputCacheSlot{
				{
					Id:       0,
194
					Inputs:   []*input.Input{{Token: 1}, {Token: 2}},
195
196
197
198
199
					InUse:    true,
					lastUsed: time.Now().Add(-time.Second),
				},
				{
					Id:       1,
200
					Inputs:   []*input.Input{{Token: 1}},
201
202
203
204
					InUse:    false,
					lastUsed: time.Now().Add(-2 * time.Second),
				},
			}},
205
			prompt:  []*input.Input{{Token: 1}, {Token: 2}},
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
			longest: expected{result: 1, len: 1},
			best:    expected{result: 1, len: 2},
		},
	}

	for _, tt := range tests {
		t.Run("Longest-"+tt.name, func(t *testing.T) {
			result, resultLen, err := tt.cache.findLongestCacheSlot(tt.prompt)
			if err != nil {
				t.Errorf("findLongestCacheSlot: err %v", err)
			} else if result.Id != tt.longest.result || resultLen != tt.longest.len {
				t.Errorf("findLongestCacheSlot: slot have %v, want %v len have %v, want %v",
					result.Id, tt.longest.result, resultLen, tt.longest.len)
			}
		})
	}

	for _, tt := range tests {
		t.Run("Best-"+tt.name, func(t *testing.T) {
			result, resultLen, err := tt.cache.findBestCacheSlot(tt.prompt)
			if err != nil {
				t.Errorf("findBestCacheSlot: err %v", err)
			} else if result.Id != tt.best.result || resultLen != tt.best.len {
				t.Errorf("findBestCacheSlot: slot have %v, want %v len have %v, want %v",
					result.Id, tt.best.result, resultLen, tt.best.len)
			}
		})
	}
}
235
236
237
238

func TestShiftDiscard(t *testing.T) {
	tests := []struct {
		name     string
Jesse Gross's avatar
Jesse Gross committed
239
240
241
242
		numCtx   int32
		numKeep  int32
		inputLen int32
		expected int32
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
	}{
		{
			name:     "Shift",
			numCtx:   2048,
			numKeep:  5,
			inputLen: 2048,
			expected: 1021,
		},
		{
			name:     "Max Keep",
			numCtx:   2048,
			numKeep:  2047,
			inputLen: 2048,
			expected: 1,
		},
		{
			name:     "No Keep",
			numCtx:   2048,
			numKeep:  0,
			inputLen: 2048,
			expected: 1024,
		},
		{
			name:     "Truncate",
			numCtx:   2048,
			numKeep:  5,
			inputLen: 5000,
			expected: 3973,
		},
		{
			name:     "Truncate Keep",
			numCtx:   2048,
			numKeep:  2047,
			inputLen: 5000,
			expected: 2953,
		},
		{
			name:     "No Op",
			numCtx:   2048,
			numKeep:  5,
			inputLen: 512,
			expected: 0,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			c := InputCache{numCtx: tt.numCtx}
			result := c.ShiftDiscard(tt.inputLen, tt.numKeep)
			if result != tt.expected {
				t.Errorf("shiftDiscard(ctx: %v, keep: %v input: %v): have %v; want %v", tt.numCtx, tt.numKeep, tt.inputLen, result, tt.expected)
			}
		})
	}
}
298
299
300
301
302

func TestLoadCacheSlot(t *testing.T) {
	tests := []struct {
		name           string
		cache          InputCache
303
		prompt         []*input.Input
304
305
306
307
308
309
310
311
312
313
314
		wantErr        bool
		expectedSlotId int
		expectedPrompt int // expected length of remaining prompt
	}{
		{
			name: "Basic cache hit - single user",
			cache: InputCache{
				multiUserCache: false,
				slots: []InputCacheSlot{
					{
						Id:       0,
315
						Inputs:   []*input.Input{{Token: 1}, {Token: 2}},
316
317
318
319
320
						InUse:    false,
						lastUsed: time.Now().Add(-time.Second),
					},
					{
						Id:       1,
321
						Inputs:   []*input.Input{},
322
323
324
325
326
						InUse:    false,
						lastUsed: time.Now().Add(-2 * time.Second),
					},
				},
			},
327
			prompt:         []*input.Input{{Token: 1}, {Token: 2}, {Token: 3}},
328
329
330
331
332
333
334
335
336
337
338
			wantErr:        false,
			expectedSlotId: 0,
			expectedPrompt: 1, // Only token 3 remains
		},
		{
			name: "Basic cache hit - multi user",
			cache: InputCache{
				multiUserCache: true,
				slots: []InputCacheSlot{
					{
						Id:       0,
339
						Inputs:   []*input.Input{{Token: 1}, {Token: 2}},
340
341
342
343
344
						InUse:    false,
						lastUsed: time.Now().Add(-time.Second),
					},
					{
						Id:       1,
345
						Inputs:   []*input.Input{},
346
347
348
349
350
						InUse:    false,
						lastUsed: time.Now().Add(-2 * time.Second),
					},
				},
			},
351
			prompt:         []*input.Input{{Token: 1}, {Token: 2}, {Token: 3}},
352
353
354
355
356
357
358
359
360
361
362
			wantErr:        false,
			expectedSlotId: 0,
			expectedPrompt: 1, // Only token 3 remains
		},
		{
			name: "Exact match - leave one input",
			cache: InputCache{
				multiUserCache: false,
				slots: []InputCacheSlot{
					{
						Id:       0,
363
						Inputs:   []*input.Input{{Token: 1}, {Token: 2}},
364
365
366
367
368
						InUse:    false,
						lastUsed: time.Now().Add(-time.Second),
					},
				},
			},
369
			prompt:         []*input.Input{{Token: 1}, {Token: 2}},
370
371
372
373
374
375
376
377
378
379
380
			wantErr:        false,
			expectedSlotId: 0,
			expectedPrompt: 1, // Should leave 1 token for sampling
		},
		{
			name: "No available slots",
			cache: InputCache{
				multiUserCache: false,
				slots: []InputCacheSlot{
					{
						Id:       0,
381
						Inputs:   []*input.Input{{Token: 1}, {Token: 2}},
382
383
384
385
386
						InUse:    true,
						lastUsed: time.Now().Add(-time.Second),
					},
				},
			},
387
			prompt:         []*input.Input{{Token: 1}, {Token: 2}, {Token: 3}},
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
			wantErr:        true,
			expectedSlotId: -1,
			expectedPrompt: -1,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			slot, remainingPrompt, err := tt.cache.LoadCacheSlot(tt.prompt)

			// Check error state
			if (err != nil) != tt.wantErr {
				t.Errorf("LoadCacheSlot() error = %v, wantErr %v", err, tt.wantErr)
				return
			}

			if tt.wantErr {
				return // Skip further checks if we expected an error
			}

			// Verify slot ID
			if slot.Id != tt.expectedSlotId {
				t.Errorf("LoadCacheSlot() slot ID = %v, expected %v", slot.Id, tt.expectedSlotId)
			}

			// Verify slot is now marked in use
			if !slot.InUse {
				t.Errorf("LoadCacheSlot() slot not marked InUse")
			}

			// Verify remaining prompt length
			if len(remainingPrompt) != tt.expectedPrompt {
				t.Errorf("LoadCacheSlot() remaining prompt length = %v, expected %v",
					len(remainingPrompt), tt.expectedPrompt)
			}
		})
	}
}
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445

// Mock implementation of the Cache interface
type mockCache struct {
	shouldFail bool
}

// Implement only the methods needed for the test
func (m *mockCache) Remove(seq int, beginIndex, endIndex int32) error {
	if m.shouldFail {
		return fmt.Errorf("mock cache removal error")
	}
	return nil
}

// Stub implementations for other interface methods
func (m *mockCache) SetLayer(layer int)                                                            {}
func (m *mockCache) Get(ctx ml.Context) (ml.Tensor, ml.Tensor, ml.Tensor)                          { return nil, nil, nil }
func (m *mockCache) Put(ctx ml.Context, key, value ml.Tensor)                                      {}
func (m *mockCache) Init(backend ml.Backend, dtype ml.DType, maxSequences, capacity, maxBatch int) {}
func (m *mockCache) Close()                                                                        {}
446
func (m *mockCache) StartForward(ctx ml.Context, batch input.Batch, reserve bool) error            { return nil }
447
448
func (m *mockCache) CopyPrefix(srcSeq, dstSeq int, len int32)                                      {}
func (m *mockCache) SetConfig(ml.CacheConfig)                                                      {}
449
func (m *mockCache) CanResume(seq int, pos int32) bool                                             { return true }
450
451
452
453
454

func TestShiftCacheSlot(t *testing.T) {
	tests := []struct {
		name          string
		numCtx        int32
455
		inputs        []*input.Input
456
457
458
459
460
461
462
463
		numKeep       int32
		cacheErr      bool
		wantErr       any
		wantInputsLen int
	}{
		{
			name:          "Normal shift",
			numCtx:        10,
464
			inputs:        []*input.Input{{Token: 1}, {Token: 2}, {Token: 3}, {Token: 4}, {Token: 5}, {Token: 6}, {Token: 7}, {Token: 8}, {Token: 9}, {Token: 10}},
465
466
467
468
469
470
471
472
			numKeep:       2,
			cacheErr:      false, // No error
			wantErr:       nil,
			wantInputsLen: 6, // After discarding 4 tokens
		},
		{
			name:          "Cache removal fails",
			numCtx:        10,
473
			inputs:        []*input.Input{{Token: 1}, {Token: 2}, {Token: 3}, {Token: 4}, {Token: 5}, {Token: 6}, {Token: 7}, {Token: 8}, {Token: 9}, {Token: 10}},
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
			numKeep:       2,
			cacheErr:      true,
			wantErr:       &ErrReprocessInputs{},
			wantInputsLen: 0, // Original inputs should be cleared
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			mock := &mockCache{shouldFail: tt.cacheErr}
			c := InputCache{
				numCtx: tt.numCtx,
				cache:  mock,
			}
			slot := &InputCacheSlot{
				Id:     123,
490
				Inputs: make([]*input.Input, len(tt.inputs)),
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
			}
			copy(slot.Inputs, tt.inputs)

			err := c.ShiftCacheSlot(slot, tt.numKeep)

			if tt.wantErr != nil {
				if err == nil {
					t.Errorf("Expected error but got nil")
					return
				}

				if !errors.As(err, &tt.wantErr) {
					t.Errorf("Expected error of type %T but got %T: %v", tt.wantErr, err, err)
				}
			} else if err != nil {
				t.Errorf("Unexpected error: %v", err)
			}

			if len(slot.Inputs) != tt.wantInputsLen {
				t.Errorf("Slot inputs length after operation: got %v, want %v", len(slot.Inputs), tt.wantInputsLen)
			}
		})
	}
}