Unverified Commit e432ae4a authored by Tushar Sharma's avatar Tushar Sharma Committed by GitHub
Browse files

build: default to using dev instead of local-dev for vllm build (#2834)


Signed-off-by: default avatarTushar Sharma <tusharma@nvidia.com>
parent 5c197b39
......@@ -91,11 +91,10 @@ Follow these steps to get your NVIDIA Dynamo development environment up and runn
### Step 1: Build the Development Container Image
Build `dynamo:latest-vllm-local-dev` from scratch from the source:
- Note that currently, `local-dev` is only implemented for `--framework VLLM`.
Build `dynamo:latest-vllm` from scratch from the source:
```bash
./container/build.sh --target local-dev --framework VLLM
./container/build.sh --target dev --framework VLLM
```
The container will be built and give certain file permissions to your local uid and gid.
......
......@@ -7,7 +7,7 @@
"name": "NVIDIA Dynamo Dev Container Development",
"remoteUser": "ubuntu", // Matches our container user
"updateRemoteUserUID": true, // Updates the UID of the remote user to match the host user, avoids permission errors
"image": "dynamo:latest-vllm-local-dev", // Use the latest VLLM local dev image
"image": "dynamo:latest-vllm", // Use the latest VLLM local dev image
"runArgs": [
"--gpus=all",
"--network=host",
......
......@@ -294,7 +294,7 @@ CMD []
# Use this stage when you need a full development environment with additional
# tooling beyond the base runtime image.
FROM runtime AS local-dev
FROM runtime AS dev
# Install utilities
RUN apt-get update -y && \
......
......@@ -465,7 +465,7 @@ fi
# Add NIXL_REF as a build argument
BUILD_ARGS+=" --build-arg NIXL_REF=${NIXL_REF} "
if [[ $TARGET == "local-dev" ]]; then
if [[ $TARGET == "dev" ]]; then
BUILD_ARGS+=" --build-arg USER_UID=$(id -u) --build-arg USER_GID=$(id -g) "
fi
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment