Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
e432ae4a
Unverified
Commit
e432ae4a
authored
Sep 03, 2025
by
Tushar Sharma
Committed by
GitHub
Sep 03, 2025
Browse files
build: default to using dev instead of local-dev for vllm build (#2834)
Signed-off-by:
Tushar Sharma
<
tusharma@nvidia.com
>
parent
5c197b39
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
6 deletions
+5
-6
.devcontainer/README.md
.devcontainer/README.md
+2
-3
.devcontainer/devcontainer.json
.devcontainer/devcontainer.json
+1
-1
container/Dockerfile.vllm
container/Dockerfile.vllm
+1
-1
container/build.sh
container/build.sh
+1
-1
No files found.
.devcontainer/README.md
View file @
e432ae4a
...
@@ -91,11 +91,10 @@ Follow these steps to get your NVIDIA Dynamo development environment up and runn
...
@@ -91,11 +91,10 @@ Follow these steps to get your NVIDIA Dynamo development environment up and runn
### Step 1: Build the Development Container Image
### Step 1: Build the Development Container Image
Build
`dynamo:latest-vllm-local-dev`
from scratch from the source:
Build
`dynamo:latest-vllm`
from scratch from the source:
-
Note that currently,
`local-dev`
is only implemented for
`--framework VLLM`
.
```
bash
```
bash
./container/build.sh
--target
local-
dev
--framework
VLLM
./container/build.sh
--target
dev
--framework
VLLM
```
```
The container will be built and give certain file permissions to your local uid and gid.
The container will be built and give certain file permissions to your local uid and gid.
...
...
.devcontainer/devcontainer.json
View file @
e432ae4a
...
@@ -7,7 +7,7 @@
...
@@ -7,7 +7,7 @@
"name"
:
"NVIDIA Dynamo Dev Container Development"
,
"name"
:
"NVIDIA Dynamo Dev Container Development"
,
"remoteUser"
:
"ubuntu"
,
//
Matches
our
container
user
"remoteUser"
:
"ubuntu"
,
//
Matches
our
container
user
"updateRemoteUserUID"
:
true
,
//
Updates
the
UID
of
the
remote
user
to
match
the
host
user
,
avoids
permission
errors
"updateRemoteUserUID"
:
true
,
//
Updates
the
UID
of
the
remote
user
to
match
the
host
user
,
avoids
permission
errors
"image"
:
"dynamo:latest-vllm
-local-dev
"
,
//
Use
the
latest
VLLM
local
dev
image
"image"
:
"dynamo:latest-vllm"
,
//
Use
the
latest
VLLM
local
dev
image
"runArgs"
:
[
"runArgs"
:
[
"--gpus=all"
,
"--gpus=all"
,
"--network=host"
,
"--network=host"
,
...
...
container/Dockerfile.vllm
View file @
e432ae4a
...
@@ -294,7 +294,7 @@ CMD []
...
@@ -294,7 +294,7 @@ CMD []
# Use this stage when you need a full development environment with additional
# Use this stage when you need a full development environment with additional
# tooling beyond the base runtime image.
# tooling beyond the base runtime image.
FROM runtime AS
local-
dev
FROM runtime AS dev
# Install utilities
# Install utilities
RUN apt-get update -y && \
RUN apt-get update -y && \
...
...
container/build.sh
View file @
e432ae4a
...
@@ -465,7 +465,7 @@ fi
...
@@ -465,7 +465,7 @@ fi
# Add NIXL_REF as a build argument
# Add NIXL_REF as a build argument
BUILD_ARGS+
=
" --build-arg NIXL_REF=
${
NIXL_REF
}
"
BUILD_ARGS+
=
" --build-arg NIXL_REF=
${
NIXL_REF
}
"
if
[[
$TARGET
==
"
local-
dev"
]]
;
then
if
[[
$TARGET
==
"dev"
]]
;
then
BUILD_ARGS+
=
" --build-arg USER_UID=
$(
id
-u
)
--build-arg USER_GID=
$(
id
-g
)
"
BUILD_ARGS+
=
" --build-arg USER_UID=
$(
id
-u
)
--build-arg USER_GID=
$(
id
-g
)
"
fi
fi
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment