"vscode:/vscode.git/clone" did not exist on "d6195a748b3d68d3e81a4f09513ece4e04f5c571"
watcher.rs 18.5 KB
Newer Older
Ryan Olson's avatar
Ryan Olson committed
1
2
3
// SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

Ryan Olson's avatar
Ryan Olson committed
4
use std::sync::Arc;
5
use tokio::sync::mpsc::Sender;
6

7
use anyhow::Context as _;
8
use tokio::sync::{Notify, mpsc::Receiver};
Ryan Olson's avatar
Ryan Olson committed
9

Neelay Shah's avatar
Neelay Shah committed
10
use dynamo_runtime::{
11
    DistributedRuntime,
12
    pipeline::{
13
14
        ManyOut, Operator, RouterMode, SegmentSource, ServiceBackend, SingleIn, Source,
        network::egress::push_router::PushRouter,
15
    },
16
17
    protocols::annotated::Annotated,
    transports::etcd::{KeyValue, WatchEvent},
18
};
Ryan Olson's avatar
Ryan Olson committed
19

20
21
use crate::{
    backend::Backend,
22
23
    entrypoint,
    kv_router::KvRouterConfig,
24
    model_card::ModelDeploymentCard,
25
26
    model_type::{ModelInput, ModelType},
    preprocessor::{OpenAIPreprocessor, PreprocessedEmbeddingRequest, prompt::PromptFormatter},
27
28
29
30
31
32
33
34
35
    protocols::{
        common::llm_backend::EmbeddingsEngineOutput,
        openai::{
            chat_completions::{
                NvCreateChatCompletionRequest, NvCreateChatCompletionStreamResponse,
            },
            completions::{NvCreateCompletionRequest, NvCreateCompletionResponse},
            embeddings::{NvCreateEmbeddingRequest, NvCreateEmbeddingResponse},
        },
36
37
    },
};
38

39
use super::{MODEL_ROOT_PATH, ModelEntry, ModelManager};
40
use crate::namespace::is_global_namespace;
41

42
43
44
45
46
47
#[derive(Debug, Clone, Copy, PartialEq)]
pub enum ModelUpdate {
    Added(ModelType),
    Removed(ModelType),
}

48
pub struct ModelWatcher {
49
    manager: Arc<ModelManager>,
50
    drt: DistributedRuntime,
51
    router_mode: RouterMode,
52
    notify_on_model: Notify,
53
    model_update_tx: Option<Sender<ModelUpdate>>,
54
    kv_router_config: Option<KvRouterConfig>,
55
    busy_threshold: Option<f64>,
Ryan Olson's avatar
Ryan Olson committed
56
57
}

58
59
60
61
62
const ALL_MODEL_TYPES: &[ModelType] = &[
    ModelType::Chat,
    ModelType::Completions,
    ModelType::Embedding,
];
63

64
impl ModelWatcher {
65
    pub fn new(
66
        runtime: DistributedRuntime,
67
        model_manager: Arc<ModelManager>,
68
        router_mode: RouterMode,
69
        kv_router_config: Option<KvRouterConfig>,
70
        busy_threshold: Option<f64>,
71
72
    ) -> ModelWatcher {
        Self {
73
            manager: model_manager,
74
            drt: runtime,
75
            router_mode,
76
            notify_on_model: Notify::new(),
77
            model_update_tx: None,
78
            kv_router_config,
79
            busy_threshold,
80
        }
81
    }
Ryan Olson's avatar
Ryan Olson committed
82

83
84
85
86
    pub fn set_notify_on_model_update(&mut self, tx: Sender<ModelUpdate>) {
        self.model_update_tx = Some(tx);
    }

87
88
89
90
91
92
93
94
95
96
97
    /// Wait until we have at least one chat completions model and return it's name.
    pub async fn wait_for_chat_model(&self) -> String {
        // Loop in case it gets added and immediately deleted
        loop {
            if let Some(model_name) = self.manager.list_chat_completions_models().first() {
                return model_name.to_owned();
            }
            self.notify_on_model.notified().await
        }
    }

98
99
100
    /// Common watch logic with optional namespace filtering
    pub async fn watch(&self, mut events_rx: Receiver<WatchEvent>, target_namespace: Option<&str>) {
        let global_namespace = target_namespace.is_none_or(is_global_namespace);
101
102
103
104
105
106
107

        while let Some(event) = events_rx.recv().await {
            match event {
                WatchEvent::Put(kv) => {
                    let model_entry = match serde_json::from_slice::<ModelEntry>(kv.value()) {
                        Ok(model_entry) => model_entry,
                        Err(err) => {
108
109
110
111
112
113
114
115
                            match kv.value_str() {
                                Ok(value) => {
                                    tracing::error!(%err, value, "Invalid JSON in model entry")
                                }
                                Err(value_str_err) => {
                                    tracing::error!(original_error = %err, %value_str_err, "Invalid UTF-8 string in model entry, expected JSON")
                                }
                            }
116
117
118
                            continue;
                        }
                    };
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133

                    // Filter by namespace if target_namespace is specified
                    if !global_namespace
                        && let Some(target_ns) = target_namespace
                        && model_entry.endpoint_id.namespace != target_ns
                    {
                        tracing::debug!(
                            model_namespace = model_entry.endpoint_id.namespace,
                            target_namespace = target_ns,
                            model_name = model_entry.name,
                            "Skipping model from different namespace"
                        );
                        continue;
                    }

134
135
136
137
138
139
140
141
142
                    let key = match kv.key_str() {
                        Ok(k) => k,
                        Err(err) => {
                            tracing::error!(%err, ?kv, "Invalid UTF-8 string in model entry key, skipping");
                            continue;
                        }
                    };
                    self.manager.save_model_entry(key, model_entry.clone());

143
144
145
146
147
148
                    if let Some(tx) = &self.model_update_tx {
                        tx.send(ModelUpdate::Added(model_entry.model_type))
                            .await
                            .ok();
                    }

149
                    if self.manager.has_model_any(&model_entry.name) {
150
151
152
153
154
                        tracing::trace!(
                            name = model_entry.name,
                            namespace = model_entry.endpoint_id.namespace,
                            "New endpoint for existing model"
                        );
155
                        self.notify_on_model.notify_waiters();
156
157
158
                        continue;
                    }

159
                    match self.handle_put(&model_entry).await {
160
                        Ok(()) => {
161
162
163
164
165
                            tracing::info!(
                                model_name = model_entry.name,
                                namespace = model_entry.endpoint_id.namespace,
                                "added model"
                            );
166
                            self.notify_on_model.notify_waiters();
167
                        }
168
169
170
                        Err(err) => {
                            tracing::error!(
                                error = format!("{err:#}"),
171
172
173
                                "error adding model {} from namespace {}",
                                model_entry.name,
                                model_entry.endpoint_id.namespace,
174
                            );
175
176
177
                        }
                    }
                }
178
179
                WatchEvent::Delete(kv) => match self.handle_delete(&kv).await {
                    Ok(Some(model_name)) => {
180
                        tracing::info!(model_name, "removed model");
181
                    }
182
183
184
                    Ok(None) => {
                        // There are other instances running this model, nothing to do
                    }
185
                    Err(e) => {
186
                        tracing::error!(error = %e, "error removing model");
187
                    }
188
                },
189
            }
Ryan Olson's avatar
Ryan Olson committed
190
191
192
        }
    }

193
194
195
    /// If the last instance running this model has gone delete it.
    /// Returns the name of the model we just deleted, if any.
    async fn handle_delete(&self, kv: &KeyValue) -> anyhow::Result<Option<String>> {
196
        let key = kv.key_str()?;
197
        let model_entry = match self.manager.remove_model_entry(key) {
198
199
200
201
202
            Some(entry) => entry,
            None => {
                anyhow::bail!("Missing ModelEntry for {key}");
            }
        };
203
204
205
206
207
208
209
210
        let model_name = model_entry.name;
        let active_instances = self
            .entries_for_model(&model_name)
            .await
            .with_context(|| model_name.clone())?;
        if !active_instances.is_empty() {
            return Ok(None);
        }
211

212
        // Ignore the errors because model could be either type
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
        let chat_model_remove_err = self.manager.remove_chat_completions_model(&model_name);
        let completions_model_remove_err = self.manager.remove_completions_model(&model_name);
        let embeddings_model_remove_err = self.manager.remove_embeddings_model(&model_name);

        let mut chat_model_removed = false;
        let mut completions_model_removed = false;
        let mut embeddings_model_removed = false;

        if chat_model_remove_err.is_ok() && self.manager.list_chat_completions_models().is_empty() {
            chat_model_removed = true;
        }
        if completions_model_remove_err.is_ok() && self.manager.list_completions_models().is_empty()
        {
            completions_model_removed = true;
        }
        if embeddings_model_remove_err.is_ok() && self.manager.list_embeddings_models().is_empty() {
            embeddings_model_removed = true;
        }

        if !chat_model_removed && !completions_model_removed && !embeddings_model_removed {
            tracing::debug!(
                "No updates to send for model {}: chat_model_removed: {}, completions_model_removed: {}, embeddings_model_removed: {}",
                model_name,
                chat_model_removed,
                completions_model_removed,
                embeddings_model_removed
            );
        } else {
            for model_type in ALL_MODEL_TYPES {
242
                if ((chat_model_removed && *model_type == ModelType::Chat)
243
                    || (completions_model_removed && *model_type == ModelType::Completions)
244
245
                    || (embeddings_model_removed && *model_type == ModelType::Embedding))
                    && let Some(tx) = &self.model_update_tx
246
                {
247
                    tx.send(ModelUpdate::Removed(*model_type)).await.ok();
248
249
250
                }
            }
        }
251

252
        Ok(Some(model_name))
253
    }
Ryan Olson's avatar
Ryan Olson committed
254

255
256
    // Handles a PUT event from etcd, this usually means adding a new model to the list of served
    // models.
257
    async fn handle_put(&self, model_entry: &ModelEntry) -> anyhow::Result<()> {
258
        let endpoint_id = &model_entry.endpoint_id;
259
        let component = self
260
261
            .drt
            .namespace(&endpoint_id.namespace)?
262
            .component(&endpoint_id.component)?;
263
        let client = component.endpoint(&endpoint_id.name).client().await?;
264
265
        let model_slug = model_entry.slug();
        let card = match ModelDeploymentCard::load_from_store(&model_slug, &self.drt).await {
266
267
268
269
270
271
272
273
            Ok(Some(mut card)) => {
                tracing::debug!(card.display_name, "adding model");
                // Ensure runtime_config is populated
                if let Some(rc) = model_entry.runtime_config.clone() {
                    card.runtime_config = rc;
                }
                card
            }
274
275
            Ok(None) => {
                anyhow::bail!("Missing ModelDeploymentCard in storage under key {model_slug}");
276
277
            }
            Err(err) => {
278
279
280
                anyhow::bail!(
                    "Error fetching ModelDeploymentCard from storage under key {model_slug}. {err}"
                );
281
282
            }
        };
283

284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
        if model_entry.model_input == ModelInput::Tokens
            && (model_entry.model_type.supports_chat()
                || model_entry.model_type.supports_completions())
        {
            // Case 1: Tokens + (Chat OR Completions OR Both)
            // A model that expects pre-processed requests meaning it's up to us whether we
            // handle Chat or Completions requests, so handle whatever the model supports.

            let kv_chooser = if self.router_mode == RouterMode::KV {
                Some(
                    self.manager
                        .kv_chooser_for(
                            &model_entry.name,
                            &component,
                            card.kv_cache_block_size,
                            self.kv_router_config,
                        )
                        .await?,
                )
            } else {
                None
            };
306

307
            // This is expensive, we are loading ~10MiB JSON, so only do it once
308
            let tokenizer_hf = card.tokenizer_hf().context("tokenizer_hf")?;
309

310
311
            // Add chat engine only if the model supports chat
            if model_entry.model_type.supports_chat() {
312
313
314
315
316
317
318
319
320
                let chat_engine = entrypoint::build_routed_pipeline::<
                    NvCreateChatCompletionRequest,
                    NvCreateChatCompletionStreamResponse,
                >(
                    &card,
                    &client,
                    self.router_mode,
                    self.busy_threshold,
                    kv_chooser.clone(),
321
                    tokenizer_hf.clone(),
322
                )
323
324
                .await
                .context("build_routed_pipeline")?;
325
                self.manager
326
327
                    .add_chat_completions_model(&model_entry.name, chat_engine)
                    .context("add_chat_completions_model")?;
328
                tracing::info!("Chat completions is ready");
329
            }
330

331
332
333
334
            // Add completions engine only if the model supports completions
            if model_entry.model_type.supports_completions() {
                let formatter = PromptFormatter::no_op();
                let PromptFormatter::OAI(formatter) = formatter;
335
336
337
338
                let preprocessor = OpenAIPreprocessor::new_with_parts(
                    card.clone(),
                    formatter,
                    tokenizer_hf.clone(),
339
340
                )
                .context("OpenAIPreprocessor::new_with_parts")?;
341
                let completions_engine = entrypoint::build_routed_pipeline_with_preprocessor::<
342
343
344
345
346
347
348
349
                    NvCreateCompletionRequest,
                    NvCreateCompletionResponse,
                >(
                    &card,
                    &client,
                    self.router_mode,
                    self.busy_threshold,
                    kv_chooser,
350
                    preprocessor,
351
                    tokenizer_hf,
352
                )
353
354
                .await
                .context("build_routed_pipeline_with_preprocessor")?;
355
                self.manager
356
357
                    .add_completions_model(&model_entry.name, completions_engine)
                    .context("add_completions_model")?;
358
                tracing::info!("Completions is ready");
359
            }
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
        } else if model_entry.model_input == ModelInput::Text
            && model_entry.model_type.supports_chat()
        {
            // Case 3: Text + Chat
            let push_router = PushRouter::<
                NvCreateChatCompletionRequest,
                Annotated<NvCreateChatCompletionStreamResponse>,
            >::from_client_with_threshold(
                client, self.router_mode, self.busy_threshold
            )
            .await?;
            let engine = Arc::new(push_router);
            self.manager
                .add_chat_completions_model(&model_entry.name, engine)?;
        } else if model_entry.model_input == ModelInput::Text
            && model_entry.model_type.supports_completions()
        {
            // Case 2: Text + Completions
            let push_router = PushRouter::<
                NvCreateCompletionRequest,
                Annotated<NvCreateCompletionResponse>,
            >::from_client_with_threshold(
                client, self.router_mode, self.busy_threshold
            )
            .await?;
            let engine = Arc::new(push_router);
            self.manager
                .add_completions_model(&model_entry.name, engine)?;
        } else if model_entry.model_input == ModelInput::Tokens
            && model_entry.model_type.supports_embedding()
        {
            // Case 4: Tokens + Embeddings

            // Create preprocessing pipeline similar to Backend
            let frontend = SegmentSource::<
                SingleIn<NvCreateEmbeddingRequest>,
                ManyOut<Annotated<NvCreateEmbeddingResponse>>,
            >::new();

399
400
            let preprocessor = OpenAIPreprocessor::new(card.clone())?.into_operator();
            let backend = Backend::from_mdc(&card).into_operator();
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431

            let router = PushRouter::<
                PreprocessedEmbeddingRequest,
                Annotated<EmbeddingsEngineOutput>,
            >::from_client_with_threshold(
                client, self.router_mode, self.busy_threshold
            )
            .await?;

            // Note: Embeddings don't need KV routing complexity
            let service_backend = ServiceBackend::from_engine(Arc::new(router));

            // Link the pipeline: frontend -> preprocessor -> backend -> service_backend -> backend -> preprocessor -> frontend
            let embedding_engine = frontend
                .link(preprocessor.forward_edge())?
                .link(backend.forward_edge())?
                .link(service_backend)?
                .link(backend.backward_edge())?
                .link(preprocessor.backward_edge())?
                .link(frontend)?;

            self.manager
                .add_embeddings_model(&model_entry.name, embedding_engine)?;
        } else {
            // Reject unsupported combinations
            anyhow::bail!(
                "Unsupported model configuration: {} with {} input. Supported combinations: \
                Tokens+(Chat|Completions), Text+Chat, Text+Completions, Tokens+Embeddings",
                model_entry.model_type,
                model_entry.model_input.as_str()
            );
432
        }
Ryan Olson's avatar
Ryan Olson committed
433

434
435
        Ok(())
    }
436

437
    /// All the registered ModelEntry, one per instance
438
    pub async fn all_entries(&self) -> anyhow::Result<Vec<ModelEntry>> {
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
        let Some(etcd_client) = self.drt.etcd_client() else {
            anyhow::bail!("all_entries: Missing etcd client");
        };
        let kvs = etcd_client.kv_get_prefix(MODEL_ROOT_PATH).await?;
        let mut entries = Vec::with_capacity(kvs.len());
        for kv in kvs {
            let model_entry = match serde_json::from_slice::<ModelEntry>(kv.value()) {
                Ok(model_entry) => model_entry,
                Err(err) => {
                    match kv.value_str() {
                        Ok(value) => {
                            tracing::error!(%err, value, "Invalid JSON in model entry")
                        }
                        Err(value_str_err) => {
                            tracing::error!(original_error = %err, %value_str_err, "Invalid UTF-8 string in model entry, expected JSON")
                        }
                    }
                    continue;
                }
            };
            entries.push(model_entry);
460
        }
461
462
463
        Ok(entries)
    }

464
    pub async fn entries_for_model(&self, model_name: &str) -> anyhow::Result<Vec<ModelEntry>> {
465
466
467
        let mut all = self.all_entries().await?;
        all.retain(|entry| entry.name == model_name);
        Ok(all)
468
    }
Ryan Olson's avatar
Ryan Olson committed
469
}