watcher.rs 17.1 KB
Newer Older
Ryan Olson's avatar
Ryan Olson committed
1
2
3
// SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

Ryan Olson's avatar
Ryan Olson committed
4
use std::sync::Arc;
5
use tokio::sync::mpsc::Sender;
6

7
use anyhow::Context as _;
8
use tokio::sync::{Notify, mpsc::Receiver};
Ryan Olson's avatar
Ryan Olson committed
9

Neelay Shah's avatar
Neelay Shah committed
10
use dynamo_runtime::{
11
    DistributedRuntime,
12
    pipeline::{
13
14
        ManyOut, Operator, RouterMode, SegmentSource, ServiceBackend, SingleIn, Source,
        network::egress::push_router::PushRouter,
15
    },
16
17
    protocols::annotated::Annotated,
    transports::etcd::{KeyValue, WatchEvent},
18
};
Ryan Olson's avatar
Ryan Olson committed
19

20
21
use crate::{
    backend::Backend,
22
23
    entrypoint,
    kv_router::KvRouterConfig,
24
    model_type::ModelType,
25
26
27
28
29
30
31
32
33
34
    preprocessor::{OpenAIPreprocessor, PreprocessedEmbeddingRequest},
    protocols::{
        common::llm_backend::EmbeddingsEngineOutput,
        openai::{
            chat_completions::{
                NvCreateChatCompletionRequest, NvCreateChatCompletionStreamResponse,
            },
            completions::{NvCreateCompletionRequest, NvCreateCompletionResponse},
            embeddings::{NvCreateEmbeddingRequest, NvCreateEmbeddingResponse},
        },
35
36
    },
};
37

38
use super::{MODEL_ROOT_PATH, ModelEntry, ModelManager};
39
use crate::namespace::is_global_namespace;
40

41
42
43
44
45
46
#[derive(Debug, Clone, Copy, PartialEq)]
pub enum ModelUpdate {
    Added(ModelType),
    Removed(ModelType),
}

47
pub struct ModelWatcher {
48
    manager: Arc<ModelManager>,
49
    drt: DistributedRuntime,
50
    router_mode: RouterMode,
51
    notify_on_model: Notify,
52
    model_update_tx: Option<Sender<ModelUpdate>>,
53
    kv_router_config: Option<KvRouterConfig>,
54
    busy_threshold: Option<f64>,
Ryan Olson's avatar
Ryan Olson committed
55
56
}

57
58
59
const ALL_MODEL_TYPES: &[ModelType] =
    &[ModelType::Chat, ModelType::Completion, ModelType::Embedding];

60
impl ModelWatcher {
61
    pub fn new(
62
        runtime: DistributedRuntime,
63
        model_manager: Arc<ModelManager>,
64
        router_mode: RouterMode,
65
        kv_router_config: Option<KvRouterConfig>,
66
        busy_threshold: Option<f64>,
67
68
    ) -> ModelWatcher {
        Self {
69
            manager: model_manager,
70
            drt: runtime,
71
            router_mode,
72
            notify_on_model: Notify::new(),
73
            model_update_tx: None,
74
            kv_router_config,
75
            busy_threshold,
76
        }
77
    }
Ryan Olson's avatar
Ryan Olson committed
78

79
80
81
82
    pub fn set_notify_on_model_update(&mut self, tx: Sender<ModelUpdate>) {
        self.model_update_tx = Some(tx);
    }

83
84
85
86
87
88
89
90
91
92
93
    /// Wait until we have at least one chat completions model and return it's name.
    pub async fn wait_for_chat_model(&self) -> String {
        // Loop in case it gets added and immediately deleted
        loop {
            if let Some(model_name) = self.manager.list_chat_completions_models().first() {
                return model_name.to_owned();
            }
            self.notify_on_model.notified().await
        }
    }

94
95
96
    /// Common watch logic with optional namespace filtering
    pub async fn watch(&self, mut events_rx: Receiver<WatchEvent>, target_namespace: Option<&str>) {
        let global_namespace = target_namespace.is_none_or(is_global_namespace);
97
98
99
100
101
102
103

        while let Some(event) = events_rx.recv().await {
            match event {
                WatchEvent::Put(kv) => {
                    let model_entry = match serde_json::from_slice::<ModelEntry>(kv.value()) {
                        Ok(model_entry) => model_entry,
                        Err(err) => {
104
105
106
107
108
109
110
111
                            match kv.value_str() {
                                Ok(value) => {
                                    tracing::error!(%err, value, "Invalid JSON in model entry")
                                }
                                Err(value_str_err) => {
                                    tracing::error!(original_error = %err, %value_str_err, "Invalid UTF-8 string in model entry, expected JSON")
                                }
                            }
112
113
114
                            continue;
                        }
                    };
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129

                    // Filter by namespace if target_namespace is specified
                    if !global_namespace
                        && let Some(target_ns) = target_namespace
                        && model_entry.endpoint_id.namespace != target_ns
                    {
                        tracing::debug!(
                            model_namespace = model_entry.endpoint_id.namespace,
                            target_namespace = target_ns,
                            model_name = model_entry.name,
                            "Skipping model from different namespace"
                        );
                        continue;
                    }

130
131
132
133
134
135
136
137
138
                    let key = match kv.key_str() {
                        Ok(k) => k,
                        Err(err) => {
                            tracing::error!(%err, ?kv, "Invalid UTF-8 string in model entry key, skipping");
                            continue;
                        }
                    };
                    self.manager.save_model_entry(key, model_entry.clone());

139
140
141
142
143
144
                    if let Some(tx) = &self.model_update_tx {
                        tx.send(ModelUpdate::Added(model_entry.model_type))
                            .await
                            .ok();
                    }

145
                    if self.manager.has_model_any(&model_entry.name) {
146
147
148
149
150
                        tracing::trace!(
                            name = model_entry.name,
                            namespace = model_entry.endpoint_id.namespace,
                            "New endpoint for existing model"
                        );
151
                        self.notify_on_model.notify_waiters();
152
153
154
                        continue;
                    }

155
                    match self.handle_put(&model_entry).await {
156
                        Ok(()) => {
157
158
159
160
161
                            tracing::info!(
                                model_name = model_entry.name,
                                namespace = model_entry.endpoint_id.namespace,
                                "added model"
                            );
162
                            self.notify_on_model.notify_waiters();
163
                        }
164
165
166
                        Err(err) => {
                            tracing::error!(
                                error = format!("{err:#}"),
167
168
169
                                "error adding model {} from namespace {}",
                                model_entry.name,
                                model_entry.endpoint_id.namespace,
170
                            );
171
172
173
                        }
                    }
                }
174
175
                WatchEvent::Delete(kv) => match self.handle_delete(&kv).await {
                    Ok(Some(model_name)) => {
176
                        tracing::info!("removed model {}", model_name);
177
                    }
178
179
180
                    Ok(None) => {
                        // There are other instances running this model, nothing to do
                    }
181
                    Err(e) => {
182
                        tracing::error!("error removing model: {}", e);
183
                    }
184
                },
185
            }
Ryan Olson's avatar
Ryan Olson committed
186
187
188
        }
    }

189
190
191
    /// If the last instance running this model has gone delete it.
    /// Returns the name of the model we just deleted, if any.
    async fn handle_delete(&self, kv: &KeyValue) -> anyhow::Result<Option<String>> {
192
        let key = kv.key_str()?;
193
        let model_entry = match self.manager.remove_model_entry(key) {
194
195
196
197
198
            Some(entry) => entry,
            None => {
                anyhow::bail!("Missing ModelEntry for {key}");
            }
        };
199
200
201
202
203
204
205
206
        let model_name = model_entry.name;
        let active_instances = self
            .entries_for_model(&model_name)
            .await
            .with_context(|| model_name.clone())?;
        if !active_instances.is_empty() {
            return Ok(None);
        }
207

208
        // Ignore the errors because model could be either type
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
        let chat_model_remove_err = self.manager.remove_chat_completions_model(&model_name);
        let completions_model_remove_err = self.manager.remove_completions_model(&model_name);
        let embeddings_model_remove_err = self.manager.remove_embeddings_model(&model_name);

        let mut chat_model_removed = false;
        let mut completions_model_removed = false;
        let mut embeddings_model_removed = false;

        if chat_model_remove_err.is_ok() && self.manager.list_chat_completions_models().is_empty() {
            chat_model_removed = true;
        }
        if completions_model_remove_err.is_ok() && self.manager.list_completions_models().is_empty()
        {
            completions_model_removed = true;
        }
        if embeddings_model_remove_err.is_ok() && self.manager.list_embeddings_models().is_empty() {
            embeddings_model_removed = true;
        }

        if !chat_model_removed && !completions_model_removed && !embeddings_model_removed {
            tracing::debug!(
                "No updates to send for model {}: chat_model_removed: {}, completions_model_removed: {}, embeddings_model_removed: {}",
                model_name,
                chat_model_removed,
                completions_model_removed,
                embeddings_model_removed
            );
        } else {
            for model_type in ALL_MODEL_TYPES {
238
                if ((chat_model_removed && *model_type == ModelType::Chat)
239
                    || (completions_model_removed && *model_type == ModelType::Completion)
240
241
                    || (embeddings_model_removed && *model_type == ModelType::Embedding))
                    && let Some(tx) = &self.model_update_tx
242
                {
243
                    tx.send(ModelUpdate::Removed(*model_type)).await.ok();
244
245
246
                }
            }
        }
247

248
        Ok(Some(model_name))
249
    }
Ryan Olson's avatar
Ryan Olson committed
250

251
252
    // Handles a PUT event from etcd, this usually means adding a new model to the list of served
    // models.
253
    async fn handle_put(&self, model_entry: &ModelEntry) -> anyhow::Result<()> {
254
        let endpoint_id = &model_entry.endpoint_id;
255
        let component = self
256
257
            .drt
            .namespace(&endpoint_id.namespace)?
258
            .component(&endpoint_id.component)?;
259
        let client = component.endpoint(&endpoint_id.name).client().await?;
260

261
262
263
264
        let Some(etcd_client) = self.drt.etcd_client() else {
            // Should be impossible because we only get here on an etcd event
            anyhow::bail!("Missing etcd_client");
        };
265
        let card = match model_entry.load_mdc(&etcd_client).await {
266
267
268
269
270
271
272
273
274
            Ok(card) => {
                tracing::debug!(card.display_name, "adding model");
                Some(card)
            }
            Err(err) => {
                tracing::info!(%err, "load_mdc did not complete");
                None
            }
        };
275

276
277
278
279
280
281
282
283
284
285
286
287
288
289
        match model_entry.model_type {
            ModelType::Backend => {
                // A Backend model expects pre-processed requests meaning it's up to us whether we
                // handle Chat or Completions requests, so handle both.

                let Some(mut card) = card else {
                    anyhow::bail!("Missing model deployment card");
                };
                // Download tokenizer.json etc to local disk
                // This cache_dir is a tempfile::TempDir will be deleted on drop. I _think_
                // OpenAIPreprocessor::new loads the files, so we can delete them after this
                // function. Needs checking carefully, possibly we need to store it in state.
                let _cache_dir = Some(card.move_from_nats(self.drt.nats_client()).await?);

290
291
292
                let kv_chooser = if self.router_mode == RouterMode::KV {
                    Some(
                        self.manager
293
294
295
296
                            .kv_chooser_for(
                                &model_entry.name,
                                &component,
                                card.kv_cache_block_size,
297
                                self.kv_router_config,
298
                            )
299
300
301
302
                            .await?,
                    )
                } else {
                    None
303
                };
304

305
306
307
308
309
310
311
312
313
314
315
                let chat_engine = entrypoint::build_routed_pipeline::<
                    NvCreateChatCompletionRequest,
                    NvCreateChatCompletionStreamResponse,
                >(
                    &card,
                    &client,
                    self.router_mode,
                    self.busy_threshold,
                    kv_chooser.clone(),
                )
                .await?;
316
317
318
                self.manager
                    .add_chat_completions_model(&model_entry.name, chat_engine)?;

319
320
321
322
323
324
325
326
327
328
329
                let completions_engine = entrypoint::build_routed_pipeline::<
                    NvCreateCompletionRequest,
                    NvCreateCompletionResponse,
                >(
                    &card,
                    &client,
                    self.router_mode,
                    self.busy_threshold,
                    kv_chooser,
                )
                .await?;
330
331
332
333
334
335
336
                self.manager
                    .add_completions_model(&model_entry.name, completions_engine)?;
            }
            ModelType::Chat => {
                let push_router = PushRouter::<
                    NvCreateChatCompletionRequest,
                    Annotated<NvCreateChatCompletionStreamResponse>,
337
338
339
                >::from_client_with_threshold(
                    client, Default::default(), self.busy_threshold
                )
340
341
342
343
344
345
                .await?;
                let engine = Arc::new(push_router);
                self.manager
                    .add_chat_completions_model(&model_entry.name, engine)?;
            }
            ModelType::Completion => {
346
347
                let push_router = PushRouter::<
                    NvCreateCompletionRequest,
348
                    Annotated<NvCreateCompletionResponse>,
349
350
351
                >::from_client_with_threshold(
                    client, Default::default(), self.busy_threshold
                )
352
                .await?;
353
354
355
356
                let engine = Arc::new(push_router);
                self.manager
                    .add_completions_model(&model_entry.name, engine)?;
            }
357
            ModelType::Embedding => {
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
                let Some(mut card) = card else {
                    anyhow::bail!("Missing model deployment card for embedding model");
                };

                // Download tokenizer files to local disk
                let _cache_dir = Some(card.move_from_nats(self.drt.nats_client()).await?);

                // Create preprocessing pipeline similar to Backend
                let frontend = SegmentSource::<
                    SingleIn<NvCreateEmbeddingRequest>,
                    ManyOut<Annotated<NvCreateEmbeddingResponse>>,
                >::new();

                let preprocessor = OpenAIPreprocessor::new(card.clone()).await?.into_operator();
                let backend = Backend::from_mdc(card.clone()).await?.into_operator();

                let router = PushRouter::<
                    PreprocessedEmbeddingRequest,
                    Annotated<EmbeddingsEngineOutput>,
377
378
379
                >::from_client_with_threshold(
                    client, self.router_mode, self.busy_threshold
                )
380
                .await?;
381
382
383
384
385
386
387
388
389
390
391
392
393

                // Note: Embeddings don't need KV routing complexity
                let service_backend = ServiceBackend::from_engine(Arc::new(router));

                // Link the pipeline: frontend -> preprocessor -> backend -> service_backend -> backend -> preprocessor -> frontend
                let embedding_engine = frontend
                    .link(preprocessor.forward_edge())?
                    .link(backend.forward_edge())?
                    .link(service_backend)?
                    .link(backend.backward_edge())?
                    .link(preprocessor.backward_edge())?
                    .link(frontend)?;

394
                self.manager
395
                    .add_embeddings_model(&model_entry.name, embedding_engine)?;
396
            }
397
        }
Ryan Olson's avatar
Ryan Olson committed
398

399
400
        Ok(())
    }
401

402
    /// All the registered ModelEntry, one per instance
403
    pub async fn all_entries(&self) -> anyhow::Result<Vec<ModelEntry>> {
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
        let Some(etcd_client) = self.drt.etcd_client() else {
            anyhow::bail!("all_entries: Missing etcd client");
        };
        let kvs = etcd_client.kv_get_prefix(MODEL_ROOT_PATH).await?;
        let mut entries = Vec::with_capacity(kvs.len());
        for kv in kvs {
            let model_entry = match serde_json::from_slice::<ModelEntry>(kv.value()) {
                Ok(model_entry) => model_entry,
                Err(err) => {
                    match kv.value_str() {
                        Ok(value) => {
                            tracing::error!(%err, value, "Invalid JSON in model entry")
                        }
                        Err(value_str_err) => {
                            tracing::error!(original_error = %err, %value_str_err, "Invalid UTF-8 string in model entry, expected JSON")
                        }
                    }
                    continue;
                }
            };
            entries.push(model_entry);
425
        }
426
427
428
        Ok(entries)
    }

429
    pub async fn entries_for_model(&self, model_name: &str) -> anyhow::Result<Vec<ModelEntry>> {
430
431
432
        let mut all = self.all_entries().await?;
        all.retain(|entry| entry.name == model_name);
        Ok(all)
433
    }
Ryan Olson's avatar
Ryan Olson committed
434
}