distributed.rs 25.3 KB
Newer Older
1
2
// SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0
Ryan Olson's avatar
Ryan Olson committed
3

4
use crate::component::{Component, Instance};
5
use crate::pipeline::PipelineError;
6
use crate::pipeline::network::manager::NetworkManager;
7
use crate::service::{ServiceClient, ServiceSet};
8
use crate::storage::kv::{self, Store as _};
Ryan Olson's avatar
Ryan Olson committed
9
use crate::{
10
    component::{self, ComponentBuilder, Endpoint, Namespace},
11
    discovery::Discovery,
12
13
    metrics::PrometheusUpdateCallback,
    metrics::{MetricsHierarchy, MetricsRegistry},
Ryan Olson's avatar
Ryan Olson committed
14
15
    transports::{etcd, nats, tcp},
};
16
use crate::{discovery, system_status_server, transports};
Ryan Olson's avatar
Ryan Olson committed
17

18
use super::utils::GracefulShutdownTracker;
19
20
use crate::SystemHealth;
use crate::runtime::Runtime;
Ryan Olson's avatar
Ryan Olson committed
21

22
// Used instead of std::cell::OnceCell because get_or_try_init there is nightly
23
use async_once_cell::OnceCell;
24

25
use std::fmt;
26
use std::sync::{Arc, OnceLock, Weak};
27
use std::time::Duration;
28
use tokio::sync::watch::Receiver;
29
30

use anyhow::Result;
Ryan Olson's avatar
Ryan Olson committed
31
32
use derive_getters::Dissolve;
use figment::error;
33
34
use std::collections::HashMap;
use tokio::sync::Mutex;
35
use tokio_util::sync::CancellationToken;
Ryan Olson's avatar
Ryan Olson committed
36

37
38
type InstanceMap = HashMap<Endpoint, Weak<Receiver<Vec<Instance>>>>;

39
40
41
42
43
44
45
46
/// Distributed [Runtime] which provides access to shared resources across the cluster, this includes
/// communication protocols and transports.
#[derive(Clone)]
pub struct DistributedRuntime {
    // local runtime
    runtime: Runtime,

    nats_client: Option<transports::nats::Client>,
47
    store: kv::Manager,
48
    network_manager: Arc<NetworkManager>,
49
50
    tcp_server: Arc<OnceCell<Arc<transports::tcp::server::TcpStreamServer>>>,
    system_status_server: Arc<OnceLock<Arc<system_status_server::SystemStatusServerInfo>>>,
51
    request_plane: RequestPlaneMode,
52
53
54
55

    // Service discovery client
    discovery_client: Arc<dyn discovery::Discovery>,

56
57
58
59
    // Discovery metadata (only used for Kubernetes backend)
    // Shared with system status server to expose via /metadata endpoint
    discovery_metadata: Option<Arc<tokio::sync::RwLock<discovery::DiscoveryMetadata>>>,

60
61
62
63
64
65
66
    // local registry for components
    // the registry allows us to use share runtime resources across instances of the same component object.
    // take for example two instances of a client to the same remote component. The registry allows us to use
    // a single endpoint watcher for both clients, this keeps the number background tasking watching specific
    // paths in etcd to a minimum.
    component_registry: component::Registry,

67
    instance_sources: Arc<tokio::sync::Mutex<InstanceMap>>,
68
69
70
71

    // Health Status
    system_health: Arc<parking_lot::Mutex<SystemHealth>>,

72
73
74
    // Local endpoint registry for in-process calls
    local_endpoint_registry: crate::local_endpoint_registry::LocalEndpointRegistry,

75
76
77
78
    // This hierarchy's own metrics registry
    metrics_registry: MetricsRegistry,
}

79
impl MetricsHierarchy for DistributedRuntime {
80
81
82
83
    fn basename(&self) -> String {
        "".to_string() // drt has no basename. Basename only begins with the Namespace.
    }

84
85
86
87
88
89
    fn parent_hierarchies(&self) -> Vec<&dyn MetricsHierarchy> {
        vec![] // drt is the root, so no parent hierarchies
    }

    fn get_metrics_registry(&self) -> &MetricsRegistry {
        &self.metrics_registry
90
91
92
    }
}

Ryan Olson's avatar
Ryan Olson committed
93
94
95
96
97
98
impl std::fmt::Debug for DistributedRuntime {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "DistributedRuntime")
    }
}

Ryan Olson's avatar
Ryan Olson committed
99
100
impl DistributedRuntime {
    pub async fn new(runtime: Runtime, config: DistributedConfig) -> Result<Self> {
101
        let (selected_kv_store, nats_config, request_plane) = config.dissolve();
Ryan Olson's avatar
Ryan Olson committed
102
103
104

        let runtime_clone = runtime.clone();

105
        let store = match selected_kv_store {
106
            kv::Selector::Etcd(etcd_config) => {
107
108
109
110
                let etcd_client = etcd::Client::new(*etcd_config, runtime_clone).await.inspect_err(|err|
                    // The returned error doesn't show because of a dropped runtime error, so
                    // log it first.
                    tracing::error!(%err, "Could not connect to etcd. Pass `--store-kv ..` to use a different backend or start etcd."))?;
111
                kv::Manager::etcd(etcd_client)
112
            }
113
            kv::Selector::File(root) => kv::Manager::file(runtime.primary_token(), root),
114
            kv::Selector::Memory => kv::Manager::memory(),
115
        };
Ryan Olson's avatar
Ryan Olson committed
116

117
118
119
120
        let nats_client = match nats_config {
            Some(nc) => Some(nc.connect().await?),
            None => None,
        };
Ryan Olson's avatar
Ryan Olson committed
121

122
        // Start system status server for health and metrics if enabled in configuration
123
124
125
126
127
128
129
130
        let config = crate::config::RuntimeConfig::from_settings().unwrap_or_default();
        // IMPORTANT: We must extract cancel_token from runtime BEFORE moving runtime into the struct below.
        // This is because after moving, runtime is no longer accessible in this scope (ownership rules).
        let cancel_token = if config.system_server_enabled() {
            Some(runtime.clone().child_token())
        } else {
            None
        };
131
132
        let starting_health_status = config.starting_health_status.clone();
        let use_endpoint_health_status = config.use_endpoint_health_status.clone();
133
134
        let health_endpoint_path = config.system_health_path.clone();
        let live_endpoint_path = config.system_live_path.clone();
135
        let system_health = Arc::new(parking_lot::Mutex::new(SystemHealth::new(
136
137
            starting_health_status,
            use_endpoint_health_status,
138
139
            health_endpoint_path,
            live_endpoint_path,
140
        )));
141

142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
        // Initialize discovery client based on backend configuration
        let discovery_backend =
            std::env::var("DYN_DISCOVERY_BACKEND").unwrap_or_else(|_| "kv_store".to_string());

        let (discovery_client, discovery_metadata) = match discovery_backend.as_str() {
            "kubernetes" => {
                tracing::info!("Initializing Kubernetes discovery backend");
                let metadata = Arc::new(tokio::sync::RwLock::new(
                    crate::discovery::DiscoveryMetadata::new(),
                ));
                let client = crate::discovery::KubeDiscoveryClient::new(
                    metadata.clone(),
                    runtime.primary_token(),
                )
                .await
                .inspect_err(
                    |err| tracing::error!(%err, "Failed to initialize Kubernetes discovery client"),
                )?;
                (Arc::new(client) as Arc<dyn Discovery>, Some(metadata))
            }
            _ => {
                tracing::info!("Initializing KV store discovery backend");
                use crate::discovery::KVStoreDiscovery;
                (
                    Arc::new(KVStoreDiscovery::new(
                        store.clone(),
                        runtime.primary_token(),
                    )) as Arc<dyn Discovery>,
                    None,
                )
            }
173
174
        };

175
        let component_registry = component::Registry::new();
176

177
178
179
180
181
182
183
184
        // NetworkManager for request plane
        let network_manager = NetworkManager::new(
            runtime.child_token(),
            nats_client.clone().map(|c| c.client().clone()),
            component_registry.clone(),
            request_plane,
        );

185
        let distributed_runtime = Self {
Ryan Olson's avatar
Ryan Olson committed
186
            runtime,
187
            store,
188
            network_manager: Arc::new(network_manager),
Ryan Olson's avatar
Ryan Olson committed
189
190
            nats_client,
            tcp_server: Arc::new(OnceCell::new()),
191
            system_status_server: Arc::new(OnceLock::new()),
192
            discovery_client,
193
            discovery_metadata,
194
            component_registry,
195
            instance_sources: Arc::new(Mutex::new(HashMap::new())),
196
            metrics_registry: crate::MetricsRegistry::new(),
197
            system_health,
198
            request_plane,
199
            local_endpoint_registry: crate::local_endpoint_registry::LocalEndpointRegistry::new(),
200
201
        };

202
203
204
205
206
207
        // Initialize the uptime gauge in SystemHealth
        distributed_runtime
            .system_health
            .lock()
            .initialize_uptime_gauge(&distributed_runtime)?;

208
        // Handle system status server initialization
209
        if let Some(cancel_token) = cancel_token {
210
            // System server is enabled - start both the state and HTTP server
211
            let host = config.system_host.clone();
212
            let port = config.system_port as u16;
213

214
            // Start system status server (it creates SystemStatusState internally)
215
            match crate::system_status_server::spawn_system_status_server(
216
217
218
219
                &host,
                port,
                cancel_token,
                Arc::new(distributed_runtime.clone()),
220
                distributed_runtime.discovery_metadata.clone(),
221
222
223
            )
            .await
            {
224
                Ok((addr, handle)) => {
225
                    tracing::info!("System status server started successfully on {}", addr);
226

227
228
229
230
231
232
                    // Store system status server information
                    let system_status_server_info =
                        crate::system_status_server::SystemStatusServerInfo::new(
                            addr,
                            Some(handle),
                        );
233

234
                    // Initialize the system_status_server field
235
                    distributed_runtime
236
237
238
                        .system_status_server
                        .set(Arc::new(system_status_server_info))
                        .expect("System status server info should only be set once");
239
240
                }
                Err(e) => {
241
                    tracing::error!("System status server startup failed: {}", e);
242
                }
243
            }
244
        } else {
245
            // System server HTTP is disabled, but uptime metrics are still being tracked via SystemHealth
246
247
248
            tracing::debug!(
                "System status server HTTP endpoints disabled, but uptime metrics are being tracked"
            );
249
250
        }

251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
        // Start health check manager if enabled
        if config.health_check_enabled {
            let health_check_config = crate::health_check::HealthCheckConfig {
                canary_wait_time: std::time::Duration::from_secs(config.canary_wait_time_secs),
                request_timeout: std::time::Duration::from_secs(
                    config.health_check_request_timeout_secs,
                ),
            };

            // Start the health check manager (spawns per-endpoint monitoring tasks)
            match crate::health_check::start_health_check_manager(
                distributed_runtime.clone(),
                Some(health_check_config),
            )
            .await
            {
                Ok(()) => tracing::info!(
                    "Health check manager started (canary_wait_time: {}s, request_timeout: {}s)",
                    config.canary_wait_time_secs,
                    config.health_check_request_timeout_secs
                ),
                Err(e) => tracing::error!("Health check manager failed to start: {}", e),
            }
        }

276
        Ok(distributed_runtime)
Ryan Olson's avatar
Ryan Olson committed
277
278
279
    }

    pub async fn from_settings(runtime: Runtime) -> Result<Self> {
280
        let config = DistributedConfig::from_settings();
Ryan Olson's avatar
Ryan Olson committed
281
282
283
284
285
286
287
        Self::new(runtime, config).await
    }

    pub fn runtime(&self) -> &Runtime {
        &self.runtime
    }

288
289
290
291
    pub fn primary_token(&self) -> CancellationToken {
        self.runtime.primary_token()
    }

292
293
294
295
296
297
298
299
300
301
302
    // TODO: Don't hand out pointers, instead have methods to use the registry in friendly ways
    // (without being aware of async locks and so on)
    pub fn component_registry(&self) -> &component::Registry {
        &self.component_registry
    }

    // TODO: Don't hand out pointers, instead provide system health related services.
    pub fn system_health(&self) -> Arc<parking_lot::Mutex<SystemHealth>> {
        self.system_health.clone()
    }

303
304
305
306
307
308
309
    /// Get the local endpoint registry for in-process endpoint calls
    pub fn local_endpoint_registry(
        &self,
    ) -> &crate::local_endpoint_registry::LocalEndpointRegistry {
        &self.local_endpoint_registry
    }

310
    pub fn connection_id(&self) -> u64 {
311
        self.discovery_client.instance_id()
Ryan Olson's avatar
Ryan Olson committed
312
313
314
315
    }

    pub fn shutdown(&self) {
        self.runtime.shutdown();
316
        self.store.shutdown();
Ryan Olson's avatar
Ryan Olson committed
317
318
319
320
    }

    /// Create a [`Namespace`]
    pub fn namespace(&self, name: impl Into<String>) -> Result<Namespace> {
321
        Namespace::new(self.clone(), name.into())
Ryan Olson's avatar
Ryan Olson committed
322
323
    }

324
325
326
    /// Returns the discovery interface for service registration and discovery
    pub fn discovery(&self) -> Arc<dyn Discovery> {
        self.discovery_client.clone()
327
328
    }

329
    pub async fn tcp_server(&self) -> Result<Arc<tcp::server::TcpStreamServer>> {
Ryan Olson's avatar
Ryan Olson committed
330
331
332
333
334
        Ok(self
            .tcp_server
            .get_or_try_init(async move {
                let options = tcp::server::ServerOptions::default();
                let server = tcp::server::TcpStreamServer::new(options).await?;
335
                Ok::<_, PipelineError>(server)
Ryan Olson's avatar
Ryan Olson committed
336
337
338
339
340
            })
            .await?
            .clone())
    }

341
    /// Get the network manager
342
343
344
    ///
    /// The network manager consolidates all network configuration and provides
    /// unified access to request plane servers and clients.
345
346
    pub fn network_manager(&self) -> Arc<NetworkManager> {
        self.network_manager.clone()
347
348
349
350
351
352
353
354
355
    }

    /// Get the request plane server (convenience method)
    ///
    /// This is a shortcut for `network_manager().await?.server().await`.
    pub async fn request_plane_server(
        &self,
    ) -> Result<Arc<dyn crate::pipeline::network::ingress::unified_server::RequestPlaneServer>>
    {
356
        self.network_manager().server().await
Ryan Olson's avatar
Ryan Olson committed
357
358
    }

359
360
361
362
363
    /// Get system status server information if available
    pub fn system_status_server_info(
        &self,
    ) -> Option<Arc<crate::system_status_server::SystemStatusServerInfo>> {
        self.system_status_server.get().cloned()
364
365
    }

366
    /// An interface to store things outside of the process. Usually backed by something like etcd.
367
    /// Currently does key-value, but will grow to include whatever we need to store.
368
    pub fn store(&self) -> &kv::Manager {
369
        &self.store
370
371
    }

372
373
374
375
376
    /// How the frontend should talk to the backend.
    pub fn request_plane(&self) -> RequestPlaneMode {
        self.request_plane
    }

377
378
379
    pub fn child_token(&self) -> CancellationToken {
        self.runtime.child_token()
    }
380

381
382
383
384
    pub(crate) fn graceful_shutdown_tracker(&self) -> Arc<GracefulShutdownTracker> {
        self.runtime.graceful_shutdown_tracker()
    }

385
    pub fn instance_sources(&self) -> Arc<Mutex<InstanceMap>> {
386
387
        self.instance_sources.clone()
    }
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413

    /// TODO: This is a temporary KV router measure for component/component.rs EventPublisher impl for
    /// Component, to allow it to publish to NATS. KV Router is the only user.
    pub(crate) async fn kv_router_nats_publish(
        &self,
        subject: String,
        payload: bytes::Bytes,
    ) -> anyhow::Result<()> {
        let Some(nats_client) = self.nats_client.as_ref() else {
            anyhow::bail!("KV router's EventPublisher requires NATS");
        };
        Ok(nats_client.client().publish(subject, payload).await?)
    }

    /// TODO: This is a temporary KV router measure for component/component.rs EventSubscriber impl for
    /// Component, to allow it to subscribe to NATS. KV Router is the only user.
    pub(crate) async fn kv_router_nats_subscribe(
        &self,
        subject: String,
    ) -> Result<async_nats::Subscriber> {
        let Some(nats_client) = self.nats_client.as_ref() else {
            anyhow::bail!("KV router's EventSubscriber requires NATS");
        };
        Ok(nats_client.client().subscribe(subject).await?)
    }

414
415
416
417
    /// DEPRECATED: This method exists only for NATS request plane support.
    /// Once everything uses the TCP request plane, this can be removed along with
    /// the NATS service registration infrastructure.
    pub fn register_nats_service(&self, component: Component) {
418
419
420
421
        let drt = self.clone();
        self.runtime().secondary().spawn(async move {
            let service_name = component.service_name();

422
423
424
425
426
427
428
429
430
431
432
433
434
435
            // Pre-check to save cost of creating the service, but don't hold the lock
            if drt
                .component_registry()
                .inner
                .lock()
                .await
                .services
                .contains_key(&service_name)
            {
                // The NATS service is per component, but it is called from `serve_endpoint`, and there
                // are often multiple endpoints for a component (e.g. `clear_kv_blocks` and `generate`).
                tracing::trace!("Service {service_name} already exists");
                return;
            }
436

437
438
439
440
441
442
443
444
445
446
            let Some(nats_client) = drt.nats_client.as_ref() else {
                tracing::error!("Cannot create NATS service without NATS.");
                return;
            };
            let description = None;
            let nats_service = match crate::component::service::build_nats_service(
                nats_client,
                &component,
                description,
            )
447
            .await
448
449
450
451
452
453
454
            {
                Ok(service) => service,
                Err(err) => {
                    tracing::error!(error = %err, component = service_name, "Failed to build NATS service");
                    return;
                }
            };
455

456
457
458
459
            let mut guard = drt.component_registry().inner.lock().await;
            if !guard.services.contains_key(&service_name) {
                // Normal case
                guard.services.insert(service_name.clone(), nats_service);
460

461
                tracing::info!("Added NATS service {service_name}");
462

463
464
465
466
467
468
469
                drop(guard);
            } else {
                drop(guard);
                let _ = nats_service.stop().await;
                // The NATS service is per component, but it is called from `serve_endpoint`, and there
                // are often multiple endpoints for a component (e.g. `clear_kv_blocks` and `generate`).
                // TODO: Is this still true?
470
            }
471
        });
472
    }
Ryan Olson's avatar
Ryan Olson committed
473
474
475
476
}

#[derive(Dissolve)]
pub struct DistributedConfig {
477
    pub store_backend: kv::Selector,
478
    pub nats_config: Option<nats::ClientOptions>,
479
    pub request_plane: RequestPlaneMode,
Ryan Olson's avatar
Ryan Olson committed
480
481
482
}

impl DistributedConfig {
483
    pub fn from_settings() -> DistributedConfig {
484
        let request_plane = RequestPlaneMode::from_env();
Ryan Olson's avatar
Ryan Olson committed
485
        DistributedConfig {
486
            store_backend: kv::Selector::Etcd(Box::default()),
487
488
489
490
491
492
            nats_config: if request_plane.is_nats() {
                Some(nats::ClientOptions::default())
            } else {
                None
            },
            request_plane,
Ryan Olson's avatar
Ryan Olson committed
493
494
        }
    }
Ryan Olson's avatar
Ryan Olson committed
495
496

    pub fn for_cli() -> DistributedConfig {
497
498
499
500
        let etcd_config = etcd::ClientOptions {
            attach_lease: false,
            ..Default::default()
        };
501
        let request_plane = RequestPlaneMode::from_env();
502
        DistributedConfig {
503
            store_backend: kv::Selector::Etcd(Box::new(etcd_config)),
504
505
506
507
508
509
            nats_config: if request_plane.is_nats() {
                Some(nats::ClientOptions::default())
            } else {
                None
            },
            request_plane,
510
511
        }
    }
512
513
514
515
516

    /// A DistributedConfig that isn't distributed, for when the frontend and backend are in the
    /// same process.
    pub fn process_local() -> DistributedConfig {
        DistributedConfig {
517
            store_backend: kv::Selector::Memory,
518
519
520
521
522
523
            nats_config: None,
            // This won't be used in process local, so we likely need a "none" option to
            // communicate that and avoid opening the ports.
            request_plane: RequestPlaneMode::Tcp,
        }
    }
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
}

/// Request plane transport mode configuration
///
/// This determines how requests are distributed from routers to workers:
/// - `Nats`: Use NATS for request distribution (default, legacy)
/// - `Http`: Use HTTP/2 for request distribution
/// - `Tcp`: Use raw TCP for request distribution with msgpack support
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum RequestPlaneMode {
    /// Use NATS for request plane (default for backward compatibility)
    Nats,
    /// Use HTTP/2 for request plane
    Http,
    /// Use raw TCP for request plane with msgpack support
    Tcp,
}

impl Default for RequestPlaneMode {
    fn default() -> Self {
        Self::Nats
    }
}

impl fmt::Display for RequestPlaneMode {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            Self::Nats => write!(f, "nats"),
            Self::Http => write!(f, "http"),
            Self::Tcp => write!(f, "tcp"),
        }
    }
}

impl std::str::FromStr for RequestPlaneMode {
    type Err = anyhow::Error;

    fn from_str(s: &str) -> std::result::Result<Self, Self::Err> {
        match s.to_lowercase().as_str() {
            "nats" => Ok(Self::Nats),
            "http" => Ok(Self::Http),
            "tcp" => Ok(Self::Tcp),
            _ => Err(anyhow::anyhow!(
                "Invalid request plane mode: '{}'. Valid options are: 'nats', 'http', 'tcp'",
                s
            )),
570
        }
Ryan Olson's avatar
Ryan Olson committed
571
    }
Ryan Olson's avatar
Ryan Olson committed
572
}
573

574
575
576
577
578
579
580
581
582
impl RequestPlaneMode {
    /// Get the request plane mode from environment variable (uncached)
    /// Reads from `DYN_REQUEST_PLANE` environment variable.
    fn from_env() -> Self {
        std::env::var("DYN_REQUEST_PLANE")
            .ok()
            .and_then(|s| s.parse().ok())
            .unwrap_or_default()
    }
583
584
585
586

    pub fn is_nats(&self) -> bool {
        matches!(self, RequestPlaneMode::Nats)
    }
587
588
}

589
pub mod distributed_test_utils {
590
591
    //! Common test helper functions for DistributedRuntime tests

592
    /// Helper function to create a DRT instance for integration-only tests.
593
    /// Uses from_current to leverage existing tokio runtime
594
    /// Note: Settings are read from environment variables inside DistributedRuntime::from_settings
595
    #[cfg(feature = "integration")]
596
    pub async fn create_test_drt_async() -> super::DistributedRuntime {
597
        use crate::{storage::kv, transports::nats};
598

599
        let rt = crate::Runtime::from_current().unwrap();
600
        let config = super::DistributedConfig {
601
            store_backend: kv::Selector::Memory,
602
            nats_config: Some(nats::ClientOptions::default()),
603
            request_plane: crate::distributed::RequestPlaneMode::default(),
604
605
        };
        super::DistributedRuntime::new(rt, config).await.unwrap()
606
607
    }
}
608

609
#[cfg(all(test, feature = "integration"))]
610
mod tests {
611
    use super::RequestPlaneMode;
612
613
614
615
    use super::distributed_test_utils::create_test_drt_async;

    #[tokio::test]
    async fn test_drt_uptime_after_delay_system_disabled() {
616
        use crate::config::environment_names::runtime::system as env_system;
617
        // Test uptime with system status server disabled
618
        temp_env::async_with_vars([(env_system::DYN_SYSTEM_PORT, None::<&str>)], async {
619
620
621
622
623
624
625
            // Start a DRT
            let drt = create_test_drt_async().await;

            // Wait 50ms
            tokio::time::sleep(tokio::time::Duration::from_millis(50)).await;

            // Check that uptime is 50+ ms
626
            let uptime = drt.system_health.lock().uptime();
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
            assert!(
                uptime >= std::time::Duration::from_millis(50),
                "Expected uptime to be at least 50ms, but got {:?}",
                uptime
            );

            println!(
                "✓ DRT uptime test passed (system disabled): uptime = {:?}",
                uptime
            );
        })
        .await;
    }

    #[tokio::test]
    async fn test_drt_uptime_after_delay_system_enabled() {
643
        use crate::config::environment_names::runtime::system as env_system;
644
        // Test uptime with system status server enabled
645
        temp_env::async_with_vars([(env_system::DYN_SYSTEM_PORT, Some("8081"))], async {
646
647
648
649
650
651
652
            // Start a DRT
            let drt = create_test_drt_async().await;

            // Wait 50ms
            tokio::time::sleep(tokio::time::Duration::from_millis(50)).await;

            // Check that uptime is 50+ ms
653
            let uptime = drt.system_health.lock().uptime();
654
655
656
657
658
659
660
661
662
663
664
665
666
            assert!(
                uptime >= std::time::Duration::from_millis(50),
                "Expected uptime to be at least 50ms, but got {:?}",
                uptime
            );

            println!(
                "✓ DRT uptime test passed (system enabled): uptime = {:?}",
                uptime
            );
        })
        .await;
    }
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702

    #[test]
    fn test_request_plane_mode_from_str() {
        assert_eq!(
            "nats".parse::<RequestPlaneMode>().unwrap(),
            RequestPlaneMode::Nats
        );
        assert_eq!(
            "http".parse::<RequestPlaneMode>().unwrap(),
            RequestPlaneMode::Http
        );
        assert_eq!(
            "tcp".parse::<RequestPlaneMode>().unwrap(),
            RequestPlaneMode::Tcp
        );
        assert_eq!(
            "NATS".parse::<RequestPlaneMode>().unwrap(),
            RequestPlaneMode::Nats
        );
        assert_eq!(
            "HTTP".parse::<RequestPlaneMode>().unwrap(),
            RequestPlaneMode::Http
        );
        assert_eq!(
            "TCP".parse::<RequestPlaneMode>().unwrap(),
            RequestPlaneMode::Tcp
        );
        assert!("invalid".parse::<RequestPlaneMode>().is_err());
    }

    #[test]
    fn test_request_plane_mode_display() {
        assert_eq!(RequestPlaneMode::Nats.to_string(), "nats");
        assert_eq!(RequestPlaneMode::Http.to_string(), "http");
        assert_eq!(RequestPlaneMode::Tcp.to_string(), "tcp");
    }
703
}