distributed.rs 14.9 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
// SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
Ryan Olson's avatar
Ryan Olson committed
15
16

pub use crate::component::Component;
17
use crate::transports::nats::DRTNatsClientPrometheusMetrics;
Ryan Olson's avatar
Ryan Olson committed
18
use crate::{
19
    ErrorContext, RuntimeCallback,
20
    component::{self, ComponentBuilder, Endpoint, InstanceSource, Namespace},
Ryan Olson's avatar
Ryan Olson committed
21
    discovery::DiscoveryClient,
22
    metrics::MetricsRegistry,
Ryan Olson's avatar
Ryan Olson committed
23
24
25
26
    service::ServiceClient,
    transports::{etcd, nats, tcp},
};

27
use super::{Arc, DistributedRuntime, OK, OnceCell, Result, Runtime, SystemHealth, Weak, error};
28
use std::sync::OnceLock;
Ryan Olson's avatar
Ryan Olson committed
29
30
31

use derive_getters::Dissolve;
use figment::error;
32
33
use std::collections::HashMap;
use tokio::sync::Mutex;
34
use tokio_util::sync::CancellationToken;
Ryan Olson's avatar
Ryan Olson committed
35

36
37
38
39
40
41
42
43
44
45
impl MetricsRegistry for DistributedRuntime {
    fn basename(&self) -> String {
        "".to_string() // drt has no basename. Basename only begins with the Namespace.
    }

    fn parent_hierarchy(&self) -> Vec<String> {
        vec![] // drt is the root, so no parent hierarchy
    }
}

Ryan Olson's avatar
Ryan Olson committed
46
47
48
49
50
51
impl std::fmt::Debug for DistributedRuntime {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "DistributedRuntime")
    }
}

Ryan Olson's avatar
Ryan Olson committed
52
53
impl DistributedRuntime {
    pub async fn new(runtime: Runtime, config: DistributedConfig) -> Result<Self> {
54
        let (etcd_config, nats_config, is_static) = config.dissolve();
Ryan Olson's avatar
Ryan Olson committed
55
56
57

        let runtime_clone = runtime.clone();

58
59
60
        let etcd_client = if is_static {
            None
        } else {
61
            Some(etcd::Client::new(etcd_config.clone(), runtime_clone).await?)
62
        };
Ryan Olson's avatar
Ryan Olson committed
63

64
        let nats_client = nats_config.clone().connect().await?;
Ryan Olson's avatar
Ryan Olson committed
65

66
        // Start system status server for health and metrics if enabled in configuration
67
68
69
70
71
72
73
74
        let config = crate::config::RuntimeConfig::from_settings().unwrap_or_default();
        // IMPORTANT: We must extract cancel_token from runtime BEFORE moving runtime into the struct below.
        // This is because after moving, runtime is no longer accessible in this scope (ownership rules).
        let cancel_token = if config.system_server_enabled() {
            Some(runtime.clone().child_token())
        } else {
            None
        };
75
76
        let starting_health_status = config.starting_health_status.clone();
        let use_endpoint_health_status = config.use_endpoint_health_status.clone();
77
78
79
        let health_endpoint_path = config.system_health_path.clone();
        let live_endpoint_path = config.system_live_path.clone();
        let system_health = Arc::new(std::sync::Mutex::new(SystemHealth::new(
80
81
            starting_health_status,
            use_endpoint_health_status,
82
83
            health_endpoint_path,
            live_endpoint_path,
84
        )));
85

86
87
        let nats_client_for_metrics = nats_client.clone();

88
        let distributed_runtime = Self {
Ryan Olson's avatar
Ryan Olson committed
89
90
91
92
            runtime,
            etcd_client,
            nats_client,
            tcp_server: Arc::new(OnceCell::new()),
93
            system_status_server: Arc::new(OnceLock::new()),
Ryan Olson's avatar
Ryan Olson committed
94
            component_registry: component::Registry::new(),
95
            is_static,
96
            instance_sources: Arc::new(Mutex::new(HashMap::new())),
97
            hierarchy_to_metricsregistry: Arc::new(std::sync::RwLock::new(HashMap::<
98
                String,
99
                crate::MetricsRegistryEntry,
100
            >::new())),
101
            system_health,
102
103
        };

104
        let nats_client_metrics = DRTNatsClientPrometheusMetrics::new(
105
106
107
108
109
110
            &distributed_runtime,
            nats_client_for_metrics.client().clone(),
        )?;
        let mut drt_hierarchies = distributed_runtime.parent_hierarchy();
        drt_hierarchies.push(distributed_runtime.hierarchy());
        // Register a callback to update NATS client metrics
111
112
        let nats_client_callback = Arc::new({
            let nats_client_clone = nats_client_metrics.clone();
113
            move || {
114
                nats_client_clone.set_from_client_stats();
115
116
117
                Ok(())
            }
        });
118
        distributed_runtime.register_metrics_callback(drt_hierarchies, nats_client_callback);
119

120
121
122
123
124
125
126
        // Initialize the uptime gauge in SystemHealth
        distributed_runtime
            .system_health
            .lock()
            .unwrap()
            .initialize_uptime_gauge(&distributed_runtime)?;

127
        // Handle system status server initialization
128
        if let Some(cancel_token) = cancel_token {
129
            // System server is enabled - start both the state and HTTP server
130
131
132
            let host = config.system_host.clone();
            let port = config.system_port;

133
            // Start system status server (it creates SystemStatusState internally)
134
            match crate::system_status_server::spawn_system_status_server(
135
136
137
138
                &host,
                port,
                cancel_token,
                Arc::new(distributed_runtime.clone()),
139
140
141
            )
            .await
            {
142
                Ok((addr, handle)) => {
143
                    tracing::info!("System status server started successfully on {}", addr);
144

145
146
147
148
149
150
                    // Store system status server information
                    let system_status_server_info =
                        crate::system_status_server::SystemStatusServerInfo::new(
                            addr,
                            Some(handle),
                        );
151

152
                    // Initialize the system_status_server field
153
                    distributed_runtime
154
155
156
                        .system_status_server
                        .set(Arc::new(system_status_server_info))
                        .expect("System status server info should only be set once");
157
158
                }
                Err(e) => {
159
                    tracing::error!("System status server startup failed: {}", e);
160
                }
161
            }
162
        } else {
163
            // System server HTTP is disabled, but uptime metrics are still being tracked via SystemHealth
164
165
166
            tracing::debug!(
                "System status server HTTP endpoints disabled, but uptime metrics are being tracked"
            );
167
168
169
        }

        Ok(distributed_runtime)
Ryan Olson's avatar
Ryan Olson committed
170
171
172
    }

    pub async fn from_settings(runtime: Runtime) -> Result<Self> {
173
174
175
176
177
178
179
        let config = DistributedConfig::from_settings(false);
        Self::new(runtime, config).await
    }

    // Call this if you are using static workers that do not need etcd-based discovery.
    pub async fn from_settings_without_discovery(runtime: Runtime) -> Result<Self> {
        let config = DistributedConfig::from_settings(true);
Ryan Olson's avatar
Ryan Olson committed
180
181
182
183
184
185
186
        Self::new(runtime, config).await
    }

    pub fn runtime(&self) -> &Runtime {
        &self.runtime
    }

187
188
189
190
    pub fn primary_token(&self) -> CancellationToken {
        self.runtime.primary_token()
    }

191
192
193
194
    /// The etcd lease all our components will be attached to.
    /// Not available for static workers.
    pub fn primary_lease(&self) -> Option<etcd::Lease> {
        self.etcd_client.as_ref().map(|c| c.primary_lease())
Ryan Olson's avatar
Ryan Olson committed
195
196
197
198
199
200
201
202
    }

    pub fn shutdown(&self) {
        self.runtime.shutdown();
    }

    /// Create a [`Namespace`]
    pub fn namespace(&self, name: impl Into<String>) -> Result<Namespace> {
203
        Namespace::new(self.clone(), name.into(), self.is_static)
Ryan Olson's avatar
Ryan Olson committed
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
    }

    // /// Create a [`Component`]
    // pub fn component(
    //     &self,
    //     name: impl Into<String>,
    //     namespace: impl Into<String>,
    // ) -> Result<Component> {
    //     Ok(ComponentBuilder::from_runtime(self.clone())
    //         .name(name.into())
    //         .namespace(namespace.into())
    //         .build()?)
    // }

    pub(crate) fn discovery_client(&self, namespace: impl Into<String>) -> DiscoveryClient {
219
220
221
222
223
224
        DiscoveryClient::new(
            namespace.into(),
            self.etcd_client
                .clone()
                .expect("Attempt to get discovery_client on static DistributedRuntime"),
        )
Ryan Olson's avatar
Ryan Olson committed
225
226
227
228
229
230
    }

    pub(crate) fn service_client(&self) -> ServiceClient {
        ServiceClient::new(self.nats_client.clone())
    }

231
    pub async fn tcp_server(&self) -> Result<Arc<tcp::server::TcpStreamServer>> {
Ryan Olson's avatar
Ryan Olson committed
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
        Ok(self
            .tcp_server
            .get_or_try_init(async move {
                let options = tcp::server::ServerOptions::default();
                let server = tcp::server::TcpStreamServer::new(options).await?;
                OK(server)
            })
            .await?
            .clone())
    }

    pub fn nats_client(&self) -> nats::Client {
        self.nats_client.clone()
    }

247
248
249
250
251
    /// Get system status server information if available
    pub fn system_status_server_info(
        &self,
    ) -> Option<Arc<crate::system_status_server::SystemStatusServerInfo>> {
        self.system_status_server.get().cloned()
252
253
    }

254
    // todo(ryan): deprecate this as we move to Discovery traits and Component Identifiers
255
    pub fn etcd_client(&self) -> Option<etcd::Client> {
Ryan Olson's avatar
Ryan Olson committed
256
257
        self.etcd_client.clone()
    }
258
259
260
261

    pub fn child_token(&self) -> CancellationToken {
        self.runtime.child_token()
    }
262
263
264
265

    pub fn instance_sources(&self) -> Arc<Mutex<HashMap<Endpoint, Weak<InstanceSource>>>> {
        self.instance_sources.clone()
    }
266

267
268
    /// Add a Prometheus metric to a specific hierarchy's registry. Note that it is possible
    /// to register the same metric name multiple times, as long as the labels are different.
269
270
271
272
273
274
275
276
    pub fn add_prometheus_metric(
        &self,
        hierarchy: &str,
        prometheus_metric: Box<dyn prometheus::core::Collector>,
    ) -> anyhow::Result<()> {
        let mut registries = self.hierarchy_to_metricsregistry.write().unwrap();
        let entry = registries.entry(hierarchy.to_string()).or_default();

277
278
279
280
281
        // Try to register the metric
        entry
            .prometheus_registry
            .register(prometheus_metric)
            .map_err(|e| e.into())
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
    }

    /// Add a callback function to metrics registries for the given hierarchies
    pub fn register_metrics_callback(&self, hierarchies: Vec<String>, callback: RuntimeCallback) {
        let mut registries = self.hierarchy_to_metricsregistry.write().unwrap();
        for hierarchy in hierarchies {
            registries
                .entry(hierarchy)
                .or_default()
                .add_callback(callback.clone());
        }
    }

    /// Execute all callbacks for a given hierarchy key and return their results
    pub fn execute_metrics_callbacks(&self, hierarchy: &str) -> Vec<anyhow::Result<()>> {
        // Clone callbacks while holding read lock (fast operation)
        let callbacks = {
            let registries = self.hierarchy_to_metricsregistry.read().unwrap();
            registries
                .get(hierarchy)
                .map(|entry| entry.runtime_callbacks.clone())
        }; // Read lock released here

        // Execute callbacks without holding the lock
        match callbacks {
            Some(callbacks) => callbacks.iter().map(|callback| callback()).collect(),
            None => Vec::new(),
        }
    }

    /// Get all registered hierarchy keys. Private because it is only used for testing.
    fn get_registered_hierarchies(&self) -> Vec<String> {
        let registries = self.hierarchy_to_metricsregistry.read().unwrap();
        registries.keys().cloned().collect()
    }
Ryan Olson's avatar
Ryan Olson committed
317
318
319
320
321
322
}

#[derive(Dissolve)]
pub struct DistributedConfig {
    pub etcd_config: etcd::ClientOptions,
    pub nats_config: nats::ClientOptions,
323
    pub is_static: bool,
Ryan Olson's avatar
Ryan Olson committed
324
325
326
}

impl DistributedConfig {
327
    pub fn from_settings(is_static: bool) -> DistributedConfig {
Ryan Olson's avatar
Ryan Olson committed
328
329
330
        DistributedConfig {
            etcd_config: etcd::ClientOptions::default(),
            nats_config: nats::ClientOptions::default(),
331
            is_static,
Ryan Olson's avatar
Ryan Olson committed
332
333
        }
    }
Ryan Olson's avatar
Ryan Olson committed
334
335
336
337
338

    pub fn for_cli() -> DistributedConfig {
        let mut config = DistributedConfig {
            etcd_config: etcd::ClientOptions::default(),
            nats_config: nats::ClientOptions::default(),
339
            is_static: false,
Ryan Olson's avatar
Ryan Olson committed
340
341
342
343
344
345
        };

        config.etcd_config.attach_lease = false;

        config
    }
Ryan Olson's avatar
Ryan Olson committed
346
}
347
348

#[cfg(test)]
349
pub mod distributed_test_utils {
350
351
352
353
354
355
356
357
358
359
360
361
362
363
    //! Common test helper functions for DistributedRuntime tests
    // TODO: Use in-memory DistributedRuntime for tests instead of full runtime when available.

    /// Helper function to create a DRT instance for tests
    /// Uses from_current to leverage existing tokio runtime
    /// Note: Settings are read from environment variables inside DistributedRuntime::from_settings_without_discovery
    #[cfg(feature = "integration")]
    pub async fn create_test_drt_async() -> crate::DistributedRuntime {
        let rt = crate::Runtime::from_current().unwrap();
        crate::DistributedRuntime::from_settings_without_discovery(rt)
            .await
            .unwrap()
    }
}
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421

#[cfg(feature = "integration")]
#[cfg(test)]
mod tests {
    use super::distributed_test_utils::create_test_drt_async;

    #[tokio::test]
    async fn test_drt_uptime_after_delay_system_disabled() {
        // Test uptime with system status server disabled
        temp_env::async_with_vars([("DYN_SYSTEM_ENABLED", Some("false"))], async {
            // Start a DRT
            let drt = create_test_drt_async().await;

            // Wait 50ms
            tokio::time::sleep(tokio::time::Duration::from_millis(50)).await;

            // Check that uptime is 50+ ms
            let uptime = drt.system_health.lock().unwrap().uptime();
            assert!(
                uptime >= std::time::Duration::from_millis(50),
                "Expected uptime to be at least 50ms, but got {:?}",
                uptime
            );

            println!(
                "✓ DRT uptime test passed (system disabled): uptime = {:?}",
                uptime
            );
        })
        .await;
    }

    #[tokio::test]
    async fn test_drt_uptime_after_delay_system_enabled() {
        // Test uptime with system status server enabled
        temp_env::async_with_vars([("DYN_SYSTEM_ENABLED", Some("true"))], async {
            // Start a DRT
            let drt = create_test_drt_async().await;

            // Wait 50ms
            tokio::time::sleep(tokio::time::Duration::from_millis(50)).await;

            // Check that uptime is 50+ ms
            let uptime = drt.system_health.lock().unwrap().uptime();
            assert!(
                uptime >= std::time::Duration::from_millis(50),
                "Expected uptime to be at least 50ms, but got {:?}",
                uptime
            );

            println!(
                "✓ DRT uptime test passed (system enabled): uptime = {:?}",
                uptime
            );
        })
        .await;
    }
}