kv_router.rs 20 KB
Newer Older
1
// SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2
3
// SPDX-License-Identifier: Apache-2.0

4
use std::collections::HashMap;
Yan Ru Pei's avatar
Yan Ru Pei committed
5
use std::sync::Arc;
6
use std::time::{Duration, Instant};
7

8
use anyhow::Result;
Yan Ru Pei's avatar
Yan Ru Pei committed
9
use dynamo_kv_router::{ConcurrentRadixTree, ThreadPoolIndexer};
10
use dynamo_runtime::{
11
    component::{Client, Endpoint},
12
    discovery::DiscoveryQuery,
13
    pipeline::{
14
15
        AsyncEngine, AsyncEngineContextProvider, Error, ManyOut, ResponseStream, SingleIn,
        async_trait,
16
    },
17
    protocols::EndpointId,
18
    protocols::annotated::Annotated,
19
    traits::DistributedRuntimeProvider,
20
};
21
use futures::stream;
Yan Ru Pei's avatar
Yan Ru Pei committed
22
use tokio::sync::oneshot;
23
use tracing::Instrument;
24
use validator::Validate;
25

26
27
28
29
30
// Re-export from dynamo-kv-router crate
pub use dynamo_kv_router::approx;
pub use dynamo_kv_router::indexer;
pub use dynamo_kv_router::protocols;

31
pub mod config;
32
pub mod metrics;
33
pub mod prefill_router;
34
pub mod publisher;
35
pub mod push_router;
36
pub mod queue;
37
pub mod recorder;
38
pub mod scheduler;
39
pub mod sequence;
40
pub mod subscriber;
41
pub mod worker_query;
42

43
pub use config::{KvRouterConfig, RouterConfigOverride};
44
pub use prefill_router::PrefillRouter;
45
pub use push_router::{DirectRoutingRouter, KvPushRouter};
46

47
use crate::{
48
    discovery::RuntimeConfigWatch,
49
    kv_router::{
50
        approx::PruneConfig,
Yan Ru Pei's avatar
Yan Ru Pei committed
51
        indexer::{GetWorkersRequest, KvIndexer, KvIndexerInterface, KvRouterError},
Yan Ru Pei's avatar
Yan Ru Pei committed
52
        protocols::{
53
54
            BlockExtraInfo, DpRank, LocalBlockHash, OverlapScores, RouterEvent, RouterRequest,
            RouterResponse, TokensWithHashes, WorkerId, WorkerSelectionResult, WorkerWithDpRank,
Yan Ru Pei's avatar
Yan Ru Pei committed
55
            compute_block_hash_for_seq,
Yan Ru Pei's avatar
Yan Ru Pei committed
56
        },
57
        scheduler::{KvScheduler, KvSchedulerError, PotentialLoad, SchedulingRequest},
58
        sequence::{SequenceError, SequenceRequest},
59
    },
60
    local_model::runtime_config::ModelRuntimeConfig,
61
62
};

63
64
// [gluo TODO] shouldn't need to be public
// this should be discovered from the component
65
66
67
68
69

// for metric scraping (pull-based)
pub const KV_METRICS_ENDPOINT: &str = "load_metrics";

// for metric publishing (push-based)
70
pub const KV_EVENT_SUBJECT: &str = "kv-events";
71
72
73
74
75
pub const KV_METRICS_SUBJECT: &str = "kv_metrics";

// for inter-router comms
pub const PREFILL_SUBJECT: &str = "prefill_events";
pub const ACTIVE_SEQUENCES_SUBJECT: &str = "active_sequences_events";
76

77
78
79
80
// for radix tree snapshot storage
pub const RADIX_STATE_BUCKET: &str = "radix-bucket";
pub const RADIX_STATE_FILE: &str = "radix-state";

81
82
83
// for worker-local kvindexer query
pub const WORKER_KV_INDEXER_BUFFER_SIZE: usize = 1024; // store 1024 most recent events in worker buffer

84
85
86
87
88
89
/// Generates a dp_rank-specific endpoint name for the worker KV indexer query service.
/// Each dp_rank has its own LocalKvIndexer and query endpoint to ensure per-dp_rank monotonicity.
pub fn worker_kv_indexer_query_endpoint(dp_rank: DpRank) -> String {
    format!("worker_kv_indexer_query_dp{dp_rank}")
}

90
// for router discovery registration
91
pub const KV_ROUTER_ENDPOINT: &str = "router-discovery";
92
93

/// Creates an EndpointId for the KV router in the given namespace.
94
pub fn router_endpoint_id(namespace: String, component: String) -> EndpointId {
95
96
    EndpointId {
        namespace,
97
        component,
98
99
100
101
102
        name: KV_ROUTER_ENDPOINT.to_string(),
    }
}

/// Creates a DiscoveryQuery for the KV router in the given namespace.
103
pub fn router_discovery_query(namespace: String, component: String) -> DiscoveryQuery {
104
105
    DiscoveryQuery::Endpoint {
        namespace,
106
        component,
107
108
109
110
        endpoint: KV_ROUTER_ENDPOINT.to_string(),
    }
}

111
112
113
114
/// A trait that users can implement to define custom selection logic
pub trait WorkerSelector {
    fn select_worker(
        &self,
115
        workers: &HashMap<protocols::WorkerId, ModelRuntimeConfig>,
116
        request: &SchedulingRequest,
117
        block_size: u32,
118
119
    ) -> Result<WorkerSelectionResult, KvSchedulerError>;
}
120

Yan Ru Pei's avatar
Yan Ru Pei committed
121
#[derive(Clone)]
122
pub enum Indexer {
Yan Ru Pei's avatar
Yan Ru Pei committed
123
    /// Single-threaded radix tree with channel-based event processing.
124
    /// Supports TTL-based expiration and size-based pruning.
125
    /// Has the ability to persist and snapshot states.
126
    KvIndexer(KvIndexer),
127

Yan Ru Pei's avatar
Yan Ru Pei committed
128
129
130
131
132
    /// Concurrent radix tree with a thread pool for event processing.
    /// Uses sticky worker routing for per-worker event serialization.
    /// Does not support TTL/pruning.
    Concurrent(Arc<ThreadPoolIndexer<ConcurrentRadixTree>>),

133
134
135
    /// Used when we do not wish to use the indexer at all (e.g., when overlap_score_weight is 0).
    /// Note: This will cause KV events to accumulate in JetStream as we do not regularly purge them.
    None,
136
137
138
}

impl Indexer {
139
140
141
142
143
144
    pub fn new(
        component: &dynamo_runtime::component::Component,
        kv_router_config: &KvRouterConfig,
        block_size: u32,
    ) -> Self {
        if kv_router_config.overlap_score_weight == 0.0 {
Yan Ru Pei's avatar
Yan Ru Pei committed
145
146
147
148
149
150
151
            return Indexer::None;
        }

        if kv_router_config.router_event_threads > 1 {
            return Indexer::Concurrent(Arc::new(ThreadPoolIndexer::new(
                ConcurrentRadixTree::new(),
                kv_router_config.router_event_threads as usize,
152
                block_size,
Yan Ru Pei's avatar
Yan Ru Pei committed
153
            )));
154
        }
Yan Ru Pei's avatar
Yan Ru Pei committed
155
156

        let kv_indexer_metrics = indexer::KvIndexerMetrics::from_component(component);
157
        let cancellation_token = component.drt().primary_token();
Yan Ru Pei's avatar
Yan Ru Pei committed
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176

        // If use_kv_events is false, enable TTL and pruning for approximate behavior
        let prune_config = if !kv_router_config.use_kv_events {
            Some(PruneConfig {
                ttl: Duration::from_secs_f64(kv_router_config.router_ttl_secs),
                max_tree_size: kv_router_config.router_max_tree_size,
                prune_target_ratio: kv_router_config.router_prune_target_ratio,
            })
        } else {
            None
        };

        Indexer::KvIndexer(KvIndexer::new_with_frequency(
            cancellation_token,
            None, // expiration_duration for frequency tracking
            block_size,
            kv_indexer_metrics,
            prune_config,
        ))
177
178
179
    }

    pub(crate) async fn find_matches(
180
181
182
183
184
        &self,
        sequence: Vec<LocalBlockHash>,
    ) -> Result<OverlapScores, KvRouterError> {
        match self {
            Indexer::KvIndexer(indexer) => indexer.find_matches(sequence).await,
Yan Ru Pei's avatar
Yan Ru Pei committed
185
            Indexer::Concurrent(tpi) => tpi.find_matches(sequence).await,
186
            Indexer::None => Ok(OverlapScores::new()),
187
188
        }
    }
189

190
    pub(crate) async fn dump_events(&self) -> Result<Vec<RouterEvent>, KvRouterError> {
191
192
        match self {
            Indexer::KvIndexer(indexer) => indexer.dump_events().await,
Yan Ru Pei's avatar
Yan Ru Pei committed
193
            Indexer::Concurrent(tpi) => tpi.dump_events().await,
194
195
196
197
198
            Indexer::None => {
                panic!(
                    "Cannot dump events: indexer does not exist (is overlap_score_weight set to 0?)"
                );
            }
199
200
        }
    }
201

202
    pub(crate) async fn process_routing_decision_for_request(
203
        &self,
204
        tokens_with_hashes: &mut TokensWithHashes,
205
206
207
208
209
        worker: WorkerWithDpRank,
    ) -> Result<(), KvRouterError> {
        match self {
            Indexer::KvIndexer(indexer) => {
                indexer
210
                    .process_routing_decision_for_request(tokens_with_hashes, worker)
211
212
                    .await
            }
Yan Ru Pei's avatar
Yan Ru Pei committed
213
214
215
216
            Indexer::Concurrent(tpi) => {
                tpi.process_routing_decision_for_request(tokens_with_hashes, worker)
                    .await
            }
217
218
219
            Indexer::None => Ok(()),
        }
    }
Yan Ru Pei's avatar
Yan Ru Pei committed
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261

    pub(crate) async fn apply_event(&self, event: RouterEvent) {
        match self {
            Indexer::KvIndexer(indexer) => {
                if let Err(e) = indexer.event_sender().send(event).await {
                    tracing::warn!("Failed to send event to indexer: {e}");
                }
            }
            Indexer::Concurrent(tpi) => tpi.apply_event(event).await,
            Indexer::None => {}
        }
    }

    pub(crate) async fn remove_worker(&self, worker_id: WorkerId) {
        match self {
            Indexer::KvIndexer(indexer) => {
                if let Err(e) = indexer.remove_worker_sender().send(worker_id).await {
                    tracing::warn!("Failed to send worker removal for {worker_id}: {e}");
                }
            }
            Indexer::Concurrent(tpi) => {
                KvIndexerInterface::remove_worker(tpi.as_ref(), worker_id).await;
            }
            Indexer::None => {}
        }
    }

    pub(crate) async fn get_workers(&self) -> Vec<WorkerId> {
        match self {
            Indexer::KvIndexer(indexer) => {
                let (resp_tx, resp_rx) = oneshot::channel();
                let req = GetWorkersRequest { resp: resp_tx };
                if let Err(e) = indexer.get_workers_sender().send(req).await {
                    tracing::warn!("Failed to send get_workers request: {e}");
                    return Vec::new();
                }
                resp_rx.await.unwrap_or_default()
            }
            Indexer::Concurrent(tpi) => tpi.backend().get_workers(),
            Indexer::None => Vec::new(),
        }
    }
262
263
}

264
265
/// A KvRouter only decides which worker you should use. It doesn't send you there.
/// TODO: Rename this to indicate it only selects a worker, it does not route.
266
pub struct KvRouter {
267
    indexer: Indexer,
268
    scheduler: KvScheduler,
269
    block_size: u32,
270
    kv_router_config: KvRouterConfig,
Yan Ru Pei's avatar
Yan Ru Pei committed
271
    cancellation_token: tokio_util::sync::CancellationToken,
272
    client: Client,
273
274
275
276
}

impl KvRouter {
    pub async fn new(
277
278
        endpoint: Endpoint,
        client: Client,
279
        mut workers_with_configs: RuntimeConfigWatch,
280
        block_size: u32,
281
        selector: Option<Box<dyn WorkerSelector + Send + Sync>>,
282
        kv_router_config: Option<KvRouterConfig>,
283
        worker_type: &'static str,
284
    ) -> Result<Self> {
285
        let kv_router_config = kv_router_config.unwrap_or_default();
286
        kv_router_config.validate()?;
287
        let component = endpoint.component();
288
        let cancellation_token = component.drt().primary_token();
289

290
        let indexer = Indexer::new(component, &kv_router_config, block_size);
291

292
        // Wait for at least one worker with a known runtime config before starting scheduler
293
294
295
296
297
298
        let _ = workers_with_configs
            .wait_for(|m| !m.is_empty())
            .await
            .map_err(|_| {
                anyhow::anyhow!("runtime config watch closed before any workers appeared")
            })?;
299

300
        let scheduler = KvScheduler::start(
301
            component.clone(),
302
            block_size,
303
            workers_with_configs.clone(),
304
            selector,
305
            &kv_router_config,
306
            worker_type,
307
308
        )
        .await?;
309

310
311
        // Start KV event subscription if needed (use_kv_events=true and overlap_score_weight>0)
        if kv_router_config.should_subscribe_to_kv_events() {
312
313
            subscriber::start_subscriber(component.clone(), &kv_router_config, indexer.clone())
                .await?;
314
        } else {
315
            tracing::info!(
316
317
318
                "Skipping KV event subscription (use_kv_events={}, overlap_score_weight={})",
                kv_router_config.use_kv_events,
                kv_router_config.overlap_score_weight,
319
            );
320
        }
321

322
        tracing::info!("KV Routing initialized");
323
        Ok(Self {
324
            indexer,
325
            scheduler,
326
            block_size,
327
            kv_router_config,
Yan Ru Pei's avatar
Yan Ru Pei committed
328
            cancellation_token,
329
            client,
330
        })
331
332
    }

333
334
335
336
337
    /// Get a reference to the client used by this KvRouter
    pub fn client(&self) -> &Client {
        &self.client
    }

338
339
340
341
342
343
344
345
    pub fn indexer(&self) -> &Indexer {
        &self.indexer
    }

    pub fn kv_router_config(&self) -> &KvRouterConfig {
        &self.kv_router_config
    }

346
    /// Give these tokens, find the worker with the best match in it's KV cache.
Yan Ru Pei's avatar
Yan Ru Pei committed
347
    /// Returns the best worker (with dp_rank) and overlap amount in number of blocks.
Yan Ru Pei's avatar
Yan Ru Pei committed
348
    /// Now also takes optional context_id for request tracking
349
    #[allow(clippy::too_many_arguments)]
Yan Ru Pei's avatar
Yan Ru Pei committed
350
    pub async fn find_best_match(
351
        &self,
Yan Ru Pei's avatar
Yan Ru Pei committed
352
        context_id: Option<&str>,
353
        tokens: &[u32],
354
        block_mm_infos: Option<&[Option<BlockExtraInfo>]>,
355
        router_config_override: Option<&RouterConfigOverride>,
356
        update_states: bool,
357
        lora_name: Option<String>,
358
        priority_jump: f64,
Yan Ru Pei's avatar
Yan Ru Pei committed
359
    ) -> anyhow::Result<(WorkerWithDpRank, u32)> {
360
361
        let start = Instant::now();

Yan Ru Pei's avatar
Yan Ru Pei committed
362
        if update_states && context_id.is_none() {
363
            anyhow::bail!("context_id must be provided when update_states is true");
Yan Ru Pei's avatar
Yan Ru Pei committed
364
365
        }

366
        let isl_tokens = tokens.len();
367

368
        let block_hashes = tracing::info_span!("kv_router.compute_block_hashes")
369
            .in_scope(|| compute_block_hash_for_seq(tokens, self.block_size, block_mm_infos));
370
        let hash_elapsed = start.elapsed();
371

372
373
374
375
376
        let overlap_scores = self
            .indexer
            .find_matches(block_hashes)
            .instrument(tracing::info_span!("kv_router.find_matches"))
            .await?;
377
        let find_matches_elapsed = start.elapsed();
378

379
        // Compute seq_hashes only if scheduler needs it for active blocks tracking
380
381
382
383
384
385
386
        let maybe_seq_hashes = tracing::info_span!("kv_router.compute_seq_hashes").in_scope(|| {
            self.kv_router_config.compute_seq_hashes_for_tracking(
                tokens,
                self.block_size,
                router_config_override,
            )
        });
387
        let seq_hash_elapsed = start.elapsed();
388

Yan Ru Pei's avatar
Yan Ru Pei committed
389
        let best_worker = self
390
            .scheduler
391
            .schedule(
Yan Ru Pei's avatar
Yan Ru Pei committed
392
                context_id.map(|s| s.to_string()),
393
                isl_tokens,
394
                maybe_seq_hashes,
395
                overlap_scores.clone(),
396
                router_config_override,
397
                update_states,
398
                lora_name,
399
                priority_jump,
400
            )
401
            .instrument(tracing::info_span!("kv_router.schedule"))
402
            .await?;
403
404
405
406
407
408
409
410
        let total_elapsed = start.elapsed();

        metrics::ROUTING_OVERHEAD_METRICS.observe(
            hash_elapsed,
            find_matches_elapsed,
            seq_hash_elapsed,
            total_elapsed,
        );
411

412
        #[cfg(feature = "bench")]
413
414
415
416
417
418
419
420
421
        tracing::info!(
            isl_tokens,
            hash_us = hash_elapsed.as_micros() as u64,
            find_matches_us = (find_matches_elapsed - hash_elapsed).as_micros() as u64,
            seq_hash_us = (seq_hash_elapsed - find_matches_elapsed).as_micros() as u64,
            schedule_us = (total_elapsed - seq_hash_elapsed).as_micros() as u64,
            total_us = total_elapsed.as_micros() as u64,
            "find_best_match completed"
        );
422

423
424
        // Note: Routing decision recording (for approximate mode) is now handled
        // by KvPushRouter::generate after select_worker returns.
425

426
427
        let overlap_amount = overlap_scores
            .scores
Yan Ru Pei's avatar
Yan Ru Pei committed
428
            .get(&best_worker)
429
430
            .copied()
            .unwrap_or(0);
Yan Ru Pei's avatar
Yan Ru Pei committed
431
        Ok((best_worker, overlap_amount))
432
433
    }

434
    #[allow(clippy::too_many_arguments)]
435
436
437
438
439
    pub async fn add_request(
        &self,
        request_id: String,
        tokens: &[u32],
        overlap_blocks: u32,
440
        expected_output_tokens: Option<u32>,
Yan Ru Pei's avatar
Yan Ru Pei committed
441
        worker: WorkerWithDpRank,
442
        lora_name: Option<String>,
443
        router_config_override: Option<&RouterConfigOverride>,
444
445
    ) {
        let isl_tokens = tokens.len();
446

447
448
449
450
451
        let maybe_seq_hashes = self.kv_router_config.compute_seq_hashes_for_tracking(
            tokens,
            self.block_size,
            router_config_override,
        );
452

453
454
        if let Err(e) = self
            .scheduler
455
456
457
458
459
            .add_request(SequenceRequest {
                request_id: request_id.clone(),
                token_sequence: maybe_seq_hashes,
                isl: isl_tokens,
                overlap: overlap_blocks,
460
                expected_output_tokens,
Yan Ru Pei's avatar
Yan Ru Pei committed
461
                worker,
462
                lora_name,
463
            })
464
465
466
467
            .await
        {
            tracing::warn!("Failed to add request {request_id}: {e}");
        }
468
469
    }

470
    pub async fn mark_prefill_completed(&self, request_id: &str) -> Result<(), SequenceError> {
471
        self.scheduler.mark_prefill_completed(request_id).await
472
473
    }

474
    pub async fn free(&self, request_id: &str) -> Result<(), SequenceError> {
475
        self.scheduler.free(request_id).await
476
    }
477

478
479
480
481
482
483
    /// Get the worker type for this router ("prefill" or "decode").
    /// Used for Prometheus metric labeling.
    pub fn worker_type(&self) -> &'static str {
        self.scheduler.worker_type()
    }

484
485
486
487
488
489
490
491
492
493
    pub async fn add_output_block(
        &self,
        request_id: &str,
        decay_fraction: Option<f64>,
    ) -> Result<(), SequenceError> {
        self.scheduler
            .add_output_block(request_id, decay_fraction)
            .await
    }

494
    pub fn block_size(&self) -> u32 {
495
496
        self.block_size
    }
497

498
499
500
501
502
503
504
505
506
507
508
509
    /// Compute the overlap blocks for a given token sequence and worker.
    /// This queries the indexer to find how many blocks are already cached.
    pub async fn get_overlap_blocks(
        &self,
        tokens: &[u32],
        worker: WorkerWithDpRank,
    ) -> Result<u32, KvRouterError> {
        let block_hashes = compute_block_hash_for_seq(tokens, self.block_size, None);
        let overlap_scores = self.indexer.find_matches(block_hashes).await?;
        Ok(overlap_scores.scores.get(&worker).copied().unwrap_or(0))
    }

510
    /// Get potential prefill and decode loads for all workers
511
512
513
514
515
    pub async fn get_potential_loads(
        &self,
        tokens: &[u32],
        router_config_override: Option<&RouterConfigOverride>,
    ) -> Result<Vec<PotentialLoad>> {
516
        let isl_tokens = tokens.len();
517
        let block_hashes = compute_block_hash_for_seq(tokens, self.block_size, None);
518
        let overlap_scores = self.indexer.find_matches(block_hashes.clone()).await?;
519

520
521
522
523
524
        let maybe_seq_hashes = self.kv_router_config.compute_seq_hashes_for_tracking(
            tokens,
            self.block_size,
            router_config_override,
        );
525

526
527
        Ok(self
            .scheduler
528
            .get_potential_loads(maybe_seq_hashes, isl_tokens, overlap_scores)
529
530
531
            .await)
    }

532
533
534
535
    /// Dump all events from the indexer
    pub async fn dump_events(&self) -> Result<Vec<RouterEvent>, KvRouterError> {
        self.indexer.dump_events().await
    }
536
537
}

Michael Feil's avatar
Michael Feil committed
538
539
// NOTE: KVRouter works like a PushRouter,
// but without the reverse proxy functionality, but based on contract of 3 request types
540
541
542
543
544
545
546
#[async_trait]
impl AsyncEngine<SingleIn<RouterRequest>, ManyOut<Annotated<RouterResponse>>, Error> for KvRouter {
    async fn generate(
        &self,
        request: SingleIn<RouterRequest>,
    ) -> Result<ManyOut<Annotated<RouterResponse>>> {
        let (request, ctx) = request.into_parts();
Michael Feil's avatar
Michael Feil committed
547
548
549
        let context_id = ctx.context().id().to_string();
        // Handle different request types
        let response = match request {
550
551
552
553
            RouterRequest::New {
                tokens,
                block_mm_infos,
            } => {
Yan Ru Pei's avatar
Yan Ru Pei committed
554
                let (best_worker, overlap_blocks) = self
555
556
557
558
559
560
561
562
563
                    .find_best_match(
                        Some(&context_id),
                        &tokens,
                        block_mm_infos.as_deref(),
                        None,
                        true,
                        None,
                        0.0,
                    )
Michael Feil's avatar
Michael Feil committed
564
565
566
                    .await?;

                RouterResponse::New {
Yan Ru Pei's avatar
Yan Ru Pei committed
567
568
                    worker_id: best_worker.worker_id,
                    dp_rank: best_worker.dp_rank,
Michael Feil's avatar
Michael Feil committed
569
570
571
                    overlap_blocks,
                }
            }
572
573
574
575
576
577
            RouterRequest::MarkPrefill => RouterResponse::PrefillMarked {
                success: self.mark_prefill_completed(&context_id).await.is_ok(),
            },
            RouterRequest::MarkFree => RouterResponse::FreeMarked {
                success: self.free(&context_id).await.is_ok(),
            },
Michael Feil's avatar
Michael Feil committed
578
        };
579
580
581
582
583
584

        let response = Annotated::from_data(response);
        let stream = stream::iter(vec![response]);
        Ok(ResponseStream::new(Box::pin(stream), ctx.context()))
    }
}
585

Yan Ru Pei's avatar
Yan Ru Pei committed
586
587
588
589
590
591
impl Drop for KvRouter {
    fn drop(&mut self) {
        tracing::info!("Dropping KvRouter - cancelling background tasks");
        self.cancellation_token.cancel();
    }
}