kv_router.rs 19.8 KB
Newer Older
1
// SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2
3
// SPDX-License-Identifier: Apache-2.0

4
use std::collections::HashMap;
Yan Ru Pei's avatar
Yan Ru Pei committed
5
use std::sync::Arc;
6
use std::time::{Duration, Instant};
7

8
use anyhow::Result;
Yan Ru Pei's avatar
Yan Ru Pei committed
9
use dynamo_kv_router::{ConcurrentRadixTree, ThreadPoolIndexer};
10
use dynamo_runtime::{
11
    component::{Client, Endpoint},
12
    discovery::DiscoveryQuery,
13
    pipeline::{
14
15
        AsyncEngine, AsyncEngineContextProvider, Error, ManyOut, ResponseStream, SingleIn,
        async_trait,
16
    },
17
    protocols::EndpointId,
18
    protocols::annotated::Annotated,
19
    traits::DistributedRuntimeProvider,
20
};
21
use futures::stream;
Yan Ru Pei's avatar
Yan Ru Pei committed
22
use tokio::sync::oneshot;
23
use validator::Validate;
24

25
26
27
28
29
// Re-export from dynamo-kv-router crate
pub use dynamo_kv_router::approx;
pub use dynamo_kv_router::indexer;
pub use dynamo_kv_router::protocols;

30
pub mod config;
31
pub mod metrics;
32
pub mod prefill_router;
33
pub mod publisher;
34
pub mod push_router;
35
pub mod queue;
36
pub mod recorder;
37
pub mod scheduler;
38
pub mod sequence;
39
pub mod subscriber;
40
pub mod worker_query;
41

42
pub use config::{KvRouterConfig, RouterConfigOverride};
43
pub use prefill_router::PrefillRouter;
44
pub use push_router::{DirectRoutingRouter, KvPushRouter};
45

46
use crate::{
47
    discovery::RuntimeConfigWatch,
48
    kv_router::{
49
        approx::PruneConfig,
Yan Ru Pei's avatar
Yan Ru Pei committed
50
        indexer::{GetWorkersRequest, KvIndexer, KvIndexerInterface, KvRouterError},
Yan Ru Pei's avatar
Yan Ru Pei committed
51
        protocols::{
52
            DpRank, LocalBlockHash, OverlapScores, RouterEvent, RouterRequest, RouterResponse,
Yan Ru Pei's avatar
Yan Ru Pei committed
53
54
            TokensWithHashes, WorkerId, WorkerSelectionResult, WorkerWithDpRank,
            compute_block_hash_for_seq,
Yan Ru Pei's avatar
Yan Ru Pei committed
55
        },
56
        scheduler::{KvScheduler, KvSchedulerError, PotentialLoad, SchedulingRequest},
57
        sequence::{SequenceError, SequenceRequest},
58
    },
59
    local_model::runtime_config::ModelRuntimeConfig,
60
61
};

62
63
// [gluo TODO] shouldn't need to be public
// this should be discovered from the component
64
65
66
67
68

// for metric scraping (pull-based)
pub const KV_METRICS_ENDPOINT: &str = "load_metrics";

// for metric publishing (push-based)
69
pub const KV_EVENT_SUBJECT: &str = "kv-events";
70
71
72
73
74
pub const KV_METRICS_SUBJECT: &str = "kv_metrics";

// for inter-router comms
pub const PREFILL_SUBJECT: &str = "prefill_events";
pub const ACTIVE_SEQUENCES_SUBJECT: &str = "active_sequences_events";
75

76
77
78
79
// for radix tree snapshot storage
pub const RADIX_STATE_BUCKET: &str = "radix-bucket";
pub const RADIX_STATE_FILE: &str = "radix-state";

80
81
82
// for worker-local kvindexer query
pub const WORKER_KV_INDEXER_BUFFER_SIZE: usize = 1024; // store 1024 most recent events in worker buffer

83
84
85
86
87
88
/// Generates a dp_rank-specific endpoint name for the worker KV indexer query service.
/// Each dp_rank has its own LocalKvIndexer and query endpoint to ensure per-dp_rank monotonicity.
pub fn worker_kv_indexer_query_endpoint(dp_rank: DpRank) -> String {
    format!("worker_kv_indexer_query_dp{dp_rank}")
}

89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
// for router discovery registration
pub const KV_ROUTER_COMPONENT: &str = "kv-router";
pub const KV_ROUTER_ENDPOINT: &str = "generate";

/// Creates an EndpointId for the KV router in the given namespace.
pub fn router_endpoint_id(namespace: String) -> EndpointId {
    EndpointId {
        namespace,
        component: KV_ROUTER_COMPONENT.to_string(),
        name: KV_ROUTER_ENDPOINT.to_string(),
    }
}

/// Creates a DiscoveryQuery for the KV router in the given namespace.
pub fn router_discovery_query(namespace: String) -> DiscoveryQuery {
    DiscoveryQuery::Endpoint {
        namespace,
        component: KV_ROUTER_COMPONENT.to_string(),
        endpoint: KV_ROUTER_ENDPOINT.to_string(),
    }
}

111
112
113
114
/// A trait that users can implement to define custom selection logic
pub trait WorkerSelector {
    fn select_worker(
        &self,
115
        workers: &HashMap<protocols::WorkerId, ModelRuntimeConfig>,
116
        request: &SchedulingRequest,
117
        block_size: u32,
118
119
    ) -> Result<WorkerSelectionResult, KvSchedulerError>;
}
120

Yan Ru Pei's avatar
Yan Ru Pei committed
121
#[derive(Clone)]
122
pub enum Indexer {
Yan Ru Pei's avatar
Yan Ru Pei committed
123
    /// Single-threaded radix tree with channel-based event processing.
124
    /// Supports TTL-based expiration and size-based pruning.
125
    /// Has the ability to persist and snapshot states.
126
    KvIndexer(KvIndexer),
127

Yan Ru Pei's avatar
Yan Ru Pei committed
128
129
130
131
132
    /// Concurrent radix tree with a thread pool for event processing.
    /// Uses sticky worker routing for per-worker event serialization.
    /// Does not support TTL/pruning.
    Concurrent(Arc<ThreadPoolIndexer<ConcurrentRadixTree>>),

133
134
135
    /// Used when we do not wish to use the indexer at all (e.g., when overlap_score_weight is 0).
    /// Note: This will cause KV events to accumulate in JetStream as we do not regularly purge them.
    None,
136
137
138
}

impl Indexer {
139
140
141
142
143
144
145
    pub fn new(
        component: &dynamo_runtime::component::Component,
        kv_router_config: &KvRouterConfig,
        block_size: u32,
        cancellation_token: tokio_util::sync::CancellationToken,
    ) -> Self {
        if kv_router_config.overlap_score_weight == 0.0 {
Yan Ru Pei's avatar
Yan Ru Pei committed
146
147
148
149
150
151
152
            return Indexer::None;
        }

        if kv_router_config.router_event_threads > 1 {
            return Indexer::Concurrent(Arc::new(ThreadPoolIndexer::new(
                ConcurrentRadixTree::new(),
                kv_router_config.router_event_threads as usize,
153
                block_size,
Yan Ru Pei's avatar
Yan Ru Pei committed
154
            )));
155
        }
Yan Ru Pei's avatar
Yan Ru Pei committed
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176

        let kv_indexer_metrics = indexer::KvIndexerMetrics::from_component(component);

        // If use_kv_events is false, enable TTL and pruning for approximate behavior
        let prune_config = if !kv_router_config.use_kv_events {
            Some(PruneConfig {
                ttl: Duration::from_secs_f64(kv_router_config.router_ttl_secs),
                max_tree_size: kv_router_config.router_max_tree_size,
                prune_target_ratio: kv_router_config.router_prune_target_ratio,
            })
        } else {
            None
        };

        Indexer::KvIndexer(KvIndexer::new_with_frequency(
            cancellation_token,
            None, // expiration_duration for frequency tracking
            block_size,
            kv_indexer_metrics,
            prune_config,
        ))
177
178
179
    }

    pub(crate) async fn find_matches(
180
181
182
183
184
        &self,
        sequence: Vec<LocalBlockHash>,
    ) -> Result<OverlapScores, KvRouterError> {
        match self {
            Indexer::KvIndexer(indexer) => indexer.find_matches(sequence).await,
Yan Ru Pei's avatar
Yan Ru Pei committed
185
            Indexer::Concurrent(tpi) => tpi.find_matches(sequence).await,
186
187
188
            Indexer::None => Ok(OverlapScores {
                scores: HashMap::new(),
                frequencies: Vec::new(),
189
                tree_sizes: HashMap::new(),
190
            }),
191
192
        }
    }
193

194
    pub(crate) async fn dump_events(&self) -> Result<Vec<RouterEvent>, KvRouterError> {
195
196
        match self {
            Indexer::KvIndexer(indexer) => indexer.dump_events().await,
Yan Ru Pei's avatar
Yan Ru Pei committed
197
            Indexer::Concurrent(tpi) => tpi.dump_events().await,
198
199
200
201
202
            Indexer::None => {
                panic!(
                    "Cannot dump events: indexer does not exist (is overlap_score_weight set to 0?)"
                );
            }
203
204
        }
    }
205

206
    pub(crate) async fn process_routing_decision_for_request(
207
        &self,
208
        tokens_with_hashes: &mut TokensWithHashes,
209
210
211
212
213
        worker: WorkerWithDpRank,
    ) -> Result<(), KvRouterError> {
        match self {
            Indexer::KvIndexer(indexer) => {
                indexer
214
                    .process_routing_decision_for_request(tokens_with_hashes, worker)
215
216
                    .await
            }
Yan Ru Pei's avatar
Yan Ru Pei committed
217
218
219
220
            Indexer::Concurrent(tpi) => {
                tpi.process_routing_decision_for_request(tokens_with_hashes, worker)
                    .await
            }
221
222
223
            Indexer::None => Ok(()),
        }
    }
Yan Ru Pei's avatar
Yan Ru Pei committed
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265

    pub(crate) async fn apply_event(&self, event: RouterEvent) {
        match self {
            Indexer::KvIndexer(indexer) => {
                if let Err(e) = indexer.event_sender().send(event).await {
                    tracing::warn!("Failed to send event to indexer: {e}");
                }
            }
            Indexer::Concurrent(tpi) => tpi.apply_event(event).await,
            Indexer::None => {}
        }
    }

    pub(crate) async fn remove_worker(&self, worker_id: WorkerId) {
        match self {
            Indexer::KvIndexer(indexer) => {
                if let Err(e) = indexer.remove_worker_sender().send(worker_id).await {
                    tracing::warn!("Failed to send worker removal for {worker_id}: {e}");
                }
            }
            Indexer::Concurrent(tpi) => {
                KvIndexerInterface::remove_worker(tpi.as_ref(), worker_id).await;
            }
            Indexer::None => {}
        }
    }

    pub(crate) async fn get_workers(&self) -> Vec<WorkerId> {
        match self {
            Indexer::KvIndexer(indexer) => {
                let (resp_tx, resp_rx) = oneshot::channel();
                let req = GetWorkersRequest { resp: resp_tx };
                if let Err(e) = indexer.get_workers_sender().send(req).await {
                    tracing::warn!("Failed to send get_workers request: {e}");
                    return Vec::new();
                }
                resp_rx.await.unwrap_or_default()
            }
            Indexer::Concurrent(tpi) => tpi.backend().get_workers(),
            Indexer::None => Vec::new(),
        }
    }
266
267
}

268
269
/// A KvRouter only decides which worker you should use. It doesn't send you there.
/// TODO: Rename this to indicate it only selects a worker, it does not route.
270
pub struct KvRouter {
271
    indexer: Indexer,
272
    scheduler: KvScheduler,
273
    block_size: u32,
274
    kv_router_config: KvRouterConfig,
Yan Ru Pei's avatar
Yan Ru Pei committed
275
    cancellation_token: tokio_util::sync::CancellationToken,
276
    client: Client,
277
278
279
}

impl KvRouter {
280
    #[allow(clippy::too_many_arguments)]
281
    pub async fn new(
282
283
        endpoint: Endpoint,
        client: Client,
284
        mut workers_with_configs: RuntimeConfigWatch,
285
        block_size: u32,
286
        selector: Option<Box<dyn WorkerSelector + Send + Sync>>,
287
        kv_router_config: Option<KvRouterConfig>,
288
        router_id: u64,
289
        worker_type: &'static str,
290
    ) -> Result<Self> {
291
        let kv_router_config = kv_router_config.unwrap_or_default();
292
        kv_router_config.validate()?;
293
        let component = endpoint.component();
294
        let cancellation_token = component.drt().primary_token();
295

296
297
298
299
300
301
        let indexer = Indexer::new(
            component,
            &kv_router_config,
            block_size,
            cancellation_token.clone(),
        );
302

303
        // Wait for at least one worker with a known runtime config before starting scheduler
304
305
306
307
308
309
        let _ = workers_with_configs
            .wait_for(|m| !m.is_empty())
            .await
            .map_err(|_| {
                anyhow::anyhow!("runtime config watch closed before any workers appeared")
            })?;
310

311
        let scheduler = KvScheduler::start(
312
            component.clone(),
313
            block_size,
314
            workers_with_configs.clone(),
315
            selector,
316
            kv_router_config.router_replica_sync,
317
            router_id,
318
            worker_type,
319
            kv_router_config.router_queue_threshold,
320
321
        )
        .await?;
322

323
324
325
326
327
328
        // Start KV event subscription if needed (use_kv_events=true and overlap_score_weight>0)
        if kv_router_config.should_subscribe_to_kv_events() {
            subscriber::start_subscriber(
                component.clone(),
                &kv_router_config,
                router_id,
Yan Ru Pei's avatar
Yan Ru Pei committed
329
                indexer.clone(),
330
331
332
333
                cancellation_token.clone(),
            )
            .await?;
        } else {
334
            tracing::info!(
335
336
337
                "Skipping KV event subscription (use_kv_events={}, overlap_score_weight={})",
                kv_router_config.use_kv_events,
                kv_router_config.overlap_score_weight,
338
            );
339
        }
340

341
        tracing::info!("KV Routing initialized");
342
        Ok(Self {
343
            indexer,
344
            scheduler,
345
            block_size,
346
            kv_router_config,
Yan Ru Pei's avatar
Yan Ru Pei committed
347
            cancellation_token,
348
            client,
349
        })
350
351
    }

352
353
354
355
356
    /// Get a reference to the client used by this KvRouter
    pub fn client(&self) -> &Client {
        &self.client
    }

357
358
359
360
361
362
363
364
    pub fn indexer(&self) -> &Indexer {
        &self.indexer
    }

    pub fn kv_router_config(&self) -> &KvRouterConfig {
        &self.kv_router_config
    }

365
    /// Give these tokens, find the worker with the best match in it's KV cache.
Yan Ru Pei's avatar
Yan Ru Pei committed
366
    /// Returns the best worker (with dp_rank) and overlap amount in number of blocks.
Yan Ru Pei's avatar
Yan Ru Pei committed
367
    /// Now also takes optional context_id for request tracking
368
    #[allow(clippy::too_many_arguments)]
Yan Ru Pei's avatar
Yan Ru Pei committed
369
    pub async fn find_best_match(
370
        &self,
Yan Ru Pei's avatar
Yan Ru Pei committed
371
        context_id: Option<&str>,
372
        tokens: &[u32],
373
        router_config_override: Option<&RouterConfigOverride>,
374
        update_states: bool,
375
        lora_name: Option<String>,
376
        priority_jump: f64,
Yan Ru Pei's avatar
Yan Ru Pei committed
377
    ) -> anyhow::Result<(WorkerWithDpRank, u32)> {
378
379
        let start = Instant::now();

Yan Ru Pei's avatar
Yan Ru Pei committed
380
        if update_states && context_id.is_none() {
381
            anyhow::bail!("context_id must be provided when update_states is true");
Yan Ru Pei's avatar
Yan Ru Pei committed
382
383
        }

384
        let isl_tokens = tokens.len();
385

386
        let block_hashes = compute_block_hash_for_seq(tokens, self.block_size, None);
387
        let hash_elapsed = start.elapsed();
388

389
        let overlap_scores = self.indexer.find_matches(block_hashes).await?;
390
        let find_matches_elapsed = start.elapsed();
391

392
        // Compute seq_hashes only if scheduler needs it for active blocks tracking
393
394
395
396
397
        let maybe_seq_hashes = self.kv_router_config.compute_seq_hashes_for_tracking(
            tokens,
            self.block_size,
            router_config_override,
        );
398
        let seq_hash_elapsed = start.elapsed();
399

Yan Ru Pei's avatar
Yan Ru Pei committed
400
        let best_worker = self
401
            .scheduler
402
            .schedule(
Yan Ru Pei's avatar
Yan Ru Pei committed
403
                context_id.map(|s| s.to_string()),
404
                isl_tokens,
405
                maybe_seq_hashes,
406
                overlap_scores.clone(),
407
                router_config_override,
408
                update_states,
409
                lora_name,
410
                priority_jump,
411
            )
412
            .await?;
413
414
415
416
417
418
419
420
        let total_elapsed = start.elapsed();

        metrics::ROUTING_OVERHEAD_METRICS.observe(
            hash_elapsed,
            find_matches_elapsed,
            seq_hash_elapsed,
            total_elapsed,
        );
421

422
        #[cfg(feature = "bench")]
423
424
425
426
427
428
429
430
431
        tracing::info!(
            isl_tokens,
            hash_us = hash_elapsed.as_micros() as u64,
            find_matches_us = (find_matches_elapsed - hash_elapsed).as_micros() as u64,
            seq_hash_us = (seq_hash_elapsed - find_matches_elapsed).as_micros() as u64,
            schedule_us = (total_elapsed - seq_hash_elapsed).as_micros() as u64,
            total_us = total_elapsed.as_micros() as u64,
            "find_best_match completed"
        );
432

433
434
        // Note: Routing decision recording (for approximate mode) is now handled
        // by KvPushRouter::generate after select_worker returns.
435

436
437
        let overlap_amount = overlap_scores
            .scores
Yan Ru Pei's avatar
Yan Ru Pei committed
438
            .get(&best_worker)
439
440
            .copied()
            .unwrap_or(0);
Yan Ru Pei's avatar
Yan Ru Pei committed
441
        Ok((best_worker, overlap_amount))
442
443
    }

444
    #[allow(clippy::too_many_arguments)]
445
446
447
448
449
    pub async fn add_request(
        &self,
        request_id: String,
        tokens: &[u32],
        overlap_blocks: u32,
450
        expected_output_tokens: Option<u32>,
Yan Ru Pei's avatar
Yan Ru Pei committed
451
        worker: WorkerWithDpRank,
452
        lora_name: Option<String>,
453
        router_config_override: Option<&RouterConfigOverride>,
454
455
    ) {
        let isl_tokens = tokens.len();
456

457
458
459
460
461
        let maybe_seq_hashes = self.kv_router_config.compute_seq_hashes_for_tracking(
            tokens,
            self.block_size,
            router_config_override,
        );
462

463
464
        if let Err(e) = self
            .scheduler
465
466
467
468
469
            .add_request(SequenceRequest {
                request_id: request_id.clone(),
                token_sequence: maybe_seq_hashes,
                isl: isl_tokens,
                overlap: overlap_blocks,
470
                expected_output_tokens,
Yan Ru Pei's avatar
Yan Ru Pei committed
471
                worker,
472
                lora_name,
473
            })
474
475
476
477
            .await
        {
            tracing::warn!("Failed to add request {request_id}: {e}");
        }
478
479
    }

480
    pub async fn mark_prefill_completed(&self, request_id: &str) -> Result<(), SequenceError> {
481
        self.scheduler.mark_prefill_completed(request_id).await
482
483
    }

484
    pub async fn free(&self, request_id: &str) -> Result<(), SequenceError> {
485
        self.scheduler.free(request_id).await
486
    }
487

488
489
490
491
492
493
    /// Get the worker type for this router ("prefill" or "decode").
    /// Used for Prometheus metric labeling.
    pub fn worker_type(&self) -> &'static str {
        self.scheduler.worker_type()
    }

494
495
496
497
498
499
500
501
502
503
    pub async fn add_output_block(
        &self,
        request_id: &str,
        decay_fraction: Option<f64>,
    ) -> Result<(), SequenceError> {
        self.scheduler
            .add_output_block(request_id, decay_fraction)
            .await
    }

504
    pub fn block_size(&self) -> u32 {
505
506
        self.block_size
    }
507

508
509
510
511
512
513
514
515
516
517
518
519
    /// Compute the overlap blocks for a given token sequence and worker.
    /// This queries the indexer to find how many blocks are already cached.
    pub async fn get_overlap_blocks(
        &self,
        tokens: &[u32],
        worker: WorkerWithDpRank,
    ) -> Result<u32, KvRouterError> {
        let block_hashes = compute_block_hash_for_seq(tokens, self.block_size, None);
        let overlap_scores = self.indexer.find_matches(block_hashes).await?;
        Ok(overlap_scores.scores.get(&worker).copied().unwrap_or(0))
    }

520
    /// Get potential prefill and decode loads for all workers
521
522
523
524
525
    pub async fn get_potential_loads(
        &self,
        tokens: &[u32],
        router_config_override: Option<&RouterConfigOverride>,
    ) -> Result<Vec<PotentialLoad>> {
526
        let isl_tokens = tokens.len();
527
        let block_hashes = compute_block_hash_for_seq(tokens, self.block_size, None);
528
        let overlap_scores = self.indexer.find_matches(block_hashes.clone()).await?;
529

530
531
532
533
534
        let maybe_seq_hashes = self.kv_router_config.compute_seq_hashes_for_tracking(
            tokens,
            self.block_size,
            router_config_override,
        );
535

536
537
        Ok(self
            .scheduler
538
            .get_potential_loads(maybe_seq_hashes, isl_tokens, overlap_scores)
539
540
541
            .await)
    }

542
543
544
545
    /// Dump all events from the indexer
    pub async fn dump_events(&self) -> Result<Vec<RouterEvent>, KvRouterError> {
        self.indexer.dump_events().await
    }
546
547
}

Michael Feil's avatar
Michael Feil committed
548
549
// NOTE: KVRouter works like a PushRouter,
// but without the reverse proxy functionality, but based on contract of 3 request types
550
551
552
553
554
555
556
#[async_trait]
impl AsyncEngine<SingleIn<RouterRequest>, ManyOut<Annotated<RouterResponse>>, Error> for KvRouter {
    async fn generate(
        &self,
        request: SingleIn<RouterRequest>,
    ) -> Result<ManyOut<Annotated<RouterResponse>>> {
        let (request, ctx) = request.into_parts();
Michael Feil's avatar
Michael Feil committed
557
558
559
        let context_id = ctx.context().id().to_string();
        // Handle different request types
        let response = match request {
560
            RouterRequest::New { tokens } => {
Yan Ru Pei's avatar
Yan Ru Pei committed
561
                let (best_worker, overlap_blocks) = self
562
                    .find_best_match(Some(&context_id), &tokens, None, true, None, 0.0)
Michael Feil's avatar
Michael Feil committed
563
564
565
                    .await?;

                RouterResponse::New {
Yan Ru Pei's avatar
Yan Ru Pei committed
566
567
                    worker_id: best_worker.worker_id,
                    dp_rank: best_worker.dp_rank,
Michael Feil's avatar
Michael Feil committed
568
569
570
                    overlap_blocks,
                }
            }
571
572
573
574
575
576
            RouterRequest::MarkPrefill => RouterResponse::PrefillMarked {
                success: self.mark_prefill_completed(&context_id).await.is_ok(),
            },
            RouterRequest::MarkFree => RouterResponse::FreeMarked {
                success: self.free(&context_id).await.is_ok(),
            },
Michael Feil's avatar
Michael Feil committed
577
        };
578
579
580
581
582
583

        let response = Annotated::from_data(response);
        let stream = stream::iter(vec![response]);
        Ok(ResponseStream::new(Box::pin(stream), ctx.context()))
    }
}
584

Yan Ru Pei's avatar
Yan Ru Pei committed
585
586
587
588
589
590
impl Drop for KvRouter {
    fn drop(&mut self) {
        tracing::info!("Dropping KvRouter - cancelling background tasks");
        self.cancellation_token.cancel();
    }
}