component.rs 22.2 KB
Newer Older
1
2
// SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0
Ryan Olson's avatar
Ryan Olson committed
3
4
5

//! The [Component] module defines the top-level API for building distributed applications.
//!
Graham King's avatar
Graham King committed
6
7
8
//! A distributed application consists of a set of [Component] that can host one
//! or more [Endpoint]. Each [Endpoint] is a network-accessible service
//! that can be accessed by other [Component] in the distributed application.
Ryan Olson's avatar
Ryan Olson committed
9
10
11
12
//!
//! A [Component] is made discoverable by registering it with the distributed runtime under
//! a [`Namespace`].
//!
Graham King's avatar
Graham King committed
13
//! A [`Namespace`] is a logical grouping of [Component] that are grouped together.
Ryan Olson's avatar
Ryan Olson committed
14
15
16
17
18
19
20
21
22
23
24
25
//!
//! We might extend namespace to include grouping behavior, which would define groups of
//! components that are tightly coupled.
//!
//! A [Component] is the core building block of a distributed application. It is a logical
//! unit of work such as a `Preprocessor` or `SmartRouter` that has a well-defined role in the
//! distributed application.
//!
//! A [Component] can present to the distributed application one or more configuration files
//! which define how that component was constructed/configured and what capabilities it can
//! provide.
//!
Graham King's avatar
Graham King committed
26
//! Other [Component] can write to watching locations within a [Component] etcd
Ryan Olson's avatar
Ryan Olson committed
27
28
29
30
31
//! path. This allows the [Component] to take dynamic actions depending on the watch
//! triggers.
//!
//! TODO: Top-level Overview of Endpoints/Functions

32
use crate::{
33
34
    config::HealthStatus,
    discovery::Lease,
35
    metrics::{MetricsRegistry, prometheus_names},
36
    service::ServiceSet,
37
    transports::etcd::EtcdPath,
38
};
Ryan Olson's avatar
Ryan Olson committed
39

Ryan Olson's avatar
Ryan Olson committed
40
use super::{
41
    DistributedRuntime, Result, Runtime, error,
42
43
44
45
    traits::*,
    transports::etcd::{COMPONENT_KEYWORD, ENDPOINT_KEYWORD},
    transports::nats::Slug,
    utils::Duration,
Ryan Olson's avatar
Ryan Olson committed
46
};
Ryan Olson's avatar
Ryan Olson committed
47

48
use crate::pipeline::network::{PushWorkHandler, ingress::push_endpoint::PushEndpoint};
49
use crate::protocols::EndpointId;
50
use crate::service::ComponentNatsServerPrometheusMetrics;
Ryan Olson's avatar
Ryan Olson committed
51
52
53
54
55
56
57
58
use async_nats::{
    rustls::quic,
    service::{Service, ServiceExt},
};
use derive_builder::Builder;
use derive_getters::Getters;
use educe::Educe;
use serde::{Deserialize, Serialize};
59
use service::EndpointStatsHandler;
60
use std::{collections::HashMap, hash::Hash, sync::Arc};
Ryan Olson's avatar
Ryan Olson committed
61
62
63
use validator::{Validate, ValidationError};

mod client;
64
65
#[allow(clippy::module_inception)]
mod component;
Ryan Olson's avatar
Ryan Olson committed
66
mod endpoint;
Ryan Olson's avatar
Ryan Olson committed
67
mod namespace;
Ryan Olson's avatar
Ryan Olson committed
68
mod registry;
69
pub mod service;
Ryan Olson's avatar
Ryan Olson committed
70

71
72
73
74
75
76
pub use client::{Client, InstanceSource};

/// The root etcd path where each instance registers itself in etcd.
/// An instance is namespace+component+endpoint+lease_id and must be unique.
pub const INSTANCE_ROOT_PATH: &str = "instances";

77
78
79
/// The root etcd path where each namespace is registered in etcd.
pub const ETCD_ROOT_PATH: &str = "dynamo://";

Ryan Olson's avatar
Ryan Olson committed
80
81
82
83
84
85
#[derive(Debug, Clone, Serialize, Deserialize, Eq, PartialEq)]
#[serde(rename_all = "snake_case")]
pub enum TransportType {
    NatsTcp(String),
}

86
87
88
89
90
91
#[derive(Default)]
pub struct RegistryInner {
    services: HashMap<String, Service>,
    stats_handlers: HashMap<String, Arc<std::sync::Mutex<HashMap<String, EndpointStatsHandler>>>>,
}

Ryan Olson's avatar
Ryan Olson committed
92
93
#[derive(Clone)]
pub struct Registry {
94
    inner: Arc<tokio::sync::Mutex<RegistryInner>>,
Ryan Olson's avatar
Ryan Olson committed
95
96
97
}

#[derive(Debug, Clone, Serialize, Deserialize)]
98
pub struct Instance {
Ryan Olson's avatar
Ryan Olson committed
99
100
101
    pub component: String,
    pub endpoint: String,
    pub namespace: String,
102
    pub instance_id: i64,
Ryan Olson's avatar
Ryan Olson committed
103
104
105
    pub transport: TransportType,
}

106
impl Instance {
107
    pub fn id(&self) -> i64 {
108
        self.instance_id
109
    }
110
111
112
113
114
115
116
    pub fn endpoint_id(&self) -> EndpointId {
        EndpointId {
            namespace: self.namespace.clone(),
            component: self.component.clone(),
            name: self.endpoint.clone(),
        }
    }
117
118
}

Ryan Olson's avatar
Ryan Olson committed
119
/// A [Component] a discoverable entity in the distributed runtime.
Graham King's avatar
Graham King committed
120
121
/// You can host [Endpoint] on a [Component] by first creating
/// a [Service] then adding one or more [Endpoint] to the [Service].
Ryan Olson's avatar
Ryan Olson committed
122
123
///
/// You can also issue a request to a [Component]'s [Endpoint] by creating a [Client].
124
#[derive(Educe, Builder, Clone, Validate)]
Ryan Olson's avatar
Ryan Olson committed
125
126
127
128
129
#[educe(Debug)]
#[builder(pattern = "owned")]
pub struct Component {
    #[builder(private)]
    #[educe(Debug(ignore))]
130
    drt: Arc<DistributedRuntime>,
Ryan Olson's avatar
Ryan Olson committed
131
132
133
134

    // todo - restrict the namespace to a-z0-9-_A-Z
    /// Name of the component
    #[builder(setter(into))]
135
    #[validate(custom(function = "validate_allowed_chars"))]
Ryan Olson's avatar
Ryan Olson committed
136
137
    name: String,

138
139
140
141
    /// Additional labels for metrics
    #[builder(default = "Vec::new()")]
    labels: Vec<(String, String)>,

Ryan Olson's avatar
Ryan Olson committed
142
143
144
    // todo - restrict the namespace to a-z0-9-_A-Z
    /// Namespace
    #[builder(setter(into))]
145
    namespace: Namespace,
146
147
148
149

    // A static component's endpoints cannot be discovered via etcd, they are
    // fixed at startup time.
    is_static: bool,
Ryan Olson's avatar
Ryan Olson committed
150
151
}

152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
impl Hash for Component {
    fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
        self.namespace.name().hash(state);
        self.name.hash(state);
        self.is_static.hash(state);
    }
}

impl PartialEq for Component {
    fn eq(&self, other: &Self) -> bool {
        self.namespace.name() == other.namespace.name()
            && self.name == other.name
            && self.is_static == other.is_static
    }
}

impl Eq for Component {}

170
171
impl std::fmt::Display for Component {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
172
        write!(f, "{}.{}", self.namespace.name(), self.name)
173
174
175
    }
}

176
177
178
179
180
181
182
183
184
185
186
187
impl DistributedRuntimeProvider for Component {
    fn drt(&self) -> &DistributedRuntime {
        &self.drt
    }
}

impl RuntimeProvider for Component {
    fn rt(&self) -> &Runtime {
        self.drt.rt()
    }
}

188
189
190
191
192
193
194
195
196
197
198
199
200
201
impl MetricsRegistry for Component {
    fn basename(&self) -> String {
        self.name.clone()
    }

    fn parent_hierarchy(&self) -> Vec<String> {
        [
            self.namespace.parent_hierarchy(),
            vec![self.namespace.basename()],
        ]
        .concat()
    }
}

Ryan Olson's avatar
Ryan Olson committed
202
impl Component {
203
204
205
206
207
    /// The component part of an instance path in etcd.
    pub fn etcd_root(&self) -> String {
        let ns = self.namespace.name();
        let cp = &self.name;
        format!("{INSTANCE_ROOT_PATH}/{ns}/{cp}")
Ryan Olson's avatar
Ryan Olson committed
208
209
    }

210
    pub fn service_name(&self) -> String {
211
        let service_name = format!("{}_{}", self.namespace.name(), self.name);
212
        Slug::slugify(&service_name).to_string()
Ryan Olson's avatar
Ryan Olson committed
213
214
    }

215
    pub fn path(&self) -> String {
216
        format!("{}/{}", self.namespace.name(), self.name)
217
218
    }

219
220
221
222
223
    pub fn etcd_path(&self) -> EtcdPath {
        EtcdPath::new_component(&self.namespace.name(), &self.name)
            .expect("Component name and namespace should be valid")
    }

224
    pub fn namespace(&self) -> &Namespace {
225
226
227
        &self.namespace
    }

228
229
230
231
    pub fn name(&self) -> String {
        self.name.clone()
    }

232
233
234
235
    pub fn labels(&self) -> &[(String, String)] {
        &self.labels
    }

Ryan Olson's avatar
Ryan Olson committed
236
237
238
239
    pub fn endpoint(&self, endpoint: impl Into<String>) -> Endpoint {
        Endpoint {
            component: self.clone(),
            name: endpoint.into(),
240
            is_static: self.is_static,
241
            labels: Vec::new(),
Ryan Olson's avatar
Ryan Olson committed
242
243
244
        }
    }

245
    pub async fn list_instances(&self) -> anyhow::Result<Vec<Instance>> {
246
247
248
249
250
251
        let Some(etcd_client) = self.drt.etcd_client() else {
            return Ok(vec![]);
        };
        let mut out = vec![];
        // The extra slash is important to only list exact component matches, not substrings.
        for kv in etcd_client
252
            .kv_get_prefix(format!("{}/", self.etcd_root()))
253
254
            .await?
        {
255
            let val = match serde_json::from_slice::<Instance>(kv.value()) {
256
257
258
                Ok(val) => val,
                Err(err) => {
                    anyhow::bail!(
259
                        "Error converting etcd response to Instance: {err}. {}",
260
261
262
263
264
265
266
                        kv.value_str()?
                    );
                }
            };
            out.push(val);
        }
        Ok(out)
Ryan Olson's avatar
Ryan Olson committed
267
268
    }

269
270
    /// Scrape ServiceSet, which contains NATS stats as well as user defined stats
    /// embedded in data field of ServiceInfo.
271
    pub async fn scrape_stats(&self, timeout: Duration) -> Result<ServiceSet> {
272
        // Debug: scraping stats for component
Ryan Olson's avatar
Ryan Olson committed
273
274
275
        let service_name = self.service_name();
        let service_client = self.drt().service_client();
        service_client
276
            .collect_services(&service_name, timeout)
Ryan Olson's avatar
Ryan Olson committed
277
278
279
            .await
    }

280
    /// Add Prometheus metrics for this component's NATS service stats.
281
    ///
282
    /// Starts a background task that periodically requests service statistics from NATS
283
284
285
286
    /// and updates the corresponding Prometheus metrics. The first scrape happens immediately,
    /// then subsequent scrapes occur at a fixed interval of 9.8 seconds (MAX_WAIT_MS),
    /// which should be near or smaller than typical Prometheus scraping intervals to ensure
    /// metrics are fresh when Prometheus collects them.
287
    pub fn start_scraping_nats_service_component_metrics(&self) -> Result<()> {
288
        const MAX_WAIT_MS: std::time::Duration = std::time::Duration::from_millis(9800); // Should be <= Prometheus scrape interval
289

290
291
        // If there is another component with the same service name, this will fail.
        let component_metrics = ComponentNatsServerPrometheusMetrics::new(self)?;
292
293
294
295

        let component_clone = self.clone();
        let mut hierarchies = self.parent_hierarchy();
        hierarchies.push(self.hierarchy());
296
297
298
299
300
301
302
        debug_assert!(
            hierarchies
                .last()
                .map(|x| x.as_str())
                .unwrap_or_default()
                .eq_ignore_ascii_case(&self.service_name())
        ); // it happens that in component, hierarchy and service name are the same
303

304
305
306
307
        // Start a background task that scrapes stats every 5 seconds
        let m = component_metrics.clone();
        let c = component_clone.clone();

308
309
310
311
312
313
314
315
316
        // Use the DRT's runtime handle to spawn the background task.
        // We cannot use regular `tokio::spawn` here because:
        // 1. This method may be called from contexts without an active Tokio runtime
        //    (e.g., tests that create a DRT in a blocking context)
        // 2. Tests often create a temporary runtime just to build the DRT, then drop it
        // 3. `tokio::spawn` requires being called from within a runtime context
        // By using the DRT's own runtime handle, we ensure the task runs in the
        // correct runtime that will persist for the lifetime of the component.
        c.drt().runtime().secondary().spawn(async move {
317
318
            let timeout = std::time::Duration::from_millis(500);
            let mut interval = tokio::time::interval(MAX_WAIT_MS);
319
320
321
322
323
324
325
326
327
328
329
330
331
332
            interval.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Skip);

            loop {
                match c.scrape_stats(timeout).await {
                    Ok(service_set) => {
                        m.update_from_service_set(&service_set);
                    }
                    Err(err) => {
                        tracing::error!(
                            "Background scrape failed for {}: {}",
                            c.service_name(),
                            err
                        );
                        m.reset_to_zeros();
333
334
                    }
                }
335

336
337
                interval.tick().await;
            }
338
339
340
341
342
        });

        Ok(())
    }

Graham King's avatar
Graham King committed
343
344
    /// TODO
    ///
Ryan Olson's avatar
Ryan Olson committed
345
    /// This method will scrape the stats for all available services
Graham King's avatar
Graham King committed
346
    /// Returns a stream of `ServiceInfo` objects.
Ryan Olson's avatar
Ryan Olson committed
347
348
349
350
351
352
353
354
355
356
357
358
    /// This should be consumed by a `[tokio::time::timeout_at`] because each services
    /// will only respond once, but there is no way to know when all services have responded.
    pub async fn stats_stream(&self) -> Result<()> {
        unimplemented!("collect_stats")
    }

    pub fn service_builder(&self) -> service::ServiceConfigBuilder {
        service::ServiceConfigBuilder::from_component(self.clone())
    }
}

impl ComponentBuilder {
359
    pub fn from_runtime(drt: Arc<DistributedRuntime>) -> Self {
Ryan Olson's avatar
Ryan Olson committed
360
361
362
363
364
365
366
367
368
369
370
        Self::default().drt(drt)
    }
}

#[derive(Debug, Clone)]
pub struct Endpoint {
    component: Component,

    // todo - restrict alphabet
    /// Endpoint name
    name: String,
371
372

    is_static: bool,
373
374
375

    /// Additional labels for metrics
    labels: Vec<(String, String)>,
Ryan Olson's avatar
Ryan Olson committed
376
377
}

378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
impl Hash for Endpoint {
    fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
        self.component.hash(state);
        self.name.hash(state);
        self.is_static.hash(state);
    }
}

impl PartialEq for Endpoint {
    fn eq(&self, other: &Self) -> bool {
        self.component == other.component
            && self.name == other.name
            && self.is_static == other.is_static
    }
}

impl Eq for Endpoint {}

396
397
398
399
400
401
402
403
404
405
406
407
impl DistributedRuntimeProvider for Endpoint {
    fn drt(&self) -> &DistributedRuntime {
        self.component.drt()
    }
}

impl RuntimeProvider for Endpoint {
    fn rt(&self) -> &Runtime {
        self.component.rt()
    }
}

408
409
410
411
412
413
414
415
416
417
418
419
420
421
impl MetricsRegistry for Endpoint {
    fn basename(&self) -> String {
        self.name.clone()
    }

    fn parent_hierarchy(&self) -> Vec<String> {
        [
            self.component.parent_hierarchy(),
            vec![self.component.basename()],
        ]
        .concat()
    }
}

Ryan Olson's avatar
Ryan Olson committed
422
impl Endpoint {
423
424
425
426
427
428
429
430
    pub fn id(&self) -> EndpointId {
        EndpointId {
            namespace: self.component.namespace().name().to_string(),
            component: self.component.name().to_string(),
            name: self.name().to_string(),
        }
    }

Ryan Olson's avatar
Ryan Olson committed
431
432
433
434
    pub fn name(&self) -> &str {
        &self.name
    }

435
436
437
438
    pub fn component(&self) -> &Component {
        &self.component
    }

439
    // todo(ryan): deprecate this as we move to Discovery traits and Component Identifiers
440
    pub fn path(&self) -> String {
441
442
443
444
445
446
        format!(
            "{}/{}/{}",
            self.component.path(),
            ENDPOINT_KEYWORD,
            self.name
        )
447
448
    }

449
450
451
452
453
    /// The endpoint part of an instance path in etcd
    pub fn etcd_root(&self) -> String {
        let component_path = self.component.etcd_root();
        let endpoint_name = &self.name;
        format!("{component_path}/{endpoint_name}")
Ryan Olson's avatar
Ryan Olson committed
454
455
    }

456
457
458
459
460
461
462
463
464
465
    /// The endpoint as an EtcdPath object
    pub fn etcd_path(&self) -> EtcdPath {
        EtcdPath::new_endpoint(
            &self.component.namespace().name(),
            &self.component.name(),
            &self.name,
        )
        .expect("Endpoint name and component name should be valid")
    }

466
    /// The fully path of an instance in etcd
467
    pub fn etcd_path_with_lease_id(&self, lease_id: i64) -> String {
468
        let endpoint_root = self.etcd_root();
469
        if self.is_static {
470
            endpoint_root
471
        } else {
472
            format!("{endpoint_root}:{lease_id:x}")
473
        }
Ryan Olson's avatar
Ryan Olson committed
474
475
    }

476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
    /// The endpoint as an EtcdPath object with lease ID
    pub fn etcd_path_object_with_lease_id(&self, lease_id: i64) -> EtcdPath {
        if self.is_static {
            self.etcd_path()
        } else {
            EtcdPath::new_endpoint_with_lease(
                &self.component.namespace().name(),
                &self.component.name(),
                &self.name,
                lease_id,
            )
            .expect("Endpoint name and component name should be valid")
        }
    }

Ryan Olson's avatar
Ryan Olson committed
491
    pub fn name_with_id(&self, lease_id: i64) -> String {
492
493
494
495
496
        if self.is_static {
            self.name.clone()
        } else {
            format!("{}-{:x}", self.name, lease_id)
        }
Ryan Olson's avatar
Ryan Olson committed
497
498
    }

Ryan Olson's avatar
Ryan Olson committed
499
500
501
502
503
504
505
506
507
508
509
    pub fn subject(&self) -> String {
        format!("{}.{}", self.component.service_name(), self.name)
    }

    /// Subject to an instance of the [Endpoint] with a specific lease id
    pub fn subject_to(&self, lease_id: i64) -> String {
        format!(
            "{}.{}",
            self.component.service_name(),
            self.name_with_id(lease_id)
        )
Ryan Olson's avatar
Ryan Olson committed
510
511
    }

512
    pub async fn client(&self) -> Result<client::Client> {
513
514
515
516
517
        if self.is_static {
            client::Client::new_static(self.clone()).await
        } else {
            client::Client::new_dynamic(self.clone()).await
        }
Ryan Olson's avatar
Ryan Olson committed
518
519
520
521
522
523
524
    }

    pub fn endpoint_builder(&self) -> endpoint::EndpointConfigBuilder {
        endpoint::EndpointConfigBuilder::from_endpoint(self.clone())
    }
}

525
#[derive(Builder, Clone, Validate)]
Ryan Olson's avatar
Ryan Olson committed
526
527
528
#[builder(pattern = "owned")]
pub struct Namespace {
    #[builder(private)]
529
    runtime: Arc<DistributedRuntime>,
Ryan Olson's avatar
Ryan Olson committed
530

531
    #[validate(custom(function = "validate_allowed_chars"))]
Ryan Olson's avatar
Ryan Olson committed
532
    name: String,
533
534

    is_static: bool,
535
536
537

    #[builder(default = "None")]
    parent: Option<Arc<Namespace>>,
538
539
540
541

    /// Additional labels for metrics
    #[builder(default = "Vec::new()")]
    labels: Vec<(String, String)>,
Ryan Olson's avatar
Ryan Olson committed
542
543
}

544
545
546
547
548
549
impl DistributedRuntimeProvider for Namespace {
    fn drt(&self) -> &DistributedRuntime {
        &self.runtime
    }
}

550
551
552
553
554
555
556
557
558
559
impl std::fmt::Debug for Namespace {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(
            f,
            "Namespace {{ name: {}; is_static: {}; parent: {:?} }}",
            self.name, self.is_static, self.parent
        )
    }
}

560
561
562
563
564
565
impl RuntimeProvider for Namespace {
    fn rt(&self) -> &Runtime {
        self.runtime.rt()
    }
}

566
567
568
569
570
571
impl std::fmt::Display for Namespace {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "{}", self.name)
    }
}

Ryan Olson's avatar
Ryan Olson committed
572
impl Namespace {
573
    pub(crate) fn new(runtime: DistributedRuntime, name: String, is_static: bool) -> Result<Self> {
Ryan Olson's avatar
Ryan Olson committed
574
        Ok(NamespaceBuilder::default()
575
            .runtime(Arc::new(runtime))
Ryan Olson's avatar
Ryan Olson committed
576
            .name(name)
577
            .is_static(is_static)
Ryan Olson's avatar
Ryan Olson committed
578
579
580
            .build()?)
    }

581
    /// Create a [`Component`] in the namespace who's endpoints can be discovered with etcd
Ryan Olson's avatar
Ryan Olson committed
582
    pub fn component(&self, name: impl Into<String>) -> Result<Component> {
583
        Ok(ComponentBuilder::from_runtime(self.runtime.clone())
Ryan Olson's avatar
Ryan Olson committed
584
            .name(name)
585
            .namespace(self.clone())
586
            .is_static(self.is_static)
587
            .build()?)
Ryan Olson's avatar
Ryan Olson committed
588
    }
Ryan Olson's avatar
Ryan Olson committed
589

590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
    /// Create a [`Namespace`] in the parent namespace
    pub fn namespace(&self, name: impl Into<String>) -> Result<Namespace> {
        Ok(NamespaceBuilder::default()
            .runtime(self.runtime.clone())
            .name(name.into())
            .is_static(self.is_static)
            .parent(Some(Arc::new(self.clone())))
            .build()?)
    }

    pub fn etcd_path(&self) -> String {
        format!("{}{}", ETCD_ROOT_PATH, self.name())
    }

    pub fn name(&self) -> String {
        match &self.parent {
            Some(parent) => format!("{}.{}", parent.name(), self.name),
            None => self.name.clone(),
        }
Ryan Olson's avatar
Ryan Olson committed
609
    }
Ryan Olson's avatar
Ryan Olson committed
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
}

// Custom validator function
fn validate_allowed_chars(input: &str) -> Result<(), ValidationError> {
    // Define the allowed character set using a regex
    let regex = regex::Regex::new(r"^[a-z0-9-_]+$").unwrap();

    if regex.is_match(input) {
        Ok(())
    } else {
        Err(ValidationError::new("invalid_characters"))
    }
}

// TODO - enable restrictions to the character sets allowed for namespaces,
// components, and endpoints.
//
// Put Validate traits on the struct and use the `validate_allowed_chars` method
// to validate the fields.

// #[cfg(test)]
// mod tests {
//     use super::*;
//     use validator::Validate;

//     #[test]
//     fn test_valid_names() {
//         // Valid strings
//         let valid_inputs = vec![
//             "abc",        // Lowercase letters
//             "abc123",     // Letters and numbers
//             "a-b-c",      // Letters with hyphens
//             "a_b_c",      // Letters with underscores
//             "a-b_c-123",  // Mixed valid characters
//             "a",          // Single character
//             "a_b",        // Short valid pattern
//             "123456",     // Only numbers
//             "a---b_c123", // Repeated hyphens/underscores
//         ];

//         for input in valid_inputs {
//             let result = validate_allowed_chars(input);
//             assert!(result.is_ok(), "Expected '{}' to be valid", input);
//         }
//     }

//     #[test]
//     fn test_invalid_names() {
//         // Invalid strings
//         let invalid_inputs = vec![
//             "abc!",     // Invalid character `!`
//             "abc@",     // Invalid character `@`
//             "123$",     // Invalid character `$`
//             "foo.bar",  // Invalid character `.`
//             "foo/bar",  // Invalid character `/`
//             "foo\\bar", // Invalid character `\`
//             "abc#",     // Invalid character `#`
//             "abc def",  // Spaces are not allowed
//             "foo,",     // Invalid character `,`
//             "",         // Empty string
//         ];

//         for input in invalid_inputs {
//             let result = validate_allowed_chars(input);
//             assert!(result.is_err(), "Expected '{}' to be invalid", input);
//         }
//     }

//     // #[test]
//     // fn test_struct_validation_valid() {
//     //     // Struct with valid data
//     //     let valid_data = InputData {
//     //         name: "valid-name_123".to_string(),
//     //     };
//     //     assert!(valid_data.validate().is_ok());
//     // }

//     // #[test]
//     // fn test_struct_validation_invalid() {
//     //     // Struct with invalid data
//     //     let invalid_data = InputData {
//     //         name: "invalid!name".to_string(),
//     //     };
//     //     let result = invalid_data.validate();
//     //     assert!(result.is_err());

//     //     if let Err(errors) = result {
//     //         let error_map = errors.field_errors();
//     //         assert!(error_map.contains_key("name"));
//     //         let name_errors = &error_map["name"];
//     //         assert_eq!(name_errors[0].code, "invalid_characters");
//     //     }
//     // }

//     #[test]
//     fn test_edge_cases() {
//         // Edge cases
//         let edge_inputs = vec![
//             ("-", true),   // Single hyphen
//             ("_", true),   // Single underscore
//             ("a-", true),  // Letter with hyphen
//             ("-", false),  // Repeated hyphens
//             ("-a", false), // Hyphen at the beginning
//             ("a-", false), // Hyphen at the end
//         ];

//         for (input, expected_validity) in edge_inputs {
//             let result = validate_allowed_chars(input);
//             if expected_validity {
//                 assert!(result.is_ok(), "Expected '{}' to be valid", input);
//             } else {
//                 assert!(result.is_err(), "Expected '{}' to be invalid", input);
//             }
//         }
//     }
// }