distributed.rs 14.3 KB
Newer Older
1
2
// SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0
Ryan Olson's avatar
Ryan Olson committed
3
4

pub use crate::component::Component;
5
6
7
use crate::storage::key_value_store::{
    EtcdStore, KeyValueStore, KeyValueStoreEnum, KeyValueStoreManager, MemoryStore,
};
8
use crate::transports::nats::DRTNatsClientPrometheusMetrics;
Ryan Olson's avatar
Ryan Olson committed
9
use crate::{
10
    ErrorContext,
11
    component::{self, ComponentBuilder, Endpoint, InstanceSource, Namespace},
12
    discovery::DiscoveryClient,
13
14
    metrics::PrometheusUpdateCallback,
    metrics::{MetricsHierarchy, MetricsRegistry},
Ryan Olson's avatar
Ryan Olson committed
15
16
17
18
    service::ServiceClient,
    transports::{etcd, nats, tcp},
};

19
use super::utils::GracefulShutdownTracker;
20
use super::{Arc, DistributedRuntime, OK, OnceCell, Result, Runtime, SystemHealth, Weak, error};
21
use std::sync::OnceLock;
Ryan Olson's avatar
Ryan Olson committed
22
23
24

use derive_getters::Dissolve;
use figment::error;
25
26
use std::collections::HashMap;
use tokio::sync::Mutex;
27
use tokio_util::sync::CancellationToken;
Ryan Olson's avatar
Ryan Olson committed
28

29
impl MetricsHierarchy for DistributedRuntime {
30
31
32
33
    fn basename(&self) -> String {
        "".to_string() // drt has no basename. Basename only begins with the Namespace.
    }

34
35
36
37
38
39
    fn parent_hierarchies(&self) -> Vec<&dyn MetricsHierarchy> {
        vec![] // drt is the root, so no parent hierarchies
    }

    fn get_metrics_registry(&self) -> &MetricsRegistry {
        &self.metrics_registry
40
41
42
    }
}

Ryan Olson's avatar
Ryan Olson committed
43
44
45
46
47
48
impl std::fmt::Debug for DistributedRuntime {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "DistributedRuntime")
    }
}

Ryan Olson's avatar
Ryan Olson committed
49
50
impl DistributedRuntime {
    pub async fn new(runtime: Runtime, config: DistributedConfig) -> Result<Self> {
51
        let (etcd_config, nats_config, is_static) = config.dissolve();
Ryan Olson's avatar
Ryan Olson committed
52
53
54

        let runtime_clone = runtime.clone();

55
        let (etcd_client, store) = if is_static {
56
            (None, KeyValueStoreManager::memory())
57
        } else {
58
            let etcd_client = etcd::Client::new(etcd_config.clone(), runtime_clone).await?;
59
            let store = KeyValueStoreManager::etcd(etcd_client.clone());
60
            (Some(etcd_client), store)
61
        };
Ryan Olson's avatar
Ryan Olson committed
62

63
        let nats_client = Some(nats_config.clone().connect().await?);
Ryan Olson's avatar
Ryan Olson committed
64

65
        // Start system status server for health and metrics if enabled in configuration
66
67
68
69
70
71
72
73
        let config = crate::config::RuntimeConfig::from_settings().unwrap_or_default();
        // IMPORTANT: We must extract cancel_token from runtime BEFORE moving runtime into the struct below.
        // This is because after moving, runtime is no longer accessible in this scope (ownership rules).
        let cancel_token = if config.system_server_enabled() {
            Some(runtime.clone().child_token())
        } else {
            None
        };
74
75
        let starting_health_status = config.starting_health_status.clone();
        let use_endpoint_health_status = config.use_endpoint_health_status.clone();
76
77
        let health_endpoint_path = config.system_health_path.clone();
        let live_endpoint_path = config.system_live_path.clone();
78
        let system_health = Arc::new(parking_lot::Mutex::new(SystemHealth::new(
79
80
            starting_health_status,
            use_endpoint_health_status,
81
82
            health_endpoint_path,
            live_endpoint_path,
83
        )));
84

85
86
        let nats_client_for_metrics = nats_client.clone();

87
88
89
90
91
92
93
94
        // Initialize discovery client with mock implementation
        // TODO: Replace MockDiscoveryClient with KeyValueStoreDiscoveryClient or KubeDiscoveryClient
        let discovery_client = {
            use crate::discovery::{MockDiscoveryClient, SharedMockRegistry};
            let registry = SharedMockRegistry::new();
            Arc::new(MockDiscoveryClient::new(None, registry)) as Arc<dyn DiscoveryClient>
        };

95
        let distributed_runtime = Self {
Ryan Olson's avatar
Ryan Olson committed
96
97
            runtime,
            etcd_client,
98
            store,
Ryan Olson's avatar
Ryan Olson committed
99
100
            nats_client,
            tcp_server: Arc::new(OnceCell::new()),
101
            system_status_server: Arc::new(OnceLock::new()),
102
            discovery_client,
Ryan Olson's avatar
Ryan Olson committed
103
            component_registry: component::Registry::new(),
104
            is_static,
105
            instance_sources: Arc::new(Mutex::new(HashMap::new())),
106
            metrics_registry: crate::MetricsRegistry::new(),
107
            system_health,
108
109
        };

110
111
112
113
114
        if let Some(nats_client_for_metrics) = nats_client_for_metrics {
            let nats_client_metrics = DRTNatsClientPrometheusMetrics::new(
                &distributed_runtime,
                nats_client_for_metrics.client().clone(),
            )?;
115
            // Register a callback to update NATS client metrics on the DRT's metrics registry
116
117
118
119
120
121
122
123
            let nats_client_callback = Arc::new({
                let nats_client_clone = nats_client_metrics.clone();
                move || {
                    nats_client_clone.set_from_client_stats();
                    Ok(())
                }
            });
            distributed_runtime
124
125
                .metrics_registry
                .add_update_callback(nats_client_callback);
126
        }
127

128
129
130
131
132
133
        // Initialize the uptime gauge in SystemHealth
        distributed_runtime
            .system_health
            .lock()
            .initialize_uptime_gauge(&distributed_runtime)?;

134
        // Handle system status server initialization
135
        if let Some(cancel_token) = cancel_token {
136
            // System server is enabled - start both the state and HTTP server
137
138
139
            let host = config.system_host.clone();
            let port = config.system_port;

140
            // Start system status server (it creates SystemStatusState internally)
141
            match crate::system_status_server::spawn_system_status_server(
142
143
144
145
                &host,
                port,
                cancel_token,
                Arc::new(distributed_runtime.clone()),
146
147
148
            )
            .await
            {
149
                Ok((addr, handle)) => {
150
                    tracing::info!("System status server started successfully on {}", addr);
151

152
153
154
155
156
157
                    // Store system status server information
                    let system_status_server_info =
                        crate::system_status_server::SystemStatusServerInfo::new(
                            addr,
                            Some(handle),
                        );
158

159
                    // Initialize the system_status_server field
160
                    distributed_runtime
161
162
163
                        .system_status_server
                        .set(Arc::new(system_status_server_info))
                        .expect("System status server info should only be set once");
164
165
                }
                Err(e) => {
166
                    tracing::error!("System status server startup failed: {}", e);
167
                }
168
            }
169
        } else {
170
            // System server HTTP is disabled, but uptime metrics are still being tracked via SystemHealth
171
172
173
            tracing::debug!(
                "System status server HTTP endpoints disabled, but uptime metrics are being tracked"
            );
174
175
        }

176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
        // Start health check manager if enabled
        if config.health_check_enabled {
            let health_check_config = crate::health_check::HealthCheckConfig {
                canary_wait_time: std::time::Duration::from_secs(config.canary_wait_time_secs),
                request_timeout: std::time::Duration::from_secs(
                    config.health_check_request_timeout_secs,
                ),
            };

            // Start the health check manager (spawns per-endpoint monitoring tasks)
            match crate::health_check::start_health_check_manager(
                distributed_runtime.clone(),
                Some(health_check_config),
            )
            .await
            {
                Ok(()) => tracing::info!(
                    "Health check manager started (canary_wait_time: {}s, request_timeout: {}s)",
                    config.canary_wait_time_secs,
                    config.health_check_request_timeout_secs
                ),
                Err(e) => tracing::error!("Health check manager failed to start: {}", e),
            }
        }

201
        Ok(distributed_runtime)
Ryan Olson's avatar
Ryan Olson committed
202
203
204
    }

    pub async fn from_settings(runtime: Runtime) -> Result<Self> {
205
206
207
208
209
210
211
        let config = DistributedConfig::from_settings(false);
        Self::new(runtime, config).await
    }

    // Call this if you are using static workers that do not need etcd-based discovery.
    pub async fn from_settings_without_discovery(runtime: Runtime) -> Result<Self> {
        let config = DistributedConfig::from_settings(true);
Ryan Olson's avatar
Ryan Olson committed
212
213
214
215
216
217
218
        Self::new(runtime, config).await
    }

    pub fn runtime(&self) -> &Runtime {
        &self.runtime
    }

219
220
221
222
    pub fn primary_token(&self) -> CancellationToken {
        self.runtime.primary_token()
    }

223
224
    pub fn connection_id(&self) -> u64 {
        self.store.connection_id()
Ryan Olson's avatar
Ryan Olson committed
225
226
227
228
229
230
231
232
    }

    pub fn shutdown(&self) {
        self.runtime.shutdown();
    }

    /// Create a [`Namespace`]
    pub fn namespace(&self, name: impl Into<String>) -> Result<Namespace> {
233
        Namespace::new(self.clone(), name.into(), self.is_static)
Ryan Olson's avatar
Ryan Olson committed
234
235
    }

236
237
238
239
240
    /// TODO: Return discovery client when KeyValueDiscoveryClient or KubeDiscoveryClient is implemented
    pub fn discovery_client(&self) -> Result<Arc<dyn DiscoveryClient>> {
        Err(error!("Discovery client not implemented!"))
    }

241
242
    pub(crate) fn service_client(&self) -> Option<ServiceClient> {
        self.nats_client().map(|nc| ServiceClient::new(nc.clone()))
Ryan Olson's avatar
Ryan Olson committed
243
244
    }

245
    pub async fn tcp_server(&self) -> Result<Arc<tcp::server::TcpStreamServer>> {
Ryan Olson's avatar
Ryan Olson committed
246
247
248
249
250
251
252
253
254
255
256
        Ok(self
            .tcp_server
            .get_or_try_init(async move {
                let options = tcp::server::ServerOptions::default();
                let server = tcp::server::TcpStreamServer::new(options).await?;
                OK(server)
            })
            .await?
            .clone())
    }

257
258
    pub fn nats_client(&self) -> Option<&nats::Client> {
        self.nats_client.as_ref()
Ryan Olson's avatar
Ryan Olson committed
259
260
    }

261
262
263
264
265
    /// Get system status server information if available
    pub fn system_status_server_info(
        &self,
    ) -> Option<Arc<crate::system_status_server::SystemStatusServerInfo>> {
        self.system_status_server.get().cloned()
266
267
    }

268
    // todo(ryan): deprecate this as we move to Discovery traits and Component Identifiers
269
    pub fn etcd_client(&self) -> Option<etcd::Client> {
Ryan Olson's avatar
Ryan Olson committed
270
271
        self.etcd_client.clone()
    }
272

273
274
275
276
277
278
    // Deprecated but our CI blocks us using the feature currently.
    //#[deprecated(note = "Use KeyValueStoreManager via store(); this will be removed")]
    pub fn deprecated_etcd_client(&self) -> Option<etcd::Client> {
        self.etcd_client.clone()
    }

279
280
    /// An interface to store things. Will eventually replace `etcd_client`.
    /// Currently does key-value, but will grow to include whatever we need to store.
281
282
    pub fn store(&self) -> &KeyValueStoreManager {
        &self.store
283
284
    }

285
286
287
    pub fn child_token(&self) -> CancellationToken {
        self.runtime.child_token()
    }
288

289
290
291
292
    pub(crate) fn graceful_shutdown_tracker(&self) -> Arc<GracefulShutdownTracker> {
        self.runtime.graceful_shutdown_tracker()
    }

293
294
295
    pub fn instance_sources(&self) -> Arc<Mutex<HashMap<Endpoint, Weak<InstanceSource>>>> {
        self.instance_sources.clone()
    }
Ryan Olson's avatar
Ryan Olson committed
296
297
298
299
300
301
}

#[derive(Dissolve)]
pub struct DistributedConfig {
    pub etcd_config: etcd::ClientOptions,
    pub nats_config: nats::ClientOptions,
302
    pub is_static: bool,
Ryan Olson's avatar
Ryan Olson committed
303
304
305
}

impl DistributedConfig {
306
    pub fn from_settings(is_static: bool) -> DistributedConfig {
Ryan Olson's avatar
Ryan Olson committed
307
308
309
        DistributedConfig {
            etcd_config: etcd::ClientOptions::default(),
            nats_config: nats::ClientOptions::default(),
310
            is_static,
Ryan Olson's avatar
Ryan Olson committed
311
312
        }
    }
Ryan Olson's avatar
Ryan Olson committed
313
314
315
316
317

    pub fn for_cli() -> DistributedConfig {
        let mut config = DistributedConfig {
            etcd_config: etcd::ClientOptions::default(),
            nats_config: nats::ClientOptions::default(),
318
            is_static: false,
Ryan Olson's avatar
Ryan Olson committed
319
320
321
322
323
324
        };

        config.etcd_config.attach_lease = false;

        config
    }
Ryan Olson's avatar
Ryan Olson committed
325
}
326

327
pub mod distributed_test_utils {
328
329
330
    //! Common test helper functions for DistributedRuntime tests
    // TODO: Use in-memory DistributedRuntime for tests instead of full runtime when available.

331
    /// Helper function to create a DRT instance for integration-only tests.
332
333
334
335
336
337
338
339
340
341
    /// Uses from_current to leverage existing tokio runtime
    /// Note: Settings are read from environment variables inside DistributedRuntime::from_settings_without_discovery
    #[cfg(feature = "integration")]
    pub async fn create_test_drt_async() -> crate::DistributedRuntime {
        let rt = crate::Runtime::from_current().unwrap();
        crate::DistributedRuntime::from_settings_without_discovery(rt)
            .await
            .unwrap()
    }
}
342

343
#[cfg(all(test, feature = "integration"))]
344
345
346
347
348
349
350
351
352
353
354
355
356
357
mod tests {
    use super::distributed_test_utils::create_test_drt_async;

    #[tokio::test]
    async fn test_drt_uptime_after_delay_system_disabled() {
        // Test uptime with system status server disabled
        temp_env::async_with_vars([("DYN_SYSTEM_ENABLED", Some("false"))], async {
            // Start a DRT
            let drt = create_test_drt_async().await;

            // Wait 50ms
            tokio::time::sleep(tokio::time::Duration::from_millis(50)).await;

            // Check that uptime is 50+ ms
358
            let uptime = drt.system_health.lock().uptime();
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
            assert!(
                uptime >= std::time::Duration::from_millis(50),
                "Expected uptime to be at least 50ms, but got {:?}",
                uptime
            );

            println!(
                "✓ DRT uptime test passed (system disabled): uptime = {:?}",
                uptime
            );
        })
        .await;
    }

    #[tokio::test]
    async fn test_drt_uptime_after_delay_system_enabled() {
        // Test uptime with system status server enabled
        temp_env::async_with_vars([("DYN_SYSTEM_ENABLED", Some("true"))], async {
            // Start a DRT
            let drt = create_test_drt_async().await;

            // Wait 50ms
            tokio::time::sleep(tokio::time::Duration::from_millis(50)).await;

            // Check that uptime is 50+ ms
384
            let uptime = drt.system_health.lock().uptime();
385
386
387
388
389
390
391
392
393
394
395
396
397
398
            assert!(
                uptime >= std::time::Duration::from_millis(50),
                "Expected uptime to be at least 50ms, but got {:?}",
                uptime
            );

            println!(
                "✓ DRT uptime test passed (system enabled): uptime = {:?}",
                uptime
            );
        })
        .await;
    }
}