GitLab

revert googletest/test/gtest-param-test_test.cc

code merge, cleanups

wip, cleanups/merge

wip, cleanups/merge

cleanup, merge

cleanup, merge

[Bazel] Detect Windows with cpu value x64_windows and x64_windows_msvc

and x64_windows_msvc

Small cleanups, merge

Optimize build matrix on pull requests

code cleanup in preparation for merges, cl 180857299

Pass the -Wmissing-declarations warning.

Also define GTEST_ATTRIBUTE_PRINTF_ in clang-cl.

Disable expensive builds on pull requests.

upstreaming cl 124976692

Run autoconf from top-level directory.

clang-cl is clang for Windows running in MSVC mode. Chromium uses it for
Windows builds. clang-cl is weird in that it defines __clang__ and
_MSC_VER, but *NOT* __GNUC__. This is vaguely analogous to how normal
clang defines __clang__ (what it is) and __GNUC__ (what it is compatible
with).

However, clang-cl still implements most GCC extensions, being clang.
Notably, the way to control -Wformat-literal is still with
__attribute__((__format__)). For better error-checking and strict
-Wformatl-literal compatibility (see
53c478d6), define
GTEST_ATTRIBUTE_PRINTF_ in clang-cl too.

This makes it easier to use GTest in projects that build with the
-Wmissing-declarations warning. This fixes the warning in headers and
source files, though not GTest's own tests as it is rather noisy there.

Fix testing::Combine on MSVC 2017.

Pass MSVC's C4826 warning.