GitLab

Comment out unused method parameters in their relevant definitions.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>

`DescribeTo(..)` and `MatchAndExplain(..)` in `gmock-matchers_test` both
override virtual methods. Remove the `virtual` keyword and apply `override` to
them instead.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>

`DescribeTo(..)` and `MatchAndExplain(..)` in `gmock-matchers_test` both
override virtual methods. Remove the `virtual` keyword and apply `override` to
them instead.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>

Provide dummy accessors for private values that are set in initializers,
but not actually used.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>

Fix matcher comparisons for std::reference_wrapper.

The googletest docs indicate that std::reference_wrapper should be used to for
objects that should not be copied by the matcher (in fact, the ByRef() function
is basically the same as a call to std::cref).

However, for many types (such as std::string), the overloaded operator== will
not resolve correctly. Specifically, this is problematic if operator== depends
on template argument deduction, where the same type is named on LHS and RHS.

Because template argument deduction happens before any implict conversions for
purposes of overload resolution, attempting to compare T with
std::reference_wrapper<T> simply looks like a comparison of unlike types.

For exapmle, std::reference_wrapper<std::string> is implicitly convertible to
'const std::string&', which would be able to choose an overload specialization
of operator==. However, the implicit conversion can only happen after template
argument deduction for operator==, so a specialization that would other be an
applicable overload is never considered.

Note also that this change only affects matchers. There are good reasons that
matchers may need to transparently hold a std::reference_wrapper. Other
comparisons (like EXPECT_EQ, et. al.) don't need to capture a reference: they
don't need to defer evaluation (as in googlemock), and they don't need to avoid
copies (as the call chain of matchers does).

PiperOrigin-RevId: 232499175

Mark legacy _TEST_CASE_ macros as deprecated

PiperOrigin-RevId: 232303251

Fix stack overflow in AnyOfArray tests.

PiperOrigin-RevId: 231881125

Add AllOfArray matcher that verifies a value matches all member of some array/container/list/set/..., e.g:
EXPECT_THAT(1, AnyOfArray({1, 2, 3}))
In the simplest form this is identical to AnyOf(1, 2, 3). But unlike that one it works on containers.

Add AnyOfArray matcher that verifies a value matches any member of some
array/container/list/set/...

PiperOrigin-RevId: 230403653

Fix mocking method arguments with templated copy constructors.

A previous change removed workarounds for old compilers from googletest and googlemock. Unfortunately, a bit of code that started as a workaround for Symbian's C++ compiler is still needed to avoid copy/move constructor ambiguity when mocking functions with certain argument types.

The test case added by this CL is extracted from Chrome's codebase, and was discovered while attempting to roll googletest.

PiperOrigin-RevId: 229801765

Refactor the `Invoke` and `InvokeWithoutArgs` actions:
 - Replace pump'd classes and functions with templates.
 - Make the polymorphic actions be polymorphic functors instead.
 - Fix Invoke(Callback*) to work with subclasses of the callbacks, instead of trying to diagnose that in gmock_doctor.

PiperOrigin-RevId: 229604112

Add move-only argument support to almost all remaining matchers.

PiperOrigin-RevId: 229030728

Deduplicate testing::ReferenceWrapper with std::reference_wrapper.
Minor cleanups in matchers_test.

PiperOrigin-RevId: 229022872

Drop generated file gmock-generated-internal-utils.h.

PiperOrigin-RevId: 228232195

Internal Change

PiperOrigin-RevId: 227575279

Remove the #ifs for old, unsupported and buggy compilers:
* old versions of GCC & MSVC
* Symbian

PiperOrigin-RevId: 227116941

Get rid of code generation for NiceMock / StrictMock.
They got small enough that it doesn't make sense to generate them.

PiperOrigin-RevId: 226455689

Unifdef c++11-related macros from googletest now that it requires C++11.

PiperOrigin-RevId: 225905601

Suppress C4503 for MCVS , again

PiperOrigin-RevId: 225895719

Suppress C4503 for MCVS

PiperOrigin-RevId: 225871050

Allow container matchers to accept move-only containers.

PiperOrigin-RevId: 225667441

Internal Change

PiperOrigin-RevId: 225231727

The gmock matchers have a concept of MatchAndExpain; where the details of the
matching are written to a "result listener". A matcher can avoid creating
expensive debug info by checking result_listener->IsInterested(); but,
unfortunately, the default matcher code (called from EXPECT_THAT) is always
"interested".

This change implements EXPECT_THAT matching to first run the matcher in a "not
interested" mode; and then run it a second time ("interested") only if the
match fails.

PiperOrigin-RevId: 225036073

rollback of 224929783

PiperOrigin-RevId: 225008559

The gmock matchers have a concept of MatchAndExpain; where the details of the
matching are written to a "result listener". A matcher can avoid creating
expensive debug info by checking result_listener->IsInterested(); but,
unfortunately, the default matcher code (called from EXPECT_THAT) is always
"interested".

This change implements EXPECT_THAT matching to first run the matcher in a "not
interested" mode; and then run it a second time ("interested") only if the
match fails.

PiperOrigin-RevId: 224929783

Deduce SizeType for SizeIs() from the return value of the size() member function

PiperOrigin-RevId: 223835674

Applied fixes for ClangTidy modernize-use-override and modernize-use-using.

PiperOrigin-RevId: 223800219

Replace pump'd Args() matcher with variadic templates.

PiperOrigin-RevId: 223794430

Fix broken OSS build

PiperOrigin-RevId: 222244158

Remove unintended dependency.

PiperOrigin-RevId: 222243874

Remove redundant Base/Derived types.

PiperOrigin-RevId: 222243634

Internal Change

PiperOrigin-RevId: 222123106

Add stringization based tests for gmock-pp.h macros

PiperOrigin-RevId: 221961835

Validate spec modifiers.

PiperOrigin-RevId: 221810235

Upgrade WithArgs family of actions to C++11.

PiperOrigin-RevId: 221671690

One macro to rule them all.

PiperOrigin-RevId: 221462515

Improve Bazel build files.

New target gtest_prod allows access to the FRIEND_TEST macro without depending on the entirety of GTest in production executables. Additionally, duplicate config_setting rules were removed and formatting was adjusted.

PiperOrigin-RevId: 220279205

Remove scoped_ptr replace with std::unique_ptr

PiperOrigin-RevId: 219291284

Remove linked_ptr and use std::shared_ptr instead

PiperOrigin-RevId: 219129336