1. 08 Nov, 2019 2 commits
    • Abseil Team's avatar
      Googletest export · d5707695
      Abseil Team authored
      Correctly deal with stringification, and forbid empty arguments where they could slip thought, in the type parameterized test API.
      
      Note: even where empty args work, it's likely to result in technically invalid code by virtue of creating reserved identifiers:
      https://en.cppreference.com/w/cpp/language/identifiers
      PiperOrigin-RevId: 279330971
      d5707695
    • Abseil Team's avatar
      Googletest export · 681454da
      Abseil Team authored
      Clone+exec death test allocates a single page of stack to run chdir + exec on.
      This is not enough when gtest is built with ASan and run on particular
      hardware.
      
      With ASan on x86_64, ExecDeathTestChildMain has frame size of 1728 bytes.
      
      Call to chdir() in ExecDeathTestChildMain ends up in
      _dl_runtime_resolve_xsavec, which attempts to save register state on the stack;
      according to cpuid(0xd) XSAVE register save area size is 2568 on my machine.
      
      This results in something like this in all death tests:
        Result: died but not with expected error.
        ...
        [  DEATH   ] AddressSanitizer:DEADLYSIGNAL
        [  DEATH   ] =================================================================
        [  DEATH   ] ==178637==ERROR: AddressSanitizer: stack-overflow on address ...
      
      PiperOrigin-RevId: 278709790
      681454da
  2. 05 Nov, 2019 4 commits
  3. 04 Nov, 2019 1 commit
  4. 02 Nov, 2019 3 commits
  5. 01 Nov, 2019 2 commits
  6. 31 Oct, 2019 2 commits
    • Abseil Team's avatar
      Googletest export · 2db3df9c
      Abseil Team authored
      Change variable name to match comment.
      
      PiperOrigin-RevId: 277713621
      2db3df9c
    • Abseil Team's avatar
      Googletest export · e2fc3a9c
      Abseil Team authored
      Tolerate std::string's explicit copy construction from std::string_view.
      
      PiperOrigin-RevId: 277583394
      e2fc3a9c
  7. 30 Oct, 2019 2 commits
  8. 29 Oct, 2019 8 commits
  9. 25 Oct, 2019 8 commits
  10. 24 Oct, 2019 2 commits
  11. 23 Oct, 2019 6 commits