GitLab

Fix ellipsis position in examples

Make the failure messages from EXPECT_EQ and friends actually symmetric (reopen of #1101)

instead of reading more like reversing the former "expected" and "actual"
roles of the LHS and RHS arguments.

This patch is manually applied from internal version (125109873)

remove unused TestCase import

remove obsolete link_directories command

User logger GTEST_LOG instead of printf in gtest.cc to log errors

remove unused variables from travis environment

drop unused valgrind package from Travis build slave installation

switch one Trevis build to Release mode

enable Travis ccache to speed up CI builds

run parallelized builds on Travis CI

CMake: use threads if allowed and found, not just if found.

... and remove explicit gcc installation (will be installed with g++
automatically)

It's not necessary, as the target_link_libraries command contains an
absolute path already, and the path given doesn't exist anymore,
leading only to linker warnings like:
ld: warning: directory not found for option
'-L/Users/travis/build/google/googletest/build/googlemock/gtest/src'

When using INSTANTIATE_TEST_CASE_P with a lambda function which uses
'info' as parameter name, GCC complains that this would shadow
parameter 'info' used in the macro's VA_ARGS call.

This turns on optimization which allows the compiler to discover more
problems and omit some more warnings.

Fix WhenSorted() documentation example

If the user's cmakelists.txt first look for threads using
find_package(Threads), then set(gtest_disable_pthreads ON),
and then include googletest. GoogleTest will not look for
threads. But since they have already been found before in
user's cmakelists, it will use them regardless.

This helped me fix build issue in darktable-org/rawspeed
on windows/MSYS2, even though there are threads, and they
are usable, googletest build was failing with issues
about AutoHandle. I was first looking for threads, and only
then including googletest, so no matter the value of
gtest_disable_pthreads, it failed.

The other obvious solution is for user to first include
googletest, and only then look for threads by himself.