Skip to content

GitLab

Switch branch/tag
  1. 14 Mar, 2022 1 commit
  3. 08 Mar, 2022 1 commit
    • Abseil Team's avatar
      Mark ACTION_Pn()-generated functions as must-use-result, adding non-compilation tests. · ae1b7ad4
      Abseil Team authored 
      This catches when a client creates an action and discards it, thinking that the action has actually been applied to something.

This will help people who make the mistake of defining, for example, both `void Use(Foo*, Bar)` and `ACTION_P(Use, bar) { Use(arg, bar); }` for later application to a Foo.  With such an overload, a client may then write `Use(bar);`, selecting the Action<> overload and being confused why nothing happens.

This also catches when a client defines their own action in terms of an ACTION_P()-generated one, invokes the Action<>'s builder, and then fails to invoke the resulting action, thinking it's operating on the outer action's parameters.

PiperOrigin-RevId: 433197479
Change-Id: I98e4389150d01a5e753230113016d9fc38b1d260
      ae1b7ad4
  5. 17 Feb, 2022 1 commit
  7. 14 Feb, 2022 1 commit
  9. 10 Feb, 2022 1 commit
  11. 08 Feb, 2022 2 commits
  13. 07 Feb, 2022 1 commit
  15. 05 Feb, 2022 2 commits
  17. 04 Feb, 2022 1 commit
  19. 01 Feb, 2022 2 commits
  21. 31 Jan, 2022 1 commit
  23. 28 Jan, 2022 1 commit
  25. 26 Jan, 2022 1 commit
  27. 25 Jan, 2022 2 commits
    • Melroy van den Berg's avatar
      Let me give a change to try it again - updating to latest version · f2d71f0b
      Melroy van den Berg authored
      f2d71f0b
    • Abseil Team's avatar
      Make recreate_environments_when_repeating=false the default. · f45d5865
      Abseil Team authored 
      So that global test environments are by default set up and torn down once,
regardless of the value of the repeat flag.

The point of global environments is to be set up and torn down once, and shared
by all tests in the process. There is no obvious reason why multiple runs of the
same test should be treated distinctly from single runs of different tests.

Having this be false by default means that repeats using a global environment
run faster. It can still be set to true if it's desired that every repeat get a
fresh environment, but this seems less important given the nature of a global
environment. Every test I've seen using a global environment uses it to set up
some expensive external resource, not something that can/should be set up for
each test anew. (Again this is unsurprising, since the environment is a global.)

PiperOrigin-RevId: 424003937
Change-Id: I9e8a825cb8900960dd65b85fe5ffcc0a337e57f3
      f45d5865
  29. 24 Jan, 2022 2 commits
  31. 21 Jan, 2022 1 commit
  33. 19 Jan, 2022 1 commit
  35. 18 Jan, 2022 1 commit
  37. 17 Jan, 2022 1 commit
  39. 14 Jan, 2022 2 commits
  41. 13 Jan, 2022 1 commit
  43. 12 Jan, 2022 1 commit
    • Abseil Team's avatar
      Fix run-on sentence · 2d07f12b
      Abseil Team authored 
          dispatch. It will use the definition from the class the constructor of which

PiperOrigin-RevId: 421291241
Change-Id: If81e3d6d3774edfbbb4baaec8a3cd96566b3b09c
      2d07f12b
  45. 11 Jan, 2022 1 commit
  47. 10 Jan, 2022 1 commit
  49. 06 Jan, 2022 10 commits