Skip to content

GitLab

Switch branch/tag
  1. 21 Feb, 2023 1 commit
    • Tom Hughes's avatar
      Remove int64_t cast in RecordProperty · 750d67d8
      Tom Hughes authored 
      Historically, calls to RecordProperty with values that are convertible to
int64_t have been casted to int64_t. The result was that types like float or
double would be truncated when printed (e.g., 4.75 -> 4). This change removes
the cast so that the types are printed in a more appropriate manner.

PiperOrigin-RevId: 511238685
Change-Id: I80de5db14462da2a3e1f476086025ae514383a17
      750d67d8
  3. 16 Feb, 2023 1 commit
  5. 15 Feb, 2023 1 commit
    • Abseil Team's avatar
      Remove strdup usage · f063cd25
      Abseil Team authored 
      PiperOrigin-RevId: 509947007
Change-Id: I31e1274afa889776829c877c40c9af589298dcf2
      f063cd25
  7. 14 Feb, 2023 1 commit
  9. 13 Feb, 2023 1 commit
  11. 08 Feb, 2023 1 commit
    • Tom Hughes's avatar
      Fix _MSC_VER check · b73f27fd
      Tom Hughes authored 
      Use "#if defined(_MSC_VER)" instead of "#if _MSC_VER" to be consistent
with other usages in googletest and to work with the "-Wundef" warning.

PiperOrigin-RevId: 508087630
Change-Id: I29c16fd2fa51a9dfecd55e10362a020318318956
      b73f27fd
  13. 07 Feb, 2023 2 commits
  15. 06 Feb, 2023 1 commit
  17. 02 Feb, 2023 4 commits
    • Tom Hughes's avatar
      Fix compiler flags in Linux presubmit · 2f2e72ba
      Tom Hughes authored 
      CXX_FLAGS should be CXXFLAGS and the quoting was wrong.
As a result, "-Werror -Wdeprecated" was not being applied.

https://cmake.org/cmake/help/latest/envvar/CXXFLAGS.html

PiperOrigin-RevId: 506656655
Change-Id: Ic5e861be3b9c32257eb9aabb845c931f3cba7122
      2f2e72ba
    • Tom Hughes's avatar
      Fix -Wsign-conversion warnings · deaf5615
      Tom Hughes authored 
      googletest/test/gtest_xml_outfile2_test_.cc:48:39:
warning: implicit conversion turns floating-point number into integer:
'float' to 'int64_t' (aka 'long') [-Wfloat-conversion]
  RecordProperty("TestFloatProperty", float_prop);
  ~~~~~~~~~~~~~~                      ^~~~~~~~~~

googletest/test/gtest_xml_outfile2_test_.cc:51:40:
warning: implicit conversion turns floating-point number into integer:
'double' to 'int64_t' (aka 'long') [-Wfloat-conversion]
  RecordProperty("TestDoubleProperty", double_prop);
  ~~~~~~~~~~~~~~                       ^~~~~~~~~~~

googletest/test/gtest_xml_outfile2_test_.cc:57:39:
warning: implicit conversion changes signedness:
'size_t' (aka 'unsigned long') to 'int64_t' (aka 'long') [-Wsign-conversion]
  RecordProperty("TestSizetProperty", size_t_prop);
  ~~~~~~~~~~~~~~                      ^~~~~~~~~~~
PiperOrigin-RevId: 506644143
Change-Id: I9c2cd5f52daebe25e73bb97f696687797ed2cabf
      deaf5615
    • Tom Hughes's avatar
      Remove unneccessary "#if _MSC_VER" · 4f7c63d9
      Tom Hughes authored 
      The GTEST_DISABLE_MSC_WARNINGS macros already have an _MSC_VER check.
This change also adds a missing GTEST_DISABLE_MSC_WARNINGS_POP_ in
gtest-typed-test_test.cc.

PiperOrigin-RevId: 506636248
Change-Id: Ifdc044528f5448fbf0175887d1671f1e1f3040b9
      4f7c63d9
    • Abseil Team's avatar
      Add a trailing decimal point to FormatTimeInMillisAsSeconds() output when input · 6f21175f
      Abseil Team authored 
      is an exact N seconds.

PiperOrigin-RevId: 506610898
Change-Id: Idcd705c719e0e721148c350c8a14f27b9eb5c4f7
      6f21175f
  19. 01 Feb, 2023 4 commits
  21. 31 Jan, 2023 1 commit
    • Tom Hughes's avatar
      Fix sign conversion warning from clang: · d9251171
      Tom Hughes authored 
      googletest/samples/prime_tables.h:81:57: error:
implicit conversion changes signedness: 'int' to 'unsigned long'
[-Werror,-Wsign-conversion]
      : is_prime_size_(max + 1), is_prime_(new bool[max + 1]) {
                                           ~~~      ~~~~^~~

PiperOrigin-RevId: 506065360
Change-Id: Ida4550562531012c089e2f9fcf530b3a78889fa3
      d9251171
  23. 30 Jan, 2023 3 commits
  25. 27 Jan, 2023 1 commit
  27. 26 Jan, 2023 3 commits
  29. 25 Jan, 2023 6 commits
  31. 24 Jan, 2023 3 commits
  33. 18 Jan, 2023 1 commit
  35. 17 Jan, 2023 5 commits
    • Tom Hughes's avatar
      Replace deprecated python calls · bdb3b0a4
      Tom Hughes authored 
      assert_ -> assertTrue/assertFalse/assertIn/assertNotIn
assertEquals -> assertEqual

PiperOrigin-RevId: 502654909
Change-Id: I25d30095a83c3806606cb80d676b3c979495e6bd
      bdb3b0a4
    • Dino Radakovic's avatar
      Announce that GitHub actions are not GoogleTest's canonical CI · bba28fa8
      Dino Radakovic authored 
      PiperOrigin-RevId: 502654465
Change-Id: I51269e8c389ad63f3737132feec1b6d20dc4c314
      bba28fa8
    • Tom Hughes's avatar
      Fix -Wimplicit-int-float-conversion warning · 5cd81a78
      Tom Hughes authored 
      We're intentionally losing precision in this case, so add a cast.

googletest/googletest/include/gtest/gtest-printers.h:532:9: error:
implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision
[-Werror,-Wimplicit-int-float-conversion]
    if (static_cast<int32_t>(val * mulfor6 + 0.5) / mulfor6 == val) return 6;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~

googletest/googletest/include/gtest/gtest-printers.h:544:9: error:
implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision
[-Werror,-Wimplicit-int-float-conversion]
    if (static_cast<int32_t>(val / divfor6 + 0.5) * divfor6 == val) return 6;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~

PiperOrigin-RevId: 502646042
Change-Id: I05989ee42675b531a9907616c9582a5a7c77bed6
      5cd81a78
    • Derek Mauro's avatar
      Update documentation for v1.13.0 · 9d697cc8
      Derek Mauro authored 
      PiperOrigin-RevId: 502644180
Change-Id: Id20b5e4eec22035da278f1767002657f66dbe79c
      9d697cc8
    • Derek Mauro's avatar
      Bump version to 1.13.0 in preparation for release · b796f7d4
      Derek Mauro authored 
      PiperOrigin-RevId: 502626077
Change-Id: I3aad27a8b725cf73163e52ef2e28e6cdfc13082b
      b796f7d4