Skip to content

GitLab

Switch branch/tag
  1. 30 Mar, 2019 1 commit
    • Enji Cooper's avatar
      Handle GTEST_SKIP() when calling `Environment::SetUp()` · 67c75ff8
      Enji Cooper authored 
      

gtest prior to this change would completely ignore `GTEST_SKIP()` if
called in `Environment::SetUp()`, instead of bailing out early, unlike
`Test::SetUp()`, which would cause the tests themselves to be skipped.
The only way (prior to this change) to skip the tests would be to
trigger a fatal error via `GTEST_FAIL()`.

Desirable behavior, in this case, when dealing with
`Environment::SetUp()` is to check for prerequisites on a system
(example, kernel supports a particular featureset, e.g., capsicum), and
skip the tests. The alternatives prior to this change would be
undesirable:

- Failing sends the wrong message to the test user, as the result of the
  tests is indeterminate, not failed.
- Having to add per-test class abstractions that override `SetUp()` to
  test for the capsicum feature set, then skip all of the tests in their
  respective SetUp fixtures, would be a lot of human and computational
  work; checking for the feature would need to be done for all of the
  tests, instead of once for all of the tests.

For those reasons, making `Environment::SetUp()` handle `GTEST_SKIP()`,
by not executing the testcases, is the most desirable solution.

In order to properly diagnose what happened when running the tests if
they are skipped, print out the diagnostics in an ad hoc manner.

Update the documentation to note this change and integrate a new test,
gtest_skip_in_environment_setup_test, into the test suite.

This change addresses #2189.
Signed-off-by: default avatarEnji Cooper <yaneurabeya@gmail.com>
      67c75ff8
  3. 28 Mar, 2019 3 commits
  5. 26 Mar, 2019 2 commits
  7. 21 Mar, 2019 6 commits
  9. 20 Mar, 2019 1 commit
  11. 19 Mar, 2019 1 commit
  13. 15 Mar, 2019 1 commit
  15. 05 Mar, 2019 3 commits
    • Gennadiy Civil's avatar
      Merge pull request #2158 from CarloWood:master · 8b6d3f9c
      Gennadiy Civil authored 
      PiperOrigin-RevId: 236716851
      8b6d3f9c
    • Abseil Team's avatar
      Googletest export · 3dd2e841
      Abseil Team authored 
      Fix emission of -Wzero-as-null-pointer-constant when comparing integers.

The following code fails to compile:

#pragma clang diagnostic error "-Wzero-as-null-pointer-constant"
void foo() {
  EXPECT_EQ(0, 0);
}

This happens because gtest checks the first argument to EXPECT_EQ and
ASSERT_EQ is a null pointer constant. The magic it does to do this causes the
warning to be emitted.

This patch removes that check. It replaces the explicit check with a Compare
overload that can only be selected when 0 or nullptr is passed on the LHS
with a pointer on the right.

This patch does not suppress -Wzero-as-null-pointer-constant when users
are actually using it as NULL.

PiperOrigin-RevId: 236654634
      3dd2e841
    • Abseil Team's avatar
      Googletest export · a1dd0778
      Abseil Team authored 
      Build gmock cleanly with clang -Wextra-semi and -Wextra-semi-stmt

Extends 56ef07a2 to take -Wc++98-compat-extra-semi
(https://reviews.llvm.org/D43162) and -Wextra-semi-stmt
(https://reviews.llvm.org/D52695) into account.

For https://crbug.com/926235.

PiperOrigin-RevId: 236643095
      a1dd0778
  17. 01 Mar, 2019 3 commits
    • Abseil Team's avatar
      Googletest export · db9b85e2
      Abseil Team authored 
      Let embedders customize GTEST_INTERNAL_DEPRECATED().

GTEST_INTERNAL_DEPRECATED is currently used to nudge googletest users to migrate off old TEST_CASE macros to the new TEST_SUITE macros. This move is non-trivial for Chromium (see https://crbug.com/925652), and might be difficult for other big projects with many dependencies.

This CL facilitates moving off of deprecated APIs by making it possible for an embedder to define GTEST_INTERNAL_DEPRECATED() in gtest/internal/custom/gtest-port.h. Example usage:

1) #define GTEST_INTERNAL_DEPRECATED() to nothing, to disable deprecation warnings while migrating off googletest's deprecated APIs. This can be preferable to having to disable all deprecation warnings (-Wno-error=deprecated or -Wno-deprecated-declarations).

2) #define GTEST_INTERNAL_DEPRECATED() for an unsupported compiler.

PiperOrigin-RevId: 236171043
      db9b85e2
    • Abseil Team's avatar
      Googletest export · 56ef07a2
      Abseil Team authored 
      Build gmock cleanly with clang -Wextra-semi

For https://crbug.com/926235.
From https://github.com/google/googletest/pull/2139.
Fixes https://github.com/google/googletest/issues/2138.

PiperOrigin-RevId: 235832527
      56ef07a2
    • Carlo Wood's avatar
      Minor build system fixes. · fc979623
      Carlo Wood authored
      fc979623
  19. 25 Feb, 2019 3 commits
  21. 22 Feb, 2019 2 commits
  23. 21 Feb, 2019 2 commits
  25. 20 Feb, 2019 6 commits
  27. 19 Feb, 2019 2 commits
  29. 13 Feb, 2019 4 commits