- 26 Jan, 2023 1 commit
-
-
Abseil Team authored
Make document and example code more clear in the caveat section for potential memory leak with `SetUpTestSuite`. PiperOrigin-RevId: 504706717 Change-Id: I5842a4569f81f6c0d636099b5cdaabe778996949
-
- 25 Jan, 2023 6 commits
-
-
Tom Hughes authored
PiperOrigin-RevId: 504670738 Change-Id: Ib68b676403204098e89f536f9b8317f9f717c24d
-
Tom Hughes authored
Possible unbalanced tuple unpacking with sequence defined at line N: left side has 1 label(s), right side has 0 value(s) [unbalanced-tuple-unpacking] PiperOrigin-RevId: 504640001 Change-Id: If8d6038a9acf74a409cb6b6ee30cea7745b4b303
-
Tom Hughes authored
PiperOrigin-RevId: 504633130 Change-Id: I3fdbc83975fea97aa53f7325d323adead0a30e24
-
Abseil Team authored
PiperOrigin-RevId: 504591836 Change-Id: I48c93490d0c3b7c6bfaceceb1cef5eedeacfe6c6
-
Tom Hughes authored
These files were formatted with automated tools. The remaining Python files require some manual fix ups, so they will be fixed separately. PiperOrigin-RevId: 504579820 Change-Id: I3923bd414bffe3ded6163ec496cd09ace3951928
-
Tom Hughes authored
PiperOrigin-RevId: 504570278 Change-Id: Iab9c988b3a781eaafbdd97c924a74c2269125799
-
- 24 Jan, 2023 3 commits
-
-
Tom Hughes authored
PiperOrigin-RevId: 504325204 Change-Id: Iaa1d6d0ab1dccaaeef26f9cb109d530835499240
-
Tom Hughes authored
PiperOrigin-RevId: 504308485 Change-Id: Ia4ae97b2173b44b89aa5d987ddefd6e0c1488386
-
Derek Mauro authored
In #4113 a user says Max clashes with a macro. Since it is only used in a test, use std::numeric_limits::max() instead. Note that in headers, the macro issue can be mitigated with parenthesis like this: `(std::numeric_limits<T>::max)()` PiperOrigin-RevId: 504284906 Change-Id: Ibf430caec1a6afdf6b303534fec6a4fd00a6373f
-
- 18 Jan, 2023 1 commit
-
-
Abseil Team authored
PiperOrigin-RevId: 502901538 Change-Id: I0cf351b9ad1411ae9c45e09550c24e006a24e179
-
- 17 Jan, 2023 6 commits
-
-
Tom Hughes authored
assert_ -> assertTrue/assertFalse/assertIn/assertNotIn assertEquals -> assertEqual PiperOrigin-RevId: 502654909 Change-Id: I25d30095a83c3806606cb80d676b3c979495e6bd
-
Dino Radakovic authored
PiperOrigin-RevId: 502654465 Change-Id: I51269e8c389ad63f3737132feec1b6d20dc4c314
-
Tom Hughes authored
We're intentionally losing precision in this case, so add a cast. googletest/googletest/include/gtest/gtest-printers.h:532:9: error: implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision [-Werror,-Wimplicit-int-float-conversion] if (static_cast<int32_t>(val * mulfor6 + 0.5) / mulfor6 == val) return 6; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ googletest/googletest/include/gtest/gtest-printers.h:544:9: error: implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision [-Werror,-Wimplicit-int-float-conversion] if (static_cast<int32_t>(val / divfor6 + 0.5) * divfor6 == val) return 6; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ PiperOrigin-RevId: 502646042 Change-Id: I05989ee42675b531a9907616c9582a5a7c77bed6 -
Derek Mauro authored
PiperOrigin-RevId: 502644180 Change-Id: Id20b5e4eec22035da278f1767002657f66dbe79c
-
Derek Mauro authored
PiperOrigin-RevId: 502626077 Change-Id: I3aad27a8b725cf73163e52ef2e28e6cdfc13082b
-
Abseil Team authored
When checked out on Windows, the repo might use \r\n line endings, and so the golden output has them. Adjust for that. PiperOrigin-RevId: 502577222 Change-Id: Iabfe537f6d95a49bf6bdcb934e855d28c65f6f89
-
- 12 Jan, 2023 2 commits
-
-
Tom Hughes authored
../googlemock/test/gmock-actions_test.cc:687:36: warning: declaration of ‘v’ shadows a member of ‘testing::{anonymous}::ReturnTest_SupportsReferenceLikeReturnType_Test::TestBody()::Result’ [-Wshadow] 687 | Result(const std::vector<int>& v) : v(&v) {} // NOLINT | ~~~~~~~~~~~~~~~~~~~~~~~~^ ../googlemock/test/gmock-actions_test.cc:686:29: note: shadowed declaration is here 686 | const std::vector<int>* v; | ^ ../googlemock/test/gmock-actions_test.cc: In constructor ‘testing::{anonymous}::ReturnTest_PrefersConversionOperator_Test::TestBody()::Out::Out(int)’: ../googlemock/test/gmock-actions_test.cc:720:28: warning: declaration of ‘x’ shadows a member of ‘testing::{anonymous}::ReturnTest_PrefersConversionOperator_Test::TestBody()::Out’ [-Wshadow] 720 | explicit Out(const int x) : x(x) {} | ~~~~~~~~~~^ ../googlemock/test/gmock-actions_test.cc:718:9: note: shadowed declaration is here 718 | int x; | ^ PiperOrigin-RevId: 501580618 Change-Id: I584710fbbe440ec724f88746e51f3be5653c32d5 -
Derek Mauro authored
PiperOrigin-RevId: 501568410 Change-Id: I0f78cd96dc9204c8ec97a1cdd09a9d63a613cc5b
-
- 11 Jan, 2023 1 commit
-
-
Derek Mauro authored
PiperOrigin-RevId: 501282034 Change-Id: I0314ac566dc5e117db5a06c97d303e5cf8822d61
-
- 05 Jan, 2023 2 commits
-
-
Tom Hughes authored
Everywhere else in the code, we check the value of GTEST_OS_ESP8266, not just whether it is defined. PiperOrigin-RevId: 499946909 Change-Id: I86f7e8947abb4e928fc24d1416d8237987b27845
-
Tom Hughes authored
PiperOrigin-RevId: 499893032 Change-Id: I33304802b7c82ae2d008f3ee89df38866e5f57ba
-
- 04 Jan, 2023 2 commits
-
-
https://godbolt.org/z/Pe5aE59xGDerek Mauro authored
Fixes #4108 PiperOrigin-RevId: 499556061 Change-Id: I1cb1564f9b77e1825fddc9236965f4a3b661d96a
-
Tom Hughes authored
Use "#if defined(_MSC_VER)" instead of "#if _MSC_VER" to be consistent with other usages in the file and to work with the "-Wundef" warning. PiperOrigin-RevId: 499471290 Change-Id: I34a9442eecf266afd74d4332cab7d39766df4ed9
-
- 22 Dec, 2022 1 commit
-
-
Abseil Team authored
@platforms//os:* instead of from @build_tools//platforms:* See https://github.com/bazelbuild/bazel/issues/8622 Necessary to fix #4096 Also need the fix for #4098 PiperOrigin-RevId: 497182073 Change-Id: Ifd568b088d2f779755dd20264edfd5dad12ca9cc
-
- 20 Dec, 2022 2 commits
-
-
Abseil Team authored
PiperOrigin-RevId: 496679950 Change-Id: I2842050902876231d49a142165bcbb88d737505d
-
Dino Radakovic authored
PiperOrigin-RevId: 496642643 Change-Id: I178efeda76cbf46e5f4bb91454c205b9a060a4ea
-
- 19 Dec, 2022 1 commit
-
-
Abseil Team authored
It is good practice to specify a name for the `testing::Property` matcher's use in diagnostics, and we should do so in our examples. PiperOrigin-RevId: 496406309 Change-Id: Ibb4d1ba63771b5d6855442b91564027cda8ddaca
-
- 15 Dec, 2022 1 commit
-
-
Abseil Team authored
Clang warns on this pattern because it looks like the author might have meant to use the value of the first part of the comma operator, so it warns that it isn't being used. The cast here signals to Clang that this behavior is intentional. This was discovered while updating gmock in Android. Clang's -Wcomma warning is on by default with either -Wall or -Werror, so users of gmock with those on in combination with -Werror are unable to build without this fix. PiperOrigin-RevId: 495655990 Change-Id: Iaf27e2199669f5b6185a877738234e551b6b6556
-
- 14 Dec, 2022 1 commit
-
-
Abseil Team authored
EXPECT_CALL doesn't seem to make much sense here. I think the intent was to use EXPECT_THAT instead. PiperOrigin-RevId: 495427663 Change-Id: I39a16ea37282729d34017c6bcd331a60cedf1fbe
-
- 12 Dec, 2022 3 commits
-
-
Derek Mauro authored
PiperOrigin-RevId: 494820396 Change-Id: I1aa0a5a0f4796fde8d0424093370fd89ebd2592e
-
Abseil Team authored
PiperOrigin-RevId: 494786543 Change-Id: I7769558dd2ca046d8957bf352dc04cfb48ff7c3a
-
Abseil Team authored
Introduces a new porting flag (GTEST_HAS_FILE_SYSTEM) to indicate whether a platform supports filesystem operations. PiperOrigin-RevId: 494751986 Change-Id: I07f73bdf478a73934b8f1a69c1ab4abda1b231ae
-
- 08 Dec, 2022 1 commit
-
-
Tom Hughes authored
PiperOrigin-RevId: 493917905 Change-Id: I20137cfcda3671ffc8edcda2b6554aa392e3a00a
-
- 07 Dec, 2022 1 commit
-
-
Derek Mauro authored
forum for non-bugs PiperOrigin-RevId: 493632811 Change-Id: I7e02c3c479c2a925b7971f6a55e1e95a5a6f2d0a
-
- 06 Dec, 2022 1 commit
-
-
Derek Mauro authored
Fixes #4076 PiperOrigin-RevId: 493158910 Change-Id: Id66c0443a6f5f4d167ae39ac79766b32cf95a383
-
- 30 Nov, 2022 1 commit
-
-
Abseil Team authored
MatcherDescriberInterface specifies that DescribeTo "should print a verb phrase", but "size ..." is not a verb phrase. Currently, ElementsAre(SizeIs(9)) is described as "has 1 element that size is equal to 9". With this change, it will be described as "has 1 element that has a size that is equal to 9". PiperOrigin-RevId: 492022324 Change-Id: I4083335f2419462464957521c1e033643b53b763
-
- 29 Nov, 2022 1 commit
-
-
Abseil Team authored
Disables `-Wunused-member-function` and `-Wused-but-marked-unused` that trigger via `MOCK_METHOD()` and `EXPECT_THAT()` macros. Fixes: #4052, #4055 PiperOrigin-RevId: 491647393 Change-Id: I8e2ad838156fa8c7e9dccd1740af797e694992b6
-
- 23 Nov, 2022 1 commit
-
-
Abseil Team authored
PiperOrigin-RevId: 490601453 Change-Id: I733b2ed8740b1c809dddb166a42993b869198469
-
- 21 Nov, 2022 1 commit
-
-
Copybara-Service authored
PiperOrigin-RevId: 490057649 Change-Id: Ia788d55cfbc576e841064b8e907f8671cc46f3bf
-