GitLab

cleanup, merge

Optimize build matrix on pull requests

code cleanup in preparation for merges, cl 180857299

Pass the -Wmissing-declarations warning.

Also define GTEST_ATTRIBUTE_PRINTF_ in clang-cl.

Disable expensive builds on pull requests.

upstreaming cl 124976692

Run autoconf from top-level directory.

clang-cl is clang for Windows running in MSVC mode. Chromium uses it for
Windows builds. clang-cl is weird in that it defines __clang__ and
_MSC_VER, but *NOT* __GNUC__. This is vaguely analogous to how normal
clang defines __clang__ (what it is) and __GNUC__ (what it is compatible
with).

However, clang-cl still implements most GCC extensions, being clang.
Notably, the way to control -Wformat-literal is still with
__attribute__((__format__)). For better error-checking and strict
-Wformatl-literal compatibility (see
53c478d6), define
GTEST_ATTRIBUTE_PRINTF_ in clang-cl too.

This makes it easier to use GTest in projects that build with the
-Wmissing-declarations warning. This fixes the warning in headers and
source files, though not GTest's own tests as it is rather noisy there.

Fix testing::Combine on MSVC 2017.

Pass MSVC's C4826 warning.

OSS Sync, cl 163329677

On platforms with std::tuple and not std::tr1::tuple, GTEST_HAS_COMBINE
gets turned off when it works fine (due to GTEST_TUPLE_NAMESPACE_).
Elsewhere in the project, several GTEST_HAS_TR1_TUPLE checks
additionally check GTEST_HAS_STD_TUPLE_, so use that formulation.

(The ones that don't are specific to std::tr1::tuple and are followed by
an identical GTEST_HAS_STD_TUPLE_ version underneath it.)

In particular, this fixes testing::Combine on MSVC 2017, which regressed
here:
https://github.com/google/googletest/pull/1348#issuecomment-353879010

Avoid warning C4619 in MSVC 2017.

C4800 has since been removed in MSVC 2017, so trying to silence it
throws warning C4619 when enabled.

When this build works, we know the autoconf support is working.

Re-enable MSVC++ C4389 warning in CmdHelperEq()

C4389 was inhibited in commit 4b83461e making behavior inconsistent with
other compilers.

CMake fixes for paths with spaces