Skip to content

GitLab

Switch branch/tag
  1. 05 Dec, 2019 2 commits
  3. 02 Dec, 2019 3 commits
  5. 27 Nov, 2019 2 commits
  7. 26 Nov, 2019 8 commits
  9. 25 Nov, 2019 2 commits
  11. 22 Nov, 2019 10 commits
  13. 21 Nov, 2019 1 commit
  15. 20 Nov, 2019 2 commits
    • Gennadiy Civil's avatar
      Merge pull request #2569 from bgianfo:master · 200ff599
      Gennadiy Civil authored 
      PiperOrigin-RevId: 281321427
      200ff599
    • Abseil Team's avatar
      Googletest export · 4bf46623
      Abseil Team authored 
      Add a breadcrumb about nullopt comparison near the Optional() matcher.

Also add a note about how otherwise-spurious 'Eq()' may be needed in some cases. Without this, something like Field(&MyStruct::optional_field_without_equals_equals, absl::nullopt) doesn't work - it converts the nullopt to an optional<> of the non-equalable type, and fails to select the operator==(optional<>, nullopt_t) overload. The Eq() lets the type persist later into the match.

PiperOrigin-RevId: 281305519
      4bf46623
  17. 19 Nov, 2019 1 commit
    • Abseil Team's avatar
      Googletest export · 50cfbb72
      Abseil Team authored 
      Update stale comments to point to proper location.

PiperOrigin-RevId: 281157036
      50cfbb72
  19. 16 Nov, 2019 2 commits
    • xyb's avatar
      Fix internal memory leak in Windows _Crt report. · dcdb6506
      xyb authored 
      We use "MemoryIsNotDeallocated" to aovid internal expected leak reported
in Windows _Crt report, like:

    {
    #ifdef _MSC_VER
    	MemoryIsNotDeallocated memory_is_not_deeallocated;
    #endif

    	static ThreadIdToThreadLocals* map = new
	ThreadIdToThreadLocals();
	return map;
    }

But int the above code, only "new ThreadIdToThreadLocals()" is
protected, if we invoke "insert()" function of the return value,
the memory allocated in "insert()" will be reported to _Crt report
also. This change try to fix this issue.
      dcdb6506
    • Brian Gianforcaro's avatar
      Fix FlatTuple compilation on older msvc. · 0c469a5a
      Brian Gianforcaro authored 
      googletest 1.10.0 fails to compile on msvc version 19.00.23917
with one compilation error:

src\googletest\include\gtest\internal\gtest-internal.h(1188) : error C2039:
'FlatTupleBase<testing::internal::FlatTuple<bool,bool>,testing::internal::IndexSequence<0,1> >':
is not a member of 'testing::internal::FlatTuple<bool,bool>'

This PR fixes the compilation error by explicitly specifying the full type that Indices is
located in the base type.
      0c469a5a
  21. 15 Nov, 2019 1 commit
  23. 13 Nov, 2019 2 commits
  25. 08 Nov, 2019 2 commits
    • Abseil Team's avatar
      Googletest export · d5707695
      Abseil Team authored 
      Correctly deal with stringification, and forbid empty arguments where they could slip thought, in the type parameterized test API.

Note: even where empty args work, it's likely to result in technically invalid code by virtue of creating reserved identifiers:
https://en.cppreference.com/w/cpp/language/identifiers
PiperOrigin-RevId: 279330971
      d5707695
    • Abseil Team's avatar
      Googletest export · 681454da
      Abseil Team authored 
      Clone+exec death test allocates a single page of stack to run chdir + exec on.
This is not enough when gtest is built with ASan and run on particular
hardware.

With ASan on x86_64, ExecDeathTestChildMain has frame size of 1728 bytes.

Call to chdir() in ExecDeathTestChildMain ends up in
_dl_runtime_resolve_xsavec, which attempts to save register state on the stack;
according to cpuid(0xd) XSAVE register save area size is 2568 on my machine.

This results in something like this in all death tests:
  Result: died but not with expected error.
  ...
  [  DEATH   ] AddressSanitizer:DEADLYSIGNAL
  [  DEATH   ] =================================================================
  [  DEATH   ] ==178637==ERROR: AddressSanitizer: stack-overflow on address ...

PiperOrigin-RevId: 278709790
      681454da
  27. 05 Nov, 2019 2 commits