Skip to content

GitLab

Switch branch/tag
  1. 06 Mar, 2023 6 commits
    • Tom Hughes's avatar
      Remove GTEST_FOR_GOOGLE_ macro · 0bdd4508
      Tom Hughes authored 
      The "more details" warning message printed by this macro is no longer
needed.

PiperOrigin-RevId: 513945729
Change-Id: I644910216dbef2fe92eee3a648f2078e705cc7a1
      0bdd4508
    • Tom Hughes's avatar
      Replace "#if GTEST_HAS_ABSL" with "#ifdef GTEST_HAS_ABSL" · 16feffa8
      Tom Hughes authored 
      This allows compilation with "-Wundef" (#3267).

PiperOrigin-RevId: 513945230
Change-Id: I45ef19c7ff3d20e97216bd031d406a03365471da
      16feffa8
    • Tom Hughes's avatar
      Use "#ifdef" with public macros · dc10c3b5
      Tom Hughes authored 
      This allows compilation with "-Wundef" (#3267).

PiperOrigin-RevId: 513944726
Change-Id: I1a3854bb2333d5dec6c0ff91ee1eddd9a766ab91
      dc10c3b5
    • Tom Hughes's avatar
      Only define GTEST_IS_THREADSAFE to 1, not 0 · 7b1ced06
      Tom Hughes authored 
      According to the comments, "Feature-indicating macros",
such as GTEST_IS_THREADSAFE should be defined to 1 when supported
and otherwise undefined (never 0).

PiperOrigin-RevId: 513944266
Change-Id: I0f5c8bed107a5f20e957ec7c70339540ca2fe831
      7b1ced06
    • Tom Hughes's avatar
      Always specify definitions for internal macros · a08c03c5
      Tom Hughes authored 
      These macros should only be used within googletest, so changing them will not
affect external users.

This allows compiling with -Wundef (#3267).

PiperOrigin-RevId: 513943800
Change-Id: I697b1005c29b0d5af06f583f202d86db48b567b9
      a08c03c5
    • Tom Hughes's avatar
      Use "#ifdef GTEST_OS_..." instead of "#if GTEST_OS_..." · 23142843
      Tom Hughes authored 
      This is compatible with compiling with "-Wundef" (#3267).

PiperOrigin-RevId: 513943378
Change-Id: I47cf5fabbb77be061c4483a0adc54511af6b191c
      23142843
  3. 03 Mar, 2023 1 commit
    • Abseil Team's avatar
      Internal Code Change · cead3d57
      Abseil Team authored 
      PiperOrigin-RevId: 513770561
Change-Id: I82fbed177c6ba4e2e5b776ae3e0255c868e32e25
      cead3d57
  5. 28 Feb, 2023 3 commits
  7. 27 Feb, 2023 4 commits
  9. 24 Feb, 2023 1 commit
  11. 23 Feb, 2023 1 commit
  13. 22 Feb, 2023 2 commits
  15. 21 Feb, 2023 2 commits
    • Sergey's avatar
      Fix error in_death_test_child_process: undeclared identifier · 10493e38
      Sergey authored 
      The error occurs if !GTEST_HAS_DEATH_TEST on Windows.
      10493e38
    • Tom Hughes's avatar
      Remove int64_t cast in RecordProperty · 750d67d8
      Tom Hughes authored 
      Historically, calls to RecordProperty with values that are convertible to
int64_t have been casted to int64_t. The result was that types like float or
double would be truncated when printed (e.g., 4.75 -> 4). This change removes
the cast so that the types are printed in a more appropriate manner.

PiperOrigin-RevId: 511238685
Change-Id: I80de5db14462da2a3e1f476086025ae514383a17
      750d67d8
  17. 19 Feb, 2023 1 commit
  19. 16 Feb, 2023 1 commit
  21. 15 Feb, 2023 1 commit
    • Abseil Team's avatar
      Remove strdup usage · f063cd25
      Abseil Team authored 
      PiperOrigin-RevId: 509947007
Change-Id: I31e1274afa889776829c877c40c9af589298dcf2
      f063cd25
  23. 14 Feb, 2023 1 commit
  25. 13 Feb, 2023 1 commit
  27. 08 Feb, 2023 1 commit
    • Tom Hughes's avatar
      Fix _MSC_VER check · b73f27fd
      Tom Hughes authored 
      Use "#if defined(_MSC_VER)" instead of "#if _MSC_VER" to be consistent
with other usages in googletest and to work with the "-Wundef" warning.

PiperOrigin-RevId: 508087630
Change-Id: I29c16fd2fa51a9dfecd55e10362a020318318956
      b73f27fd
  29. 07 Feb, 2023 2 commits
  31. 06 Feb, 2023 1 commit
  33. 02 Feb, 2023 5 commits
    • Ben Yang's avatar
      Update testing.md · 3f9c7fca
      Ben Yang authored 
      Fixed Parameter Generator table
      3f9c7fca
    • Tom Hughes's avatar
      Fix compiler flags in Linux presubmit · 2f2e72ba
      Tom Hughes authored 
      CXX_FLAGS should be CXXFLAGS and the quoting was wrong.
As a result, "-Werror -Wdeprecated" was not being applied.

https://cmake.org/cmake/help/latest/envvar/CXXFLAGS.html

PiperOrigin-RevId: 506656655
Change-Id: Ic5e861be3b9c32257eb9aabb845c931f3cba7122
      2f2e72ba
    • Tom Hughes's avatar
      Fix -Wsign-conversion warnings · deaf5615
      Tom Hughes authored 
      googletest/test/gtest_xml_outfile2_test_.cc:48:39:
warning: implicit conversion turns floating-point number into integer:
'float' to 'int64_t' (aka 'long') [-Wfloat-conversion]
  RecordProperty("TestFloatProperty", float_prop);
  ~~~~~~~~~~~~~~                      ^~~~~~~~~~

googletest/test/gtest_xml_outfile2_test_.cc:51:40:
warning: implicit conversion turns floating-point number into integer:
'double' to 'int64_t' (aka 'long') [-Wfloat-conversion]
  RecordProperty("TestDoubleProperty", double_prop);
  ~~~~~~~~~~~~~~                       ^~~~~~~~~~~

googletest/test/gtest_xml_outfile2_test_.cc:57:39:
warning: implicit conversion changes signedness:
'size_t' (aka 'unsigned long') to 'int64_t' (aka 'long') [-Wsign-conversion]
  RecordProperty("TestSizetProperty", size_t_prop);
  ~~~~~~~~~~~~~~                      ^~~~~~~~~~~
PiperOrigin-RevId: 506644143
Change-Id: I9c2cd5f52daebe25e73bb97f696687797ed2cabf
      deaf5615
    • Tom Hughes's avatar
      Remove unneccessary "#if _MSC_VER" · 4f7c63d9
      Tom Hughes authored 
      The GTEST_DISABLE_MSC_WARNINGS macros already have an _MSC_VER check.
This change also adds a missing GTEST_DISABLE_MSC_WARNINGS_POP_ in
gtest-typed-test_test.cc.

PiperOrigin-RevId: 506636248
Change-Id: Ifdc044528f5448fbf0175887d1671f1e1f3040b9
      4f7c63d9
    • Abseil Team's avatar
      Add a trailing decimal point to FormatTimeInMillisAsSeconds() output when input · 6f21175f
      Abseil Team authored 
      is an exact N seconds.

PiperOrigin-RevId: 506610898
Change-Id: Idcd705c719e0e721148c350c8a14f27b9eb5c4f7
      6f21175f
  35. 01 Feb, 2023 4 commits
  37. 31 Jan, 2023 1 commit
    • Tom Hughes's avatar
      Fix sign conversion warning from clang: · d9251171
      Tom Hughes authored 
      googletest/samples/prime_tables.h:81:57: error:
implicit conversion changes signedness: 'int' to 'unsigned long'
[-Werror,-Wsign-conversion]
      : is_prime_size_(max + 1), is_prime_(new bool[max + 1]) {
                                           ~~~      ~~~~^~~

PiperOrigin-RevId: 506065360
Change-Id: Ida4550562531012c089e2f9fcf530b3a78889fa3
      d9251171
  39. 30 Jan, 2023 1 commit