Commit ed2fe122 authored by Enji Cooper's avatar Enji Cooper
Browse files

Fix -Wunused-private-field issues with clang



Provide dummy accessors for private values that are set in initializers,
but not actually used.
Signed-off-by: default avatarEnji Cooper <yaneurabeya@gmail.com>
parent c4ccab33
...@@ -982,6 +982,8 @@ class Unprintable { ...@@ -982,6 +982,8 @@ class Unprintable {
Unprintable() : c_('a') {} Unprintable() : c_('a') {}
bool operator==(const Unprintable& /* rhs */) const { return true; } bool operator==(const Unprintable& /* rhs */) const { return true; }
// -Wunused-private-field: dummy accessor for `c_`.
char dummy_c() { return c_; }
private: private:
char c_; char c_;
}; };
......
...@@ -964,6 +964,8 @@ INSTANTIATE_TEST_SUITE_P(StatefulNamingFunctor, StatefulNamingTest, Range(0, 5), ...@@ -964,6 +964,8 @@ INSTANTIATE_TEST_SUITE_P(StatefulNamingFunctor, StatefulNamingTest, Range(0, 5),
class Unstreamable { class Unstreamable {
public: public:
explicit Unstreamable(int value) : value_(value) {} explicit Unstreamable(int value) : value_(value) {}
// -Wunused-private-field: dummy accessor for `value_`.
const int& dummy_value() const { return value_; }
private: private:
int value_; int value_;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment