Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
yangql
googletest
Commits
b7587263
Commit
b7587263
authored
Jul 23, 2008
by
shiqian
Browse files
Fixes some style nits; also fixes minor bugs in gtest-death-test.cc.
parent
57b43f27
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
5 deletions
+5
-5
include/gtest/internal/gtest-internal.h
include/gtest/internal/gtest-internal.h
+2
-2
include/gtest/internal/gtest-port.h
include/gtest/internal/gtest-port.h
+1
-1
src/gtest-death-test.cc
src/gtest-death-test.cc
+2
-2
No files found.
include/gtest/internal/gtest-internal.h
View file @
b7587263
...
@@ -241,11 +241,11 @@ String FormatForFailureMessage(wchar_t wchar);
...
@@ -241,11 +241,11 @@ String FormatForFailureMessage(wchar_t wchar);
// This internal macro is used to avoid duplicated code.
// This internal macro is used to avoid duplicated code.
#define GTEST_FORMAT_IMPL(operand2_type, operand1_printer)\
#define GTEST_FORMAT_IMPL(operand2_type, operand1_printer)\
inline String FormatForComparisonFailureMessage(\
inline String FormatForComparisonFailureMessage(\
operand2_type::value_type* str, const operand2_type& operand2) {\
operand2_type::value_type* str, const operand2_type&
/*
operand2
*/
) {\
return operand1_printer(str);\
return operand1_printer(str);\
}\
}\
inline String FormatForComparisonFailureMessage(\
inline String FormatForComparisonFailureMessage(\
const operand2_type::value_type* str, const operand2_type& operand2) {\
const operand2_type::value_type* str, const operand2_type&
/*
operand2
*/
) {\
return operand1_printer(str);\
return operand1_printer(str);\
}
}
...
...
include/gtest/internal/gtest-port.h
View file @
b7587263
...
@@ -430,7 +430,7 @@ const ::std::vector<String>& GetArgvs();
...
@@ -430,7 +430,7 @@ const ::std::vector<String>& GetArgvs();
class
Mutex
{
class
Mutex
{
public:
public:
Mutex
()
{}
Mutex
()
{}
explicit
Mutex
(
int
unused
)
{}
explicit
Mutex
(
int
/*
unused
*/
)
{}
void
AssertHeld
()
const
{}
void
AssertHeld
()
const
{}
enum
{
NO_CONSTRUCTOR_NEEDED_FOR_STATIC_MUTEX
=
0
};
enum
{
NO_CONSTRUCTOR_NEEDED_FOR_STATIC_MUTEX
=
0
};
};
};
...
...
src/gtest-death-test.cc
View file @
b7587263
...
@@ -47,7 +47,7 @@
...
@@ -47,7 +47,7 @@
// prevent a user from accidentally including gtest-internal-inl.h in
// prevent a user from accidentally including gtest-internal-inl.h in
// his code.
// his code.
#define GTEST_IMPLEMENTATION
#define GTEST_IMPLEMENTATION
#include "gtest-internal-inl.h"
#include "
src/
gtest-internal-inl.h"
#undef GTEST_IMPLEMENTATION
#undef GTEST_IMPLEMENTATION
namespace
testing
{
namespace
testing
{
...
@@ -688,7 +688,7 @@ static void SplitString(const ::std::string& str, char delimiter,
...
@@ -688,7 +688,7 @@ static void SplitString(const ::std::string& str, char delimiter,
::
std
::
vector
<
::
std
::
string
>
parsed
;
::
std
::
vector
<
::
std
::
string
>
parsed
;
::
std
::
string
::
size_type
pos
=
0
;
::
std
::
string
::
size_type
pos
=
0
;
while
(
true
)
{
while
(
true
)
{
const
::
std
::
string
::
size_type
colon
=
str
.
find
(
':'
,
pos
);
const
::
std
::
string
::
size_type
colon
=
str
.
find
(
delimiter
,
pos
);
if
(
colon
==
::
std
::
string
::
npos
)
{
if
(
colon
==
::
std
::
string
::
npos
)
{
parsed
.
push_back
(
str
.
substr
(
pos
));
parsed
.
push_back
(
str
.
substr
(
pos
));
break
;
break
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment