Merge pull request #1225 from brian-peloton/master

Speed up printing of characters which need hex escaping

Merge pull request #1225 from brian-peloton/master
Speed up printing of characters which need hex escaping
a868e618 · Gennadiy Civil · GitHub · 247a3d8e · 9e236748 · a868e618
Unverified Commit a868e618 authored Dec 05, 2017 by Gennadiy Civil Committed by GitHub Dec 05, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

googletest/src/gtest-printers.cc googletest/src/gtest-printers.cc +4 -1

No files found.
--- a/googletest/src/gtest-printers.cc
+++ b/googletest/src/gtest-printers.cc
@@ -180,7 +180,10 @@ static CharFormat PrintAsCharLiteralTo(Char c, ostream* os) {
        *os << static_cast<char>(c);
        return kAsIs;
      } else {
-        *os << "\\x" + String::FormatHexInt(static_cast<UnsignedChar>(c));
+        ostream::fmtflags flags = os->flags();
+        *os << "\\x" << std::hex << std::uppercase
+            << static_cast<int>(static_cast<UnsignedChar>(c));
+        os->flags(flags);
        return kHexEscape;
      }
  }