"git@developer.sourcefind.cn:yangql/googletest.git" did not exist on "065a0c8140dd366411b85a51911b5095753c9295"
Unverified Commit 386391b0 authored by Jonathan Wendeborn's avatar Jonathan Wendeborn
Browse files

Use existing Mock::GetReactionOnUninterestingCalls()

parent 6bbf911a
...@@ -707,31 +707,17 @@ bool Mock::VerifyAndClearExpectationsLocked(void* mock_obj) ...@@ -707,31 +707,17 @@ bool Mock::VerifyAndClearExpectationsLocked(void* mock_obj)
return expectations_met; return expectations_met;
} }
namespace {
// checks whether the specified mock_obj has a registered call reaction
bool HasCallReaction(void* mock_obj, internal::CallReaction reaction) {
const auto found = g_uninteresting_call_reaction.find(mock_obj);
if (found == g_uninteresting_call_reaction.cend()) {
return internal::kDefault == reaction;
}
return found->second == reaction;
}
}
bool Mock::IsNaggy(void* mock_obj) bool Mock::IsNaggy(void* mock_obj)
GTEST_LOCK_EXCLUDED_(internal::g_gmock_mutex) { GTEST_LOCK_EXCLUDED_(internal::g_gmock_mutex) {
internal::MutexLock l(&internal::g_gmock_mutex); return Mock::GetReactionOnUninterestingCalls(mock_obj) == internal::kWarn;
return HasCallReaction(mock_obj, internal::kWarn);
} }
bool Mock::IsNice(void* mock_obj) bool Mock::IsNice(void* mock_obj)
GTEST_LOCK_EXCLUDED_(internal::g_gmock_mutex) { GTEST_LOCK_EXCLUDED_(internal::g_gmock_mutex) {
internal::MutexLock l(&internal::g_gmock_mutex); return Mock::GetReactionOnUninterestingCalls(mock_obj) == internal::kAllow;
return HasCallReaction(mock_obj, internal::kAllow);
} }
bool Mock::IsStrict(void* mock_obj) bool Mock::IsStrict(void* mock_obj)
GTEST_LOCK_EXCLUDED_(internal::g_gmock_mutex) { GTEST_LOCK_EXCLUDED_(internal::g_gmock_mutex) {
internal::MutexLock l(&internal::g_gmock_mutex); return Mock::GetReactionOnUninterestingCalls(mock_obj) == internal::kFail;
return HasCallReaction(mock_obj, internal::kFail);
} }
// Registers a mock object and a mock method it owns. // Registers a mock object and a mock method it owns.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment