Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
yangql
googletest
Commits
265efde9
Commit
265efde9
authored
Aug 14, 2018
by
Gennadiy Civil
Browse files
Comments changes, no functionality changes.
parent
3306848f
Changes
47
Show whitespace changes
Inline
Side-by-side
Showing
20 changed files
with
25 additions
and
49 deletions
+25
-49
googletest/src/gtest.cc
googletest/src/gtest.cc
+15
-15
googletest/test/googletest-break-on-failure-unittest.py
googletest/test/googletest-break-on-failure-unittest.py
+0
-2
googletest/test/googletest-catch-exceptions-test.py
googletest/test/googletest-catch-exceptions-test.py
+0
-2
googletest/test/googletest-color-test.py
googletest/test/googletest-color-test.py
+0
-2
googletest/test/googletest-death-test-test.cc
googletest/test/googletest-death-test-test.cc
+1
-1
googletest/test/googletest-env-var-test.py
googletest/test/googletest-env-var-test.py
+0
-2
googletest/test/googletest-filepath-test.cc
googletest/test/googletest-filepath-test.cc
+1
-1
googletest/test/googletest-filter-unittest.py
googletest/test/googletest-filter-unittest.py
+0
-2
googletest/test/googletest-json-outfiles-test.py
googletest/test/googletest-json-outfiles-test.py
+2
-2
googletest/test/googletest-list-tests-unittest.py
googletest/test/googletest-list-tests-unittest.py
+0
-2
googletest/test/googletest-options-test.cc
googletest/test/googletest-options-test.cc
+1
-1
googletest/test/googletest-output-test.py
googletest/test/googletest-output-test.py
+1
-3
googletest/test/googletest-param-test-invalid-name1-test.py
googletest/test/googletest-param-test-invalid-name1-test.py
+0
-2
googletest/test/googletest-param-test-invalid-name2-test.py
googletest/test/googletest-param-test-invalid-name2-test.py
+0
-2
googletest/test/googletest-param-test-test.cc
googletest/test/googletest-param-test-test.cc
+1
-1
googletest/test/googletest-port-test.cc
googletest/test/googletest-port-test.cc
+1
-1
googletest/test/googletest-shuffle-test.py
googletest/test/googletest-shuffle-test.py
+0
-2
googletest/test/googletest-test-part-test.cc
googletest/test/googletest-test-part-test.cc
+1
-1
googletest/test/googletest-throw-on-failure-test.py
googletest/test/googletest-throw-on-failure-test.py
+1
-3
googletest/test/googletest-uninitialized-test.py
googletest/test/googletest-uninitialized-test.py
+0
-2
No files found.
googletest/src/gtest.cc
View file @
265efde9
...
@@ -54,7 +54,7 @@
...
@@ -54,7 +54,7 @@
#if GTEST_OS_LINUX
#if GTEST_OS_LINUX
//
TODO(kenton@google.com)
: Use autoconf to detect availability of
//
FIXME
: Use autoconf to detect availability of
// gettimeofday().
// gettimeofday().
# define GTEST_HAS_GETTIMEOFDAY_ 1
# define GTEST_HAS_GETTIMEOFDAY_ 1
...
@@ -93,9 +93,9 @@
...
@@ -93,9 +93,9 @@
# if GTEST_OS_WINDOWS_MINGW
# if GTEST_OS_WINDOWS_MINGW
// MinGW has gettimeofday() but not _ftime64().
// MinGW has gettimeofday() but not _ftime64().
//
TODO(kenton@google.com)
: Use autoconf to detect availability of
//
FIXME
: Use autoconf to detect availability of
// gettimeofday().
// gettimeofday().
//
TODO(kenton@google.com)
: There are other ways to get the time on
//
FIXME
: There are other ways to get the time on
// Windows, like GetTickCount() or GetSystemTimeAsFileTime(). MinGW
// Windows, like GetTickCount() or GetSystemTimeAsFileTime(). MinGW
// supports these. consider using them instead.
// supports these. consider using them instead.
# define GTEST_HAS_GETTIMEOFDAY_ 1
# define GTEST_HAS_GETTIMEOFDAY_ 1
...
@@ -110,7 +110,7 @@
...
@@ -110,7 +110,7 @@
#else
#else
// Assume other platforms have gettimeofday().
// Assume other platforms have gettimeofday().
//
TODO(kenton@google.com)
: Use autoconf to detect availability of
//
FIXME
: Use autoconf to detect availability of
// gettimeofday().
// gettimeofday().
# define GTEST_HAS_GETTIMEOFDAY_ 1
# define GTEST_HAS_GETTIMEOFDAY_ 1
...
@@ -467,7 +467,7 @@ std::string UnitTestOptions::GetAbsolutePathToOutputFile() {
...
@@ -467,7 +467,7 @@ std::string UnitTestOptions::GetAbsolutePathToOutputFile() {
internal
::
FilePath
output_name
(
colon
+
1
);
internal
::
FilePath
output_name
(
colon
+
1
);
if
(
!
output_name
.
IsAbsolutePath
())
if
(
!
output_name
.
IsAbsolutePath
())
//
TODO(wan@google.com)
: on Windows \some\path is not an absolute
//
FIXME
: on Windows \some\path is not an absolute
// path (as its meaning depends on the current drive), yet the
// path (as its meaning depends on the current drive), yet the
// following logic for turning it into an absolute path is wrong.
// following logic for turning it into an absolute path is wrong.
// Fix it.
// Fix it.
...
@@ -841,7 +841,7 @@ TimeInMillis GetTimeInMillis() {
...
@@ -841,7 +841,7 @@ TimeInMillis GetTimeInMillis() {
SYSTEMTIME
now_systime
;
SYSTEMTIME
now_systime
;
FILETIME
now_filetime
;
FILETIME
now_filetime
;
ULARGE_INTEGER
now_int64
;
ULARGE_INTEGER
now_int64
;
//
TODO(kenton@google.com)
: Shouldn't this just use
//
FIXME
: Shouldn't this just use
// GetSystemTimeAsFileTime()?
// GetSystemTimeAsFileTime()?
GetSystemTime
(
&
now_systime
);
GetSystemTime
(
&
now_systime
);
if
(
SystemTimeToFileTime
(
&
now_systime
,
&
now_filetime
))
{
if
(
SystemTimeToFileTime
(
&
now_systime
,
&
now_filetime
))
{
...
@@ -857,7 +857,7 @@ TimeInMillis GetTimeInMillis() {
...
@@ -857,7 +857,7 @@ TimeInMillis GetTimeInMillis() {
// MSVC 8 deprecates _ftime64(), so we want to suppress warning 4996
// MSVC 8 deprecates _ftime64(), so we want to suppress warning 4996
// (deprecated function) there.
// (deprecated function) there.
//
TODO(kenton@google.com)
: Use GetTickCount()? Or use
//
FIXME
: Use GetTickCount()? Or use
// SystemTimeToFileTime()
// SystemTimeToFileTime()
GTEST_DISABLE_MSC_DEPRECATED_PUSH_
()
GTEST_DISABLE_MSC_DEPRECATED_PUSH_
()
_ftime64
(
&
now
);
_ftime64
(
&
now
);
...
@@ -1396,7 +1396,7 @@ AssertionResult DoubleNearPredFormat(const char* expr1,
...
@@ -1396,7 +1396,7 @@ AssertionResult DoubleNearPredFormat(const char* expr1,
const
double
diff
=
fabs
(
val1
-
val2
);
const
double
diff
=
fabs
(
val1
-
val2
);
if
(
diff
<=
abs_error
)
return
AssertionSuccess
();
if
(
diff
<=
abs_error
)
return
AssertionSuccess
();
//
TODO(wan)
: do not print the value of an expression if it's
//
FIXME
: do not print the value of an expression if it's
// already a literal.
// already a literal.
return
AssertionFailure
()
return
AssertionFailure
()
<<
"The difference between "
<<
expr1
<<
" and "
<<
expr2
<<
"The difference between "
<<
expr1
<<
" and "
<<
expr2
...
@@ -3334,7 +3334,7 @@ void TestEventRepeater::Append(TestEventListener *listener) {
...
@@ -3334,7 +3334,7 @@ void TestEventRepeater::Append(TestEventListener *listener) {
listeners_
.
push_back
(
listener
);
listeners_
.
push_back
(
listener
);
}
}
//
TODO(vladl@google.com)
: Factor the search functionality into Vector::Find.
//
FIXME
: Factor the search functionality into Vector::Find.
TestEventListener
*
TestEventRepeater
::
Release
(
TestEventListener
*
listener
)
{
TestEventListener
*
TestEventRepeater
::
Release
(
TestEventListener
*
listener
)
{
for
(
size_t
i
=
0
;
i
<
listeners_
.
size
();
++
i
)
{
for
(
size_t
i
=
0
;
i
<
listeners_
.
size
();
++
i
)
{
if
(
listeners_
[
i
]
==
listener
)
{
if
(
listeners_
[
i
]
==
listener
)
{
...
@@ -3499,7 +3499,7 @@ void XmlUnitTestResultPrinter::OnTestIterationEnd(const UnitTest& unit_test,
...
@@ -3499,7 +3499,7 @@ void XmlUnitTestResultPrinter::OnTestIterationEnd(const UnitTest& unit_test,
xmlout
=
posix
::
FOpen
(
output_file_
.
c_str
(),
"w"
);
xmlout
=
posix
::
FOpen
(
output_file_
.
c_str
(),
"w"
);
}
}
if
(
xmlout
==
NULL
)
{
if
(
xmlout
==
NULL
)
{
//
TODO(wan)
: report the reason of the failure.
//
FIXME
: report the reason of the failure.
//
//
// We don't do it for now as:
// We don't do it for now as:
//
//
...
@@ -3528,7 +3528,7 @@ void XmlUnitTestResultPrinter::OnTestIterationEnd(const UnitTest& unit_test,
...
@@ -3528,7 +3528,7 @@ void XmlUnitTestResultPrinter::OnTestIterationEnd(const UnitTest& unit_test,
// module will consist of ordinary English text.
// module will consist of ordinary English text.
// If this module is ever modified to produce version 1.1 XML output,
// If this module is ever modified to produce version 1.1 XML output,
// most invalid characters can be retained using character references.
// most invalid characters can be retained using character references.
//
TODO(wan)
: It might be nice to have a minimally invasive, human-readable
//
FIXME
: It might be nice to have a minimally invasive, human-readable
// escaping scheme for invalid characters, rather than dropping them.
// escaping scheme for invalid characters, rather than dropping them.
std
::
string
XmlUnitTestResultPrinter
::
EscapeXml
(
std
::
string
XmlUnitTestResultPrinter
::
EscapeXml
(
const
std
::
string
&
str
,
bool
is_attribute
)
{
const
std
::
string
&
str
,
bool
is_attribute
)
{
...
@@ -3679,7 +3679,7 @@ void XmlUnitTestResultPrinter::OutputXmlAttribute(
...
@@ -3679,7 +3679,7 @@ void XmlUnitTestResultPrinter::OutputXmlAttribute(
}
}
// Prints an XML representation of a TestInfo object.
// Prints an XML representation of a TestInfo object.
//
TODO(wan)
: There is also value in printing properties with the plain printer.
//
FIXME
: There is also value in printing properties with the plain printer.
void
XmlUnitTestResultPrinter
::
OutputXmlTestInfo
(
::
std
::
ostream
*
stream
,
void
XmlUnitTestResultPrinter
::
OutputXmlTestInfo
(
::
std
::
ostream
*
stream
,
const
char
*
test_case_name
,
const
char
*
test_case_name
,
const
TestInfo
&
test_info
)
{
const
TestInfo
&
test_info
)
{
...
@@ -3906,7 +3906,7 @@ void JsonUnitTestResultPrinter::OnTestIterationEnd(const UnitTest& unit_test,
...
@@ -3906,7 +3906,7 @@ void JsonUnitTestResultPrinter::OnTestIterationEnd(const UnitTest& unit_test,
jsonout
=
posix
::
FOpen
(
output_file_
.
c_str
(),
"w"
);
jsonout
=
posix
::
FOpen
(
output_file_
.
c_str
(),
"w"
);
}
}
if
(
jsonout
==
NULL
)
{
if
(
jsonout
==
NULL
)
{
//
TODO(phosek)
: report the reason of the failure.
//
FIXME
: report the reason of the failure.
//
//
// We don't do it for now as:
// We don't do it for now as:
//
//
...
@@ -4721,7 +4721,7 @@ int UnitTest::Run() {
...
@@ -4721,7 +4721,7 @@ int UnitTest::Run() {
// VC++ doesn't define _set_abort_behavior() prior to the version 8.0.
// VC++ doesn't define _set_abort_behavior() prior to the version 8.0.
// Users of prior VC versions shall suffer the agony and pain of
// Users of prior VC versions shall suffer the agony and pain of
// clicking through the countless debug dialogs.
// clicking through the countless debug dialogs.
//
TODO(vladl@google.com)
: find a way to suppress the abort dialog() in the
//
FIXME
: find a way to suppress the abort dialog() in the
// debug mode when compiled with VC 7.1 or lower.
// debug mode when compiled with VC 7.1 or lower.
if
(
!
GTEST_FLAG
(
break_on_failure
))
if
(
!
GTEST_FLAG
(
break_on_failure
))
_set_abort_behavior
(
_set_abort_behavior
(
...
@@ -5615,7 +5615,7 @@ static bool HasGoogleTestFlagPrefix(const char* str) {
...
@@ -5615,7 +5615,7 @@ static bool HasGoogleTestFlagPrefix(const char* str) {
// @Y changes the color to yellow.
// @Y changes the color to yellow.
// @D changes to the default terminal text color.
// @D changes to the default terminal text color.
//
//
//
TODO(wan@google.com)
: Write tests for this once we add stdout
//
FIXME
: Write tests for this once we add stdout
// capturing to Google Test.
// capturing to Google Test.
static
void
PrintColorEncoded
(
const
char
*
str
)
{
static
void
PrintColorEncoded
(
const
char
*
str
)
{
GTestColor
color
=
COLOR_DEFAULT
;
// The current color.
GTestColor
color
=
COLOR_DEFAULT
;
// The current color.
...
...
googletest/test/googletest-break-on-failure-unittest.py
View file @
265efde9
...
@@ -38,8 +38,6 @@ by invoking googletest-break-on-failure-unittest_ (a program written with
...
@@ -38,8 +38,6 @@ by invoking googletest-break-on-failure-unittest_ (a program written with
Google Test) with different environments and command line flags.
Google Test) with different environments and command line flags.
"""
"""
__author__
=
'wan@google.com (Zhanyong Wan)'
import
os
import
os
import
gtest_test_utils
import
gtest_test_utils
...
...
googletest/test/googletest-catch-exceptions-test.py
View file @
265efde9
...
@@ -35,8 +35,6 @@ googletest-catch-exceptions-ex-test_ (programs written with
...
@@ -35,8 +35,6 @@ googletest-catch-exceptions-ex-test_ (programs written with
Google Test) and verifies their output.
Google Test) and verifies their output.
"""
"""
__author__
=
'vladl@google.com (Vlad Losev)'
import
gtest_test_utils
import
gtest_test_utils
# Constants.
# Constants.
...
...
googletest/test/googletest-color-test.py
View file @
265efde9
...
@@ -31,8 +31,6 @@
...
@@ -31,8 +31,6 @@
"""Verifies that Google Test correctly determines whether to use colors."""
"""Verifies that Google Test correctly determines whether to use colors."""
__author__
=
'wan@google.com (Zhanyong Wan)'
import
os
import
os
import
gtest_test_utils
import
gtest_test_utils
...
...
googletest/test/googletest-death-test-test.cc
View file @
265efde9
...
@@ -1279,7 +1279,7 @@ TEST(ParseNaturalNumberTest, WorksForShorterIntegers) {
...
@@ -1279,7 +1279,7 @@ TEST(ParseNaturalNumberTest, WorksForShorterIntegers) {
# if GTEST_OS_WINDOWS
# if GTEST_OS_WINDOWS
TEST
(
EnvironmentTest
,
HandleFitsIntoSizeT
)
{
TEST
(
EnvironmentTest
,
HandleFitsIntoSizeT
)
{
//
TODO(vladl@google.com)
: Remove this test after this condition is verified
//
FIXME
: Remove this test after this condition is verified
// in a static assertion in gtest-death-test.cc in the function
// in a static assertion in gtest-death-test.cc in the function
// GetStatusFileDescriptor.
// GetStatusFileDescriptor.
ASSERT_TRUE
(
sizeof
(
HANDLE
)
<=
sizeof
(
size_t
));
ASSERT_TRUE
(
sizeof
(
HANDLE
)
<=
sizeof
(
size_t
));
...
...
googletest/test/googletest-env-var-test.py
View file @
265efde9
...
@@ -31,8 +31,6 @@
...
@@ -31,8 +31,6 @@
"""Verifies that Google Test correctly parses environment variables."""
"""Verifies that Google Test correctly parses environment variables."""
__author__
=
'wan@google.com (Zhanyong Wan)'
import
os
import
os
import
gtest_test_utils
import
gtest_test_utils
...
...
googletest/test/googletest-filepath-test.cc
View file @
265efde9
...
@@ -50,7 +50,7 @@ namespace internal {
...
@@ -50,7 +50,7 @@ namespace internal {
namespace
{
namespace
{
#if GTEST_OS_WINDOWS_MOBILE
#if GTEST_OS_WINDOWS_MOBILE
//
TODO(wan@google.com)
: Move these to the POSIX adapter section in
//
FIXME
: Move these to the POSIX adapter section in
// gtest-port.h.
// gtest-port.h.
// Windows CE doesn't have the remove C function.
// Windows CE doesn't have the remove C function.
...
...
googletest/test/googletest-filter-unittest.py
View file @
265efde9
...
@@ -40,8 +40,6 @@ Note that test sharding may also influence which tests are filtered. Therefore,
...
@@ -40,8 +40,6 @@ Note that test sharding may also influence which tests are filtered. Therefore,
we test that here also.
we test that here also.
"""
"""
__author__
=
'wan@google.com (Zhanyong Wan)'
import
os
import
os
import
re
import
re
import
sets
import
sets
...
...
googletest/test/googletest-json-outfiles-test.py
View file @
265efde9
...
@@ -136,11 +136,11 @@ class GTestJsonOutFilesTest(gtest_test_utils.TestCase):
...
@@ -136,11 +136,11 @@ class GTestJsonOutFilesTest(gtest_test_utils.TestCase):
self
.
assert_
(
p
.
exited
)
self
.
assert_
(
p
.
exited
)
self
.
assertEquals
(
0
,
p
.
exit_code
)
self
.
assertEquals
(
0
,
p
.
exit_code
)
#
TODO(wan@google.com)
: libtool causes the built test binary to be
#
FIXME
: libtool causes the built test binary to be
# named lt-gtest_xml_outfiles_test_ instead of
# named lt-gtest_xml_outfiles_test_ instead of
# gtest_xml_outfiles_test_. To account for this possibility, we
# gtest_xml_outfiles_test_. To account for this possibility, we
# allow both names in the following code. We should remove this
# allow both names in the following code. We should remove this
#
hack when Chandler Carruth's
libtool replacement tool is ready.
#
when
libtool replacement tool is ready.
output_file_name1
=
test_name
+
'.json'
output_file_name1
=
test_name
+
'.json'
output_file1
=
os
.
path
.
join
(
self
.
output_dir_
,
output_file_name1
)
output_file1
=
os
.
path
.
join
(
self
.
output_dir_
,
output_file_name1
)
output_file_name2
=
'lt-'
+
output_file_name1
output_file_name2
=
'lt-'
+
output_file_name1
...
...
googletest/test/googletest-list-tests-unittest.py
View file @
265efde9
...
@@ -37,8 +37,6 @@ by invoking googletest-list-tests-unittest_ (a program written with
...
@@ -37,8 +37,6 @@ by invoking googletest-list-tests-unittest_ (a program written with
Google Test) the command line flags.
Google Test) the command line flags.
"""
"""
__author__
=
'phanna@google.com (Patrick Hanna)'
import
re
import
re
import
gtest_test_utils
import
gtest_test_utils
...
...
googletest/test/googletest-options-test.cc
View file @
265efde9
...
@@ -105,7 +105,7 @@ TEST(OutputFileHelpersTest, GetCurrentExecutableName) {
...
@@ -105,7 +105,7 @@ TEST(OutputFileHelpersTest, GetCurrentExecutableName) {
#elif GTEST_OS_FUCHSIA
#elif GTEST_OS_FUCHSIA
const
bool
success
=
exe_str
==
"app"
;
const
bool
success
=
exe_str
==
"app"
;
#else
#else
//
TODO(wan@google.com)
: remove the hard-coded "lt-" prefix when
//
FIXME
: remove the hard-coded "lt-" prefix when
// Chandler Carruth's libtool replacement is ready.
// Chandler Carruth's libtool replacement is ready.
const
bool
success
=
const
bool
success
=
exe_str
==
"googletest-options-test"
||
exe_str
==
"googletest-options-test"
||
...
...
googletest/test/googletest-output-test.py
View file @
265efde9
...
@@ -38,8 +38,6 @@ googletest_output_test.py --gengolden
...
@@ -38,8 +38,6 @@ googletest_output_test.py --gengolden
googletest_output_test.py
googletest_output_test.py
"""
"""
__author__
=
'wan@google.com (Zhanyong Wan)'
import
difflib
import
difflib
import
os
import
os
import
re
import
re
...
@@ -57,7 +55,7 @@ NO_STACKTRACE_SUPPORT_FLAG = '--no_stacktrace_support'
...
@@ -57,7 +55,7 @@ NO_STACKTRACE_SUPPORT_FLAG = '--no_stacktrace_support'
IS_LINUX
=
os
.
name
==
'posix'
and
os
.
uname
()[
0
]
==
'Linux'
IS_LINUX
=
os
.
name
==
'posix'
and
os
.
uname
()[
0
]
==
'Linux'
IS_WINDOWS
=
os
.
name
==
'nt'
IS_WINDOWS
=
os
.
name
==
'nt'
#
TODO(vladl@google.com)
: remove the _lin suffix.
#
FIXME
: remove the _lin suffix.
GOLDEN_NAME
=
'googletest-output-test-golden-lin.txt'
GOLDEN_NAME
=
'googletest-output-test-golden-lin.txt'
PROGRAM_PATH
=
gtest_test_utils
.
GetTestExecutablePath
(
'googletest-output-test_'
)
PROGRAM_PATH
=
gtest_test_utils
.
GetTestExecutablePath
(
'googletest-output-test_'
)
...
...
googletest/test/googletest-param-test-invalid-name1-test.py
View file @
265efde9
...
@@ -30,8 +30,6 @@
...
@@ -30,8 +30,6 @@
"""Verifies that Google Test warns the user when not initialized properly."""
"""Verifies that Google Test warns the user when not initialized properly."""
__author__
=
'jmadill@google.com (Jamie Madill)'
import
gtest_test_utils
import
gtest_test_utils
binary_name
=
'googletest-param-test-invalid-name1-test_'
binary_name
=
'googletest-param-test-invalid-name1-test_'
...
...
googletest/test/googletest-param-test-invalid-name2-test.py
View file @
265efde9
...
@@ -30,8 +30,6 @@
...
@@ -30,8 +30,6 @@
"""Verifies that Google Test warns the user when not initialized properly."""
"""Verifies that Google Test warns the user when not initialized properly."""
__author__
=
'jmadill@google.com (Jamie Madill)'
import
gtest_test_utils
import
gtest_test_utils
binary_name
=
'googletest-param-test-invalid-name2-test_'
binary_name
=
'googletest-param-test-invalid-name2-test_'
...
...
googletest/test/googletest-param-test-test.cc
View file @
265efde9
...
@@ -67,7 +67,7 @@ using ::testing::internal::UnitTestOptions;
...
@@ -67,7 +67,7 @@ using ::testing::internal::UnitTestOptions;
// Prints a value to a string.
// Prints a value to a string.
//
//
//
TODO(wan@google.com)
: remove PrintValue() when we move matchers and
//
FIXME
: remove PrintValue() when we move matchers and
// EXPECT_THAT() from Google Mock to Google Test. At that time, we
// EXPECT_THAT() from Google Mock to Google Test. At that time, we
// can write EXPECT_THAT(x, Eq(y)) to compare two tuples x and y, as
// can write EXPECT_THAT(x, Eq(y)) to compare two tuples x and y, as
// EXPECT_THAT() and the matchers know how to print tuples.
// EXPECT_THAT() and the matchers know how to print tuples.
...
...
googletest/test/googletest-port-test.cc
View file @
265efde9
...
@@ -224,7 +224,7 @@ TEST(ScopedPtrTest, DefinesElementType) {
...
@@ -224,7 +224,7 @@ TEST(ScopedPtrTest, DefinesElementType) {
StaticAssertTypeEq
<
int
,
::
testing
::
internal
::
scoped_ptr
<
int
>::
element_type
>
();
StaticAssertTypeEq
<
int
,
::
testing
::
internal
::
scoped_ptr
<
int
>::
element_type
>
();
}
}
//
TODO(vladl@google.com)
: Implement THE REST of scoped_ptr tests.
//
FIXME
: Implement THE REST of scoped_ptr tests.
TEST
(
GtestCheckSyntaxTest
,
BehavesLikeASingleStatement
)
{
TEST
(
GtestCheckSyntaxTest
,
BehavesLikeASingleStatement
)
{
if
(
AlwaysFalse
())
if
(
AlwaysFalse
())
...
...
googletest/test/googletest-shuffle-test.py
View file @
265efde9
...
@@ -30,8 +30,6 @@
...
@@ -30,8 +30,6 @@
"""Verifies that test shuffling works."""
"""Verifies that test shuffling works."""
__author__
=
'wan@google.com (Zhanyong Wan)'
import
os
import
os
import
gtest_test_utils
import
gtest_test_utils
...
...
googletest/test/googletest-test-part-test.cc
View file @
265efde9
...
@@ -200,6 +200,6 @@ TEST_F(TestPartResultArrayDeathTest, DiesWhenIndexIsOutOfBound) {
...
@@ -200,6 +200,6 @@ TEST_F(TestPartResultArrayDeathTest, DiesWhenIndexIsOutOfBound) {
EXPECT_DEATH_IF_SUPPORTED
(
results
.
GetTestPartResult
(
1
),
""
);
EXPECT_DEATH_IF_SUPPORTED
(
results
.
GetTestPartResult
(
1
),
""
);
}
}
//
TODO(mheule@google.com)
: Add a test for the class HasNewFatalFailureHelper.
//
FIXME
: Add a test for the class HasNewFatalFailureHelper.
}
// namespace
}
// namespace
googletest/test/googletest-throw-on-failure-test.py
View file @
265efde9
...
@@ -35,8 +35,6 @@ This script invokes googletest-throw-on-failure-test_ (a program written with
...
@@ -35,8 +35,6 @@ This script invokes googletest-throw-on-failure-test_ (a program written with
Google Test) with different environments and command line flags.
Google Test) with different environments and command line flags.
"""
"""
__author__
=
'wan@google.com (Zhanyong Wan)'
import
os
import
os
import
gtest_test_utils
import
gtest_test_utils
...
@@ -75,7 +73,7 @@ def Run(command):
...
@@ -75,7 +73,7 @@ def Run(command):
return
p
.
exited
and
p
.
exit_code
==
0
return
p
.
exited
and
p
.
exit_code
==
0
# The tests.
TODO(wan@google.com)
: refactor the class to share common
# The tests.
FIXME
: refactor the class to share common
# logic with code in googletest-break-on-failure-unittest.py.
# logic with code in googletest-break-on-failure-unittest.py.
class
ThrowOnFailureTest
(
gtest_test_utils
.
TestCase
):
class
ThrowOnFailureTest
(
gtest_test_utils
.
TestCase
):
"""Tests the throw-on-failure mode."""
"""Tests the throw-on-failure mode."""
...
...
googletest/test/googletest-uninitialized-test.py
View file @
265efde9
...
@@ -31,8 +31,6 @@
...
@@ -31,8 +31,6 @@
"""Verifies that Google Test warns the user when not initialized properly."""
"""Verifies that Google Test warns the user when not initialized properly."""
__author__
=
'wan@google.com (Zhanyong Wan)'
import
gtest_test_utils
import
gtest_test_utils
COMMAND
=
gtest_test_utils
.
GetTestExecutablePath
(
'googletest-uninitialized-test_'
)
COMMAND
=
gtest_test_utils
.
GetTestExecutablePath
(
'googletest-uninitialized-test_'
)
...
...
Prev
1
2
3
Next
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment